From b791cc4fbec459b2eef502502e44a3d00688e083 Mon Sep 17 00:00:00 2001 From: Mike Pennisi Date: Wed, 10 Feb 2016 17:15:49 -0500 Subject: [PATCH] Runner: Re-use lock to share access to stdout When executing multiple tests in parallel, each "child" thread would write to the process's standard output buffer immediately upon test completion. Because thread execution order and instruction interleaving is non-deterministic, this made it possible for characters to be emitted out-of-order. When extended to support multiple concurrent threads, the runner was outfitted with a "log lock" dedicated to sharing access to the output file (when applicable). Re-use this lock when writing to standard out, ensuring proper ordering of test result messages. --- tools/packaging/test262.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/packaging/test262.py b/tools/packaging/test262.py index 26f3f8b526..735d796cac 100755 --- a/tools/packaging/test262.py +++ b/tools/packaging/test262.py @@ -606,10 +606,11 @@ class TestSuite(object): if logname: self.WriteLog(result) finally: + progress.HasRun(result) + if workers_count > 1: log_lock.release() - progress.HasRun(result) if workers_count == 1: exec_case() else: