From bb6ce7e435c1ff0aad565dba83948fd208eb7510 Mon Sep 17 00:00:00 2001
From: Alexey Shvayka <shvaikalesh@gmail.com>
Date: Tue, 8 Oct 2019 21:58:27 +0300
Subject: [PATCH] Add test for Proxy "has" trap on prototype (#2382)

* Use allowProxyTraps.js in [[Set]] tests

* Add [[HasProperty]] test
---
 test/built-ins/Proxy/has/call-in-prototype.js | 42 +++++++++++++++++++
 .../call-parameters-prototype-dunder-proto.js |  5 ++-
 .../Proxy/set/call-parameters-prototype.js    |  5 ++-
 3 files changed, 48 insertions(+), 4 deletions(-)
 create mode 100644 test/built-ins/Proxy/has/call-in-prototype.js

diff --git a/test/built-ins/Proxy/has/call-in-prototype.js b/test/built-ins/Proxy/has/call-in-prototype.js
new file mode 100644
index 0000000000..2e4037b8aa
--- /dev/null
+++ b/test/built-ins/Proxy/has/call-in-prototype.js
@@ -0,0 +1,42 @@
+// Copyright (C) 2019 Alexey Shvayka. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+/*---
+esid: sec-proxy-object-internal-methods-and-internal-slots-hasproperty-p
+description: >
+  Ordinary [[HasProperty]] forwards call to Proxy "has" trap with correct arguments.
+info: |
+  OrdinaryHasProperty ( O, P )
+
+  ...
+  4. Let parent be ? O.[[GetPrototypeOf]]().
+  5. If parent is not null, then
+    a. Return ? parent.[[HasProperty]](P).
+
+  [[HasProperty]] ( P )
+
+  ...
+  8. Let booleanTrapResult be ! ToBoolean(? Call(trap, handler, « target, P »)).
+  ...
+  10. Return booleanTrapResult.
+includes: [proxyTrapsHelper.js]
+features: [Proxy]
+---*/
+
+var _handler, _target, _prop;
+var target = {};
+var handler = allowProxyTraps({
+  has: function(target, prop) {
+    _handler = this;
+    _target = target;
+    _prop = prop;
+
+    return false;
+  },
+});
+var proxy = new Proxy(target, handler);
+var heir = Object.create(proxy);
+
+assert.sameValue('prop' in heir, false);
+assert.sameValue(_handler, handler, 'handler is context');
+assert.sameValue(_target, target, 'target is the first parameter');
+assert.sameValue(_prop, 'prop', 'given prop is the second paramter');
diff --git a/test/built-ins/Proxy/set/call-parameters-prototype-dunder-proto.js b/test/built-ins/Proxy/set/call-parameters-prototype-dunder-proto.js
index a401786ffb..5f0fbbd69c 100644
--- a/test/built-ins/Proxy/set/call-parameters-prototype-dunder-proto.js
+++ b/test/built-ins/Proxy/set/call-parameters-prototype-dunder-proto.js
@@ -25,12 +25,13 @@ info: |
   8. Let booleanTrapResult be ! ToBoolean(? Call(trap, handler, « target, P, V, Receiver »)).
   ...
   12. Return true.
+includes: [proxyTrapsHelper.js]
 features: [Proxy]
 ---*/
 
 var _handler, _target, _prop, _value, _receiver;
 var target = {};
-var handler = {
+var handler = allowProxyTraps({
   set: function(target, prop, value, receiver) {
     _handler = this;
     _target = target;
@@ -39,7 +40,7 @@ var handler = {
     _receiver = receiver;
     return true;
   },
-};
+});
 
 var proxy = new Proxy(target, handler);
 var receiver = Object.create(proxy);
diff --git a/test/built-ins/Proxy/set/call-parameters-prototype.js b/test/built-ins/Proxy/set/call-parameters-prototype.js
index e1a28f5271..86178a4567 100644
--- a/test/built-ins/Proxy/set/call-parameters-prototype.js
+++ b/test/built-ins/Proxy/set/call-parameters-prototype.js
@@ -24,12 +24,13 @@ info: |
   8. Let booleanTrapResult be ! ToBoolean(? Call(trap, handler, « target, P, V, Receiver »)).
   ...
   12. Return true.
+includes: [proxyTrapsHelper.js]
 features: [Proxy]
 ---*/
 
 var _handler, _target, _prop, _value, _receiver;
 var target = {};
-var handler = {
+var handler = allowProxyTraps({
   set: function(target, prop, value, receiver) {
     _handler = this;
     _target = target;
@@ -38,7 +39,7 @@ var handler = {
     _receiver = receiver;
     return true;
   },
-};
+});
 
 var proxy = new Proxy(target, handler);
 var receiver = Object.create(proxy);