RAB: Integrate staging tests for the .some method (#4175)

* Import relevant files from #3888

* Removing parts in resizableArrayBufferUtils.js and adding it in includes,
while applying review changes from PRs for previously tested methods.

* Address review comments.
This commit is contained in:
Ioanna M Dimitriou H 2024-08-09 18:05:04 +02:00 committed by GitHub
parent 5dc04b7332
commit bcb42e339d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
6 changed files with 539 additions and 0 deletions

View File

@ -0,0 +1,84 @@
// Copyright 2023 the V8 project authors. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.
/*---
esid: sec-array.prototype.some
description: >
Array.p.some behaves correctly on TypedArrays backed by resizable buffers that
are grown mid-iteration.
features: [resizable-arraybuffer]
includes: [compareArray.js, resizableArrayBufferUtils.js]
---*/
let values;
let rab;
let resizeAfter;
let resizeTo;
// Collects the view of the resizable array buffer rab into values, with an
// iteration during which, after resizeAfter steps, rab is resized to length
// resizeTo. To be called by a method of the view being collected.
// Note that rab, values, resizeAfter, and resizeTo may need to be reset
// before calling this.
function ResizeMidIteration(n) {
CollectValuesAndResize(n, values, rab, resizeAfter, resizeTo);
return false;
}
// Orig. array: [0, 2, 4, 6]
// [0, 2, 4, 6] << fixedLength
// [4, 6] << fixedLengthWithOffset
// [0, 2, 4, 6, ...] << lengthTracking
// [4, 6, ...] << lengthTrackingWithOffset
for (let ctor of ctors) {
rab = CreateRabForTest(ctor);
const fixedLength = new ctor(rab, 0, 4);
values = [];
resizeAfter = 2;
resizeTo = 5 * ctor.BYTES_PER_ELEMENT;
assert(!Array.prototype.some.call(fixedLength, ResizeMidIteration));
assert.compareArray(values, [
0,
2,
4,
6
]);
}
for (let ctor of ctors) {
rab = CreateRabForTest(ctor);
const fixedLengthWithOffset = new ctor(rab, 2 * ctor.BYTES_PER_ELEMENT, 2);
values = [];
resizeAfter = 1;
resizeTo = 5 * ctor.BYTES_PER_ELEMENT;
assert(!Array.prototype.some.call(fixedLengthWithOffset, ResizeMidIteration));
assert.compareArray(values, [
4,
6
]);
}
for (let ctor of ctors) {
rab = CreateRabForTest(ctor);
const lengthTracking = new ctor(rab, 0);
values = [];
resizeAfter = 2;
resizeTo = 5 * ctor.BYTES_PER_ELEMENT;
assert(!Array.prototype.some.call(lengthTracking, ResizeMidIteration));
assert.compareArray(values, [
0,
2,
4,
6
]);
}
for (let ctor of ctors) {
rab = CreateRabForTest(ctor);
const lengthTrackingWithOffset = new ctor(rab, 2 * ctor.BYTES_PER_ELEMENT);
values = [];
rab = rab;
resizeAfter = 1;
resizeTo = 5 * ctor.BYTES_PER_ELEMENT;
assert(!Array.prototype.some.call(lengthTrackingWithOffset, ResizeMidIteration));
assert.compareArray(values, [
4,
6
]);
}

View File

@ -0,0 +1,74 @@
// Copyright 2023 the V8 project authors. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.
/*---
esid: sec-array.prototype.some
description: >
Array.p.some behaves correctly on TypedArrays backed by resizable buffers that
are shrunk mid-iteration.
features: [resizable-arraybuffer]
includes: [compareArray.js, resizableArrayBufferUtils.js]
---*/
let values;
let rab;
let resizeAfter;
let resizeTo;
// Collects the view of the resizable array buffer rab into values, with an
// iteration during which, after resizeAfter steps, rab is resized to length
// resizeTo. To be called by a method of the view being collected.
// Note that rab, values, resizeAfter, and resizeTo may need to be reset
// before calling this.
function ResizeMidIteration(n) {
CollectValuesAndResize(n, values, rab, resizeAfter, resizeTo);
return false;
}
// Orig. array: [0, 2, 4, 6]
// [0, 2, 4, 6] << fixedLength
// [4, 6] << fixedLengthWithOffset
// [0, 2, 4, 6, ...] << lengthTracking
// [4, 6, ...] << lengthTrackingWithOffset
for (let ctor of ctors) {
rab = CreateRabForTest(ctor);
const fixedLength = new ctor(rab, 0, 4);
values = [];
resizeAfter = 2;
resizeTo = 3 * ctor.BYTES_PER_ELEMENT;
assert(!Array.prototype.some.call(fixedLength, ResizeMidIteration));
assert.compareArray(values, [
0,
2
]);
}
for (let ctor of ctors) {
rab = CreateRabForTest(ctor);
const fixedLengthWithOffset = new ctor(rab, 2 * ctor.BYTES_PER_ELEMENT, 2);
values = [];
resizeAfter = 1;
resizeTo = 3 * ctor.BYTES_PER_ELEMENT;
assert(!Array.prototype.some.call(fixedLengthWithOffset, ResizeMidIteration));
assert.compareArray(values, [4]);
}
for (let ctor of ctors) {
rab = CreateRabForTest(ctor);
const lengthTracking = new ctor(rab, 0);
values = [];
resizeAfter = 2;
resizeTo = 3 * ctor.BYTES_PER_ELEMENT;
assert(!Array.prototype.some.call(lengthTracking, ResizeMidIteration));
assert.compareArray(values, [
0,
2,
4
]);
}
for (let ctor of ctors) {
rab = CreateRabForTest(ctor);
const lengthTrackingWithOffset = new ctor(rab, 2 * ctor.BYTES_PER_ELEMENT);
values = [];
resizeAfter = 1;
resizeTo = 3 * ctor.BYTES_PER_ELEMENT;
assert(!Array.prototype.some.call(lengthTrackingWithOffset, ResizeMidIteration));
assert.compareArray(values, [4]);
}

View File

@ -0,0 +1,99 @@
// Copyright 2023 the V8 project authors. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.
/*---
esid: sec-array.prototype.some
description: >
Array.p.some behaves correctly on TypedArrays backed by resizable buffers.
includes: [resizableArrayBufferUtils.js]
features: [resizable-arraybuffer]
---*/
for (let ctor of ctors) {
const rab = CreateResizableArrayBuffer(4 * ctor.BYTES_PER_ELEMENT, 8 * ctor.BYTES_PER_ELEMENT);
const fixedLength = new ctor(rab, 0, 4);
const fixedLengthWithOffset = new ctor(rab, 2 * ctor.BYTES_PER_ELEMENT, 2);
const lengthTracking = new ctor(rab, 0);
const lengthTrackingWithOffset = new ctor(rab, 2 * ctor.BYTES_PER_ELEMENT);
// Write some data into the array.
const taWrite = new ctor(rab);
for (let i = 0; i < 4; ++i) {
WriteToTypedArray(taWrite, i, 2 * i);
}
// Orig. array: [0, 2, 4, 6]
// [0, 2, 4, 6] << fixedLength
// [4, 6] << fixedLengthWithOffset
// [0, 2, 4, 6, ...] << lengthTracking
// [4, 6, ...] << lengthTrackingWithOffset
function div3(n) {
return Number(n) % 3 == 0;
}
function over10(n) {
return Number(n) > 10;
}
assert(Array.prototype.some.call(fixedLength, div3));
assert(!Array.prototype.some.call(fixedLength, over10));
assert(Array.prototype.some.call(fixedLengthWithOffset, div3));
assert(!Array.prototype.some.call(fixedLengthWithOffset, over10));
assert(Array.prototype.some.call(lengthTracking, div3));
assert(!Array.prototype.some.call(lengthTracking, over10));
assert(Array.prototype.some.call(lengthTrackingWithOffset, div3));
assert(!Array.prototype.some.call(lengthTrackingWithOffset, over10));
// Shrink so that fixed length TAs go out of bounds.
rab.resize(3 * ctor.BYTES_PER_ELEMENT);
// Orig. array: [0, 2, 4]
// [0, 2, 4, ...] << lengthTracking
// [4, ...] << lengthTrackingWithOffset
assert(!Array.prototype.some.call(fixedLength, div3));
assert(!Array.prototype.some.call(fixedLengthWithOffset, div3));
assert(Array.prototype.some.call(lengthTracking, div3));
assert(!Array.prototype.some.call(lengthTracking, over10));
assert(!Array.prototype.some.call(lengthTrackingWithOffset, div3));
assert(!Array.prototype.some.call(lengthTrackingWithOffset, over10));
// Shrink so that the TAs with offset go out of bounds.
rab.resize(1 * ctor.BYTES_PER_ELEMENT);
assert(!Array.prototype.some.call(fixedLength, div3));
assert(!Array.prototype.some.call(fixedLengthWithOffset, div3));
assert(!Array.prototype.some.call(lengthTrackingWithOffset, div3));
assert(Array.prototype.some.call(lengthTracking, div3));
assert(!Array.prototype.some.call(lengthTracking, over10));
// Shrink to zero.
rab.resize(0);
assert(!Array.prototype.some.call(fixedLength, div3));
assert(!Array.prototype.some.call(fixedLengthWithOffset, div3));
assert(!Array.prototype.some.call(lengthTrackingWithOffset, div3));
assert(!Array.prototype.some.call(lengthTracking, div3));
assert(!Array.prototype.some.call(lengthTracking, over10));
// Grow so that all TAs are back in-bounds.
rab.resize(6 * ctor.BYTES_PER_ELEMENT);
for (let i = 0; i < 6; ++i) {
WriteToTypedArray(taWrite, i, 2 * i);
}
// Orig. array: [0, 2, 4, 6, 8, 10]
// [0, 2, 4, 6] << fixedLength
// [4, 6] << fixedLengthWithOffset
// [0, 2, 4, 6, 8, 10, ...] << lengthTracking
// [4, 6, 8, 10, ...] << lengthTrackingWithOffset
assert(Array.prototype.some.call(fixedLength, div3));
assert(!Array.prototype.some.call(fixedLength, over10));
assert(Array.prototype.some.call(fixedLengthWithOffset, div3));
assert(!Array.prototype.some.call(fixedLengthWithOffset, over10));
assert(Array.prototype.some.call(lengthTracking, div3));
assert(!Array.prototype.some.call(lengthTracking, over10));
assert(Array.prototype.some.call(lengthTrackingWithOffset, div3));
assert(!Array.prototype.some.call(lengthTrackingWithOffset, over10));
}

View File

@ -0,0 +1,84 @@
// Copyright 2023 the V8 project authors. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.
/*---
esid: sec-%typedarray%.prototype.some
description: >
TypedArray.p.some behaves correctly on TypedArrays backed by resizable buffers
which are grown mid-iteration.
features: [resizable-arraybuffer]
includes: [compareArray.js, resizableArrayBufferUtils.js]
---*/
let values;
let rab;
let resizeAfter;
let resizeTo;
// Below the argument array should be a view of the resizable array buffer rab.
// This array gets collected into values via reduce and CollectValuesAndResize.
// The latter performs an during which, after resizeAfter steps, rab is resized
// to length resizeTo. Note that rab, values, resizeAfter, and resizeTo may need
// to be reset before calling this.
function ResizeMidIteration(n) {
CollectValuesAndResize(n, values, rab, resizeAfter, resizeTo);
return false;
}
// Orig. array: [0, 2, 4, 6]
// [0, 2, 4, 6] << fixedLength
// [4, 6] << fixedLengthWithOffset
// [0, 2, 4, 6, ...] << lengthTracking
// [4, 6, ...] << lengthTrackingWithOffset
for (let ctor of ctors) {
rab = CreateRabForTest(ctor);
const fixedLength = new ctor(rab, 0, 4);
values = [];
resizeAfter = 2;
resizeTo = 5 * ctor.BYTES_PER_ELEMENT;
assert(!fixedLength.some(ResizeMidIteration));
assert.compareArray(values, [
0,
2,
4,
6
]);
}
for (let ctor of ctors) {
rab = CreateRabForTest(ctor);
const fixedLengthWithOffset = new ctor(rab, 2 * ctor.BYTES_PER_ELEMENT, 2);
values = [];
resizeAfter = 1;
resizeTo = 5 * ctor.BYTES_PER_ELEMENT;
assert(!fixedLengthWithOffset.some(ResizeMidIteration));
assert.compareArray(values, [
4,
6
]);
}
for (let ctor of ctors) {
rab = CreateRabForTest(ctor);
const lengthTracking = new ctor(rab, 0);
values = [];
resizeAfter = 2;
resizeTo = 5 * ctor.BYTES_PER_ELEMENT;
assert(!lengthTracking.some(ResizeMidIteration));
assert.compareArray(values, [
0,
2,
4,
6
]);
}
for (let ctor of ctors) {
rab = CreateRabForTest(ctor);
const lengthTrackingWithOffset = new ctor(rab, 2 * ctor.BYTES_PER_ELEMENT);
values = [];
rab = rab;
resizeAfter = 1;
resizeTo = 5 * ctor.BYTES_PER_ELEMENT;
assert(!lengthTrackingWithOffset.some(ResizeMidIteration));
assert.compareArray(values, [
4,
6
]);
}

View File

@ -0,0 +1,83 @@
// Copyright 2023 the V8 project authors. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.
/*---
esid: sec-%typedarray%.prototype.some
description: >
TypedArray.p.some behaves correctly on TypedArrays backed by resizable buffers
which are shrunk mid-iteration.
features: [resizable-arraybuffer]
includes: [compareArray.js, resizableArrayBufferUtils.js]
---*/
let values;
let rab;
let resizeAfter;
let resizeTo;
// Below the argument array should be a view of the resizable array buffer rab.
// This array gets collected into values via reduce and CollectValuesAndResize.
// The latter performs an during which, after resizeAfter steps, rab is resized
// to length resizeTo. Note that rab, values, resizeAfter, and resizeTo may need
// to be reset before calling this.
function ResizeMidIteration(n) {
CollectValuesAndResize(n, values, rab, resizeAfter, resizeTo);
return false;
}
// Orig. array: [0, 2, 4, 6]
// [0, 2, 4, 6] << fixedLength
// [4, 6] << fixedLengthWithOffset
// [0, 2, 4, 6, ...] << lengthTracking
// [4, 6, ...] << lengthTrackingWithOffset
for (let ctor of ctors) {
rab = CreateRabForTest(ctor);
const fixedLength = new ctor(rab, 0, 4);
values = [];
resizeAfter = 2;
resizeTo = 3 * ctor.BYTES_PER_ELEMENT;
assert(!fixedLength.some(ResizeMidIteration));
assert.compareArray(values, [
0,
2,
undefined,
undefined
]);
}
for (let ctor of ctors) {
rab = CreateRabForTest(ctor);
const fixedLengthWithOffset = new ctor(rab, 2 * ctor.BYTES_PER_ELEMENT, 2);
values = [];
resizeAfter = 1;
resizeTo = 3 * ctor.BYTES_PER_ELEMENT;
assert(!fixedLengthWithOffset.some(ResizeMidIteration));
assert.compareArray(values, [
4,
undefined
]);
}
for (let ctor of ctors) {
rab = CreateRabForTest(ctor);
const lengthTracking = new ctor(rab, 0);
values = [];
resizeAfter = 2;
resizeTo = 3 * ctor.BYTES_PER_ELEMENT;
assert(!lengthTracking.some(ResizeMidIteration));
assert.compareArray(values, [
0,
2,
4,
undefined
]);
}
for (let ctor of ctors) {
rab = CreateRabForTest(ctor);
const lengthTrackingWithOffset = new ctor(rab, 2 * ctor.BYTES_PER_ELEMENT);
values = [];
resizeAfter = 1;
resizeTo = 3 * ctor.BYTES_PER_ELEMENT;
assert(!lengthTrackingWithOffset.some(ResizeMidIteration));
assert.compareArray(values, [
4,
undefined
]);
}

View File

@ -0,0 +1,115 @@
// Copyright 2023 the V8 project authors. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.
/*---
esid: sec-%typedarray%.prototype.some
description: >
TypedArray.p.some behaves correctly on TypedArrays backed by resizable buffers.
includes: [resizableArrayBufferUtils.js]
features: [resizable-arraybuffer]
---*/
for (let ctor of ctors) {
const rab = CreateResizableArrayBuffer(4 * ctor.BYTES_PER_ELEMENT, 8 * ctor.BYTES_PER_ELEMENT);
const fixedLength = new ctor(rab, 0, 4);
const fixedLengthWithOffset = new ctor(rab, 2 * ctor.BYTES_PER_ELEMENT, 2);
const lengthTracking = new ctor(rab, 0);
const lengthTrackingWithOffset = new ctor(rab, 2 * ctor.BYTES_PER_ELEMENT);
// Write some data into the array.
const taWrite = new ctor(rab);
for (let i = 0; i < 4; ++i) {
WriteToTypedArray(taWrite, i, 2 * i);
}
// Orig. array: [0, 2, 4, 6]
// [0, 2, 4, 6] << fixedLength
// [4, 6] << fixedLengthWithOffset
// [0, 2, 4, 6, ...] << lengthTracking
// [4, 6, ...] << lengthTrackingWithOffset
function div3(n) {
return Number(n) % 3 == 0;
}
function over10(n) {
return Number(n) > 10;
}
assert(fixedLength.some(div3));
assert(!fixedLength.some(over10));
assert(fixedLengthWithOffset.some(div3));
assert(!fixedLengthWithOffset.some(over10));
assert(lengthTracking.some(div3));
assert(!lengthTracking.some(over10));
assert(lengthTrackingWithOffset.some(div3));
assert(!lengthTrackingWithOffset.some(over10));
// Shrink so that fixed length TAs go out of bounds.
rab.resize(3 * ctor.BYTES_PER_ELEMENT);
// Orig. array: [0, 2, 4]
// [0, 2, 4, ...] << lengthTracking
// [4, ...] << lengthTrackingWithOffset
assert.throws(TypeError, () => {
fixedLength.some(div3);
});
assert.throws(TypeError, () => {
fixedLengthWithOffset.some(div3);
});
assert(lengthTracking.some(div3));
assert(!lengthTracking.some(over10));
assert(!lengthTrackingWithOffset.some(div3));
assert(!lengthTrackingWithOffset.some(over10));
// Shrink so that the TAs with offset go out of bounds.
rab.resize(1 * ctor.BYTES_PER_ELEMENT);
assert.throws(TypeError, () => {
fixedLength.some(div3);
});
assert.throws(TypeError, () => {
fixedLengthWithOffset.some(div3);
});
assert.throws(TypeError, () => {
lengthTrackingWithOffset.some(div3);
});
assert(lengthTracking.some(div3));
assert(!lengthTracking.some(over10));
// Shrink to zero.
rab.resize(0);
assert.throws(TypeError, () => {
fixedLength.some(div3);
});
assert.throws(TypeError, () => {
fixedLengthWithOffset.some(div3);
});
assert.throws(TypeError, () => {
lengthTrackingWithOffset.some(div3);
});
assert(!lengthTracking.some(div3));
assert(!lengthTracking.some(over10));
// Grow so that all TAs are back in-bounds.
rab.resize(6 * ctor.BYTES_PER_ELEMENT);
for (let i = 0; i < 6; ++i) {
WriteToTypedArray(taWrite, i, 2 * i);
}
// Orig. array: [0, 2, 4, 6, 8, 10]
// [0, 2, 4, 6] << fixedLength
// [4, 6] << fixedLengthWithOffset
// [0, 2, 4, 6, 8, 10, ...] << lengthTracking
// [4, 6, 8, 10, ...] << lengthTrackingWithOffset
assert(fixedLength.some(div3));
assert(!fixedLength.some(over10));
assert(fixedLengthWithOffset.some(div3));
assert(!fixedLengthWithOffset.some(over10));
assert(lengthTracking.some(div3));
assert(!lengthTracking.some(over10));
assert(lengthTrackingWithOffset.some(div3));
assert(!lengthTrackingWithOffset.some(over10));
}