From c623dd288ae609b4cda4066331dc1102e3334b48 Mon Sep 17 00:00:00 2001
From: Alexey Shvayka <shvaikalesh@gmail.com>
Date: Tue, 2 Mar 2021 19:24:14 +0200
Subject: [PATCH] Test valid descriptor & invalid index

---
 .../BigInt/key-is-not-numeric-index-throws.js | 45 +++++++++++++++++++
 .../key-is-not-numeric-index-throws.js        | 45 +++++++++++++++++++
 2 files changed, 90 insertions(+)
 create mode 100644 test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/key-is-not-numeric-index-throws.js
 create mode 100644 test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/key-is-not-numeric-index-throws.js

diff --git a/test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/key-is-not-numeric-index-throws.js b/test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/key-is-not-numeric-index-throws.js
new file mode 100644
index 0000000000..633390385f
--- /dev/null
+++ b/test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/key-is-not-numeric-index-throws.js
@@ -0,0 +1,45 @@
+// Copyright (C) 2021 Alexey Shvayka. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+/*---
+esid: sec-integer-indexed-exotic-objects-defineownproperty-p-desc
+description: >
+  Throws TypeError for valid descriptor & canonical numeric string that is invalid index.
+info: |
+  [[DefineOwnProperty]] ( P, Desc )
+
+  [...]
+  3. If Type(P) is String, then
+    a. Let numericIndex be ! CanonicalNumericIndexString(P).
+    b. If numericIndex is not undefined, then
+      i. If ! IsValidIntegerIndex(O, numericIndex) is false, return false.
+
+  IsValidIntegerIndex ( O, index )
+
+  [...]
+  3. If ! IsIntegralNumber(index) is false, return false.
+  4. If index is -0𝔽, return false.
+  5. If ℝ(index) < 0 or ℝ(index) ≥ O.[[ArrayLength]], return false.
+includes: [testBigIntTypedArray.js]
+features: [align-detached-buffer-semantics-with-web-reality, BigInt, TypedArray]
+---*/
+
+testWithBigIntTypedArrayConstructors(function(TA) {
+  var sample = new TA([0n]);
+  var desc = Object.getOwnPropertyDescriptor(sample, "0");
+
+  assert.throws(TypeError, function() {
+    Object.defineProperty(sample, "1", desc);
+  });
+
+  assert.throws(TypeError, function() {
+    Object.defineProperty(sample, "-1", desc);
+  });
+
+  assert.throws(TypeError, function() {
+    Object.defineProperty(sample, "1.5", desc);
+  });
+
+  assert.throws(TypeError, function() {
+    Object.defineProperty(sample, "-0", desc);
+  });
+});
diff --git a/test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/key-is-not-numeric-index-throws.js b/test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/key-is-not-numeric-index-throws.js
new file mode 100644
index 0000000000..060565d395
--- /dev/null
+++ b/test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/key-is-not-numeric-index-throws.js
@@ -0,0 +1,45 @@
+// Copyright (C) 2021 Alexey Shvayka. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+/*---
+esid: sec-integer-indexed-exotic-objects-defineownproperty-p-desc
+description: >
+  Throws TypeError for valid descriptor & canonical numeric string that is invalid index.
+info: |
+  [[DefineOwnProperty]] ( P, Desc )
+
+  [...]
+  3. If Type(P) is String, then
+    a. Let numericIndex be ! CanonicalNumericIndexString(P).
+    b. If numericIndex is not undefined, then
+      i. If ! IsValidIntegerIndex(O, numericIndex) is false, return false.
+
+  IsValidIntegerIndex ( O, index )
+
+  [...]
+  3. If ! IsIntegralNumber(index) is false, return false.
+  4. If index is -0𝔽, return false.
+  5. If ℝ(index) < 0 or ℝ(index) ≥ O.[[ArrayLength]], return false.
+includes: [testTypedArray.js]
+features: [align-detached-buffer-semantics-with-web-reality, TypedArray]
+---*/
+
+testWithTypedArrayConstructors(function(TA) {
+  var sample = new TA([0]);
+  var desc = Object.getOwnPropertyDescriptor(sample, "0");
+
+  assert.throws(TypeError, function() {
+    Object.defineProperty(sample, "1", desc);
+  });
+
+  assert.throws(TypeError, function() {
+    Object.defineProperty(sample, "-1", desc);
+  });
+
+  assert.throws(TypeError, function() {
+    Object.defineProperty(sample, "1.5", desc);
+  });
+
+  assert.throws(TypeError, function() {
+    Object.defineProperty(sample, "-0", desc);
+  });
+});