Merge pull request #1491 from bocoup/bigint-fix

Bigint fix: the remaining bugs found in #1461
2025-07-28 16:34:27 +02:00 · 2018-03-13 16:07:42 -04:00 · 2018-03-13 16:07:42 -04:00 · cdbf81856b
commit cdbf81856b
parent 2975694f86 cc86629301
32 changed files with 50 additions and 41 deletions
--- a/test/built-ins/TypedArray/prototype/fill/BigInt/return-abrupt-from-end-as-symbol.js
+++ b/test/built-ins/TypedArray/prototype/fill/BigInt/return-abrupt-from-end-as-symbol.js
@ -33,6 +33,6 @@ var end = Symbol(1);
 testWithBigIntTypedArrayConstructors(function(TA) {
  var sample = new TA();
  assert.throws(TypeError, function() {
-    sample.fill(1, 0, end);
+    sample.fill(1n, 0, end);
  });
 });
--- a/test/built-ins/TypedArray/prototype/fill/BigInt/return-abrupt-from-start-as-symbol.js
+++ b/test/built-ins/TypedArray/prototype/fill/BigInt/return-abrupt-from-start-as-symbol.js
@ -32,6 +32,6 @@ var start = Symbol(1);
 testWithBigIntTypedArrayConstructors(function(TA) {
  var sample = new TA();
  assert.throws(TypeError, function() {
-    sample.fill(1, start);
+    sample.fill(1n, start);
  });
 });
--- a/test/built-ins/TypedArray/prototype/includes/BigInt/detached-buffer.js
+++ b/test/built-ins/TypedArray/prototype/includes/BigInt/detached-buffer.js
@ -23,6 +23,6 @@ testWithBigIntTypedArrayConstructors(function(TA) {
  var sample = new TA(1);
  $DETACHBUFFER(sample.buffer);
  assert.throws(TypeError, function() {
-    sample.includes(0);
+    sample.includes(0n);
  });
 });
--- a/test/built-ins/TypedArray/prototype/includes/BigInt/fromIndex-equal-or-greater-length-returns-false.js
+++ b/test/built-ins/TypedArray/prototype/includes/BigInt/fromIndex-equal-or-greater-length-returns-false.js
@ -31,6 +31,6 @@ testWithBigIntTypedArrayConstructors(function(TA) {
  var sample;

  sample = new TA(42);
-  assert.sameValue(sample.includes(0, 42), false);
-  assert.sameValue(sample.includes(0, 43), false);
+  assert.sameValue(sample.includes(0n, 42), false);
+  assert.sameValue(sample.includes(0n, 43), false);
 });
--- a/test/built-ins/TypedArray/prototype/includes/BigInt/length-zero-returns-false.js
+++ b/test/built-ins/TypedArray/prototype/includes/BigInt/length-zero-returns-false.js
@ -33,7 +33,7 @@ testWithBigIntTypedArrayConstructors(function(TA) {
  assert.sameValue(sample.includes(0), false, "returns false");
  assert.sameValue(sample.includes(), false, "returns false - no arg");
  assert.sameValue(
-    sample.includes(0, fromIndex), false,
+    sample.includes(0n, fromIndex), false,
    "length is checked before ToInteger(fromIndex)"
  );
 });
--- a/test/built-ins/TypedArray/prototype/indexOf/BigInt/detached-buffer.js
+++ b/test/built-ins/TypedArray/prototype/indexOf/BigInt/detached-buffer.js
@ -23,6 +23,6 @@ testWithBigIntTypedArrayConstructors(function(TA) {
  var sample = new TA(1);
  $DETACHBUFFER(sample.buffer);
  assert.throws(TypeError, function() {
-    sample.indexOf(0);
+    sample.indexOf(0n);
  });
 });
--- a/test/built-ins/TypedArray/prototype/indexOf/BigInt/fromIndex-equal-or-greater-length-returns-minus-one.js
+++ b/test/built-ins/TypedArray/prototype/indexOf/BigInt/fromIndex-equal-or-greater-length-returns-minus-one.js
@ -25,6 +25,6 @@ testWithBigIntTypedArrayConstructors(function(TA) {
  var sample;

  sample = new TA(42);
-  assert.sameValue(sample.indexOf(0, 42), -1);
-  assert.sameValue(sample.indexOf(0, 43), -1);
+  assert.sameValue(sample.indexOf(0n, 42), -1);
+  assert.sameValue(sample.indexOf(0n, 43), -1);
 });
--- a/test/built-ins/TypedArray/prototype/indexOf/BigInt/length-zero-returns-minus-one.js
+++ b/test/built-ins/TypedArray/prototype/indexOf/BigInt/length-zero-returns-minus-one.js
@ -29,9 +29,9 @@ var fromIndex = {

 testWithBigIntTypedArrayConstructors(function(TA) {
  var sample = new TA();
-  assert.sameValue(sample.indexOf(0), -1, "returns -1");
+  assert.sameValue(sample.indexOf(0n), -1, "returns -1");
  assert.sameValue(
-    sample.indexOf(0, fromIndex), -1,
+    sample.indexOf(0n, fromIndex), -1,
    "length is checked before ToInteger(fromIndex)"
  );
 });
--- a/test/built-ins/TypedArray/prototype/indexOf/BigInt/return-abrupt-tointeger-fromindex-symbol.js
+++ b/test/built-ins/TypedArray/prototype/indexOf/BigInt/return-abrupt-tointeger-fromindex-symbol.js
@ -27,6 +27,6 @@ testWithBigIntTypedArrayConstructors(function(TA) {
  var sample = new TA(1);

  assert.throws(TypeError, function() {
-    sample.indexOf(7, fromIndex);
+    sample.indexOf(7n, fromIndex);
  });
 });
--- a/test/built-ins/TypedArray/prototype/indexOf/BigInt/return-abrupt-tointeger-fromindex.js
+++ b/test/built-ins/TypedArray/prototype/indexOf/BigInt/return-abrupt-tointeger-fromindex.js
@ -31,6 +31,6 @@ testWithBigIntTypedArrayConstructors(function(TA) {
  var sample = new TA(1);

  assert.throws(Test262Error, function() {
-    sample.indexOf(7, fromIndex);
+    sample.indexOf(7n, fromIndex);
  });
 });
--- a/test/built-ins/TypedArray/prototype/lastIndexOf/BigInt/detached-buffer.js
+++ b/test/built-ins/TypedArray/prototype/lastIndexOf/BigInt/detached-buffer.js
@ -23,6 +23,6 @@ testWithBigIntTypedArrayConstructors(function(TA) {
  var sample = new TA(1);
  $DETACHBUFFER(sample.buffer);
  assert.throws(TypeError, function() {
-    sample.lastIndexOf(0);
+    sample.lastIndexOf(0n);
  });
 });
--- a/test/built-ins/TypedArray/prototype/lastIndexOf/BigInt/length-zero-returns-minus-one.js
+++ b/test/built-ins/TypedArray/prototype/lastIndexOf/BigInt/length-zero-returns-minus-one.js
@ -31,7 +31,7 @@ testWithBigIntTypedArrayConstructors(function(TA) {
  var sample = new TA();
  assert.sameValue(sample.lastIndexOf(0), -1, "returns -1");
  assert.sameValue(
-    sample.lastIndexOf(0, fromIndex), -1,
+    sample.lastIndexOf(0n, fromIndex), -1,
    "length is checked before ToInteger(fromIndex)"
  );
 });
--- a/test/built-ins/TypedArray/prototype/lastIndexOf/BigInt/return-abrupt-tointeger-fromindex-symbol.js
+++ b/test/built-ins/TypedArray/prototype/lastIndexOf/BigInt/return-abrupt-tointeger-fromindex-symbol.js
@ -27,6 +27,6 @@ testWithBigIntTypedArrayConstructors(function(TA) {
  var sample = new TA(1);

  assert.throws(TypeError, function() {
-    sample.lastIndexOf(7, fromIndex);
+    sample.lastIndexOf(7n, fromIndex);
  });
 });
--- a/test/built-ins/TypedArray/prototype/lastIndexOf/BigInt/return-abrupt-tointeger-fromindex.js
+++ b/test/built-ins/TypedArray/prototype/lastIndexOf/BigInt/return-abrupt-tointeger-fromindex.js
@ -31,6 +31,6 @@ testWithBigIntTypedArrayConstructors(function(TA) {
  var sample = new TA(1);

  assert.throws(Test262Error, function() {
-    sample.lastIndexOf(7, fromIndex);
+    sample.lastIndexOf(7n, fromIndex);
  });
 });
--- a/test/built-ins/TypedArray/prototype/set/BigInt/typedarray-arg-set-values-diff-buffer-other-type-sab.js
+++ b/test/built-ins/TypedArray/prototype/set/BigInt/typedarray-arg-set-values-diff-buffer-other-type-sab.js
@ -13,7 +13,8 @@ features: [BigInt, SharedArrayBuffer, TypedArray]

 testWithBigIntTypedArrayConstructors(function(TA) {
  var sab = new SharedArrayBuffer(2 * BigInt64Array.BYTES_PER_ELEMENT);
-  var src = new BigInt64Array(sab);
+  var otherCtor = TA === BigInt64Array ? BigUint64Array : BigInt64Array;
+  var src = new otherCtor(sab);
  src[0] = 42n;
  src[1] = 43n;
  var sample, result;
--- a/test/built-ins/TypedArray/prototype/sort/BigInt/sortcompare-with-no-tostring.js
+++ b/test/built-ins/TypedArray/prototype/sort/BigInt/sortcompare-with-no-tostring.js
@ -18,10 +18,14 @@ includes: [testBigIntTypedArray.js, compareArray.js]
 features: [BigInt, TypedArray]
 ---*/

-var origToString = Number.prototype.toString;
+var toStringCalled = false;
+BigInt.prototype.toString = function() {
+  toStringCalled = true;
+}

 testWithBigIntTypedArrayConstructors(function(TA) {
  var sample = new TA([20n, 100n, 3n]);
  var result = sample.sort();
+  assert.sameValue(toStringCalled, false, "BigInt.prototype.toString will not be called");
  assert(compareArray(result, [3n, 20n, 100n]));
 });
--- a/test/built-ins/TypedArray/prototype/sort/sortcompare-with-no-tostring.js
+++ b/test/built-ins/TypedArray/prototype/sort/sortcompare-with-no-tostring.js
@ -18,10 +18,14 @@ includes: [testTypedArray.js, compareArray.js]
 features: [TypedArray]
 ---*/

-var origToString = Number.prototype.toString;
+var toStringCalled = false;
+Number.prototype.toString = function() {
+  toStringCalled = true;
+}

 testWithTypedArrayConstructors(function(TA) {
  var sample = new TA([20, 100, 3]);
  var result = sample.sort();
-  assert(compareArray(result, [3, 20, 100]));
+  assert.sameValue(toStringCalled, false, "Number.prototype.toString will not be called");
+  assert(compareArray(result, [3, 20, 100]), "Default sorting by value");
 });
--- a/test/built-ins/TypedArrayConstructors/ctors-bigint/buffer-arg/invoked-with-undefined-newtarget-sab.js
+++ b/test/built-ins/TypedArrayConstructors/ctors-bigint/buffer-arg/invoked-with-undefined-newtarget-sab.js
@ -20,7 +20,7 @@ features: [BigInt, SharedArrayBuffer, TypedArray]
 ---*/

 testWithBigIntTypedArrayConstructors(function(TA) {
-  var buffer = new SharedArrayBuffer(4);
+  var buffer = new SharedArrayBuffer(TA.BYTES_PER_ELEMENT);
  assert.throws(TypeError, function() {
    TA(buffer);
  });
--- a/test/built-ins/TypedArrayConstructors/ctors-bigint/buffer-arg/invoked-with-undefined-newtarget.js
+++ b/test/built-ins/TypedArrayConstructors/ctors-bigint/buffer-arg/invoked-with-undefined-newtarget.js
@ -19,7 +19,7 @@ features: [BigInt, TypedArray]
 ---*/

 testWithBigIntTypedArrayConstructors(function(TA) {
-  var buffer = new ArrayBuffer(4);
+  var buffer = new ArrayBuffer(TA.BYTES_PER_ELEMENT);
  assert.throws(TypeError, function() {
    TA(buffer);
  });
--- a/test/built-ins/TypedArrayConstructors/ctors-bigint/typedarray-arg/other-ctor-buffer-ctor-access-throws.js
+++ b/test/built-ins/TypedArrayConstructors/ctors-bigint/typedarray-arg/other-ctor-buffer-ctor-access-throws.js
@ -26,7 +26,7 @@ features: [BigInt, TypedArray]
 ---*/

 testWithBigIntTypedArrayConstructors(function(TA) {
-  var OtherCtor = TA === Int8Array ? Int16Array : Int8Array;
+  var OtherCtor = TA === BigInt64Array ? BigUint64Array : BigInt64Array;
  var sample = new OtherCtor();

  Object.defineProperty(sample.buffer, "constructor", {
--- a/test/built-ins/TypedArrayConstructors/from/BigInt/custom-ctor-returns-smaller-instance-throws.js
+++ b/test/built-ins/TypedArrayConstructors/from/BigInt/custom-ctor-returns-smaller-instance-throws.js
@ -22,7 +22,7 @@ includes: [testBigIntTypedArray.js]
 features: [BigInt, Symbol.iterator, TypedArray]
 ---*/

-var sourceItor = [1, 2];
+var sourceItor = [1n, 2n];
 var sourceObj = {
  length: 2
 };
--- a/test/built-ins/TypedArrayConstructors/from/BigInt/mapfn-abrupt-completion.js
+++ b/test/built-ins/TypedArrayConstructors/from/BigInt/mapfn-abrupt-completion.js
@ -18,7 +18,7 @@ features: [BigInt, TypedArray]
 ---*/

 var source = {
-  "0": 42,
+  "0": 42n,
  length: 2
 };
 var mapfn = function() {
--- a/test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/detached-buffer-realm.js
+++ b/test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/detached-buffer-realm.js
@ -29,7 +29,7 @@ features: [BigInt, cross-realm, Reflect, TypedArray]

 var other = $262.createRealm().global;
 var desc = {
-  value: 0,
+  value: 0n,
  configurable: false,
  enumerable: true,
  writable: true
--- a/test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/detached-buffer.js
+++ b/test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/detached-buffer.js
@ -27,7 +27,7 @@ features: [BigInt, Reflect, TypedArray]
 ---*/

 var desc = {
-  value: 0,
+  value: 0n,
  configurable: false,
  enumerable: true,
  writable: true
--- a/test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/key-is-greater-than-last-index.js
+++ b/test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/key-is-greater-than-last-index.js
@ -25,7 +25,7 @@ testWithBigIntTypedArrayConstructors(function(TA) {

  assert.sameValue(
    Reflect.defineProperty(sample, "2", {
-      value: 42,
+      value: 42n,
      configurable: false,
      enumerable: true,
      writable: true
@ -36,7 +36,7 @@ testWithBigIntTypedArrayConstructors(function(TA) {

  assert.sameValue(
    Reflect.defineProperty(sample, "3", {
-      value: 42,
+      value: 42n,
      configurable: false,
      enumerable: true,
      writable: true
--- a/test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/key-is-lower-than-zero.js
+++ b/test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/key-is-lower-than-zero.js
@ -23,7 +23,7 @@ testWithBigIntTypedArrayConstructors(function(TA) {

  assert.sameValue(
    Reflect.defineProperty(sample, "-1", {
-      value: 42,
+      value: 42n,
      configurable: false,
      enumerable: true,
      writable: true
--- a/test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/key-is-minus-zero.js
+++ b/test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/key-is-minus-zero.js
@ -23,7 +23,7 @@ testWithBigIntTypedArrayConstructors(function(TA) {

  assert.sameValue(
    Reflect.defineProperty(sample, "-0", {
-      value: 42,
+      value: 42n,
      configurable: false,
      enumerable: true,
      writable: true
--- a/test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/key-is-not-integer.js
+++ b/test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/key-is-not-integer.js
@ -21,7 +21,7 @@ testWithBigIntTypedArrayConstructors(function(TA) {

  assert.sameValue(
    Reflect.defineProperty(sample, "0.1", {
-      value: 42,
+      value: 42n,
      configurable: false,
      enumerable: true,
      writable: true
@ -38,7 +38,7 @@ testWithBigIntTypedArrayConstructors(function(TA) {

  assert.sameValue(
    Reflect.defineProperty(sample, "0.000001", {
-      value: 42,
+      value: 42n,
      configurable: false,
      enumerable: true,
      writable: true
@ -58,7 +58,7 @@ testWithBigIntTypedArrayConstructors(function(TA) {

  assert.sameValue(
    Reflect.defineProperty(sample, "1.1", {
-      value: 42,
+      value: 42n,
      configurable: false,
      enumerable: true,
      writable: true
@ -75,7 +75,7 @@ testWithBigIntTypedArrayConstructors(function(TA) {

  assert.sameValue(
    Reflect.defineProperty(sample, "Infinity", {
-      value: 42,
+      value: 42n,
      configurable: false,
      enumerable: true,
      writable: true
@ -99,7 +99,7 @@ testWithBigIntTypedArrayConstructors(function(TA) {

  assert.sameValue(
    Reflect.defineProperty(sample, "-Infinity", {
-      value: 42,
+      value: 42n,
      configurable: false,
      enumerable: true,
      writable: true
--- a/test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/key-is-numericindex-desc-configurable.js
+++ b/test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/key-is-numericindex-desc-configurable.js
@ -23,7 +23,7 @@ testWithBigIntTypedArrayConstructors(function(TA) {

  assert.sameValue(
    Reflect.defineProperty(sample, "0", {
-      value: 42,
+      value: 42n,
      configurable: true,
      enumerable: true,
      writable: true
--- a/test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/key-is-numericindex-desc-not-enumerable.js
+++ b/test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/key-is-numericindex-desc-not-enumerable.js
@ -23,7 +23,7 @@ testWithBigIntTypedArrayConstructors(function(TA) {

  assert.sameValue(
    Reflect.defineProperty(sample, "0", {
-      value: 42,
+      value: 42n,
      configurable: false,
      enumerable: false,
      writable: true
--- a/test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/key-is-numericindex-desc-not-writable.js
+++ b/test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/key-is-numericindex-desc-not-writable.js
@ -23,7 +23,7 @@ testWithBigIntTypedArrayConstructors(function(TA) {

  assert.sameValue(
    Reflect.defineProperty(sample, "0", {
-      value: 42,
+      value: 42n,
      configurable: false,
      enumerable: true,
      writable: false
--- a/test/built-ins/TypedArrayConstructors/internals/Set/BigInt/detached-buffer-realm.js
+++ b/test/built-ins/TypedArrayConstructors/internals/Set/BigInt/detached-buffer-realm.js
@ -35,6 +35,6 @@ testWithBigIntTypedArrayConstructors(function(TA) {
  $DETACHBUFFER(sample.buffer);

  assert.throws(TypeError, function() {
-    sample[0] = 0;
+    sample[0] = 0n;
  });
 });