From ce2061eccd3a2939fcd4616ad5bc4f5ce13a842e Mon Sep 17 00:00:00 2001 From: Philip Chimento Date: Wed, 14 Sep 2022 15:29:36 -0700 Subject: [PATCH] Temporal: Adjust order of operations in Calendar.___fromFields This implements the normative change in https://github.com/tc39/proposal-temporal/pull/2377 which reached consensus at the September 2022 TC39 meeting. It changes the order in which observable operations are performed on the values passed to the ___fromFields methods of Calendar. --- .../prototype/dateFromFields/order-of-operations.js | 6 +++--- .../prototype/monthDayFromFields/order-of-operations.js | 6 +++--- .../prototype/yearMonthFromFields/order-of-operations.js | 6 +++--- .../prototype/dateFromFields/order-of-operations.js | 6 +++--- .../prototype/monthDayFromFields/order-of-operations.js | 6 +++--- .../prototype/yearMonthFromFields/order-of-operations.js | 6 +++--- 6 files changed, 18 insertions(+), 18 deletions(-) diff --git a/test/built-ins/Temporal/Calendar/prototype/dateFromFields/order-of-operations.js b/test/built-ins/Temporal/Calendar/prototype/dateFromFields/order-of-operations.js index e682993310..09399b7651 100644 --- a/test/built-ins/Temporal/Calendar/prototype/dateFromFields/order-of-operations.js +++ b/test/built-ins/Temporal/Calendar/prototype/dateFromFields/order-of-operations.js @@ -9,9 +9,6 @@ features: [Temporal] ---*/ const expected = [ - "get options.overflow", - "get options.overflow.toString", - "call options.overflow.toString", "get fields.day", "get fields.day.valueOf", "call fields.day.valueOf", @@ -24,6 +21,9 @@ const expected = [ "get fields.year", "get fields.year.valueOf", "call fields.year.valueOf", + "get options.overflow", + "get options.overflow.toString", + "call options.overflow.toString", ]; const actual = []; diff --git a/test/built-ins/Temporal/Calendar/prototype/monthDayFromFields/order-of-operations.js b/test/built-ins/Temporal/Calendar/prototype/monthDayFromFields/order-of-operations.js index d8e5eb4ebb..e35cd53c68 100644 --- a/test/built-ins/Temporal/Calendar/prototype/monthDayFromFields/order-of-operations.js +++ b/test/built-ins/Temporal/Calendar/prototype/monthDayFromFields/order-of-operations.js @@ -9,9 +9,6 @@ features: [Temporal] ---*/ const expected = [ - "get options.overflow", - "get options.overflow.toString", - "call options.overflow.toString", "get fields.day", "get fields.day.valueOf", "call fields.day.valueOf", @@ -24,6 +21,9 @@ const expected = [ "get fields.year", "get fields.year.valueOf", "call fields.year.valueOf", + "get options.overflow", + "get options.overflow.toString", + "call options.overflow.toString", ]; const actual = []; diff --git a/test/built-ins/Temporal/Calendar/prototype/yearMonthFromFields/order-of-operations.js b/test/built-ins/Temporal/Calendar/prototype/yearMonthFromFields/order-of-operations.js index f9cd798e27..61810dab3b 100644 --- a/test/built-ins/Temporal/Calendar/prototype/yearMonthFromFields/order-of-operations.js +++ b/test/built-ins/Temporal/Calendar/prototype/yearMonthFromFields/order-of-operations.js @@ -9,9 +9,6 @@ features: [Temporal] ---*/ const expected = [ - "get options.overflow", - "get options.overflow.toString", - "call options.overflow.toString", "get fields.month", "get fields.month.valueOf", "call fields.month.valueOf", @@ -21,6 +18,9 @@ const expected = [ "get fields.year", "get fields.year.valueOf", "call fields.year.valueOf", + "get options.overflow", + "get options.overflow.toString", + "call options.overflow.toString", ]; const actual = []; diff --git a/test/intl402/Temporal/Calendar/prototype/dateFromFields/order-of-operations.js b/test/intl402/Temporal/Calendar/prototype/dateFromFields/order-of-operations.js index 9e48327741..a5639d8e4e 100644 --- a/test/intl402/Temporal/Calendar/prototype/dateFromFields/order-of-operations.js +++ b/test/intl402/Temporal/Calendar/prototype/dateFromFields/order-of-operations.js @@ -9,9 +9,6 @@ features: [Temporal] ---*/ const expected = [ - "get options.overflow", - "get options.overflow.toString", - "call options.overflow.toString", "get fields.day", "get fields.day.valueOf", "call fields.day.valueOf", @@ -30,6 +27,9 @@ const expected = [ "get fields.year", "get fields.year.valueOf", "call fields.year.valueOf", + "get options.overflow", + "get options.overflow.toString", + "call options.overflow.toString", ]; const actual = []; diff --git a/test/intl402/Temporal/Calendar/prototype/monthDayFromFields/order-of-operations.js b/test/intl402/Temporal/Calendar/prototype/monthDayFromFields/order-of-operations.js index ec94fdcdde..2c39686e3d 100644 --- a/test/intl402/Temporal/Calendar/prototype/monthDayFromFields/order-of-operations.js +++ b/test/intl402/Temporal/Calendar/prototype/monthDayFromFields/order-of-operations.js @@ -9,9 +9,6 @@ features: [Temporal] ---*/ const expected = [ - "get options.overflow", - "get options.overflow.toString", - "call options.overflow.toString", "get fields.day", "get fields.day.valueOf", "call fields.day.valueOf", @@ -30,6 +27,9 @@ const expected = [ "get fields.year", "get fields.year.valueOf", "call fields.year.valueOf", + "get options.overflow", + "get options.overflow.toString", + "call options.overflow.toString", ]; const actual = []; diff --git a/test/intl402/Temporal/Calendar/prototype/yearMonthFromFields/order-of-operations.js b/test/intl402/Temporal/Calendar/prototype/yearMonthFromFields/order-of-operations.js index 882cfd0b3a..ad3129730a 100644 --- a/test/intl402/Temporal/Calendar/prototype/yearMonthFromFields/order-of-operations.js +++ b/test/intl402/Temporal/Calendar/prototype/yearMonthFromFields/order-of-operations.js @@ -9,9 +9,6 @@ features: [Temporal] ---*/ const expected = [ - "get options.overflow", - "get options.overflow.toString", - "call options.overflow.toString", "get fields.era", "get fields.era.toString", "call fields.era.toString", @@ -27,6 +24,9 @@ const expected = [ "get fields.year", "get fields.year.valueOf", "call fields.year.valueOf", + "get options.overflow", + "get options.overflow.toString", + "call options.overflow.toString", ]; const actual = [];