tyler.durden
/
test262
mirror of https://github.com/tc39/test262.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

asyncHelpers implementation: Apply suggestions from code review 

Co-authored-by: Philip Chimento <philip.chimento@gmail.com>
This commit is contained in:
Cam 2023-02-17 13:46:00 -08:00 committed by Philip Chimento
parent eb44f67274
commit d216cc1972
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
CONTRIBUTING.md
View File

@ -357,7 +357,6 @@ includes: [asyncHelpers.js]
asyncTest(async function() { asyncTest(async function() {
assert.sameValue(true, await someTestCode(1), "someTestCode(1) should return true"); assert.sameValue(true, await someTestCode(1), "someTestCode(1) should return true");
;
}); });
``` ```
@ -367,7 +366,7 @@ For more complicated asynchronous testing, such as testing Promise or other core
* If the argument to `$DONE` is a truthy value, the test is considered to have failed and the argument is displayed as the failure reason. * If the argument to `$DONE` is a truthy value, the test is considered to have failed and the argument is displayed as the failure reason.
### Checking Exception Type and Message in Asynchronous Tests ### Checking Exception Type in Asynchronous Tests
The `asyncHelpers.js` harness file defines `assert.throwsAsync`, analogous in form to `assert.throws`. It requires that the passed function _asynchronously_ throws the specified exception type, and will reject functions that synchronously throw the specified exception type (and presumably summon [Zalgo](https://blog.izs.me/2013/08/designing-apis-for-asynchrony/)). The `asyncHelpers.js` harness file defines `assert.throwsAsync`, analogous in form to `assert.throws`. It requires that the passed function _asynchronously_ throws the specified exception type, and will reject functions that synchronously throw the specified exception type (and presumably summon [Zalgo](https://blog.izs.me/2013/08/designing-apis-for-asynchrony/)).