PR Feedback

This commit is contained in:
Ron Buckton 2021-02-20 16:02:49 -08:00 committed by Rick Waldron
parent a567e4c819
commit d66f270313
3 changed files with 10 additions and 10 deletions

View File

@ -18,13 +18,13 @@ info: |
let groupNames = Object.getOwnPropertyNames(/(?<fst>.)|(?<snd>.)/du.exec("abcd").indices.groups); let groupNames = Object.getOwnPropertyNames(/(?<fst>.)|(?<snd>.)/du.exec("abcd").indices.groups);
assert.compareArray(groupNames, ["fst", "snd"]); assert.compareArray(groupNames, ["fst", "snd"]);
// // Properties are created with Define, not Set // Properties are created with Define, not Set
// let counter = 0; let counter = 0;
// Object.defineProperty(Object.prototype, 'x', {set() { counter++; }}); Object.defineProperty(Object.prototype, 'x', {set() { counter++; }});
let indices = /(?<x>.)/d.exec('a').indices; let indices = /(?<x>.)/d.exec('a').indices;
let groups = indices.groups; let groups = indices.groups;
// assert.sameValue(counter, 0); assert.sameValue(counter, 0);
// Properties are writable, enumerable and configurable // Properties are writable, enumerable and configurable
// (from CreateDataProperty) // (from CreateDataProperty)

View File

@ -30,16 +30,16 @@ r.hasIndices = "";
assert.sameValue(get.call(r), "", "hasIndices: the empty string"); assert.sameValue(get.call(r), "", "hasIndices: the empty string");
r.hasIndices = "string"; r.hasIndices = "string";
assert.sameValue(get.call(r), "s", "hasIndices: string"); assert.sameValue(get.call(r), "d", "hasIndices: string");
r.hasIndices = 86; r.hasIndices = 86;
assert.sameValue(get.call(r), "s", "hasIndices: 86"); assert.sameValue(get.call(r), "d", "hasIndices: 86");
r.hasIndices = Symbol(); r.hasIndices = Symbol();
assert.sameValue(get.call(r), "s", "hasIndices: Symbol()"); assert.sameValue(get.call(r), "d", "hasIndices: Symbol()");
r.hasIndices = []; r.hasIndices = [];
assert.sameValue(get.call(r), "s", "hasIndices: []"); assert.sameValue(get.call(r), "d", "hasIndices: []");
r.hasIndices = {}; r.hasIndices = {};
assert.sameValue(get.call(r), "s", "hasIndices: {}"); assert.sameValue(get.call(r), "d", "hasIndices: {}");

View File

@ -15,7 +15,7 @@ info: |
features: [regexp-match-indices, cross-realm] features: [regexp-match-indices, cross-realm]
---*/ ---*/
var dotAll = Object.getOwnPropertyDescriptor(RegExp.prototype, 'hasIndices').get; var hasIndices = Object.getOwnPropertyDescriptor(RegExp.prototype, 'hasIndices').get;
var other = $262.createRealm().global; var other = $262.createRealm().global;
var otherRegExpProto = other.RegExp.prototype; var otherRegExpProto = other.RegExp.prototype;
var otherRegExpGetter = Object.getOwnPropertyDescriptor(otherRegExpProto, 'hasIndices').get; var otherRegExpGetter = Object.getOwnPropertyDescriptor(otherRegExpProto, 'hasIndices').get;