Use BigInt values idiomatically

Prior to this commit, a number of tests used non-BigInt values where
BigInt value are commonly used. Although this was technically
permissible to validate the behavior under test, the atypical usage
patterns tended to obscure the tests' purpose. Replace with more
appropriate values.
This commit is contained in:
Mike Pennisi 2021-09-23 19:59:44 -04:00 committed by Rick Waldron
parent 741db35b65
commit de6583d61d
5 changed files with 15 additions and 15 deletions

View File

@ -29,14 +29,14 @@ testWithBigIntTypedArrayConstructors(TA => {
} catch (_) {}
// no error following grow:
array.includes(0);
array.includes(0n);
try {
ab.resize(BPE * 3);
} catch (_) {}
// no error following shrink (within bounds):
array.includes(0);
array.includes(0n);
var expectedError;
try {
@ -53,7 +53,7 @@ testWithBigIntTypedArrayConstructors(TA => {
}
assert.throws(expectedError, () => {
array.includes(0);
array.includes(0n);
throw new Test262Error('includes completed successfully');
});
});

View File

@ -29,14 +29,14 @@ testWithBigIntTypedArrayConstructors(TA => {
} catch (_) {}
// no error following grow:
array.indexOf(0);
array.indexOf(0n);
try {
ab.resize(BPE * 3);
} catch (_) {}
// no error following shrink (within bounds):
array.indexOf(0);
array.indexOf(0n);
var expectedError;
try {
@ -53,7 +53,7 @@ testWithBigIntTypedArrayConstructors(TA => {
}
assert.throws(expectedError, () => {
array.indexOf(0);
array.indexOf(0n);
throw new Test262Error('indexOf completed successfully');
});
});

View File

@ -29,14 +29,14 @@ testWithBigIntTypedArrayConstructors(TA => {
} catch (_) {}
// no error following grow:
array.join(0);
array.join(',');
try {
ab.resize(BPE * 3);
} catch (_) {}
// no error following shrink (within bounds):
array.join(0);
array.join(',');
var expectedError;
try {
@ -53,7 +53,7 @@ testWithBigIntTypedArrayConstructors(TA => {
}
assert.throws(expectedError, () => {
array.join(0);
array.join(',');
throw new Test262Error('join completed successfully');
});
});

View File

@ -29,14 +29,14 @@ testWithBigIntTypedArrayConstructors(TA => {
} catch (_) {}
// no error following grow:
array.lastIndexOf(0);
array.lastIndexOf(0n);
try {
ab.resize(BPE * 3);
} catch (_) {}
// no error following shrink (within bounds):
array.lastIndexOf(0);
array.lastIndexOf(0n);
var expectedError;
try {
@ -53,7 +53,7 @@ testWithBigIntTypedArrayConstructors(TA => {
}
assert.throws(expectedError, () => {
array.lastIndexOf(0);
array.lastIndexOf(0n);
throw new Test262Error('lastIndexOf completed successfully');
});
});

View File

@ -29,14 +29,14 @@ testWithBigIntTypedArrayConstructors(TA => {
} catch (_) {}
// no error following grow:
array.map(() => {});
array.map(() => 0n);
try {
ab.resize(BPE * 3);
} catch (_) {}
// no error following shrink (within bounds):
array.map(() => {});
array.map(() => 0n);
var expectedError;
try {
@ -53,7 +53,7 @@ testWithBigIntTypedArrayConstructors(TA => {
}
assert.throws(expectedError, () => {
array.map(() => {});
array.map(() => 0n);
throw new Test262Error('map completed successfully');
});
});