From e33d93fecce221af5de128c5050250141413d9d2 Mon Sep 17 00:00:00 2001 From: Richard Gibson Date: Wed, 23 Jul 2025 11:40:14 -0400 Subject: [PATCH] Try to avoid "Argument list too long" when many files are changed --- .github/workflows/checks.yml | 10 ++++------ .github/workflows/esmeta-test262.yml | 10 ++++------ 2 files changed, 8 insertions(+), 12 deletions(-) diff --git a/.github/workflows/checks.yml b/.github/workflows/checks.yml index 5606392203..eca7367f32 100644 --- a/.github/workflows/checks.yml +++ b/.github/workflows/checks.yml @@ -38,14 +38,12 @@ jobs: if: | github.event_name == 'pull_request' && steps.changed_tests.outputs.any_changed == 'true' - env: - CHANGED: ${{ steps.changed_tests.outputs.all_changed_files }} run: | - echo New or modified test files: - for file in $CHANGED; do + echo 'New or modified test files:' + for file in ${{ steps.changed_tests.outputs.all_changed_files }}; do echo $file - done - ./tools/lint/lint.py $CHANGED 2> >(tee errors.out >&2) + done | tee "$HOME/changed.txt" + cat "$HOME/changed.txt" | xargs ./tools/lint/lint.py 2> >(tee errors.out >&2) - name: Create annotations in the PR if: failure() && github.event_name == 'pull_request' diff --git a/.github/workflows/esmeta-test262.yml b/.github/workflows/esmeta-test262.yml index eb464f2f04..cf5dcd8344 100644 --- a/.github/workflows/esmeta-test262.yml +++ b/.github/workflows/esmeta-test262.yml @@ -39,11 +39,9 @@ jobs: - name: run test262 if: steps.changed_tests.outputs.any_changed == 'true' - env: - CHANGED: ${{ steps.changed_tests.outputs.all_changed_files }} run: | - echo New or modified test files: - for file in $CHANGED; do + echo 'New or modified test files:' + for file in ${{ steps.changed_tests.outputs.all_changed_files }}; do echo $file - done - "${ESMETA_HOME}"/bin/esmeta test262-test -status -test262dir=$(pwd) $CHANGED + done | tee "$HOME/changed.txt" + cat "$HOME/changed.txt" | xargs "${ESMETA_HOME}"/bin/esmeta test262-test -status -test262dir=$(pwd)