From e3c64eeb6be2a9fab4934537064eb9017f5f360e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andr=C3=A9=20Bargull?= Date: Wed, 30 Apr 2025 14:16:19 +0200 Subject: [PATCH] Remove onlyStrict flag and 'use strict' directive from tests which run in strict and non-strict mode --- test/staging/sm/Array/concat-spreadable-basic.js | 4 ---- test/staging/sm/Array/concat-spreadable-primitive.js | 4 ---- test/staging/sm/Proxy/define-writable-as-non-writable.js | 4 ---- test/staging/sm/Proxy/delete-non-extensible.js | 4 ---- test/staging/sm/Proxy/report-writable-as-non-writable.js | 4 ---- .../sm/extensions/element-setting-ToNumber-detaches.js | 9 --------- 6 files changed, 29 deletions(-) diff --git a/test/staging/sm/Array/concat-spreadable-basic.js b/test/staging/sm/Array/concat-spreadable-basic.js index d499d794c5..681a05b608 100644 --- a/test/staging/sm/Array/concat-spreadable-basic.js +++ b/test/staging/sm/Array/concat-spreadable-basic.js @@ -4,14 +4,11 @@ */ /*--- -flags: - - onlyStrict includes: [deepEqual.js] description: | pending esid: pending ---*/ -"use strict"; const x = Object.freeze([1, 2, 3]); @@ -44,4 +41,3 @@ assert.deepEqual(x.concat(array), [1, 2, 3, [5, 4]]); // Explicitly spreadable array[Symbol.isConcatSpreadable] = true; assert.deepEqual(x.concat(array), [1, 2, 3, 5, 4]); - diff --git a/test/staging/sm/Array/concat-spreadable-primitive.js b/test/staging/sm/Array/concat-spreadable-primitive.js index f570807979..93c5273d2e 100644 --- a/test/staging/sm/Array/concat-spreadable-primitive.js +++ b/test/staging/sm/Array/concat-spreadable-primitive.js @@ -4,14 +4,11 @@ */ /*--- -flags: - - onlyStrict includes: [compareArray.js] description: | pending esid: pending ---*/ -"use strict"; // Primitive values should never be tried to spread let primitives = [ @@ -41,4 +38,3 @@ for (let value of primitives) { prototype.length; } - diff --git a/test/staging/sm/Proxy/define-writable-as-non-writable.js b/test/staging/sm/Proxy/define-writable-as-non-writable.js index 58d83b99c9..471474f444 100644 --- a/test/staging/sm/Proxy/define-writable-as-non-writable.js +++ b/test/staging/sm/Proxy/define-writable-as-non-writable.js @@ -2,13 +2,10 @@ // This code is governed by the BSD license found in the LICENSE file. /*--- -flags: - - onlyStrict description: | pending esid: pending ---*/ -"use strict"; var target = {}; Object.defineProperty(target, "test", {configurable: false, writable: true, value: 5}); @@ -23,4 +20,3 @@ var proxy = new Proxy(target, { assert.throws(TypeError, () => Object.defineProperty(proxy, "test", {writable: false})); assert.throws(TypeError, () => Reflect.defineProperty(proxy, "test", {writable: false})); - diff --git a/test/staging/sm/Proxy/delete-non-extensible.js b/test/staging/sm/Proxy/delete-non-extensible.js index a2131bc05d..68f69887f5 100644 --- a/test/staging/sm/Proxy/delete-non-extensible.js +++ b/test/staging/sm/Proxy/delete-non-extensible.js @@ -2,13 +2,10 @@ // This code is governed by the BSD license found in the LICENSE file. /*--- -flags: - - onlyStrict description: | pending esid: pending ---*/ -"use strict"; var target = { test: true }; Object.preventExtensions(target); @@ -24,4 +21,3 @@ assert.sameValue(Reflect.deleteProperty(proxy, "missing"), true); assert.throws(TypeError, () => { delete proxy.test; }); assert.throws(TypeError, () => Reflect.deleteProperty(proxy, "test")); - diff --git a/test/staging/sm/Proxy/report-writable-as-non-writable.js b/test/staging/sm/Proxy/report-writable-as-non-writable.js index 813035dee9..b86fd24094 100644 --- a/test/staging/sm/Proxy/report-writable-as-non-writable.js +++ b/test/staging/sm/Proxy/report-writable-as-non-writable.js @@ -2,13 +2,10 @@ // This code is governed by the BSD license found in the LICENSE file. /*--- -flags: - - onlyStrict description: | pending esid: pending ---*/ -"use strict"; var target = {}; Object.defineProperty(target, "test", @@ -24,4 +21,3 @@ var proxy = new Proxy(target, { assert.throws(TypeError, () => Object.getOwnPropertyDescriptor(proxy, "test")); assert.throws(TypeError, () => Reflect.getOwnPropertyDescriptor(proxy, "test")); - diff --git a/test/staging/sm/extensions/element-setting-ToNumber-detaches.js b/test/staging/sm/extensions/element-setting-ToNumber-detaches.js index e771e4f870..d36ec574c5 100644 --- a/test/staging/sm/extensions/element-setting-ToNumber-detaches.js +++ b/test/staging/sm/extensions/element-setting-ToNumber-detaches.js @@ -4,19 +4,10 @@ */ /*--- -flags: - - onlyStrict description: | Don't assert assigning into memory detached while converting the value to assign into a number esid: pending ---*/ -"use strict"; // make test fail when limitation below is fixed - -// Technically per current spec the element-sets should throw in strict mode, -// but we just silently do nothing for now, somewhat due to limitations of our -// internal MOP (which can't easily say "try this special behavior, else fall -// back on normal logic"), somewhat because it's consistent with current -// behavior (as of this test's addition) for out-of-bounds sets. var ab = new ArrayBuffer(64); var ta = new Uint32Array(ab);