tyler.durden
/
test262
mirror of https://github.com/tc39/test262.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Property clearing code of RegExp constructor is wrong 

This code is setting values to $1 etc., which can be non-writable or accessors.
For example, https://github.com/tc39/proposal-regexp-legacy-features/ is specifying them as accessors, and they should throw an error when
it is done in strict code. We should execute `(/(?:)/).test("");` to clear them.
This commit is contained in:
Yusuke Suzuki 2020-08-26 12:39:11 -07:00 committed by Rick Waldron
parent b9cbff7378
commit e8cdf923ef
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
harness/testIntl.js
View File

@ -1,5 +1,6 @@
// Copyright (C) 2011 2012 Norbert Lindenberg. All rights reserved. // Copyright (C) 2011 2012 Norbert Lindenberg. All rights reserved.
// Copyright (C) 2012 2013 Mozilla Corporation. All rights reserved. // Copyright (C) 2012 2013 Mozilla Corporation. All rights reserved.
// Copyright (C) 2020 Apple Inc. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file. // This code is governed by the BSD license found in the LICENSE file.
/*--- /*---
description: | description: |
@ -2001,6 +2002,7 @@ var regExpProperties = ["$1", "$2", "$3", "$4", "$5", "$6", "$7", "$8", "$9",
var regExpPropertiesDefaultValues = (function () { var regExpPropertiesDefaultValues = (function () {
var values = Object.create(null); var values = Object.create(null);
(/(?:)/).test("");
regExpProperties.forEach(function (property) { regExpProperties.forEach(function (property) {
values[property] = RegExp[property]; values[property] = RegExp[property];
}); });
@ -2014,9 +2016,7 @@ var regExpPropertiesDefaultValues = (function () {
* RegExp constructor. * RegExp constructor.
*/ */
function testForUnwantedRegExpChanges(testFunc) { function testForUnwantedRegExpChanges(testFunc) {
regExpProperties.forEach(function (property) { (/(?:)/).test("");
RegExp[property] = regExpPropertiesDefaultValues[property];
});
testFunc(); testFunc();
regExpProperties.forEach(function (property) { regExpProperties.forEach(function (property) {
if (RegExp[property] !== regExpPropertiesDefaultValues[property]) { if (RegExp[property] !== regExpPropertiesDefaultValues[property]) {