tyler.durden/test262
1
0
Fork 0
mirror of https://github.com/tc39/test262.git synced 2025-07-24 14:35:30 +02:00
Code Issues Packages Projects Releases Wiki Activity

generation: DRY list(OrderedDict) idiom

Browse Source 
A named function is also more self-documenting. Thanks to Richard for the
suggestion.
This commit is contained in:
Philip Chimento 2024-10-16 11:39:34 -07:00 committed by Philip Chimento
parent d9d48fdd99
commit faca8af32d
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
tools/generation/lib/template.py
View File

@ -49,6 +49,11 @@ def indent(text, prefix = ' ', js_value = False):
return '\n'.join(indented) return '\n'.join(indented)
def without_duplicates(iterable):
return list(OrderedDict.fromkeys(iterable))
class Template: class Template:
def __init__(self, filename, encoding): def __init__(self, filename, encoding):
self.filename = filename self.filename = filename
@ -160,7 +165,7 @@ class Template:
features = [] features = []
features += case_values['meta'].get('features', []) features += case_values['meta'].get('features', [])
features += self.attribs['meta'].get('features', []) features += self.attribs['meta'].get('features', [])
features = list(OrderedDict.fromkeys(features)) features = without_duplicates(features)
if len(features): if len(features):
lines += ['features: ' + yaml.dump(features, lines += ['features: ' + yaml.dump(features,
default_flow_style=True, width=float('inf')).strip()] default_flow_style=True, width=float('inf')).strip()]
@ -176,7 +181,7 @@ class Template:
flags = ['generated'] flags = ['generated']
flags += case_values['meta'].get('flags', []) flags += case_values['meta'].get('flags', [])
flags += self.attribs['meta'].get('flags', []) flags += self.attribs['meta'].get('flags', [])
flags = list(OrderedDict.fromkeys(flags)) flags = without_duplicates(flags)
if 'async' in flags and negative and negative.get('phase') == 'parse' and negative.get('type') == 'SyntaxError': if 'async' in flags and negative and negative.get('phase') == 'parse' and negative.get('type') == 'SyntaxError':
flags.remove('async') flags.remove('async')
lines += ['flags: ' + yaml.dump(flags, default_flow_style=True, lines += ['flags: ' + yaml.dump(flags, default_flow_style=True,
@ -185,7 +190,7 @@ class Template:
includes = [] includes = []
includes += case_values['meta'].get('includes', []) includes += case_values['meta'].get('includes', [])
includes += self.attribs['meta'].get('includes', []) includes += self.attribs['meta'].get('includes', [])
includes = list(OrderedDict.fromkeys(includes)) includes = without_duplicates(includes)
if len(includes): if len(includes):
lines += ['includes: ' + yaml.dump(includes, lines += ['includes: ' + yaml.dump(includes,
default_flow_style=True, width=float('inf')).strip()] default_flow_style=True, width=float('inf')).strip()]