From fd75ab00970946c0da74e8304c442347b26c437c Mon Sep 17 00:00:00 2001 From: Caio Lima Date: Mon, 18 Mar 2019 22:18:55 -0300 Subject: [PATCH] Adding tests to verify private fields on Proxy Objects (#2099) --- .../class/elements/privatefield-on-proxy.js | 53 +++++++++++++++++ .../class/elements/privategetter-on-proxy.js | 59 +++++++++++++++++++ .../class/elements/privatemethods-on-proxy.js | 55 +++++++++++++++++ 3 files changed, 167 insertions(+) create mode 100644 test/language/statements/class/elements/privatefield-on-proxy.js create mode 100644 test/language/statements/class/elements/privategetter-on-proxy.js create mode 100644 test/language/statements/class/elements/privatemethods-on-proxy.js diff --git a/test/language/statements/class/elements/privatefield-on-proxy.js b/test/language/statements/class/elements/privatefield-on-proxy.js new file mode 100644 index 0000000000..467cc4a136 --- /dev/null +++ b/test/language/statements/class/elements/privatefield-on-proxy.js @@ -0,0 +1,53 @@ +// Copyright (C) 2019 Caio Lima. All rights reserved. +// This code is governed by the BSD license found in the LICENSE file. + +/*--- +description: Sucessyfully get private reference without using [[Get]] +esid: sec-getvalue +info: | + GetValue(V) + ... + 5. If IsPropertyReference(V), then + ... + b. If IsPrivateReference(V), then + i. Let env be the running execution context's PrivateNameEnvironment. + ii. Let field be ? ResolveBinding(GetReferencedName(V), env). + iii. Assert: field is a Private Name. + iv. Return ? PrivateFieldGet(field, base). + c. Return ? base.[[Get]](GetReferencedName(V), GetThisValue(V)). + PrivateFieldGet(P, O) + 1. Assert: P is a Private Name value. + 2. If O is not an object, throw a TypeError exception. + 3. Let entry be PrivateFieldFind(P, O). + 4. If entry is empty, throw a TypeError exception. + 5. Return entry.[[PrivateFieldValue]]. +includes: [compareArray.js] +features: [class, class-fields-private, Proxy] +---*/ + +let arr = []; + +class ProxyBase { + constructor() { + return new Proxy(this, { + get: function (obj, prop) { + arr.push(prop); + return obj[prop]; + } + }); + } +} + +class Test extends ProxyBase { + #f = 3; + method() { + return this.#f; + } +} + +let t = new Test(); +let r = t.method(); +assert.sameValue(r, 3); + +assert.compareArray(arr, ['method']); + diff --git a/test/language/statements/class/elements/privategetter-on-proxy.js b/test/language/statements/class/elements/privategetter-on-proxy.js new file mode 100644 index 0000000000..7e546f1cac --- /dev/null +++ b/test/language/statements/class/elements/privategetter-on-proxy.js @@ -0,0 +1,59 @@ +// Copyright (C) 2019 Caio Lima. All rights reserved. +// This code is governed by the BSD license found in the LICENSE file. + +/*--- +description: Successfully access private getter on Proxy objects without using [[Get]] +esid: sec-getvalue +info: | + GetValue(V) + ... + 5. If IsPropertyReference(V), then + ... + b. If IsPrivateReference(V), then + i. Let env be the running execution context's PrivateNameEnvironment. + ii. Let field be ? ResolveBinding(GetReferencedName(V), env). + iii. Assert: field is a Private Name. + iv. Return ? PrivateFieldGet(field, base). + c. Return ? base.[[Get]](GetReferencedName(V), GetThisValue(V)). + PrivateFieldGet(P, O) + ... + 4. Perform ? PrivateBrandCheck(O, P). + 5. If P.[[Kind]] is "method", + ... + 6. Else, + a. Assert: P.[[Kind]] is "accessor". + b. If P does not have a [[Get]] field, throw a TypeError exception. + c. Let getter be P.[[Get]]. + d. Return ? Call(getter, O). +includes: [compareArray.js] +features: [class, class-methods-private, Proxy] +---*/ + +let arr = []; + +class ProxyBase { + constructor() { + return new Proxy(this, { + get: function (obj, prop) { + arr.push(prop); + return obj[prop]; + } + }); + } +} + +class Test extends ProxyBase { + get #f() { + return 3; + } + method() { + return this.#f; + } +} + +let t = new Test(); +let r = t.method(); +assert.sameValue(r, 3); + +assert.compareArray(arr, ['method']); + diff --git a/test/language/statements/class/elements/privatemethods-on-proxy.js b/test/language/statements/class/elements/privatemethods-on-proxy.js new file mode 100644 index 0000000000..beb1f57214 --- /dev/null +++ b/test/language/statements/class/elements/privatemethods-on-proxy.js @@ -0,0 +1,55 @@ +// Copyright (C) 2019 Caio Lima. All rights reserved. +// This code is governed by the BSD license found in the LICENSE file. + +/*--- +description: Successfully access private method on Proxy objects without using [[Get]] +esid: sec-getvalue +info: | + GetValue(V) + ... + 5. If IsPropertyReference(V), then + ... + b. If IsPrivateReference(V), then + i. Let env be the running execution context's PrivateNameEnvironment. + ii. Let field be ? ResolveBinding(GetReferencedName(V), env). + iii. Assert: field is a Private Name. + iv. Return ? PrivateFieldGet(field, base). + c. Return ? base.[[Get]](GetReferencedName(V), GetThisValue(V)). + PrivateFieldGet(P, O) + ... + 4. Perform ? PrivateBrandCheck(O, P). + 5. If P.[[Kind]] is "method", + a. Return P.[[Value]]. + ... +includes: [compareArray.js] +features: [class, class-methods-private, Proxy] +---*/ + +let arr = []; + +class ProxyBase { + constructor() { + return new Proxy(this, { + get: function (obj, prop) { + arr.push(prop); + return obj[prop]; + } + }); + } +} + +class Test extends ProxyBase { + #f() { + return 3; + } + method() { + return this.#f(); + } +} + +let t = new Test(); +let r = t.method(); +assert.sameValue(r, 3); + +assert.compareArray(arr, ['method']); +