Commit Graph

7 Commits

Author SHA1 Message Date
Philip Chimento 615a2eb9a1 Fix tests for private reference with logical assignment
There were three things wrong with the 'and', 'or', and 'nullish' tests
that I added as part of #2940:

1. They were in the wrong folder (should be
   expressions/logical-assignment, not expressions/compound-assignment)
2. The tests for ||= and ??= on readonly accessor properties were
   incorrect. These assignments would short-circuit if the getter
   returned 1 as it previously did, so PutValue would not throw.
3. The tests for ||= and ??= on private methods were invalid, as a
   method always evaluates to true in a boolean context, and is not
   nullish, so these would always short-circuit.

I've removed the invalid private method cases, fixed the readonly
accessor cases, and added new templates to test the short-circuit
behaviour as well as the non-short-circuit behaviour.

Closes: #3413
2022-02-21 15:38:59 -05:00
Justin Ridgewell 5783f55b70 Fix init values 2020-06-10 12:34:03 -04:00
Justin Ridgewell cbea466883 Add test for NamedEvaluation of Logical Assignment 2020-06-10 12:34:03 -04:00
Rick Waldron ffaae1f7ec Logical Assignment Operators: additional syntax tests 2020-03-31 15:05:04 -04:00
Justin Ridgewell 2778324491 Fix tests 2020-03-31 10:56:40 -04:00
Justin Ridgewell 78dbc401b1 Add logical-assignment-operators feature 2020-03-31 10:56:40 -04:00
Justin Ridgewell fdf4675da9 Add tests for Logical Assignment 2020-03-31 10:56:40 -04:00