Commit Graph

19 Commits

Author SHA1 Message Date
Gus Caplan 833825849d
add lint check for newline at end of file 2019-11-10 20:18:53 -08:00
Mike Pennisi a9111d7144 lint: add rule to verify use of harness files
Verify that every test file which references a harness file using the
"includes" directive also contains at least one reference to a value
defined in the harness file.

To support this check, extend each harness file with a list of values
which it defines.
2019-09-25 14:00:50 -04:00
Ms2ger f7896ada9e Lint: Use the print function rather than the statement. 2019-08-12 17:14:07 +02:00
Ms2ger f899f9524c Lint: Use items() rather than iteritems(). 2019-08-12 17:14:07 +02:00
Ms2ger 8f5f6a1aa1 tools: update lint.py to work with pip 10+ some more (#2273)
main() and InstallRequirement were also removed from the public API.
2019-08-08 14:11:34 -04:00
André Bargull c822f4c929 Fix existing linting errors, update error phase, and add a new flags linter (#2086) 2019-03-06 12:24:44 -05:00
Leo Balter e7092eacc4 set lint rules to avoid leading or trailing empty lines in frontmatter string values
Fix #2034
Ref #1997
2019-02-25 16:14:21 -05:00
Leo Balter 7054805941
rename whitelist to exceptions in the linter tool (#2004) 2018-12-18 15:39:57 -02:00
Ujjwal Sharma fbd79b10a7 tools: update lint.py to work with pip 10+
Update the lint.py script to work with pip 10+ as pip.req was moved to
pip._internal.req in version 10 onwards and the existing code only works
on versions of pip under or equal to 9.0.3
2018-09-17 13:30:01 -04:00
Rick Waldron c686cc6099 Lint: disallow calls to verifyConfigurable and verifyProperty in same file 2018-06-07 22:38:36 -04:00
Valerie R Young 40883f4c6a Update filename character restriction in documention, linter and a few filenames 2018-05-11 22:19:01 -04:00
Rick Waldron 50d840acea Lint: inflect for pluralizing 2018-01-11 10:20:37 -05:00
Adrian Heine 0278a7d2a5 Add es[56]?id checks 2018-01-10 15:28:58 -05:00
Rick Waldron 5a791f37f4 tools/lint: install PyYAML if not available. Fixes gh-1286 2017-10-18 12:21:36 -04:00
Rick Waldron 62a73c0edd Lint: fix import order 2017-09-08 12:45:58 -04:00
Rick Waldron 65424be3ef Lint: harness features flag enforcement via linter 2017-09-08 12:24:48 -04:00
Mike Pennisi 53842533b7 Enforce use of `throw` stmt in early error tests
Previously, test consumers were encouraged to insert a `throw` statement
as the first statement of tests for early errors. This recommendation
made tests harder to consume, and as an optional transformation,
consumers may have ignored it or simply been unaware it was made. By
explicitly including such a `throw` statement, the tests become more
literal, making them easier to consume and more transparent in their
expectations.

Document expectation for all tests for early errors to include an
explicit `throw` statement. Extend linting script to verify that
contributors are automatically notified of violations and to ensure that
future contributions satisfy this expectation.
2017-06-28 11:24:36 -04:00
jugglinmike 66bd632bae Lint test `features` tag (#1060)
A recent commit introduced a document that enumerated acceptable values
for the test "features" metadata tag. However, this list was incomplete,
and maintaining it placed extra burden on the project owners.

Restructure the document into a machine-readable format. Add entries for
all previously-omitted values. Add in-line documentation with
recommendations for maintenance of the file. Extend the project's
linting tool to validate tests according to the document's contents.
2017-06-12 18:59:14 -03:00
jugglinmike 74954bfa91 Introduce automated validation for test format (#994)
This script is intended to identify common test file formatting errors
prior to their acceptance into the project. It is designed to support
future extensions for additional validation rules.
2017-05-01 12:04:05 -04:00