Commit Graph

7 Commits

Author SHA1 Message Date
Philip Chimento ac1c3546c3 Fix argument in example calls to assert.throwsAsync()
Thanks Ashley!
2023-01-20 10:25:54 -08:00
Cam 7f3558376d Fix typo in rfcs/async-helpers.md
Co-authored-by: Philip Chimento <philip.chimento@gmail.com>
2023-01-20 10:25:54 -08:00
Cam Tenny edd1e6d25f Update rfcs/async-helpers to reflect the pre-final comment consensus API for asyncTest and assert.throwsAsync 2023-01-20 10:25:54 -08:00
Philip Chimento a776c8a948 Resolve → Fulfill
Using the correct terminology here.
2023-01-20 10:25:54 -08:00
Philip Chimento 29fbe30eda Fix mistake in dynamic import test example
I overlooked the fact that passing an imported module object to $DONE will
correctly fail the test.

I still think this way of writing the test is unclear, though.
2023-01-20 10:25:54 -08:00
Philip Chimento d9dd1e8d03 Add pull request link 2023-01-20 10:25:54 -08:00
Philip Chimento 1f0702b72a RFC: Async Helpers
This proposes a `harness/asyncHelpers.js` file with two helpers in it,
`asyncTest()` and `assert.throwsAsync()`. See the RFC for further
motivation and details.

Note the draft RFC process in https://github.com/tc39/test262/pull/3525.
My idea for this pull request is that besides being an RFC in its own
right, we use it as a test case for the process. That is, we follow the
draft RFC process and hopefully either validate it, or surface changes
that need to be made, after which we can land the RFC process in our
documentation.
2023-01-20 10:25:54 -08:00