Commit Graph

200 Commits

Author SHA1 Message Date
Leo Balter 002d3484d6 Add tests for linter 2019-07-15 14:03:25 -04:00
Leo Balter 8b28871eca Update header regexp to prevent year ranges 2019-07-15 14:03:25 -04:00
Aleksey Shvayka a8d4eefa85 Skip hidden files in generator.py (#2183) 2019-05-29 10:58:53 -04:00
Leo Balter 3d4909b0fd
Use .. for git diffs in the CI routines (#2140)
the double dot gets only commits not in the left side of the double dot.

The right side assumes HEAD.

This will allow us to fetch the correct list of new or modified files in the current branch.
2019-04-25 17:56:55 -04:00
Leo Balter ebbe13e2b5
Add CircleCI (#2106)
Transfer Travis jobs to CircleCI
2019-03-20 21:04:41 -04:00
André Bargull c822f4c929 Fix existing linting errors, update error phase, and add a new flags linter (#2086) 2019-03-06 12:24:44 -05:00
André Bargull 41edfcebce Remove old test format parser and simplify yaml frontmatter parsing 2019-02-28 06:39:59 -08:00
Leo Balter e7092eacc4 set lint rules to avoid leading or trailing empty lines in frontmatter string values
Fix #2034
Ref #1997
2019-02-25 16:14:21 -05:00
Leo Balter b4e15b3d5c fix parseTestRecord for optional license header at the top 2019-02-25 15:23:40 -05:00
Leo Balter 0f64e61451 update tests for packaging tools 2019-02-25 15:23:40 -05:00
Leo Balter 8e0c0eac10 Linter should require direct throw statement for raw tests instead of DONOTEVALUATE 2019-02-14 15:06:08 -05:00
Leo Balter 48a7471060 Relax lint check for licensing in files 2019-02-14 15:06:08 -05:00
Leo Balter 7054805941
rename whitelist to exceptions in the linter tool (#2004) 2018-12-18 15:39:57 -02:00
Leo Balter dec4e5df74
Merge pull request #1801 from mathiasbynens/issue-1634
Move `throw "…"` for negative parsing errors to a helper function
2018-11-13 17:23:09 -05:00
Leo Balter d534df2b12 Use travis ci to run new or modified test files on engines 2018-11-07 10:03:00 -05:00
Mathias Bynens 8869799c6d Rebase, regenerate, and update tests 2018-10-23 13:51:17 +02:00
Mathias Bynens b9daa57dcb Rename to $DONOTEVALUATE per @leobalter's suggestion 2018-10-23 13:51:17 +02:00
Mathias Bynens e3feffb01e Move `throw "…"` for negative parsing errors to a helper function
Closes #1634.
2018-10-23 13:51:16 +02:00
Mathias Bynens 73d9169cab Generation: fix more YAML frontmatter writer to eliminate errant newlines from yaml.dump()
This applies the fix from #1821 to the remaining frontmatter properties that consist of lists.

Ref. https://github.com/tc39/test262/pull/1821/files#r222811633.
Ref. #1817.
2018-10-17 10:51:10 -04:00
Mathias Bynens e654d7b2ae Quote variables in ci_build.sh (#1858)
This makes it possible to run the script locally even if `TRAVIS_PULL_REQUEST` is not set.

Currently, it results in an error:

tools/scripts/ci_build.sh: line 2: [: !=: unary operator expected
2018-10-15 11:02:51 -04:00
Rick Waldron 01e67df36e Generation: fix yaml frontmatter writer to eliminate errant newlines from yaml.dump() 2018-10-04 16:21:11 -04:00
Ujjwal Sharma fbd79b10a7 tools: update lint.py to work with pip 10+
Update the lint.py script to work with pip 10+ as pip.req was moved to
pip._internal.req in version 10 onwards and the existing code only works
on versions of pip under or equal to 9.0.3
2018-09-17 13:30:01 -04:00
Rick Waldron ae925f6791 Lint: make esid check allow "%" (#1638) 2018-07-13 16:39:32 -04:00
jugglinmike ac02aa57ff Relax linting rules for `esid` metadata (#1632)
The document fragments used by the ECMAScript specification do not
conform to any particular pattern beyond the grammar defined by the URL
standard [1]. Relax the linting rule to enforce a simplified version of
that grammar.

[1] https://url.spec.whatwg.org/#fragment-state
2018-07-09 12:29:43 -04:00
Rick Waldron 7dc92154af Frontmatter: Adds top level "locale" attribute. Fixes gh-1515 (#1561) 2018-06-19 14:56:30 -04:00
Leo Balter f87f744741
Avoid printing tests source in the lint script (#1602) 2018-06-18 21:09:55 -04:00
Rick Waldron c686cc6099 Lint: disallow calls to verifyConfigurable and verifyProperty in same file 2018-06-07 22:38:36 -04:00
Valerie R Young 40883f4c6a Update filename character restriction in documention, linter and a few filenames 2018-05-11 22:19:01 -04:00
André Bargull 4daa3de9bf Make parseTestRecord.py python3 compatible 2018-04-24 09:52:57 -07:00
jugglinmike 7b01f9799f [generation] Tolerate unicode in source files (#1411) 2018-02-09 11:27:33 -05:00
Rick Waldron 50d840acea Lint: inflect for pluralizing 2018-01-11 10:20:37 -05:00
Rick Waldron 1a057550d8 tools/lint/lib/checks/esid.py: allow "sup-" 2018-01-10 17:32:37 -05:00
Rick Waldron 40cb228633 lint: accept frontmatter without esid, es6id. 2018-01-10 17:25:44 -05:00
Adrian Heine 0278a7d2a5 Add es[56]?id checks 2018-01-10 15:28:58 -05:00
Mike Pennisi e6d674ef7a Rename negative test "phase" for module resolution 2018-01-05 15:17:51 -05:00
Mike Pennisi 136110378b Rename negative test "phase" for parsing
Early errors may result from parsing the source text of a test file, but
they may also result from parsing some other source text as referenced
through the ES2015 module syntax. The latter form of early error is not
necessarily detectable by ECMAScript parsers, however. Because of this,
the label "early" is not sufficiently precise for all Test262 consumers
to correctly interpret all tests.

Update the "phase" name of "early" to "parse" for all those negative
tests that describe errors resulting from parsing of the file's source
text directly. A forthcoming commit will update the remaining tests to
use a "phase" name that is more specific to module resolution.
2018-01-05 15:17:50 -05:00
Adrian Heine 8e7213db38 Remove unused constants in checks/features.py 2018-01-05 12:10:01 -05:00
Rick Waldron 5a791f37f4 tools/lint: install PyYAML if not available. Fixes gh-1286 2017-10-18 12:21:36 -04:00
⭐caitp⭐ b006e1c7c7 Add a little helper for convenience in testing changes (#1260) 2017-10-04 11:46:21 -04:00
Rick Waldron e294b8004d Rename fixture and change actual test, because an empty "features" list is invalid anyway! 2017-09-08 13:05:21 -04:00
Rick Waldron 1df51ee19c Lint/test: update multiple includes test 2017-09-08 12:48:06 -04:00
Rick Waldron 62a73c0edd Lint: fix import order 2017-09-08 12:45:58 -04:00
Rick Waldron f1d38f5b3d Lint: add missing return to CheckHarnessFeatures().run 2017-09-08 12:41:24 -04:00
Rick Waldron c7a5d21bee Lint: fix CheckHarnessFeatures.comparison_result_lists initial condition checks order 2017-09-08 12:28:22 -04:00
Rick Waldron 65424be3ef Lint: harness features flag enforcement via linter 2017-09-08 12:24:48 -04:00
Leo Balter ccaf340d85 silence the make.py clean command on Travis (#1194) 2017-08-23 13:45:33 -04:00
Mike Pennisi 53842533b7 Enforce use of `throw` stmt in early error tests
Previously, test consumers were encouraged to insert a `throw` statement
as the first statement of tests for early errors. This recommendation
made tests harder to consume, and as an optional transformation,
consumers may have ignored it or simply been unaware it was made. By
explicitly including such a `throw` statement, the tests become more
literal, making them easier to consume and more transparent in their
expectations.

Document expectation for all tests for early errors to include an
explicit `throw` statement. Extend linting script to verify that
contributors are automatically notified of violations and to ensure that
future contributions satisfy this expectation.
2017-06-28 11:24:36 -04:00
jugglinmike 66bd632bae Lint test `features` tag (#1060)
A recent commit introduced a document that enumerated acceptable values
for the test "features" metadata tag. However, this list was incomplete,
and maintaining it placed extra burden on the project owners.

Restructure the document into a machine-readable format. Add entries for
all previously-omitted values. Add in-line documentation with
recommendations for maintenance of the file. Extend the project's
linting tool to validate tests according to the document's contents.
2017-06-12 18:59:14 -03:00
André Bargull dd1f55a3dc Allow to specify negative frontmatter values in templates files 2017-05-04 09:29:37 -07:00
jugglinmike 74954bfa91 Introduce automated validation for test format (#994)
This script is intended to identify common test file formatting errors
prior to their acceptance into the project. It is designed to support
future extensions for additional validation rules.
2017-05-01 12:04:05 -04:00