Commit Graph

9 Commits

Author SHA1 Message Date
Rick Waldron e294b8004d Rename fixture and change actual test, because an empty "features" list is invalid anyway! 2017-09-08 13:05:21 -04:00
Rick Waldron 1df51ee19c Lint/test: update multiple includes test 2017-09-08 12:48:06 -04:00
Rick Waldron 62a73c0edd Lint: fix import order 2017-09-08 12:45:58 -04:00
Rick Waldron f1d38f5b3d Lint: add missing return to CheckHarnessFeatures().run 2017-09-08 12:41:24 -04:00
Rick Waldron c7a5d21bee Lint: fix CheckHarnessFeatures.comparison_result_lists initial condition checks order 2017-09-08 12:28:22 -04:00
Rick Waldron 65424be3ef Lint: harness features flag enforcement via linter 2017-09-08 12:24:48 -04:00
Mike Pennisi 53842533b7 Enforce use of `throw` stmt in early error tests
Previously, test consumers were encouraged to insert a `throw` statement
as the first statement of tests for early errors. This recommendation
made tests harder to consume, and as an optional transformation,
consumers may have ignored it or simply been unaware it was made. By
explicitly including such a `throw` statement, the tests become more
literal, making them easier to consume and more transparent in their
expectations.

Document expectation for all tests for early errors to include an
explicit `throw` statement. Extend linting script to verify that
contributors are automatically notified of violations and to ensure that
future contributions satisfy this expectation.
2017-06-28 11:24:36 -04:00
jugglinmike 66bd632bae Lint test `features` tag (#1060)
A recent commit introduced a document that enumerated acceptable values
for the test "features" metadata tag. However, this list was incomplete,
and maintaining it placed extra burden on the project owners.

Restructure the document into a machine-readable format. Add entries for
all previously-omitted values. Add in-line documentation with
recommendations for maintenance of the file. Extend the project's
linting tool to validate tests according to the document's contents.
2017-06-12 18:59:14 -03:00
jugglinmike 74954bfa91 Introduce automated validation for test format (#994)
This script is intended to identify common test file formatting errors
prior to their acceptance into the project. It is designed to support
future extensions for additional validation rules.
2017-05-01 12:04:05 -04:00