test262/test/language
Mike Pennisi f782971ad2 Remove harness file, arrayContains.js
The `arrayContains` function has a number of deficiencies which make it
inappropriate for Test262:

- It apparently isn't very useful: despite being available for over 7
  years, fewer than ten tests use it
- It's misleading: its documentation reads, "Verify that a subArray is
  contained within an array." In reality, it only verifies that all the
  elements of one array are present in another--order does not matter.
- It's not ergonomic for test authors: it has been misused to create
  tests that were prone to false positives [1]
- It's not ergonomic for implementers: ostensibly designed for use with
  `assert`, the failure messages produced by tests that use it do not
  necessarily have very much context

All code in the "harness" directory adds to the total amount of
project-specific information which contributors are expected to to
learn. In light of the above deficiencies, the burden of this particular
harness file is unjustified.

Remove the harness file and its associated tests. Update the tests which
depend on it to express their expectations using alternate methods, and
strengthen the tests to assert element order wherever appropriate.

[1] https://github.com/tc39/test262/pull/3289
2021-11-01 12:55:10 -04:00
..
arguments-object chore: migrate $ERROR -> throw new Test262Error in test/language/a* (#3095) 2021-07-21 13:42:51 -07:00
asi chore: migrate $ERROR -> throw new Test262Error in test/language/a* (#3095) 2021-07-21 13:42:51 -07:00
block-scope Remove harness file, arrayContains.js 2021-11-01 12:55:10 -04:00
comments Throw distinctive errors for different failures 2021-09-02 10:36:00 -04:00
computed-property-names Transform compareArray -> assert.compareArray: test/language/**/*.js (#3239) 2021-10-15 20:35:01 -04:00
destructuring/binding Improved metadata 2020-11-18 16:44:55 -05:00
directive-prologue Fix existing linting errors, update error phase, and add a new flags linter (#2086) 2019-03-06 12:24:44 -05:00
eval-code chore: migrate $ERROR -> throw new Test262Error in test/language/e* (#3098) 2021-07-28 13:48:39 -07:00
export Update "info" field (#2941) 2021-01-28 16:03:01 -08:00
expressions generate tests 2021-10-22 09:00:00 -04:00
function-code chore: migrate $ERROR -> throw new Test262Error in test/language/f* (#3099) 2021-07-28 13:47:49 -07:00
future-reserved-words Strengthen sloppy-mode tests for future reserved words. 2021-04-20 09:54:23 -04:00
global-code chore: migrate $ERROR -> throw new Test262Error in test/language/g* (#3101) 2021-07-28 13:47:15 -07:00
identifier-resolution chore: migrate $ERROR -> throw new Test262Error in test/language/i* (#3102) 2021-07-28 13:46:58 -07:00
identifiers Add tests for Unicode v14 Identifier{Start,Part} (#3198) 2021-10-15 20:19:22 -04:00
import Add 'import-assertions' feature tag to json modules tests (#3016) 2021-06-24 14:13:45 -04:00
keywords Rename to $DONOTEVALUATE per @leobalter's suggestion 2018-10-23 13:51:17 +02:00
line-terminators chore: migrate $ERROR -> throw new Test262Error in test/language/line-terminators/* (#3103) 2021-07-28 13:46:23 -07:00
literals chore: migrate $ERROR -> throw new Test262Error in test/language/l* (#3104) 2021-07-28 13:45:44 -07:00
module-code Revert "Merge pull request #3219 from tc39/rwaldron/migrate-comparearray" 2021-10-01 10:18:47 -04:00
punctuators Rename to $DONOTEVALUATE per @leobalter's suggestion 2018-10-23 13:51:17 +02:00
reserved-words Rename to $DONOTEVALUATE per @leobalter's suggestion 2018-10-23 13:51:17 +02:00
rest-parameters Transform compareArray -> assert.compareArray: test/language/**/*.js (#3239) 2021-10-15 20:35:01 -04:00
source-text chore: migrate $ERROR -> throw new Test262Error in test/language/s* 2021-07-29 10:38:53 -04:00
statementList Remove superfluous EmptyStatement 2021-10-05 16:28:06 -04:00
statements Transform compareArray -> assert.compareArray: test/language/**/*.js (#3239) 2021-10-15 20:35:01 -04:00
types chore: migrate $ERROR -> throw new Test262Error in test/language/t* (#3106) 2021-07-28 13:44:19 -07:00
white-space chore: migrate $ERROR -> throw new Test262Error in test/language/white-space/* (#3107) 2021-07-28 13:43:40 -07:00