mirror of
https://github.com/tc39/test262.git
synced 2025-05-26 01:30:28 +02:00
d87a7da6e1
While we're at it, use assert() instead of assert.sameValue() for brevity,
if we are not specifically testing that the return value of hasOwnProperty
is the value true or false; and add more informative assertion messages to
help with debugging.
In some cases, the Object.hasOwnProperty.call could be replaced with
verifyProperty(), if the property descriptor was also being verified at
the same time.
This fixes some tests that were faulty to begin with: a common mistake was
Object.hasOwnProperty(obj, prop) which is probably going to return false
when that's not what you want.
The only instances left of `Object.hasOwnProperty` are one regression test
in implementation-contributed which I can't tell if it was intentionally
needed to trigger the regression, and a few instances of
`Object.hasOwnProperty('prototype')` which would defeat the purpose to
convert into `Object.prototype.hasOwnProperty.call(Object, 'prototype')`
form.
Closes: #3524
29 lines
881 B
JavaScript
29 lines
881 B
JavaScript
// Copyright (C) 2015 the V8 project authors. All rights reserved.
|
|
// This code is governed by the BSD license found in the LICENSE file.
|
|
/*---
|
|
es6id: 19.1.2.1
|
|
description: Does not assign non-enumerable source properties
|
|
info: |
|
|
[...]
|
|
5. For each element nextSource of sources, in ascending index order,
|
|
c. Repeat for each element nextKey of keys in List order,
|
|
i. Let desc be from.[[GetOwnProperty]](nextKey).
|
|
ii. ReturnIfAbrupt(desc).
|
|
iii. if desc is not undefined and desc.[[Enumerable]] is true, then
|
|
---*/
|
|
|
|
var target = {};
|
|
var source = Object.defineProperty({}, 'attr', {
|
|
value: 1,
|
|
enumerable: false
|
|
});
|
|
var result;
|
|
|
|
result = Object.assign(target, source);
|
|
|
|
assert(
|
|
!Object.prototype.hasOwnProperty.call(target, 'attr'),
|
|
"Non-enumerable property 'attr' does not get copied to target"
|
|
);
|
|
assert.sameValue(result, target);
|