Add async backpressure checks to review agents and skill

tux commented

2026-06-26 09:08:59 +02:00

Owner

Motivated by the Cloudflare hyper truncation bug (a dropped
Poll::Pending in poll_flush that lets shutdown race an unfinished
write, silently truncating the response). The template's static
reviewers could not catch this class; these edits raise the odds of
surfacing it and add the test pattern that actually catches it.

code-reviewer: scope note to read whole I/O/protocol modules; run
clippy (with the restriction lint let_underscore_must_use that
pedantic misses); discarded-result item; Rust async/concurrency
sub-section covering Pending propagation, flush-before-teardown,
partial writes, wakers, cancellation, and a slow-reader test gate.
security-auditor: dropped-readiness item framing silent truncation
as a data-integrity/availability defect (? is not sufficient).
code-quality skill: restriction lint in the clippy command, async
standards, and a verified BackpressureSink helper plus a
bytes-delivered == Content-Length completeness oracle.

Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com

Motivated by the Cloudflare hyper truncation bug (a dropped Poll::Pending in poll_flush that lets shutdown race an unfinished write, silently truncating the response). The template's static reviewers could not catch this class; these edits raise the odds of surfacing it and add the test pattern that actually catches it. - code-reviewer: scope note to read whole I/O/protocol modules; run clippy (with the restriction lint let_underscore_must_use that pedantic misses); discarded-result item; Rust async/concurrency sub-section covering Pending propagation, flush-before-teardown, partial writes, wakers, cancellation, and a slow-reader test gate. - security-auditor: dropped-readiness item framing silent truncation as a data-integrity/availability defect (? is not sufficient). - code-quality skill: restriction lint in the clippy command, async standards, and a verified BackpressureSink helper plus a bytes-delivered == Content-Length completeness oracle. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

tux added 1 commit

2026-06-26 09:08:59 +02:00

Add async backpressure checks to review agents and skill b42962e9aa

Motivated by the Cloudflare hyper truncation bug (a dropped
Poll::Pending in poll_flush that lets shutdown race an unfinished
write, silently truncating the response). The template's static
reviewers could not catch this class; these edits raise the odds of
surfacing it and add the test pattern that actually catches it.

- code-reviewer: scope note to read whole I/O/protocol modules; run
  clippy (with the restriction lint let_underscore_must_use that
  pedantic misses); discarded-result item; Rust async/concurrency
  sub-section covering Pending propagation, flush-before-teardown,
  partial writes, wakers, cancellation, and a slow-reader test gate.
- security-auditor: dropped-readiness item framing silent truncation
  as a data-integrity/availability defect (? is not sufficient).
- code-quality skill: restriction lint in the clippy command, async
  standards, and a verified BackpressureSink helper plus a
  bytes-delivered == Content-Length completeness oracle.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

tux merged commit 3b27d9904c into main

2026-06-26 09:09:11 +02:00

tux deleted branch improve-async-backpressure-review

2026-06-26 09:09:11 +02:00

tux referenced this pull request from a commit

2026-06-26 09:09:11 +02:00

Merge pull request 'Add async backpressure checks to review agents and skill' (#1) from improve-async-backpressure-review into main

Rows
Columns

Add async backpressure checks to review agents and skill #1