2010-02-24 00:58:38 +01:00
|
|
|
## @file
|
2009-05-27 23:10:18 +02:00
|
|
|
# Platform BDS customizations library.
|
|
|
|
|
#
|
2015-02-17 01:05:36 +01:00
|
|
|
# Copyright (c) 2007 - 2015, Intel Corporation. All rights reserved.<BR>
|
2010-04-28 14:43:04 +02:00
|
|
|
# This program and the accompanying materials
|
2009-05-27 23:10:18 +02:00
|
|
|
# are licensed and made available under the terms and conditions of the BSD License
|
|
|
|
|
# which accompanies this distribution. The full text of the license may be found at
|
|
|
|
|
# http://opensource.org/licenses/bsd-license.php
|
|
|
|
|
#
|
|
|
|
|
# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
|
|
|
|
|
# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
|
|
|
|
|
#
|
2010-02-24 00:58:38 +01:00
|
|
|
##
|
2009-05-27 23:10:18 +02:00
|
|
|
|
|
|
|
|
[Defines]
|
|
|
|
|
INF_VERSION = 0x00010005
|
|
|
|
|
BASE_NAME = PlatformBdsLib
|
2010-04-06 04:56:47 +02:00
|
|
|
FILE_GUID = F844172E-9985-44f2-BADE-0DD783462E95
|
2009-05-27 23:10:18 +02:00
|
|
|
MODULE_TYPE = DXE_DRIVER
|
|
|
|
|
VERSION_STRING = 1.0
|
2012-11-02 19:28:17 +01:00
|
|
|
LIBRARY_CLASS = PlatformBdsLib|DXE_DRIVER
|
2009-05-27 23:10:18 +02:00
|
|
|
|
|
|
|
|
#
|
|
|
|
|
# The following information is for reference only and not required by the build tools.
|
|
|
|
|
#
|
|
|
|
|
# VALID_ARCHITECTURES = IA32 X64 IPF EBC
|
|
|
|
|
#
|
|
|
|
|
|
2010-02-24 00:58:38 +01:00
|
|
|
[Sources]
|
2009-05-27 23:10:18 +02:00
|
|
|
BdsPlatform.c
|
|
|
|
|
PlatformData.c
|
2012-11-02 19:28:17 +01:00
|
|
|
QemuKernel.c
|
2009-05-27 23:10:18 +02:00
|
|
|
BdsPlatform.h
|
|
|
|
|
|
|
|
|
|
[Packages]
|
|
|
|
|
MdePkg/MdePkg.dec
|
|
|
|
|
MdeModulePkg/MdeModulePkg.dec
|
|
|
|
|
IntelFrameworkModulePkg/IntelFrameworkModulePkg.dec
|
2009-09-16 18:29:03 +02:00
|
|
|
OvmfPkg/OvmfPkg.dec
|
2009-05-27 23:10:18 +02:00
|
|
|
|
|
|
|
|
[LibraryClasses]
|
|
|
|
|
BaseLib
|
|
|
|
|
MemoryAllocationLib
|
|
|
|
|
UefiBootServicesTableLib
|
|
|
|
|
BaseMemoryLib
|
|
|
|
|
DebugLib
|
|
|
|
|
PcdLib
|
|
|
|
|
GenericBdsLib
|
|
|
|
|
PciLib
|
2009-09-16 18:29:03 +02:00
|
|
|
NvVarsFileLib
|
2012-08-28 01:28:30 +02:00
|
|
|
QemuFwCfgLib
|
2012-11-02 19:28:17 +01:00
|
|
|
LoadLinuxLib
|
2015-01-02 13:07:57 +01:00
|
|
|
QemuBootOrderLib
|
2015-02-17 01:05:36 +01:00
|
|
|
UefiLib
|
2009-05-27 23:10:18 +02:00
|
|
|
|
2009-09-26 09:15:55 +02:00
|
|
|
[Pcd]
|
2009-07-09 07:48:35 +02:00
|
|
|
gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdLogoFile
|
2009-09-26 09:15:55 +02:00
|
|
|
gUefiOvmfPkgTokenSpaceGuid.PcdEmuVariableEvent
|
2013-11-12 19:35:32 +01:00
|
|
|
gUefiOvmfPkgTokenSpaceGuid.PcdOvmfFlashVariablesEnable
|
2014-11-14 01:39:04 +01:00
|
|
|
gUefiOvmfPkgTokenSpaceGuid.PcdOvmfHostBridgePciDevId
|
2009-05-27 23:10:18 +02:00
|
|
|
|
|
|
|
|
[Pcd.IA32, Pcd.X64]
|
|
|
|
|
gEfiMdePkgTokenSpaceGuid.PcdFSBClock
|
|
|
|
|
|
2009-07-15 01:32:32 +02:00
|
|
|
[Protocols]
|
|
|
|
|
gEfiDecompressProtocolGuid
|
2015-07-14 14:01:52 +02:00
|
|
|
gEfiPciRootBridgeIoProtocolGuid
|
OvmfPkg: install DxeSmmReadyToLock in PlatformBdsLib
Currently we have the following call chain in OVMF:
PlatformBdsPolicyBehavior()
[OvmfPkg/Library/PlatformBdsLib/BdsPlatform.c]
//
// signals End-of-Dxe
//
OnEndOfDxe() [OvmfPkg/AcpiS3SaveDxe/AcpiS3Save.c]
S3Ready() [OvmfPkg/AcpiS3SaveDxe/AcpiS3Save.c]
//
// 1. saves S3 state
//
SaveS3BootScript() [OvmfPkg/AcpiS3SaveDxe/AcpiS3Save.c]
//
// 2. saves INFO opcode in S3 boot script
// 3. installs DxeSmmReadyToLockProtocol
//
The bottom of this call chain was introduced in git commit 5a217a06 (SVN
r15305, "OvmfPkg: S3 Suspend: save boot script after ACPI context"). That
patch was necessary because there was no other way, due to GenericBdsLib
calling S3Save() from BdsLibBootViaBootOption(), to perform the necessary
steps in the right order:
- save S3 system information,
- save a final (well, only) boot script opcode,
- signal DxeSmmReadyToLock, closing the boot script, and locking down
LockBox and SMM.
The GenericBdsLib bug has been fixed in the previous patch -- the call in
BdsLibBootViaBootOption() has been eliminated.
Therefore, hoist the SaveS3BootScript() code, and call, from
OvmfPkg/AcpiS3SaveDxe, to PlatformBdsLib:
PlatformBdsPolicyBehavior()
[OvmfPkg/Library/PlatformBdsLib/BdsPlatform.c]
//
// signals End-of-Dxe
//
OnEndOfDxe() [OvmfPkg/AcpiS3SaveDxe/AcpiS3Save.c]
S3Ready() [OvmfPkg/AcpiS3SaveDxe/AcpiS3Save.c]
//
// 1. saves S3 state
//
<---
SaveS3BootScript() [OvmfPkg/Library/PlatformBdsLib/BdsPlatform.c]
//
// 2. saves INFO opcode in S3 boot script
// 3. installs DxeSmmReadyToLockProtocol
//
The installation of DxeSmmReadyToLockProtocol belongs with Platform BDS,
not AcpiS3SaveDxe, and we can now undo the hack in SVN r15305, without
upsetting the relative order of the steps.
Cc: Jordan Justen <jordan.l.justen@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18037 6f19259b-4bc3-4df7-8a09-765794883524
2015-07-26 10:02:24 +02:00
|
|
|
gEfiS3SaveStateProtocolGuid # PROTOCOL SOMETIMES_CONSUMED
|
|
|
|
|
gEfiDxeSmmReadyToLockProtocolGuid # PROTOCOL SOMETIMES_PRODUCED
|
OvmfPkg: PlatformBdsLib: signal End-of-Dxe event group
(Paraphrasing git commit 9cd7d3c5 / SVN r17713:)
Currently, OvmfPkg fails to signal the End-of-Dxe event group when
entering the BDS phase, which results in some loss of functionality, eg.
variable reclaim in the variable driver, and the memory region splitting
in the DXE core that belongs to the properties table feature specified in
UEFI-2.5.
As discussed on the edk2-devel mailing list here:
http://thread.gmane.org/gmane.comp.bios.tianocore.devel/16088/focus=16109
it is up to the platform BDS to signal End-of-Dxe, since there may be
platform specific ordering constraints with respect to the signalling of
the event that are difficult to honor at the generic level.
(OvmfPkg specifics:)
(1) In OvmfPkg, we can't signal End-of-Dxe before PCI enumeration
completes. According to the previous patch, that would trigger
OvmfPkg/AcpiS3SaveDxe to save S3 state *before* the following chain of
action happened:
- PCI enumeration completes
- ACPI tables are installed by OvmfPkg/AcpiPlatformDxe
- the FACS table becomes available
Since OvmfPkg/AcpiS3SaveDxe can only save S3 state once the FACS table
is available, we must delay the End-of-Dxe signal until after PCI
enumeration completes (ie. root bridges are connected).
(2) Pre-patch, S3Ready() in OvmfPkg/AcpiS3SaveDxe is entered from
BdsLibBootViaBootOption()
[IntelFrameworkModulePkg/Library/GenericBdsLib/BdsBoot.c].
After the patch, we enter S3Ready() earlier than that, by signaling
End-of-Dxe in PlatformBdsPolicyBehavior(). The timing / location of
this new call is correct as well, and the original call (that now
becomes the chronologically second call) becomes a no-op: S3Ready() is
protected against 2nd and later entries.
Cc: Jordan Justen <jordan.l.justen@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18035 6f19259b-4bc3-4df7-8a09-765794883524
2015-07-26 10:02:13 +02:00
|
|
|
|
|
|
|
|
[Guids]
|
|
|
|
|
gEfiEndOfDxeEventGroupGuid
|
