tyler.durden
/
audk
mirror of https://github.com/acidanthera/audk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

MdeModulePkg/Browser: Fix conflicting policy in getting default of checkbox 

We have added a new policy to get default value for question:
get default from other default id if current default is not specified.
But when getting default value for checkbox, if the default
flag is not set, it will set the default value to FALSE for checkbox.
This behavior in checkbox conflicts with the new added policy,
so now we move this behavior to the end of getting default form other
default id.

Cc: Liming Gao <liming.gao@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
This commit is contained in:
Liming Gao 2016-08-18 19:51:21 +08:00 committed by Star Zeng
parent 5c66efd0ed
commit 93e59f76fe
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
MdeModulePkg/Universal/SetupBrowserDxe/Setup.c
View File

@ -4241,8 +4241,6 @@ ReGetDefault:
((DefaultId == EFI_HII_DEFAULT_CLASS_MANUFACTURING) && ((Question->Flags & EFI_IFR_CHECKBOX_DEFAULT_MFG) != 0))
) {
HiiValue->Value.b = TRUE;
} else {
HiiValue->Value.b = FALSE;
}
return EFI_SUCCESS;
@ -4269,6 +4267,11 @@ ReGetDefault:
//
Status = EFI_NOT_FOUND;
switch (Question->Operand) {
case EFI_IFR_CHECKBOX_OP:
HiiValue->Value.b = FALSE;
Status = EFI_SUCCESS;
break;
case EFI_IFR_NUMERIC_OP:
//
// Take minimum value as numeric default value