mirror of
https://github.com/acidanthera/audk.git
synced 2025-04-07 19:45:07 +02:00
MdePkg/BaseIoLibIntrinsicArmVirt ARM: avoid double word loads and stores
BaseIoLibIntrinsicArmVirt was created to prevent LTO from merging accesses to MMIO regions, resulting in instructions with multiple output registers that KVM on ARM cannot emulate (since the exception syndrome information that KVM relies on can only describe a single output register) However, using double word loads on ARM amounts to the same thing, and so code that relies on doing 64-bit MMIO to regions that are emulated under KVM (such as the GICv3 TYPER register) will still suffer from the original issue. So replace ldrd and strd with equivalent two instruction sequences. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> Acked-by: Laszlo Ersek <lersek@redhat.com> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
This commit is contained in:
parent
8558838922
commit
9cabe9d457
@ -125,7 +125,8 @@ ASM_PFX(MmioWrite32Internal):
|
||||
// @return The value read.
|
||||
//
|
||||
ASM_PFX(MmioRead64Internal):
|
||||
ldrd r0, r1, [r0]
|
||||
ldr r1, [r0, #4]
|
||||
ldr r0, [r0]
|
||||
dmb
|
||||
bx lr
|
||||
|
||||
@ -141,5 +142,6 @@ ASM_PFX(MmioRead64Internal):
|
||||
//
|
||||
ASM_PFX(MmioWrite64Internal):
|
||||
dmb st
|
||||
strd r2, r3, [r0]
|
||||
str r2, [r0]
|
||||
str r3, [r0, #4]
|
||||
bx lr
|
||||
|
@ -127,7 +127,8 @@ MmioWrite32Internal
|
||||
; @return The value read.
|
||||
;
|
||||
MmioRead64Internal
|
||||
ldrd r0, r1, [r0]
|
||||
ldr r1, [r0, #4]
|
||||
ldr r0, [r0]
|
||||
dmb
|
||||
bx lr
|
||||
|
||||
@ -143,7 +144,8 @@ MmioRead64Internal
|
||||
;
|
||||
MmioWrite64Internal
|
||||
dmb st
|
||||
strd r2, r3, [r0]
|
||||
str r2, [r0]
|
||||
str r3, [r0, #4]
|
||||
bx lr
|
||||
|
||||
END
|
||||
|
Loading…
x
Reference in New Issue
Block a user