follow up code review

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5894 6f19259b-4bc3-4df7-8a09-765794883524
This commit is contained in:
eric_tian 2008-09-16 06:13:42 +00:00
parent f73e0ad215
commit f944ec32e7
6 changed files with 40 additions and 40 deletions

View File

@ -15,26 +15,26 @@
#ifndef __PEI_PI_LIB_H__ #ifndef __PEI_PI_LIB_H__
#define __PEI_PI_LIB_H__ #define __PEI_PI_LIB_H__
#include <Pi/PiFirmwareFile.h>
/** /**
Install a EFI_PEI_FIRMWARE_VOLUME_INFO PPI to inform PEI core about the existence of a new Firmware Volume. Install a EFI_PEI_FIRMWARE_VOLUME_INFO PPI to inform PEI core about the existence of a new Firmware Volume.
The function allocate the EFI_PEI_PPI_DESCRIPTOR structure and update the fields accordingly to parameter passed The function allocate the EFI_PEI_PPI_DESCRIPTOR structure and update the fields accordingly to parameter passed
in and install the PPI. in and install the PPI.
@param FvFormat Unique identifier of the format of the memory-mapped firmware volume. If NULL is specified, @param FvFormat Unique identifier of the format of the memory-mapped firmware volume.
EFI_FIRMWARE_FILE_SYSTEM2_GUID is used as the Format GUID. If NULL is specified, EFI_FIRMWARE_FILE_SYSTEM2_GUID is used as the Format GUID.
@param FvInfo Points to a buffer which allows the EFI_PEI_FIRMWARE_VOLUME_PPI to @param FvInfo Points to a buffer which allows the EFI_PEI_FIRMWARE_VOLUME_PPI to
process the volume. The format of this buffer is specific to the FvFormat. For process the volume. The format of this buffer is specific to the FvFormat. For
memory-mapped firmware volumes, this typically points to the first byte of the memory-mapped firmware volumes, this typically points to the first byte of the
firmware volume. firmware volume.
@param FvInfoSize Size of the data provided by FvInfo. For memory-mapped firmware volumes, this is @param FvInfoSize Size of the data provided by FvInfo. For memory-mapped firmware volumes, this is
typically the size of the firmware volume. typically the size of the firmware volume.
@param ParentFvName, ParentFileName If the firmware volume originally came from a firmware file, then these point to the @param ParentFvName If the firmware volume originally came from a firmware file, then these point to the
parent firmware volume name and firmware volume file. If it did not originally come parent firmware volume name. If it did not originally come from a firmware file,
from a firmware file, these should be NULL these should be NULL.
@param ParentFileName If the firmware volume originally came from a firmware file, then these point to the
firmware volume file. If it did not originally come from a firmware file,
these should be NULL.
**/ **/
VOID VOID

View File

@ -39,7 +39,7 @@ GetPeiServicesTablePointer (
VOID VOID
EFIAPI EFIAPI
SetPeiServicesTablePointer ( SetPeiServicesTablePointer (
EFI_PEI_SERVICES ** PeiServicesTablePointer IN EFI_PEI_SERVICES ** PeiServicesTablePointer
); );
#endif #endif

View File

@ -37,8 +37,8 @@ CONST EFI_PEI_PPI_DESCRIPTOR mPpiListTemplate [] = {
The function allocate the EFI_PEI_PPI_DESCRIPTOR structure and update the fields accordingly to parameter passed The function allocate the EFI_PEI_PPI_DESCRIPTOR structure and update the fields accordingly to parameter passed
in and install the PPI. in and install the PPI.
@param FvFormat Unique identifier of the format of the memory-mapped firmware volume. If NULL is specified, @param FvFormat Unique identifier of the format of the memory-mapped firmware volume.
EFI_FIRMWARE_FILE_SYSTEM2_GUID is used as the Format GUID. If NULL is specified, EFI_FIRMWARE_FILE_SYSTEM2_GUID is used as the Format GUID.
@param FvInfo Points to a buffer which allows the EFI_PEI_FIRMWARE_VOLUME_PPI to @param FvInfo Points to a buffer which allows the EFI_PEI_FIRMWARE_VOLUME_PPI to
process the volume. The format of this buffer is specific to the FvFormat. For process the volume. The format of this buffer is specific to the FvFormat. For
memory-mapped firmware volumes, this typically points to the first byte of the memory-mapped firmware volumes, this typically points to the first byte of the
@ -46,11 +46,11 @@ CONST EFI_PEI_PPI_DESCRIPTOR mPpiListTemplate [] = {
@param FvInfoSize Size of the data provided by FvInfo. For memory-mapped firmware volumes, this is @param FvInfoSize Size of the data provided by FvInfo. For memory-mapped firmware volumes, this is
typically the size of the firmware volume. typically the size of the firmware volume.
@param ParentFvName If the firmware volume originally came from a firmware file, then these point to the @param ParentFvName If the firmware volume originally came from a firmware file, then these point to the
parent firmware volume name. If it did not originally come parent firmware volume name. If it did not originally come from a firmware file,
from a firmware file, these should be NULL. these should be NULL.
@param ParentFileName If the firmware volume originally came from a firmware file, then these point to the @param ParentFileName If the firmware volume originally came from a firmware file, then these point to the
firmware volume file. If it did not originally come firmware volume file. If it did not originally come from a firmware file,
from a firmware file, these should be NULL. these should be NULL.
**/ **/
VOID VOID

View File

@ -29,7 +29,7 @@ STATIC EFI_PEI_SERVICES **gPeiServices;
VOID VOID
EFIAPI EFIAPI
SetPeiServicesTablePointer ( SetPeiServicesTablePointer (
EFI_PEI_SERVICES **PeiServices IN EFI_PEI_SERVICES **PeiServices
) )
{ {
gPeiServices = PeiServices; gPeiServices = PeiServices;

View File

@ -65,7 +65,7 @@ GetPeiServicesTablePointer (
VOID VOID
EFIAPI EFIAPI
SetPeiServicesTablePointer ( SetPeiServicesTablePointer (
EFI_PEI_SERVICES ** PeiServicesTablePointer IN EFI_PEI_SERVICES ** PeiServicesTablePointer
) )
{ {
IA32_DESCRIPTOR Idtr; IA32_DESCRIPTOR Idtr;

View File

@ -71,7 +71,7 @@ PeiServicesTablePointerLibConstructor (
VOID VOID
EFIAPI EFIAPI
SetPeiServicesTablePointer ( SetPeiServicesTablePointer (
EFI_PEI_SERVICES ** PeiServicesTablePointer IN EFI_PEI_SERVICES ** PeiServicesTablePointer
) )
{ {
AsmWriteKr7 ((UINT64)(UINTN)PeiServicesTablePointer); AsmWriteKr7 ((UINT64)(UINTN)PeiServicesTablePointer);