Commit Graph

1633 Commits

Author SHA1 Message Date
jji4 2fead09fae Source level security checked
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7518 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-13 05:16:31 +00:00
jji4 e67ca95c86 Source level security checked
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7517 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-13 03:57:46 +00:00
vanjeff db0bd81c85 enhanced security check.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7516 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-13 03:36:02 +00:00
jljusten 4ad9d87d7a * MdeModulePkg/Core/Pei/Dependency/Dependency.h
Decrease MAX_GRAMMAR_SIZE from 256 to 64.

In Dependency.c => PeimDispatchReadiness, a local variable 'EvalStack'
makes an array of EVAL_STACK_ENTRY structures to store a stack for
processing the dependency expression.

Due to alignment considerations, sizeof (EVAL_STACK_ENTRY) is 16 bytes 
on 64 bit architectures.  This means the size of the EvalStack local
variable in PeimDispatchReadiness grows to 4kb.

In the PEI phase, the stack area may be very small, and therefore 4kb is 
much to large.  Reducing MAX_GRAMMAR_SIZE to 64 will lower the size
of EvalStack to 1kb.

While reducing this to 1kb solves an issue seen with GCC on X64, it is
still a large usage of stack for the PEI phase, and future improvements
may still need to be made.


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7514 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-12 17:15:08 +00:00
eric_tian cb0b858d6e add assert logic to avoid Klocwork fake report
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7513 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-12 08:41:34 +00:00
eric_tian 525aded947 add assert logic to avoid Klocwork fake report
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7512 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-12 06:39:01 +00:00
eric_tian a1b749d074 add assert logic to avoid Klocwork fake report
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7511 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-12 06:23:15 +00:00
vanjeff c55426ab64 fixed comments missing.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7510 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-12 06:06:23 +00:00
vanjeff df80a83c8a enhanced security check.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7509 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-12 06:05:08 +00:00
vanjeff 7c1bc8d656 Enhanced status return check.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7508 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-12 03:03:47 +00:00
vanjeff e618d0cb67 add return value check.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7507 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-12 02:33:23 +00:00
vanjeff 892b7f90c5 add NULL pointer check.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7506 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-12 01:55:32 +00:00
qhuang8 4cfc3293c7 Fix the typo in comments
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7503 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-11 07:09:19 +00:00
qhuang8 96a5ac5b0d Adjust code to fix potential array out-bound issues.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7502 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-11 07:05:43 +00:00
qhuang8 51195fbe8c Remove several unicode in comments.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7501 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-11 06:02:54 +00:00
qhuang8 ead7e7dc74 Fix the potential illegal EBC opcode issue.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7500 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-11 06:01:07 +00:00
lgao4 98b15cf156 Include the missing Guid header file to refer the global Guid
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7498 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-11 04:57:42 +00:00
lgao4 8a3f79bf36 Add the missing Guid header file.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7496 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-10 14:33:55 +00:00
lgao4 b998288321 Correct typo in comments, clean IfrSupportLib.h
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7494 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-10 13:32:19 +00:00
eric_tian fbbb42115c clean K8.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7492 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-10 09:56:23 +00:00
qwang12 a935a0d8b7 Add in ASSERT to avoid NULL point dereference.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7491 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-10 09:40:27 +00:00
xli24 dcbb35eb6c Add comments in DSC files to explain the function and design of components section.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7490 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-10 08:58:47 +00:00
vanjeff 05b1c4143c update meta.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7482 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-09 06:11:51 +00:00
qwang12 d1a54e2c3e ECC cleanup: Non-Boolean comparisons should use a compare operator (==, !=, >, < >=, <=)
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7481 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-09 05:29:17 +00:00
lgao4 2517435c8d Clean Network Driver to include Uefi.h, not PiDxe.h.
Network driver don't depend on PI definition.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7479 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-09 02:59:07 +00:00
niry 9cff2f8d36 Roll back the DEBUG mask change which cause SerialIo read_conf test item failure.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7477 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-09 01:22:19 +00:00
mdkinney ba5e88f965 Add parenthesis to expression to make order of operations clear
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7475 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-06 20:40:48 +00:00
lgao4 276a49b699 Clean up FaultTolerantWriteDxe to remove the duplicated definition.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7471 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-06 09:03:12 +00:00
niry 2374b9734b fix the operator priority bug.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7470 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-06 08:56:45 +00:00
qhuang8 8ed62a3035 Fix minor build issue.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7465 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-06 07:42:00 +00:00
qwang12 c410589ef1 K8: Add in ASSERT to detect possible NULL pointer dereference.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7462 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-06 06:34:43 +00:00
eric_tian fd0d484170 clean ecc
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7461 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-06 06:17:01 +00:00
jgong5 b2c0a17556 Pass ECC
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7460 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-06 06:08:46 +00:00
jji4 7b2207f058 Coding style checked
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7459 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-06 05:52:20 +00:00
jji4 7ae9c1ce8f Coding style checked
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7458 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-06 05:48:16 +00:00
jgong5 d59b8b55d7 fixed more issues by scrubbing.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7457 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-06 05:47:32 +00:00
eric_tian c24b392c30 fix ecc warning
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7456 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-06 05:37:46 +00:00
xli24 ed3a31b518 Pass ECC check.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7455 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-06 05:34:53 +00:00
jji4 a676b86b67 Coding style checked
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7454 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-06 05:12:48 +00:00
jgong5 81b0761486 Synced function header.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7453 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-06 05:11:15 +00:00
jgong5 f737cfb953 code scrub for UefiPxeBcDxe.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7452 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-06 05:07:34 +00:00
eric_tian 4de1f28761 fix ecc
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7451 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-06 05:00:13 +00:00
vanjeff 9006e2bbe7 update format.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7450 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-06 04:38:53 +00:00
jji4 9e1f123a3a Code level security checked
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7449 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-06 04:08:16 +00:00
eric_tian 311a71b299 Cleanup K8 warning.
We need judge return status of CoreGetMemorySpaceMap() to avoid the generation of NULL pointer of MemorySpaceMap.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7448 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-06 03:58:04 +00:00
mdkinney 7cf027141f Use UEFI macros for PE/COFF image types
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7441 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-05 19:34:49 +00:00
lgao4 19f1707078 Remove FlashMap Ppi that has been replaced by Flash related PCDs.
Remove OperatorPresence Ppi that is only related to TCG driver, which should be not in this package.


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7435 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-05 03:15:10 +00:00
qwang12 7b728d6273 Use TO_START and BY_START for UEFI driver model driver.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7431 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-04 07:59:50 +00:00
qwang12 17d6c2e782 3) Doxygen comment cleanup.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7430 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-04 07:02:05 +00:00
qwang12 e08d88c59e 3) Doxygen comment cleanup.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7429 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-04 06:59:23 +00:00
qwang12 597f4ee21c 1) Fix a typo in EhcMoniteAsyncRequests.
2) Code cleanup.
3) Doxygen comment cleanup.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7428 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-04 06:56:31 +00:00
lgao4 657abcff30 Enhance DxeCore to handle the all block sized allowed by the PI Specification and remove the assumption that the FV block size is always larger than the size of an FV Header.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7426 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-04 03:37:14 +00:00
klu2 7459a41ec0 Fix typo in meta data.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7423 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-03 13:34:10 +00:00
jji4 01a5c99447 use the GUIDed versions of events listed below: EVT_SIGNAL_VIRTUAL_ADDRESS_CHANGE and EVT_SIGNAL_EXIT_BOOT_SERVICES
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7420 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-03 11:09:53 +00:00
ywu21 6e4bac4dac fix some checklist issues
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7417 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-03 07:56:54 +00:00
vanjeff 5c998646f3 remove some internal functions and allocate some FIFO data structure instead of declaring in global variable. To save size.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7416 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-03 07:25:00 +00:00
jji4 1068a65374 Code size optimized
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7415 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-03 06:11:04 +00:00
jlin16 d089bd5ffe Fix non-asci char in comment.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7414 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-03 03:00:22 +00:00
qwang12 3018ca2d36 1) Clean up the INF and add in comment to describe the surface area of modules
2) Minor comment fix.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7413 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-03 02:23:03 +00:00
eric_tian f3e0442308 Add information in Meta-Data file
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7400 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-03 00:31:26 +00:00
eric_tian 280544daaa Add information in Meta-Data file
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7399 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-03 00:30:46 +00:00
eric_tian 603e7c0ce1 Add information in Meta-Data file
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7398 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-03 00:30:18 +00:00
eric_tian e7cd6e69e7 Add information in Meta-Data file
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7397 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-03 00:29:48 +00:00
eric_tian 57dfc48f93 enhance the condition branch to handle Unix style file path. and avoid array overflow
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7394 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-02 08:01:35 +00:00
qwang12 0ea756d403 Update the comment section of INF to add in more meta data description.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7393 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-02 07:38:16 +00:00
qwang12 fd0fd8918e Remove the accidental check in of test code.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7392 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-02 07:27:44 +00:00
qwang12 bc166db311 Add in ASSERT to check out-of-bound and possible dereference of NULL pointers.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7391 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-02 07:18:59 +00:00
eric_tian af58e37731 add parameter check logic to clean up Klocwork warning.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7390 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-02 05:50:45 +00:00
eric_tian 6041576eb2 The caller of FindVariable() function ensure VariableName != NULL && VendorGuid != NULL. In the internal of this function, we only need to ensure that (VariableName[0] != 0 && VenderGuid != NULL) is true.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7389 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-02 03:13:35 +00:00
qwang12 e4a3922f03 Update the protocol function to return EFI_INVALID_PARAMETER if CallBackFunction == NULL. The PCD library function will do ASSERT if CallBackFunction is NULL.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7385 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-01 10:04:40 +00:00
niry 3dc3861a4e re order the function definition to avoid unnecessary declaration.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7381 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-01 03:36:25 +00:00
mdkinney 4cf894eba8 Split out Synchronization Library from Base Library
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7373 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-30 00:33:39 +00:00
lgao4 6426c8ffb4 Add comments for these header files
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7364 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-23 14:45:13 +00:00
xli24 7772b1760f Update for Meta data.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7361 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-23 10:01:51 +00:00
klu2 c516c7178a Move BdsDxe and GenericBdsLib to IntelFrameworkModulePkg, these modules need dependent on gEfiLegacyBiosProtocol to provide legacy boot support. But legacy boot is not described by PI/UEFI specification.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7353 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-23 07:23:46 +00:00
klu2 485a505713 Add more checkpoint for deference pointer.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7350 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-23 04:45:48 +00:00
klu2 cb26370805 Fix issue from code scrub.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7349 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-23 03:32:01 +00:00
lgao4 9872985bb1 Add check when use Index as Array [Index] to avoid out of Array bound.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7348 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-22 15:40:06 +00:00
lgao4 80882266ed Add check after allocate pool.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7347 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-22 14:09:21 +00:00
vanjeff 60c65d37e2 remove klocwork issue.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7346 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-22 09:07:53 +00:00
xli24 7a79628e35 Add check for NULL pointer.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7344 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-22 05:03:14 +00:00
lgao4 96827f1756 Correct FeatureFlagExpress PCD format based on INF spec.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7327 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-21 07:25:23 +00:00
gikidy 364a232c4a Meta-data reviewed and verified.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7326 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-21 07:08:57 +00:00
qhuang8 a833f286fb Update to add the ASSERT()s in the right place.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7325 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-21 05:37:27 +00:00
qwang12 4a1102c9ae K8:
1) add in more ASSERT condition and updates the comment for HexStringToBuf.
2) Check the pointer returned by HiiLibGetHiiHandles.



git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7324 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-21 05:33:41 +00:00
eric_tian 29dd3b04b0 Fix Klocwork warning. We should directly return EFI_INVALID_PARAMETER when BufferSize is NULL.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7323 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-21 04:56:24 +00:00
qwang12 40a06b0ca8 K8:
1) Replace immediate constant with MACRO.
2) Add in ASSERT for NULL before dereferencing pointers and after memory allocation.
3) Add a return statement in ProcessOptions to handle the mismatch between the value stored and the opcode for one-of-option in orderedlist opcode. This case occurs when the one-of-optoin entry in OrderedList get deleted.


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7320 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-20 12:55:02 +00:00
gikidy 7bfc66a284 Meta-data review.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7319 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-20 08:27:13 +00:00
gikidy 16a747ed5e Add some info for some PCD controlled GUIDs and Protocols.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7318 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-20 05:13:35 +00:00
gikidy 32e24669c2 Meta-data review.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7317 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-20 04:57:29 +00:00
jji4 79864f54ce Source level security checked
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7316 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-20 04:17:05 +00:00
gikidy 7fa5d6e149 Meta-data review.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7314 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-20 03:07:20 +00:00
gikidy a503cc6971 Meta-data review.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7313 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-20 03:04:55 +00:00
gikidy f50cf5032a Meta-data review.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7312 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-20 03:01:44 +00:00
eric_tian f34aec3bc8 coding style
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7311 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-20 03:01:41 +00:00
qwang12 fa7b3168fd K8:
1) Add in "check-for-null" before dereferencing a pointer.
2) unify the handling of EFI_OUT_OF_RESOURCE case.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7310 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-20 02:00:46 +00:00
qwang12 d0720b5706 K8:
Add in "check-for-null" to catch the de-reference of NULL pointer.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7309 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-20 01:55:11 +00:00
qwang12 96ff65a1fb K8:
1) Fix the bug the assert conditions. || should be &&.
2) Add in code path and check-for-null-pointer to do error handling.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7308 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-20 01:52:02 +00:00
qwang12 5a829f5688 K8: add new variable PasswordSize to remove immeidate constant.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7307 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-20 01:48:39 +00:00
jji4 1ac628eee0 Assertions added
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7305 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-19 07:58:58 +00:00
jji4 c59634eab6 Source level security checked
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7303 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-19 06:55:18 +00:00
gikidy 8c80d3942e Add some ASSERT()s.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7302 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-19 06:34:35 +00:00
jji4 49fabc83a5 Source level security checked
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7301 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-19 05:23:02 +00:00
gikidy 3069bc1944 Add some ASSERT()s.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7299 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-19 01:55:14 +00:00
klu2 19c804c4b3 Fix the wrong file comments for SnpDxe.inf driver
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7298 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-18 17:19:28 +00:00
jji4 e6c4ef1336 Source level security checked
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7297 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-16 08:14:39 +00:00
gikidy 8d4cd91527 1.Moved HotPlugDevice.h & SimpleTextInNotify.h from /Guid to /Protocol
2.Modified the reference of two Guids in DEC file, Inf files and h files;

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7294 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-16 07:33:08 +00:00
niry dab714aa11 Insert comments for functions/macros and add the file headers.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7293 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-16 06:56:18 +00:00
jgong5 bd59b46eb4 sync function header to avoid ecc
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7292 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-16 00:17:38 +00:00
jgong5 24af132fc0 Fixed OPTIONAL/comma issue
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7291 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-16 00:16:17 +00:00
jgong5 3e8c18da04 code scrub fix
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7290 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-16 00:09:52 +00:00
qwang12 90e128e28a Fix a bug which print new stack size and old stack size wrongly.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7285 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-15 08:50:24 +00:00
jji4 812acaec29 Comments checked
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7284 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-15 06:09:35 +00:00
jji4 9cdae8c6a2 Array boundary evaluation expression fixed.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7283 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-15 03:46:29 +00:00
jji4 6d9f0e7eec Source level security checked
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7282 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-15 03:31:55 +00:00
jji4 b77d0076f9 Coding style checked
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7281 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-15 03:30:05 +00:00
gikidy 649e72d617 Performance and size optimised.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7280 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-15 03:11:09 +00:00
qhuang8 b364eeb012 Apply code to avoid security warnings.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7279 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-15 03:00:00 +00:00
vanjeff 03d77031fe 1. add gEfiDebugPortVariableGuid and gEfiDebugPortDevicePathGuid in MdePkg.dec, even though they are the same value with gEfiDebugPortProtocolGuid.
2. Meta data clean up.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7271 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-14 09:37:44 +00:00
vanjeff f890b1e053 1.fixed one bug to 'reconnect -r' when running 4 times.
2.Code scrub.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7269 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-14 07:47:48 +00:00
ywu21 361468ede3 fix one minor comment error
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7262 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-13 08:56:00 +00:00
ywu21 e3c8c68a76 fix minor comment error
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7261 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-13 08:55:27 +00:00
ywu21 3a1ab4bc2c sync Netlib function from c file
fix file header issues
add in out
add . at the end of lines

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7260 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-13 08:51:55 +00:00
ywu21 8f5e6151d5 fix file header issues
add . at the end of lines

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7259 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-13 08:48:19 +00:00
ywu21 9685879299 git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7258 6f19259b-4bc3-4df7-8a09-765794883524 2009-01-13 08:47:31 +00:00
xli24 c92e277d99 Minor refinement for USB modules.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7257 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-13 08:46:31 +00:00
ywu21 55a64ae0f4 unified "iSCSI" in all comments
add . at the end of lines
fix 2 file header issues and so on

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7256 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-13 08:44:22 +00:00
xli24 81464cf106 Update for code security.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7255 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-13 08:29:55 +00:00
xli24 3e03cb4d84 Refine USB Mass Storage Driver.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7247 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-12 07:30:42 +00:00
vanjeff 5fe48e5404 remove information output in SNP poll function.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7245 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-12 06:00:53 +00:00
xli24 d80ed2a76e Code scrub for USB Mass Storage Driver.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7243 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-12 03:11:00 +00:00
ywu21 cdfdbb970a add macro function comments
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7242 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-12 02:39:41 +00:00
ywu21 6aac5e5ff0 checking coding style issues:
correct include file path
delete unused include files
fix ECC error and so on

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7241 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-12 02:32:20 +00:00
lgao4 e561879137 Add INF extension Information
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7228 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-09 06:26:42 +00:00
jji4 964b4ecf36 INF extension reviewed
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7220 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-09 02:37:08 +00:00
vanjeff 677fdb90fa ECC clean up.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7213 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-08 08:46:31 +00:00
vanjeff ed055f1b63 ECC clean up.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7211 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-08 08:21:40 +00:00
jji4 e95e4b4918 INF extension reviewed
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7208 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-08 07:46:00 +00:00
gikidy 00bfdbe10a 1.Review the comments;
2.Modify the extension comment for INF file. 

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7207 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-08 07:25:05 +00:00
niry c57273b0d8 Change the file headers and some function comments.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7206 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-08 04:47:41 +00:00
jji4 3ed0238a62 INF extension reviewed
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7201 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-07 09:01:05 +00:00
eric_tian c351b60d13 clean-up MdeModulePkg/Include/Protocol.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7192 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-06 06:54:29 +00:00
lgao4 f497011482 Correct /FAcs option to /FAsc
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7191 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-06 05:09:27 +00:00
gikidy 0d401d4d9c 1. Add some ASSERT();
2. Fix some typo.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7184 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-05 09:34:40 +00:00
eric_tian 721dfef39e As variable area is not reliable in recovery path, then we should not produce ReadonlyVariable2 ppi at the point. This way causes other Pei module wanted to access to variable will fail
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7183 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-05 05:50:22 +00:00
jji4 54656366f9 1.Coding style checked
2.CompareMem() replaced by CompareGuid()


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7182 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-05 05:33:03 +00:00
lgao4 779808545d Fix VS2005 build error
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7181 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-05 02:20:16 +00:00
gikidy 5c03ed0aa1 Code scrub for GraphicConsoleDxe Module.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7179 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-04 09:36:31 +00:00
qwang12 3a306c1006 Replace CopyMem() which can be replaced by BaseLib's Read/WriteUnalianedXX() as these are applied to base data type such as UINT32.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7175 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-04 06:01:35 +00:00
lgao4 109e9a6156 Code scrub for the following drivers and librarys.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7172 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-04 03:20:55 +00:00
vanjeff 9216450d11 remove unnecessary check for NULL pointer.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7166 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-31 08:05:18 +00:00
vanjeff c33add6776 add check for NULL pointer reference.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7165 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-31 07:50:01 +00:00
xli24 eec6d259fc Renamed remotely
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7164 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-31 07:45:28 +00:00
xli24 67b8a9ce2f Code Scrub for USB Mouse Absolute Pointer Driver.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7163 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-31 07:32:33 +00:00
gikidy 3fd8027ee5 Fix some typo.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7160 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-31 06:06:57 +00:00
jgong5 e6ff63a514 enhanced function header
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7157 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-30 12:26:40 +00:00
jgong5 e29a2e7e80 Enhance function header
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7156 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-30 12:12:46 +00:00
gikidy 7601dbe7c5 Check comments, format and fix some typo.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7154 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-30 07:34:44 +00:00
vanjeff cfcbb8bc54 1. Use Mde library for Debug Port Module
2. Minimum changed for Debug Support Module.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7153 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-30 07:10:46 +00:00
jji4 2d4117c049 Typo corrected
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7152 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-30 07:06:28 +00:00
xli24 29129ce463 Code Scrub for USB mouse driver.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7151 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-30 05:55:39 +00:00
jgong5 c8d8f1e332 code scrub for Ip4ConfigDxe
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7149 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-30 02:21:34 +00:00
niry 77f00155e3 Fix the IN OUT modifier for parameters.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7147 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-29 12:58:38 +00:00
vanjeff 73e4adbe68 fixed potential NULL pointer reference issue.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7146 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-29 07:10:16 +00:00
jgong5 ca9d3a9ded Add () after function name so that Doxygen can create reference in doc.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7145 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-29 03:49:50 +00:00
ywu21 b9008c87eb git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7144 6f19259b-4bc3-4df7-8a09-765794883524 2008-12-29 01:28:11 +00:00
niry f381602727 1). Fix the debug level for DEBUG macro
2). Uniform the function description comments

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7143 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-29 01:16:13 +00:00
jgong5 99fd60317f no need to use EFIAPI
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7142 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-26 09:33:26 +00:00
gikidy 0322ed7af8 Check Library usage.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7141 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-26 09:22:38 +00:00
gikidy e15c65a371 Check Library usage and fix some typo.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7140 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-26 09:18:12 +00:00
jgong5 f51f406037 Fix OPTIONAL usage
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7139 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-26 09:12:58 +00:00
jgong5 cab450ccda Add more comments
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7138 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-26 09:09:02 +00:00
gikidy d17371e86b Check Library usage and fix some typo.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7137 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-26 08:42:24 +00:00
jji4 ec30be9e8c Coding style checked
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7136 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-26 08:07:22 +00:00
jji4 9738656b8d Unicode characters removed
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7133 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-26 07:22:08 +00:00
jji4 7351070b11 Library usage checked
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7132 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-26 06:53:45 +00:00
niry c191cdd1ff Remove a goto statement.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7131 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-26 03:40:27 +00:00
lgao4 bc459c446b Remove the capsule PCD value setting. This value is same to the default value. No setting is required.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7129 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-26 03:27:13 +00:00
klu2 98cf93471d Refine function comments for BdsDxe module.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7127 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-26 02:22:37 +00:00
niry 7557df4df3 Add more comments for Netbuf* functions in NetLib.h
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7126 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-25 14:19:52 +00:00
niry 9bc4edf21a git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7125 6f19259b-4bc3-4df7-8a09-765794883524 2008-12-25 14:17:24 +00:00
niry 32cf7c7383 Add more comments to describe the net buffer operation functions.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7124 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-25 13:39:12 +00:00
lgao4 40b96d407e Change MAX_CHOICE_NUM to max UINT8 value
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7122 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-25 09:30:36 +00:00
lgao4 68dbca6c14 Code Clean for Driver PlatformDriOverrideDxe and PlatOverMngr application. And Clean PlatDriOver library class.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7121 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-25 09:13:53 +00:00
vanjeff 7dc2fc3d06 EFI_SIGNATURE_32 has been replaced by SIGNATURE_32
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7118 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-25 02:36:03 +00:00
ywu21 9fbc74499e Pure UEFI code should not include “PiDxe.h” & “PiPei.h”
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7116 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-24 13:52:48 +00:00
ywu21 2d0eeb366b Pure UEFI code should not include “PiDxe.h” & “PiPei.h”
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7115 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-24 13:50:38 +00:00
niry 276dcc1b14 Fixing function headers.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7114 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-24 08:14:19 +00:00
jgong5 0c323d071d code scrub ArpDxe
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7113 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-24 05:26:57 +00:00
klu2 ef9273606b Refine function comments for BdsDxe module.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7111 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-24 01:50:59 +00:00
lgao4 8986b8cda6 Update Comments
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7110 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-24 01:42:23 +00:00
lgao4 5944a83bac Code clean for Ftw driver, remove the obsolete logic for boot block. Correct some comments in Pei Pcd driver.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7108 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-24 01:24:17 +00:00
vanjeff 2da292f637 1. code scrub for ConSplitterDxe.
2. fixed some bugs when thunking UGA based on GOP.


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7107 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-24 00:15:20 +00:00
qhuang8 48557c6550 Code scrub DxeIpl, Runtime, DevicePath, FvbServicesLib, DiskIo, Partition, English, EBC.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7105 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-23 16:20:43 +00:00
ywu21 6c5dc2b0bf pure UEFI should not include “PiDxe.h” and “PiPei.h”
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7101 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-23 09:18:06 +00:00
jgong5 402fa70fc9 Scrubbed some code for Ip4ConfigDxe.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7100 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-23 08:23:43 +00:00
ywu21 c3a78fc8f9 Fix function header
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7099 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-23 07:38:59 +00:00
ywu21 9a3293ac5c Fix filer header
Fix function header
Fix return status issues
Fix  in out issues
group functions source files reasonably to avoid duplicate functions declarations

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7098 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-23 07:35:46 +00:00
ywu21 ae213b7de6 Fix function header
Fix return status issues
Fix  in out issues


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7097 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-23 07:29:54 +00:00
ywu21 3e7104c26f Remove #include <Protocol/LoadedImage.h>
Remove //#include <Protocol/Ip4.h>
Remove  #include <Library/UefiLib.h>
Fix one function header description error

Fix filer header
Fix function header
Fix return status issues
Fix  in out issues
Fix  no Boolean expression issues


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7096 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-23 07:22:15 +00:00
eric_tian 257efb0ba3 fix ECC tool's warning
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7095 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-23 05:08:24 +00:00
eric_tian 498aeaf367 correct the guid value of EFI_CAPSULE_ARCH_PROTOCOL_GUID which is differ from PI1.1 spec
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7094 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-23 04:58:23 +00:00
klu2 2e9f9668a9 Refine function comments for BdsDxe module.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7093 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-23 03:32:20 +00:00
eric_tian d2bc9f321f refine comments for EFI_CONSOLE_CONTROL_PROTOCOL
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7091 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-23 02:56:44 +00:00
eric_tian aae4ad0583 remedy the comment of EFI_CONSOLE_CONTROL_PROTOCOL_LOCK_STD_IN
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7090 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-23 02:32:07 +00:00
eric_tian 3d3aafc4df remedy the ppi comment. This module is always used to produced gEfiPeiReadOnlyVariable2PpiGuid but not consumes it
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7086 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-22 06:22:36 +00:00
vanjeff fc753d3b82 code scrub for consplitter module.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7085 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-22 02:29:21 +00:00
klu2 bddd8b2d17 Refine comments for BDS module.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7084 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-19 09:06:17 +00:00
vanjeff ec815813ce fixed one bug to pass GCC.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7083 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-19 06:30:40 +00:00
jji4 ca08e40b90 Coding style corrected
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7081 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-19 02:15:47 +00:00
jji4 7df7393feb check the usage of %d,%x,%ld,%lx and so on in debug print statement.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7080 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-18 08:48:36 +00:00
lgao4 8501ba4c6d Enhance PciCfg2 driver to handle unaligned Pci access according to PI spec.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7077 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-18 07:40:19 +00:00
jji4 f7a56b6eac Library class of MemoryAllocationLib has been added.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7074 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-18 05:39:10 +00:00
jji4 94e0fd072b Library class of MemoryAllocationLib has been added.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7073 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-18 05:30:57 +00:00
jji4 9b38ff3499 Some codes have been altered and replaced by functions of memory allocation library.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7072 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-18 05:28:26 +00:00
jljusten d0cca731c3 MdeModulePkg/Universal/Network/IScsiDxe/IScsiImpl.h:
* Fix #include filename case for building under Linux

MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Misc.c:
MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Input.c:
* Fix warning of 'unhandled' cases in switch statement generated
  by GCC.


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7071 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-17 18:01:32 +00:00
qhuang8 c4f9201e2e Refine code to remove structure assignment
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7070 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-17 12:07:02 +00:00
gikidy dfe687cad5 Fix some typo.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7067 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-17 09:35:12 +00:00
gikidy 11baadb671 Code scrub for Universal\Console\TerminalDxe.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7066 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-17 09:34:06 +00:00
jji4 6c94a00d0e Some codes have been altered and replaced by library functions which makes more efficient and rational.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7065 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-17 09:20:16 +00:00
klu2 2a06f5327d refine module description for BdsDxe module.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7063 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-17 08:43:39 +00:00
gikidy 878670eaa6 Code scrub for Universal\Console\GraphicsConsoleDxe.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7061 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-17 06:23:23 +00:00
klu2 2621e6ca7a Update module description for PCD Dxe driver.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7060 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-17 03:29:16 +00:00
vanjeff 0da0de5ed8 1. add some comments.
2. remove unnecessary protocol declaration in inf file.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7059 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-17 02:17:53 +00:00
qhuang8 f3f2e05db8 Clean up to update the reference of the these macros:
EFI_SIGNATURE_16 -> SIGNATURE_16
  EFI_SIGNATURE_32 -> SIGNATURE_32
  EFI_SIGNATURE_64 -> SIGNATURE_64
  EFI_FIELD_OFFSET -> OFFSET_OF
  EFI_MAX_BIT      -> MAX_BIT
  EFI_MAX_ADDRESS  -> MAX_ADDRESS
These macros are not defined in UEFI spec. It makes more sense to use the equivalent macros in Base.h to avoid alias.


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7056 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-16 15:34:21 +00:00
qhuang8 dfa596b8f7 Fix several syntax issue to pass build.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7047 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-16 15:10:14 +00:00
vanjeff 509bc208d8 code scrub:
1. updated functions header.
2. sync some comments for .S files.
3. fixed some error in AsmFuncs.S

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7044 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-16 09:21:45 +00:00
ywu21 b263ee1718 202033 make .h more clear, seperate ComponentName.h IScsiInitiatorName.h from IScsiDriver.h
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7043 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-16 08:10:07 +00:00
ywu21 5af5b3fd84 1) fix one goto issue in IScsiProto.c
2)	add Md5.h in [Sources.common] of inf
3)	change mIScsiPrivateGuid to gIScsiPrivateGuid


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7042 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-16 07:17:19 +00:00
niry dfc1f033ea Add comments for functions.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7039 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-16 02:57:53 +00:00
qhuang8 74935bd732 Fix a missing doxygen parameter entry.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7038 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-15 16:03:37 +00:00
qhuang8 857dfc455d Code scrub performance library instances in MdeModulePkg
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7037 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-15 15:56:02 +00:00
vanjeff 43a99f081e Port AsmFuncs.s to pass CYGWINGCC build for x64.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7033 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-15 10:05:10 +00:00
xli24 3dad0f7c2e Sync function prototype.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7029 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-15 07:22:20 +00:00
xli24 b4e73a6373 Code Scrub for UsbKbDxe module.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7028 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-15 07:17:47 +00:00
ywu21 f3e1569dbb it was root caused to be Spec issue instead of code issue. It should be Action instead of * Action.
So roll back formal  change  in IScsiFormCallback ()

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7023 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-15 02:32:28 +00:00
ywu21 c5de0d5599 1) delete unused parameter from IScsiCHAPOnRspReceived ()
2)Correct one parameter mistake in IScsiFormCallback ()
3)Add OPTIONAL  in IScsiDriverBindingStop ()
4)delete unused parameter from IScsiCheckOpParams ()
5) fix 30+ [in  out]  issues


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7021 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-14 12:25:48 +00:00
xli24 999acf5ac9 Clean DriverSampleDxe for ICC build.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7020 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-14 06:00:41 +00:00
xli24 f84783148a Use correct capitalization to pass build on UNIXGCC.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7019 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-14 05:40:01 +00:00
eric_tian 45f6c85bb1 code scrub on VariableRuntime Dxe driver
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7017 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-12 09:48:24 +00:00
eric_tian 7c80e839f7 code scrub on VariableRuntime Dxe driver
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7016 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-12 09:27:17 +00:00
lgao4 57dba20b29 Change EFI_OPTIONAL_POINTER to EFI_OPTIONAL_PTR
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7015 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-12 08:51:57 +00:00
ywu21 963dbb3001 1)update function header coding style issue
change Some unexpected error happened.    to Other errors as indicated.
2) delete unused parameter in IScsiConfigFormInit()
3) correct IN OUT mistake in IScsiSessionInit ()
4)roll back one update for Piece of code in IScsiDhcp.c around line 99 on FieldIndex 

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7013 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-12 07:03:44 +00:00
gikidy d7db090280 Fix some typo.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7008 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-12 06:04:02 +00:00
gikidy 5f8be01274 Add description to .inf files.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7004 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-12 03:21:13 +00:00
jji4 5f087507ee INF head modified
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7003 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-12 03:00:18 +00:00
jji4 6f3156155b INF head modified
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7002 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-12 01:27:36 +00:00
xli24 4eac2175c6 Fix the issue that memory for device path is incorrectly freed, which leads to the bug that Richford recovery fails.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7001 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-11 15:59:27 +00:00
lgao4 cebc8d486e Code Scrub for Pcd, PlatformDriOverride and PlatOverMngr driver.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6998 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-11 09:30:13 +00:00
vanjeff c84507ab52 code scrub for DebugSpport Module.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6997 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-11 08:38:20 +00:00