Commit Graph

72 Commits

Author SHA1 Message Date
jchen20 6d1824fc6e Add comments to describe the difference between code and spec to fix the bug #202430
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8839 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-09 10:27:43 +00:00
jchen20 18d7ae2ee6 describe the difference with Spec to fix the bug #202465
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8837 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-09 09:41:35 +00:00
jchen20 b59768ca63 Add definition on SmmStatusCodeProtocol to comply the SMMCIS spec to fix the bug #202466
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8834 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-09 09:17:18 +00:00
jchen20 a69dbb0e9e the Comment the gap between Framework spec and code in the definition of FRAMEWORK_EFI_PEI_SERVICES
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8826 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-09 02:19:02 +00:00
eric_tian 13b3137440 according to DataHubSubclass spec, all fields of data record should be naturally alignment.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8821 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-08 09:56:07 +00:00
jchen20 40038403ea to fill the gap between Framework and code to fix the bug #202405, #202419, #202418, #202435,#202437, #202439, #202440
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8817 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-08 09:38:08 +00:00
eric_tian 631344e6d3 refine the DataHubRecords.h to comply with DataHubSubclass/MemSubclass/ProcSubclass/CacheSubclass spec.
add comments to notify there are gaps between code and specs.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8808 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-08 07:17:48 +00:00
eric_tian 4c617fa92b 1. add comments for those fields not defined by MemorySubclass spec.
2. change name MemorySpeed to MemoryTypeSpeed, which follows spec.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8804 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-08 04:32:40 +00:00
eric_tian 6b7058c4df Inconsistent with specification here:
It's a typo of MiscSubclass 0.9 spec. It should be a variable name "ChassisType" rather than a type "EFI_MISC_CHASSIS_TYPE".

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8803 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-08 03:59:53 +00:00
eric_tian eeff6bb017 1. EFI_MAXIMUM_CACHE_SIZE_DATA has changed to EFI_CACHE_MAXIMUM_SIZE_DATA, which follows spec.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8802 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-08 03:52:36 +00:00
eric_tian dcd8fb0c2b add comments to note it's the spec typo issue for EFI_CACHE_CONFIGURATION_DATA filed type. it should be UINT32 rather than UINT16
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8801 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-08 03:47:10 +00:00
eric_tian 2cbfdae36e add comment on EFI_PROCESSOR_CORE_FREQUENCY_LIST_DATA to note there is gap between code and spec.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8800 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-08 03:44:09 +00:00
eric_tian 2b47aaa69c add comments to note why EFI_MISC_PORT_DEVICE_PATH and etc exists here , which is not defined in MiscSubclass spec.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8797 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-08 03:38:23 +00:00
eric_tian b66be4ca3e 1. change the value of EFI_PROCESSOR_SUBCLASS_VERSION to follow spec.
2. remove EFI_STRING_TOKEN, which doesn't be defined by any spec. replace it with STRING_REF.
3. change the fields of EFI_EXP_BASE10_DATA to INT16 to follow spec.
4. change the field name of EFI_PROCESSOR_MISC_INFO to follow spec.
5. note that field which are introduced to reflect the SMBIOS2.6
6. change name EFI_PROCESSOR_HEALTH_STATUS to EFI_PROCESSOR_HEALTH_STATUS_DATA
7. EFI_CACHE_ASSOCIATION_DATA to  EFI_PROCESSOR_CACHE_ASSOCIATION_DATA

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8793 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-08 03:10:27 +00:00
eric_tian 7bfed576b0 Due to SmBios2.6 spec section 3.3.8.5 doesn't enumerate 24-way set-associative for cache info, so remove this value to follow spec.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8772 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-07 03:35:59 +00:00
darylm503 dbb698cbb5 Clean up Doxygen group comments.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8745 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-03 23:20:37 +00:00
darylm503 03df16089f Clean up Doxygen commenting.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8743 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-03 21:59:06 +00:00
vanjeff e02a0e9245 remove stranger characters.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8737 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-03 11:30:19 +00:00
klu2 8d303ef304 Synchronize the structure's member's name and comments for structure modified in CSM 0.97 specification.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8735 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-03 07:36:43 +00:00
klu2 e3e7f36a58 1, Synchronize CSM related structure definition's comments with Intel framework specification.
2, To following specification, correct following member's name:
   a) change the member name of EFI_COMPATIBILITY16_TABLE.OemintSegement to EFI_COMPATIBILITY16_TABLE.OemInt15Segment. 
   b) change the member name of EFI_COMPATIBILITY16_TABLE.OemIntOffset to EFI_COMPATIBILITY16_TABLE. OemInt15Offset. 
   c) change the member name of EFI_DISPATCH_OPROM_TABLE. BbsTablePointer to EFI_DISPATCH_OPROM_TABLE. BbsTable.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8733 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-03 06:25:35 +00:00
rsun3 2baf6c6837 PeiCis.h clean up.
1. Add Doxygen comments for FRAMEWORK_EFI_PEI_SERVICES;
2. Remove definition of EFI_PEI_STARTUP_DESCRIPTOR. It is not defined in the PEI CIS spec and is implementation specific.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8730 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-03 01:33:47 +00:00
klu2 2e747cee12 Correct the enumeration value's name for EFI_COMPATIBILITY_FUNCTIONS with Intel Framework specification.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8727 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-02 18:46:07 +00:00
rsun3 e1d8d892f2 DxeCis.h clean up.
1. Add comments
2. TIANO_DEVICE_PATH and TIANO_MEDIA_FW_VOL_FILEPATH_DEVICE_PATH_TYPE structures removed. They are not in DXE CIS spec.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8723 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-02 08:18:29 +00:00
klu2 2bbaeb0d62 Correct the structure's comments to follow doxygen format.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8721 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-02 07:40:24 +00:00
jljusten b4420c3607 Change single quote to use standard ascii character.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8708 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-01 18:18:10 +00:00
darylm503 8d129536f9 Updated copyright. Deleted erroneous "Module Name" line. Changed preceding macro, enum, and structure comments to Doxygen style. Changed existing structure member comments to Doxygen style. Cleaned up some comment blocks to conform to the coding specification. Changed @bug comments on structure members to the postfix style so that the correct members are documented. Removed duplicate, orphan, EFI_TO_COMPATIBILITY16_BOOT_TABLE comment and move remaining comment to the correct location. Add descriptive comment to terminating #endif.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8672 6f19259b-4bc3-4df7-8a09-765794883524
2009-06-26 19:36:51 +00:00
darylm503 c7ab4e83a6 Changed Copyright to 2006-2009 to reflect original through current revisions. Deleted the Module Name line. Changed "Firmware Volume Block Attributes" comments to Doxygen Style and grouped the #defines together under that comment. EFI_FVB_CAPABILITIES macro Values were not aligned. Alignment made it unclear whether this was a simple or parameterized macro. Enhanced comments to make this clear. Re-aligned the EFI_TEST_FFS_ATTRIBUTES_BIT macro to make it easier to read. Added an identifying comment to the terminating #endif.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8671 6f19259b-4bc3-4df7-8a09-765794883524
2009-06-26 19:09:39 +00:00
gikidy a244f400e5 Verified some definitions of DataHubRecord.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8666 6f19259b-4bc3-4df7-8a09-765794883524
2009-06-26 06:16:33 +00:00
lgao4 920d2c23a1 Update header file comments.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8583 6f19259b-4bc3-4df7-8a09-765794883524
2009-06-17 08:46:49 +00:00
rsun3 9f6f953491 Update comments.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8574 6f19259b-4bc3-4df7-8a09-765794883524
2009-06-16 08:33:16 +00:00
mdkinney 9226e4ee0a Clean up CSM related include files to match specification
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8469 6f19259b-4bc3-4df7-8a09-765794883524
2009-06-04 22:49:59 +00:00
gikidy 0f899407a3 Update revision reference tag.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8369 6f19259b-4bc3-4df7-8a09-765794883524
2009-05-21 09:04:03 +00:00
gikidy 470d0b274c Synchronize code with specs.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8367 6f19259b-4bc3-4df7-8a09-765794883524
2009-05-21 06:11:39 +00:00
tding1 f55d5b188e update the spec file name in header
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8201 6f19259b-4bc3-4df7-8a09-765794883524
2009-04-29 03:27:06 +00:00
tding1 253f983a4b update the header to point to Smm Cis v1.1 to cover the definition of MP API
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8200 6f19259b-4bc3-4df7-8a09-765794883524
2009-04-29 03:10:31 +00:00
gdong1 9205b2d766 Update the header file coding style (alignment, comment, etc.)
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7893 6f19259b-4bc3-4df7-8a09-765794883524
2009-03-16 10:29:27 +00:00
gdong1 f7cf806ee9 Remove the BUGBUG modifier in the comment
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7103 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-23 09:47:58 +00:00
qhuang8 e89ec8f685 Clean up to update the reference of the these macros:
EFI_SIGNATURE_16 -> SIGNATURE_16
  EFI_SIGNATURE_32 -> SIGNATURE_32
  EFI_SIGNATURE_64 -> SIGNATURE_64
  EFI_FIELD_OFFSET -> OFFSET_OF
  EFI_MAX_BIT      -> MAX_BIT
  EFI_MAX_ADDRESS  -> MAX_ADDRESS
These macros are not defined in UEFI spec. It makes more sense to use the equivalent macros in Base.h to avoid alias.


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7051 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-16 15:31:58 +00:00
qhuang8 8bc7aa6aa6 Add missing Framework HII definitions to pass build.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6172 6f19259b-4bc3-4df7-8a09-765794883524
2008-10-21 13:36:05 +00:00
klu2 eabbb93bfe Remove blank for function typedef, it break generating doxygen document
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5595 6f19259b-4bc3-4df7-8a09-765794883524
2008-07-31 08:24:25 +00:00
klu2 69686d5669 Remove blank for function typedef, it will break generating doxygen document.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5591 6f19259b-4bc3-4df7-8a09-765794883524
2008-07-31 07:44:54 +00:00
qwang12 661e7afdfd Remove the tailing ',' to ensure the code pass EBC's -Za option (Enforces strict conformance to the ANSI standard for C).
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5327 6f19259b-4bc3-4df7-8a09-765794883524
2008-06-04 10:49:37 +00:00
lgao4 c2c8503b37 Correct EFI_COMPATIBILITY16_TABLE_SIGNATURE definition to "IFE$"
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5094 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-18 04:56:52 +00:00
klu2 4a71b21a63 Add more comments for IntelFramework's header files.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5003 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-08 06:29:25 +00:00
qwang12 11219cc655 [Description]:
1) Remove the definition of EFI_DISPATCH_OPROM_TABLE from IntelFrameworkPkg\Include\Framework\Legacy16.h to TianoModulePkg\Include\LegacyBios.h as it is not defined in any Intel Framework spec.

[Impaction]:
Build break for Modules that reference this undocuments structure.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4853 6f19259b-4bc3-4df7-8a09-765794883524
2008-03-15 04:11:35 +00:00
klu2 765e516c7f Modify the structure name to follows spec.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4848 6f19259b-4bc3-4df7-8a09-765794883524
2008-03-14 01:46:44 +00:00
xli24 ab654bfd6e Add definition for EfiCacheAssociativity24Way.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4846 6f19259b-4bc3-4df7-8a09-765794883524
2008-03-13 17:49:14 +00:00
klu2 91399a51e7 Add more smbios record support.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4824 6f19259b-4bc3-4df7-8a09-765794883524
2008-03-11 05:58:06 +00:00
qwang12 6178919748 UEFI HII: Merge UEFI HII support changes from branch.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4603 6f19259b-4bc3-4df7-8a09-765794883524
2008-01-22 01:27:53 +00:00
qhuang8 8a7d75b062 Clean up: update "EFI" to "UEFI" if applicable.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4317 6f19259b-4bc3-4df7-8a09-765794883524
2007-11-22 06:00:39 +00:00