Commit Graph

1370 Commits

Author SHA1 Message Date
eric_tian 57dfc48f93 enhance the condition branch to handle Unix style file path. and avoid array overflow
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7394 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-02 08:01:35 +00:00
qwang12 0ea756d403 Update the comment section of INF to add in more meta data description.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7393 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-02 07:38:16 +00:00
qwang12 fd0fd8918e Remove the accidental check in of test code.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7392 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-02 07:27:44 +00:00
qwang12 bc166db311 Add in ASSERT to check out-of-bound and possible dereference of NULL pointers.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7391 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-02 07:18:59 +00:00
eric_tian af58e37731 add parameter check logic to clean up Klocwork warning.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7390 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-02 05:50:45 +00:00
eric_tian 6041576eb2 The caller of FindVariable() function ensure VariableName != NULL && VendorGuid != NULL. In the internal of this function, we only need to ensure that (VariableName[0] != 0 && VenderGuid != NULL) is true.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7389 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-02 03:13:35 +00:00
qwang12 e4a3922f03 Update the protocol function to return EFI_INVALID_PARAMETER if CallBackFunction == NULL. The PCD library function will do ASSERT if CallBackFunction is NULL.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7385 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-01 10:04:40 +00:00
niry 3dc3861a4e re order the function definition to avoid unnecessary declaration.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7381 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-01 03:36:25 +00:00
mdkinney 4cf894eba8 Split out Synchronization Library from Base Library
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7373 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-30 00:33:39 +00:00
lgao4 6426c8ffb4 Add comments for these header files
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7364 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-23 14:45:13 +00:00
xli24 7772b1760f Update for Meta data.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7361 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-23 10:01:51 +00:00
klu2 c516c7178a Move BdsDxe and GenericBdsLib to IntelFrameworkModulePkg, these modules need dependent on gEfiLegacyBiosProtocol to provide legacy boot support. But legacy boot is not described by PI/UEFI specification.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7353 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-23 07:23:46 +00:00
klu2 485a505713 Add more checkpoint for deference pointer.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7350 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-23 04:45:48 +00:00
klu2 cb26370805 Fix issue from code scrub.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7349 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-23 03:32:01 +00:00
lgao4 9872985bb1 Add check when use Index as Array [Index] to avoid out of Array bound.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7348 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-22 15:40:06 +00:00
lgao4 80882266ed Add check after allocate pool.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7347 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-22 14:09:21 +00:00
vanjeff 60c65d37e2 remove klocwork issue.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7346 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-22 09:07:53 +00:00
xli24 7a79628e35 Add check for NULL pointer.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7344 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-22 05:03:14 +00:00
lgao4 96827f1756 Correct FeatureFlagExpress PCD format based on INF spec.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7327 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-21 07:25:23 +00:00
gikidy 364a232c4a Meta-data reviewed and verified.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7326 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-21 07:08:57 +00:00
qhuang8 a833f286fb Update to add the ASSERT()s in the right place.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7325 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-21 05:37:27 +00:00
qwang12 4a1102c9ae K8:
1) add in more ASSERT condition and updates the comment for HexStringToBuf.
2) Check the pointer returned by HiiLibGetHiiHandles.



git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7324 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-21 05:33:41 +00:00
eric_tian 29dd3b04b0 Fix Klocwork warning. We should directly return EFI_INVALID_PARAMETER when BufferSize is NULL.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7323 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-21 04:56:24 +00:00
qwang12 40a06b0ca8 K8:
1) Replace immediate constant with MACRO.
2) Add in ASSERT for NULL before dereferencing pointers and after memory allocation.
3) Add a return statement in ProcessOptions to handle the mismatch between the value stored and the opcode for one-of-option in orderedlist opcode. This case occurs when the one-of-optoin entry in OrderedList get deleted.


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7320 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-20 12:55:02 +00:00
gikidy 7bfc66a284 Meta-data review.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7319 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-20 08:27:13 +00:00
gikidy 16a747ed5e Add some info for some PCD controlled GUIDs and Protocols.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7318 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-20 05:13:35 +00:00
gikidy 32e24669c2 Meta-data review.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7317 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-20 04:57:29 +00:00
jji4 79864f54ce Source level security checked
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7316 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-20 04:17:05 +00:00
gikidy 7fa5d6e149 Meta-data review.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7314 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-20 03:07:20 +00:00
gikidy a503cc6971 Meta-data review.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7313 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-20 03:04:55 +00:00
gikidy f50cf5032a Meta-data review.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7312 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-20 03:01:44 +00:00
eric_tian f34aec3bc8 coding style
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7311 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-20 03:01:41 +00:00
qwang12 fa7b3168fd K8:
1) Add in "check-for-null" before dereferencing a pointer.
2) unify the handling of EFI_OUT_OF_RESOURCE case.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7310 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-20 02:00:46 +00:00
qwang12 d0720b5706 K8:
Add in "check-for-null" to catch the de-reference of NULL pointer.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7309 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-20 01:55:11 +00:00
qwang12 96ff65a1fb K8:
1) Fix the bug the assert conditions. || should be &&.
2) Add in code path and check-for-null-pointer to do error handling.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7308 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-20 01:52:02 +00:00
qwang12 5a829f5688 K8: add new variable PasswordSize to remove immeidate constant.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7307 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-20 01:48:39 +00:00
jji4 1ac628eee0 Assertions added
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7305 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-19 07:58:58 +00:00
jji4 c59634eab6 Source level security checked
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7303 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-19 06:55:18 +00:00
gikidy 8c80d3942e Add some ASSERT()s.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7302 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-19 06:34:35 +00:00
jji4 49fabc83a5 Source level security checked
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7301 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-19 05:23:02 +00:00
gikidy 3069bc1944 Add some ASSERT()s.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7299 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-19 01:55:14 +00:00
klu2 19c804c4b3 Fix the wrong file comments for SnpDxe.inf driver
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7298 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-18 17:19:28 +00:00
jji4 e6c4ef1336 Source level security checked
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7297 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-16 08:14:39 +00:00
gikidy 8d4cd91527 1.Moved HotPlugDevice.h & SimpleTextInNotify.h from /Guid to /Protocol
2.Modified the reference of two Guids in DEC file, Inf files and h files;

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7294 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-16 07:33:08 +00:00
niry dab714aa11 Insert comments for functions/macros and add the file headers.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7293 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-16 06:56:18 +00:00
jgong5 bd59b46eb4 sync function header to avoid ecc
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7292 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-16 00:17:38 +00:00
jgong5 24af132fc0 Fixed OPTIONAL/comma issue
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7291 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-16 00:16:17 +00:00
jgong5 3e8c18da04 code scrub fix
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7290 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-16 00:09:52 +00:00
qwang12 90e128e28a Fix a bug which print new stack size and old stack size wrongly.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7285 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-15 08:50:24 +00:00
jji4 812acaec29 Comments checked
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7284 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-15 06:09:35 +00:00