Commit Graph

68 Commits

Author SHA1 Message Date
eric_tian af58e37731 add parameter check logic to clean up Klocwork warning.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7390 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-02 05:50:45 +00:00
jji4 49fabc83a5 Source level security checked
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7301 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-19 05:23:02 +00:00
jji4 7351070b11 Library usage checked
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7132 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-26 06:53:45 +00:00
jji4 7df7393feb check the usage of %d,%x,%ld,%lx and so on in debug print statement.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7080 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-18 08:48:36 +00:00
qhuang8 f3f2e05db8 Clean up to update the reference of the these macros:
EFI_SIGNATURE_16 -> SIGNATURE_16
  EFI_SIGNATURE_32 -> SIGNATURE_32
  EFI_SIGNATURE_64 -> SIGNATURE_64
  EFI_FIELD_OFFSET -> OFFSET_OF
  EFI_MAX_BIT      -> MAX_BIT
  EFI_MAX_ADDRESS  -> MAX_ADDRESS
These macros are not defined in UEFI spec. It makes more sense to use the equivalent macros in Base.h to avoid alias.


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7056 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-16 15:34:21 +00:00
gikidy 5f8be01274 Add description to .inf files.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7004 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-12 03:21:13 +00:00
mdkinney 50d7ebad92 Change _CR() to BASE_CR() to follow naming convention
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6888 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-06 01:23:24 +00:00
jji4 edd1ceb7a0 Typo corrected
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6845 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-04 09:15:57 +00:00
jji4 d354ab7ff9 1)Global variables have been moved backward ahead of functions.
2)INF comments have been reviewed.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6839 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-04 07:12:25 +00:00
gikidy cfc8865f17 Remove some useless EDK_RELEASE_VERSION, EFI_SPECIFICATION_VERSION ,and review VALID_ARCHITECTURES in inf files with DSC file.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6818 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-03 09:08:05 +00:00
jji4 aa79b0b379 Global variables have been moved backward ahead of functions.
Only a few cases were left due to its module structure.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6816 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-03 08:52:39 +00:00
qhuang8 bfd89145aa Add the AND of all architectural protocols for this special DXE_RUNTIME driver.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6767 6f19259b-4bc3-4df7-8a09-765794883524
2008-11-27 14:08:09 +00:00
klu2 1232b21473 1, Add <Library/DevicePathLib.h> for all source that use device path utility macros
2, Add DevicePathLib library class to module's INF that use device path utility macros

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6456 6f19259b-4bc3-4df7-8a09-765794883524
2008-11-11 15:42:40 +00:00
klu2 e4ff9017f8 Remove over specific Guid
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6389 6f19259b-4bc3-4df7-8a09-765794883524
2008-11-05 05:07:29 +00:00
jji4 fe1e36e550 Patch to remove STATIC modifier. This is on longer recommended by EFI Framework coding style. All duplicated symbols has been renamed accordingly.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6296 6f19259b-4bc3-4df7-8a09-765794883524
2008-10-30 06:05:06 +00:00
qwang12 0e549d5be5 Make use of correct format String:
1) UINT64 should use %lx
2) POINTER type should use %p
3) EFI_STATUS should use %r


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6253 6f19259b-4bc3-4df7-8a09-765794883524
2008-10-27 10:13:00 +00:00
vanjeff ed66e1bc0d clean up the un-suitable ';' location when declaring the functions.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5820 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-04 09:37:28 +00:00
lgao4 60c93673b3 The driver and library in MdePkg, MdeModulePkg and Nt32Pkg that don't depend on PI spec should include Uefi.h not PiDxe.h.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5758 6f19259b-4bc3-4df7-8a09-765794883524
2008-08-30 14:09:38 +00:00
lgao4 e872988180 remove the unused msa files in MdeModulePkg.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5726 6f19259b-4bc3-4df7-8a09-765794883524
2008-08-25 05:03:29 +00:00
qhuang8 d3f1611730 Update some module INF files in MdeModulePkg to "UEFI_DRIVER"
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5676 6f19259b-4bc3-4df7-8a09-765794883524
2008-08-18 09:18:44 +00:00
eric_tian 9920ae74af modify coding style to pass ecc tool
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5575 6f19259b-4bc3-4df7-8a09-765794883524
2008-07-28 02:43:46 +00:00
eric_tian 56a88912eb modify coding style
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5437 6f19259b-4bc3-4df7-8a09-765794883524
2008-07-09 10:06:12 +00:00
eric_tian ab6495eacf modify coding style to pass ecc tool and provide comments that complied with Doxgen.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5429 6f19259b-4bc3-4df7-8a09-765794883524
2008-07-09 01:50:16 +00:00
eric_tian 78c2ffb5a7 modify coding style to pass ecc tool and provide comments that complied with Doxgen.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5427 6f19259b-4bc3-4df7-8a09-765794883524
2008-07-08 10:26:16 +00:00
eric_tian a92d4e8a8e Make USB Stack code pass ECC tool check.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5405 6f19259b-4bc3-4df7-8a09-765794883524
2008-07-02 05:45:04 +00:00
qwang12 7c24ae3685 Boolean values and variable type BOOLEAN should not use explicit comparisons to TRUE or FALSE
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5377 6f19259b-4bc3-4df7-8a09-765794883524
2008-06-30 02:19:41 +00:00
vanjeff b4c24e2d42 [Description]:
Sync 3 trackers.
 1. A bug that may cause the low/full speed device behind 2.0 hub will not work.
 2. MajorRevision and MinorRevision need updating.
 3. Misuse UhciConvertPollRate in UHCI driver.
[Impaction]:
 EhicDxe, UhciDxe and UsbBusDxe.
[Reference Info]:
 EDK tracker 1122 - A bug that may cause the low/full speed device behind 2.0 hub will not work .
 EDK tracker 1101 - Phoenix found issue in USB and Misuse UhciConvertPollRate in UHCI driver.



git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5370 6f19259b-4bc3-4df7-8a09-765794883524
2008-06-25 05:50:41 +00:00
qhuang8 6d5794302b Add #ifndef statement for header file.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5296 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-27 01:34:25 +00:00
qhuang8 cc582cffd1 Rename the confusing PCD.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5169 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-06 09:34:46 +00:00
qhuang8 dd4047a51c [Description]:
Add a feature flag in Uhci & Ehci to disable legacy USB SMI.
[Impaction]:
  Platform integrator can choose to legacy USB SMI or not.
[Reference Info]
  EDK Tracker 1082

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5081 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-17 11:02:59 +00:00
vanjeff ffa5008abb apply for doxgen format.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5030 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-09 08:33:17 +00:00
jljusten 1be0dda62d Fix warnings generated by gcc for ia32 builds:
'cast from pointer to integer of different size'
when casting from a pointer directly to a
64 bit number.  Added an intermediate cast to
UINTN.


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5009 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-08 20:59:38 +00:00
lgao4 f0a83bb308 [Description]:
Don't need disable the legacy USB SMI in UHCI and EHCI, which is only required by UoL.
[Impaction]:
 Uhci and Ehci driver default don't need disable the legacy USB SMI.
[Reference Info]:
 EDK tracker 1082 
 

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4850 6f19259b-4bc3-4df7-8a09-765794883524
2008-03-14 05:06:26 +00:00
jljusten 1682995344 edk2/MdeModulePkg/Bus/Pci/UhciDxe/ComponentName.c:
Fix #include filename for case-sensitive filesystems.


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4753 6f19259b-4bc3-4df7-8a09-765794883524
2008-02-26 01:10:10 +00:00
vanjeff 1c61953576 1. Added EFI_MEDIA_CHANGED and EFI_INVALID_PARAMETER returns in UsbMassReadBlocks().
2. Use DEBUG () to replace some native debug function in USB stack modules.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4689 6f19259b-4bc3-4df7-8a09-765794883524
2008-02-13 09:08:24 +00:00
vanjeff 392d56cf4e fixed comments problem.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4619 6f19259b-4bc3-4df7-8a09-765794883524
2008-01-24 02:38:23 +00:00
vanjeff ea5632e56d 1. Remove USB HC Protocol installing from Uhci module. It only installs USB2 HC protocol.
2. Restore Incompatible Pci Device Support Protocol in PciBus module.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4617 6f19259b-4bc3-4df7-8a09-765794883524
2008-01-23 09:41:04 +00:00
vanjeff 6a6d955c5f Fixed potential issues to release resources when error occurs.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4341 6f19259b-4bc3-4df7-8a09-765794883524
2007-11-28 03:55:36 +00:00
qhuang8 0acd9855d8 Remove Atapi Pass Thru driver in MdeModulePkg. This module is only used for testing. We can use this module from OptionRomPkg
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4310 6f19259b-4bc3-4df7-8a09-765794883524
2007-11-20 07:17:56 +00:00
vanjeff 41057d7787 Remove gEfiNetworkInterfaceIdentifierProtocolGuid reference from code base. Only left its definition in MdePkg.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4295 6f19259b-4bc3-4df7-8a09-765794883524
2007-11-13 09:08:17 +00:00
vanjeff 68246fa809 Save original PCI attributes in start() function and restore it in Stop() for those PCI device drivers.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4212 6f19259b-4bc3-4df7-8a09-765794883524
2007-10-25 07:59:45 +00:00
lgao4 96f6af14d6 Remove the special logic on EFI_PCI_DEVICE_ENABLE in PciBus driver. And update drivers that use this macro. The reason is that
PciIoAttributes() in PciIo.c treats EFI_PCI_DEVICE_ENABLE specially so that when EFI_PCI_DEVICE_ENABLE is passed in, only the supported bits of driver will be enabled. Now many drivers use EFI_PCI_DEVICE_ENABLE to enable PCI device even if some of them don't support some of the attributes like EFI_PCI_IO_ATTRIBUTE_MEMORY. This doesn't conform to UEFI 2.0 spec.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4115 6f19259b-4bc3-4df7-8a09-765794883524
2007-10-15 07:44:27 +00:00
qhuang8 d1aeb0bdc3 Add compiler hint of "GLOBAL_REMOVE_IF_UNREFERENCED" to prevent static unicode string table linked into final image if both PcdComponentNameDisabled and PcdComponentName2Disabled are set to TRUE.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4084 6f19259b-4bc3-4df7-8a09-765794883524
2007-10-11 03:36:31 +00:00
jwang36 db01f13e00 Changed to pass the build with Visual Studio 2005
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4075 6f19259b-4bc3-4df7-8a09-765794883524
2007-10-10 07:04:15 +00:00
qhuang8 1307dcd745 Add compiler hint of "GLOBAL_REMOVE_IF_UNREFERENCED" to prevent component name structures linked into final image if PcdComponentNameDisabled or PcdComponentName2Disabled is set to TRUE.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4057 6f19259b-4bc3-4df7-8a09-765794883524
2007-10-09 07:08:08 +00:00
yshang1 23c326c201 Support ICC build .
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4039 6f19259b-4bc3-4df7-8a09-765794883524
2007-10-08 06:45:07 +00:00
yshang1 41e8ff2781 Fixed unexpected timeout in Usb MassStorage Driver.
Fixed unexpected timeout in Uhci/Ehci driver.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4038 6f19259b-4bc3-4df7-8a09-765794883524
2007-10-08 06:14:13 +00:00
qhuang8 f527bce3d0 Update to support to produce Component Name and & Component Name 2 protocol based on Feature flag PcdComponentNameDisable & PcdComponentName2Disable.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4000 6f19259b-4bc3-4df7-8a09-765794883524
2007-09-30 02:42:47 +00:00
qhuang8 f36d6e669c 1. Set the Target array to zero before fill the target id.
2. Get the command/control register base address for each channel through IDE common registers.
3. Correctify some return status to sync with newest Uefi Spec 2.1



git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@3901 6f19259b-4bc3-4df7-8a09-765794883524
2007-09-20 10:06:50 +00:00
yshang1 d074a8e1a2 Update Mde/MdeModulePkg to support ICC build for IA32/X64.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@3892 6f19259b-4bc3-4df7-8a09-765794883524
2007-09-19 06:15:43 +00:00