tyler.durden
/
audk
mirror of https://github.com/acidanthera/audk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
24,898 Commits 14 Branches 0 Tags 318 MiB
Commit Graph

852 Commits

Author SHA1 Message Date
jcarsey b6b22b132a ShellPkg: Eliminate loss of high bits in return value from exit command on 64 bit platform. 
submitted-by: jcarsey
reviewed-by:  gookboy15a
reviewed-by:  niruiyu

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12356 6f19259b-4bc3-4df7-8a09-765794883524
 2011-09-15 20:10:39 +00:00
jcarsey 6a5aa4d6dc ShellPkg: Add 3 missing function declaration comments and change a function static variable to a file global variable. 
Submitted-by: jcarsey
Reviewed-by:  geekboy15a
Reviewed-by:  ydong10

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12317 6f19259b-4bc3-4df7-8a09-765794883524
 2011-09-09 16:57:26 +00:00
jcarsey a0cd353dd2 ShellPkg: allow for mm command to properly write PCIe in non-interactive mode. 
Submitted-by: jcarsey
Reviewed-by: jljusten
Reviewed-by: marothma



git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12299 6f19259b-4bc3-4df7-8a09-765794883524
 2011-09-08 16:50:17 +00:00
ydong10 4ff7e37b4f Refine comments and two code style. 
Signed-off-by: ydong10

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12263 6f19259b-4bc3-4df7-8a09-765794883524
 2011-09-02 08:05:34 +00:00
jcarsey 5d46f17ba7 ShellPkg: fix ShellPrint-functions to allow for escape character to prevent attribute changes. 
This allows for the editors to function easily.

signed-off-by: jcarsey
reviewed-by: kidzyoung

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12187 6f19259b-4bc3-4df7-8a09-765794883524
 2011-08-23 15:34:23 +00:00
jcarsey d159ab9538 ShellPkg: fix build error when converting INTN to INT32. 
signed-off-by: jcarsey
Reviewed-by: lgao4

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12186 6f19259b-4bc3-4df7-8a09-765794883524
 2011-08-23 15:32:49 +00:00
jcarsey 382e78c09c ShellPkg: bug fix for edit search/replace function 
* Fix the search bug: if word to be searched at the beginning of the line, it can not be found out.

Signed-off-by: kidzyoung
reviewed-by: jcarsey

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12116 6f19259b-4bc3-4df7-8a09-765794883524
 2011-08-10 14:48:14 +00:00
jcarsey 573d7e468e remove CatSPrint from ShellPkg. 
signed-off-by: jcarsey
reviewed-by: lgrosenb

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12100 6f19259b-4bc3-4df7-8a09-765794883524
 2011-08-08 18:22:08 +00:00
jcarsey 1e2b43f1e2 ShellPkg: Added the Ctrl based hot key for hexedit 
* Add Ctrl based hotkey alternatives to function hotkeys.
* Update help menu for hexedit.

Signed-off-by: kidzyoung
Reviewed-by: jljusten
Reviewed-by: jcarsey

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12082 6f19259b-4bc3-4df7-8a09-765794883524
 2011-08-03 17:28:04 +00:00
jcarsey feccc28a6f cleanup function and eliminate build error. 
submitted-by:jcarsey
reviewed-by: lgao4

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12069 6f19259b-4bc3-4df7-8a09-765794883524
 2011-08-01 15:18:19 +00:00
jcarsey 5a2beb745f ShellPkg: Added the Ctrl based hot key and changed text editor's UI. 
* Add Ctrl-E hotkey for help
* Add Ctrl based hotkey alternatives to function hotkeys
* Don't show hotkey help on the main screen
* Change the file buffer's row count for display to adjust the new screen format
* Change the edit status bar location, the new edit status bar is in the last line
* Change the location of the edit bar, the new edit input bar is in the last line

Signed-off-by: kidzyoung
reviewed-by: jcarsey
reviewed-by: jljusten
reviewed-by: jiang

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12036 6f19259b-4bc3-4df7-8a09-765794883524
 2011-07-20 20:10:45 +00:00
jcarsey 5ddca3b91b fix issue about slashes on end of comment line. 
signed-off-by:jcarsey

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12003 6f19259b-4bc3-4df7-8a09-765794883524
 2011-07-11 14:32:34 +00:00
jcarsey 4d0a4fcefe Move the 2 functions associated with reading whole lines at a single time from the shell command (internal) library to the ShellLib (external) library. 
signed-off-by: jcarsey
reviewed-by: lgrosenb

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12000 6f19259b-4bc3-4df7-8a09-765794883524
 2011-07-06 22:28:36 +00:00
jcarsey ab94587a7d This refactors 3 functions out of ShellCommandLib and puts them into a new library (but as 2 functions instead of 3). This allows for users outside of the shell itself to have access to these functions. 
1) Remove the 3 functions out of the shell's internal library (ShellCommandLib)
2) Add a new library class (PathLib)
3) Add an instance of this class (BasePathLib)
4) Change all internal shell callers to use this new library class.

signed-off-by: jcarsey
reviewed-by: jljusten

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11936 6f19259b-4bc3-4df7-8a09-765794883524
 2011-06-30 22:58:53 +00:00
jcarsey f1518f6970 add fixes for code verification happyness. 
signed-off-by: jcarsey
reviewed-by: jljusten

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11935 6f19259b-4bc3-4df7-8a09-765794883524
 2011-06-30 22:25:46 +00:00
jcarsey 366f81a016 Clarify that the shared variables of the shell protocols are properly named. 
This removes the non-shared gEfiShellProtocol and gEfiShellParametersProtocol and renames the shared version to those names.

This removes the m-versions of those protocol pointers.

signed-off-by: jcarsey
reviewed-by: darylm503

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11900 6f19259b-4bc3-4df7-8a09-765794883524
 2011-06-27 21:04:22 +00:00
jcarsey 92a5447eda replace protocol presence ASSERTs with error returns. 
signed-off-by: jcarsey
reviewed-by: lgrosenb

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11899 6f19259b-4bc3-4df7-8a09-765794883524
 2011-06-27 20:33:13 +00:00
jcarsey 35f26e73cc replace assert with error. 
signed-off-by: jcarsey
reviewed-by: lgrosenb

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11897 6f19259b-4bc3-4df7-8a09-765794883524
 2011-06-27 20:28:23 +00:00
jcarsey 03131de30e Make sure size is correct. 
signed-off-by: jcarsey
reviewed-by: lgrosenb

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11896 6f19259b-4bc3-4df7-8a09-765794883524
 2011-06-27 20:27:29 +00:00
jcarsey 8bd282bee9 allow for failure return when called without a shell present. 
signed-off-by: jcarsey
reviewed-by: lgrosenb

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11894 6f19259b-4bc3-4df7-8a09-765794883524
 2011-06-27 16:45:41 +00:00
ydong10 72c8a89a65 Add check code to avoid access violation. 
Signed-off-by: ydong10
Reviewed-by: jcarsey


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11873 6f19259b-4bc3-4df7-8a09-765794883524
 2011-06-23 01:26:06 +00:00
ydong10 cd8462ea9d Check the buffer allocation result before using it. 
Signed-off-by:ydong10
Reviewed-by:jljusten


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11811 6f19259b-4bc3-4df7-8a09-765794883524
 2011-06-13 01:44:03 +00:00
jcarsey 420462d0fb remove empty sections in INF files. 
signed-off-by: jcarsey
reviewed-by: darylm503

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11769 6f19259b-4bc3-4df7-8a09-765794883524
 2011-06-08 18:28:03 +00:00
hhtian 6f18b50d02 update copyright line format 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11759 6f19259b-4bc3-4df7-8a09-765794883524
 2011-06-07 08:08:19 +00:00
jcarsey 2e8e9ed5ed Remove ASSERT within Ls for RTC error and associated changes. 
TimeDate.c: replace magic number with constant.
Ls.c: use new warning printout string and remove an ASSERT.  also replace magic number with constant.
The UNI file: add new warning printout string.

Signed-off-by: jcarsey
Reviewed-by: geekboy15a
Reviewed-by: lgrosenb


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11703 6f19259b-4bc3-4df7-8a09-765794883524
 2011-05-25 22:29:40 +00:00
jcarsey 77dd0c814e Clarify an error in Map command. 
Revert a change in Map command that affected some consistent map names being printed correctly.
Fix a library instance mapping in DSC.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11675 6f19259b-4bc3-4df7-8a09-765794883524
 2011-05-17 20:32:47 +00:00
jcarsey 82571fb5d1 add support to easily remove profiles and shell levels. the libraries will not do anything (but no longer fail), if the PCDs are changed to remove their functionality. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11666 6f19259b-4bc3-4df7-8a09-765794883524
 2011-05-16 22:12:20 +00:00
jcarsey 4880c2c94d added support for -i and -o for HII based configurations. 
added support for all EFI_DRIVER_CONFIGURATION(2) based configurations.
added support for display of all configurable handles.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11665 6f19259b-4bc3-4df7-8a09-765794883524
 2011-05-16 21:08:34 +00:00
jcarsey c89ea31f52 fix printout from SmbiosView command. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11605 6f19259b-4bc3-4df7-8a09-765794883524
 2011-05-02 16:43:15 +00:00
jcarsey f8d3e6898a check that memory allocation was successful. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11568 6f19259b-4bc3-4df7-8a09-765794883524
 2011-04-19 17:54:42 +00:00
jcarsey f20076daaf fix user input validation for time command. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11567 6f19259b-4bc3-4df7-8a09-765794883524
 2011-04-19 16:55:51 +00:00
jcarsey a49f6a2f7e fix for word wrapping. 
fix for SimpleTextInEx callbacks.
remove an ASSERT.
fix for -noconsolein parameter.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11544 6f19259b-4bc3-4df7-8a09-765794883524
 2011-04-15 18:20:40 +00:00
jcarsey 89e8537acf change file global variable to function local. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11539 6f19259b-4bc3-4df7-8a09-765794883524
 2011-04-13 23:37:50 +00:00
jcarsey eef1ed4638 rm - refine user input validation to prevent removal of CWD. 
change colors of "set" command output.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11538 6f19259b-4bc3-4df7-8a09-765794883524
 2011-04-13 23:37:21 +00:00
jcarsey a49016b117 move a function to the correct library. 
added "ren" as an alias for "mv"

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11537 6f19259b-4bc3-4df7-8a09-765794883524
 2011-04-13 23:35:59 +00:00
jcarsey 6878e7a7be update Bcfg to correctly remove by option index not variable name and add driver order items properly. 
update connect and reconnect to account for ignoring the child handle in the connect operation.

update disconnect to output correctly.

hexedit corrected to properly display status bar and title bar and refresh when required.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11525 6f19259b-4bc3-4df7-8a09-765794883524
 2011-04-12 21:55:07 +00:00
jljusten 2b578de0b2 ShellPkg: Fix GCC 4.4 build issues 
This change fixes various GCC 4.4 build issues
* EFIAPI usage inconsistencies
* multi-character literal warning ('eell')
* Filename case inconsistencies
* Use 'ULL' suffix for integers > 4GB

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11519 6f19259b-4bc3-4df7-8a09-765794883524
 2011-04-12 03:18:38 +00:00
jcarsey 411a3c3929 EditTitleBar - Remove ASSERT. Complete display output for Disk and Memory output. 
HexEdit      - Add more user input verification.  Fix output display.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11517 6f19259b-4bc3-4df7-8a09-765794883524
 2011-04-11 22:00:31 +00:00
andrewfish e0c2cc6f89 Fix Xcode, clang, and ARM build and link issues. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11513 6f19259b-4bc3-4df7-8a09-765794883524
 2011-04-07 21:50:16 +00:00
jcarsey 392fa5a63b add user input verification. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11512 6f19259b-4bc3-4df7-8a09-765794883524
 2011-04-07 21:44:09 +00:00
jcarsey d8f8021cbe ShellParametersProtocol - remove parsing from within quoted parameters. 
Pci - Add missing enumeration in switch statement.
For - Verify parameter before dereferencing.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11511 6f19259b-4bc3-4df7-8a09-765794883524
 2011-04-07 17:12:12 +00:00
jcarsey f3c5971626 add some parens. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11506 6f19259b-4bc3-4df7-8a09-765794883524
 2011-04-05 21:19:39 +00:00
jcarsey a1d4bfcc3f add comments to function declarations and definitions and updated to match coding style document. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11505 6f19259b-4bc3-4df7-8a09-765794883524
 2011-04-05 20:55:45 +00:00
jcarsey c5981e3c3d rename a file. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11504 6f19259b-4bc3-4df7-8a09-765794883524
 2011-04-05 20:18:03 +00:00
jcarsey cbdd109b43 check memory allocations for success. 
check pointer before access.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11503 6f19259b-4bc3-4df7-8a09-765794883524
 2011-04-04 21:41:24 +00:00
jcarsey 4aa4377fda correct last commit. fix build break for some compilers. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11502 6f19259b-4bc3-4df7-8a09-765794883524
 2011-04-04 16:11:07 +00:00
jcarsey 8a0b550b40 fix build break on some compilers. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11501 6f19259b-4bc3-4df7-8a09-765794883524
 2011-04-04 16:05:53 +00:00
jcarsey f2ad804f8b remove duplicate memory de-allocation. 
Add function header comment.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11500 6f19259b-4bc3-4df7-8a09-765794883524
 2011-04-01 22:19:02 +00:00
jcarsey ae724571be Comment's added and fixed. 
Pointer's checked for NULL before access and after memory allocations.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11499 6f19259b-4bc3-4df7-8a09-765794883524
 2011-04-01 22:16:01 +00:00
jcarsey b2bf973586 fix for the cp shell command - halt when an error was encountered and also fix the error message displayed. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11462 6f19259b-4bc3-4df7-8a09-765794883524
 2011-03-30 21:37:01 +00:00
jcarsey 33c031ee20 pointer verification (not NULL) and buffer overrun fixes. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11459 6f19259b-4bc3-4df7-8a09-765794883524
 2011-03-30 19:33:03 +00:00
jcarsey 6b825919f1 add more user input verification to connect and vol commands. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11458 6f19259b-4bc3-4df7-8a09-765794883524
 2011-03-30 16:36:42 +00:00
jcarsey 16751bb43d remove unused variable. 
add some parens.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11457 6f19259b-4bc3-4df7-8a09-765794883524
 2011-03-30 16:12:42 +00:00
ydong10 4bcb7fe768 Update inf file to follow spec. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11454 6f19259b-4bc3-4df7-8a09-765794883524
 2011-03-30 03:40:42 +00:00
jcarsey 2ec013ce0f clarify error message when listing files based on a metaname without a current working directory. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11450 6f19259b-4bc3-4df7-8a09-765794883524
 2011-03-29 20:19:51 +00:00
jcarsey 0841f3af8c fix changing time daylight settings without changing the time. 
add extra output for daylight setting.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11449 6f19259b-4bc3-4df7-8a09-765794883524
 2011-03-29 19:59:37 +00:00
jcarsey 980d554e3a smbiosview - add user input verification. 
HexEdit/Edit
 - More user input verification for HexEdit.
 - updated title bar refreshment.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11448 6f19259b-4bc3-4df7-8a09-765794883524
 2011-03-29 19:31:18 +00:00
jcarsey 64d753f12d initialize variable before error returns. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11447 6f19259b-4bc3-4df7-8a09-765794883524
 2011-03-29 19:28:20 +00:00
jcarsey e35b531794 prevents "" from being the result of trying to open the root of a drive. 
more input validation on vol command.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11444 6f19259b-4bc3-4df7-8a09-765794883524
 2011-03-28 21:49:17 +00:00
jcarsey 590c3cb14a cp - fix conditional for memory de-allocaiton. 
string file - fix copyright date.


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11443 6f19259b-4bc3-4df7-8a09-765794883524
 2011-03-28 18:42:51 +00:00
jcarsey 3737ac2bc3 comp - add comments and add input verification 
bcfg - updated for bugs.
compress - rename for coding standards. add comments.
dblk - add comments, input verification, and a header line
dmem - add comments, add input verification, add system table info
dmpstore - add comments
eficompress - add comments and add input verification 
efidecompress - add comments and add input verification 
loadpcirom - add comments and more output messages
memmap - add more output to exceed the spec.
mm - move functions, add comments, add input verification.
mode - add comment
pci - add input verification.
SerMode - add comments and add input verification 
setsize - add comments and add input verification 
setvar - add comments and add input verification 
smbiosview - add input verification.

clarify error messages.


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11438 6f19259b-4bc3-4df7-8a09-765794883524
 2011-03-25 21:22:20 +00:00
jcarsey 2442e62af7 add Edit and Hexedit shared features. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11437 6f19259b-4bc3-4df7-8a09-765794883524
 2011-03-25 21:15:26 +00:00
jcarsey 632820d1cf add Edit and HexEdit commands. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11436 6f19259b-4bc3-4df7-8a09-765794883524
 2011-03-25 21:15:07 +00:00
jcarsey 5a0fe66eda zero memory allocation. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11435 6f19259b-4bc3-4df7-8a09-765794883524
 2011-03-25 21:14:20 +00:00
jcarsey 361a826736 connect - add comments and add input verification 
devices - add comments and add input verification 
devtree - add comments and add input verification 
dh - add comments, add input verification, add support for "-d"
disconnect - add comments and add input verification 
drivers - add comments
drvcfg - add comment
drvdiag - add comments, add input verification, and fix language use
openinfo - add comments and add input verification 
reconnect - add comment
unload - add input verification.

main library files: add comments, #define protection, and more output to the user.


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11434 6f19259b-4bc3-4df7-8a09-765794883524
 2011-03-25 21:13:43 +00:00
jcarsey 1a63ec8f82 consist mapping - add comments and change variable names. 
UefiShellCommandLib - add comments and zero out memory allocations.

add guid to inf file.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11433 6f19259b-4bc3-4df7-8a09-765794883524
 2011-03-25 21:09:21 +00:00
jcarsey b0475f1289 clarify library type. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11432 6f19259b-4bc3-4df7-8a09-765794883524
 2011-03-25 21:06:46 +00:00
jcarsey 78ed876bf4 remove ASSERT. 
zero memory allocations.
add support for virtual devices without driver binding.

add #define protection for the header.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11431 6f19259b-4bc3-4df7-8a09-765794883524
 2011-03-25 21:06:23 +00:00
jcarsey 345cd2357a cls - add input verification. 
echo - add input verificaiton.
help - prints out commands in sorted order.
touch - add comments.
type - add error when file not found.  add comments.

main lib files:
add comments, clarify error messages.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11427 6f19259b-4bc3-4df7-8a09-765794883524
 2011-03-25 21:01:08 +00:00
jcarsey b54fd049bd Cd - add more input verification. 
Cp - support "\" as root of drive indicator.
Load - invert "-nc" to not connect.
Ls - ignore archive file attribute.
Map - add more input verification.  fix add by handle.
Mv - support overwrite question. support "\" as root of drive indicator.
Parse - add comments.
Rm - add comments.
TimeDate - add more input verification. add comments.
Vol - add new command.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11426 6f19259b-4bc3-4df7-8a09-765794883524
 2011-03-25 20:58:08 +00:00
jcarsey 2398d9b1d7 update functionality on Bcfg command. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11425 6f19259b-4bc3-4df7-8a09-765794883524
 2011-03-25 20:51:19 +00:00
jcarsey 252d945725 updated comments and added string-to-number conversion with return value to indicate success or failure. All parameter checking updated to non-case-sensitive. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11424 6f19259b-4bc3-4df7-8a09-765794883524
 2011-03-25 20:49:53 +00:00
jcarsey 68fb05272b Add Network1 profile. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11423 6f19259b-4bc3-4df7-8a09-765794883524
 2011-03-25 20:47:02 +00:00
jcarsey 9586a35127 update allocation to use Zero pool library function. 
correct copyright date.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11422 6f19259b-4bc3-4df7-8a09-765794883524
 2011-03-25 20:45:41 +00:00
jcarsey 4eb59be368 renaming the BaseFileHandleLib to UefiFileHandleLib. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11421 6f19259b-4bc3-4df7-8a09-765794883524
 2011-03-25 20:43:54 +00:00
jcarsey 77dcec128b Updating level 1 commands. 
exit - correctly convert the parameter to the return code.
for  - update string-to-number conversion.
if   - use shell string-to-number conversion and add comments.
stall- add command

main lib files:
add comments, clarify user visible strings, add stall.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11420 6f19259b-4bc3-4df7-8a09-765794883524
 2011-03-25 20:43:03 +00:00
hhtian d08fadb0e2 update copyright format 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11153 6f19259b-4bc3-4df7-8a09-765794883524
 2010-12-10 15:19:03 +00:00
jcarsey c154b99708 fixes for NULL verification. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11125 6f19259b-4bc3-4df7-8a09-765794883524
 2010-12-06 18:10:34 +00:00
jcarsey da70d02589 fix typo in comment. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11082 6f19259b-4bc3-4df7-8a09-765794883524
 2010-11-22 22:49:12 +00:00
jcarsey 5d73d92f56 Add "Debug1" profile (all but Edit and HexEdit commands) 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11068 6f19259b-4bc3-4df7-8a09-765794883524
 2010-11-16 22:36:37 +00:00
jcarsey 75aadf59c3 adding "Install1" profile. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11067 6f19259b-4bc3-4df7-8a09-765794883524
 2010-11-16 22:32:21 +00:00
jcarsey ff51746bd4 update error handling to use less ASSERT. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11053 6f19259b-4bc3-4df7-8a09-765794883524
 2010-11-12 21:40:12 +00:00
jcarsey a12e31e680 Update return value. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11052 6f19259b-4bc3-4df7-8a09-765794883524
 2010-11-12 19:50:46 +00:00
jcarsey 4ba4961641 Adding Driver1 profile commands to the UEFI Shell 2.0. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11050 6f19259b-4bc3-4df7-8a09-765794883524
 2010-11-12 19:40:21 +00:00
jcarsey 3e082d5826 Verify more memory allocations. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10910 6f19259b-4bc3-4df7-8a09-765794883524
 2010-10-04 16:44:57 +00:00
jcarsey 9ea69f8a05 Verify memory allocations were successful. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10909 6f19259b-4bc3-4df7-8a09-765794883524
 2010-10-04 16:30:40 +00:00
jcarsey d38a107995 change the en-dash to the standard dash character. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10908 6f19259b-4bc3-4df7-8a09-765794883524
 2010-10-04 16:29:30 +00:00
jcarsey e53bf79de7 verify that a memory allocation was successful. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10907 6f19259b-4bc3-4df7-8a09-765794883524
 2010-10-04 16:28:35 +00:00
jcarsey 0ab85bef03 move DeleteScriptFileStruct from a private to a public function. This allows for better memory cleanup when errors occur. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10906 6f19259b-4bc3-4df7-8a09-765794883524
 2010-10-04 16:26:29 +00:00
jcarsey 40d7a9cfaa fix a misspelling. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10905 6f19259b-4bc3-4df7-8a09-765794883524
 2010-10-04 16:25:24 +00:00
jcarsey 5dcb535512 No need to sort arrays of 1 element. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10899 6f19259b-4bc3-4df7-8a09-765794883524
 2010-09-28 18:57:40 +00:00
jljusten 7effcbff29 ShellPkg: Fix "unreachable code" warning with VS2005 
Since all paths of the switch block now return, it
is not possible to reach the code following the switch
block.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10894 6f19259b-4bc3-4df7-8a09-765794883524
 2010-09-20 07:03:51 +00:00
jcarsey 1ca79586f4 revert/update of a change this morning. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10892 6f19259b-4bc3-4df7-8a09-765794883524
 2010-09-17 21:58:15 +00:00
jcarsey 89fb1cf0db removing incorrect files. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10891 6f19259b-4bc3-4df7-8a09-765794883524
 2010-09-17 21:32:38 +00:00
jljusten e97233217e ShellPkg: Fix several GCC compiler warnings 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10890 6f19259b-4bc3-4df7-8a09-765794883524
 2010-09-17 20:09:48 +00:00
jljusten e26d7b5975 ShellPkg: Fix EFIAPI usage inconsistencies 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10888 6f19259b-4bc3-4df7-8a09-765794883524
 2010-09-17 20:08:57 +00:00
jljusten 8d095e78c6 ShellPkg: Fix path issues for Linux build support 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10887 6f19259b-4bc3-4df7-8a09-765794883524
 2010-09-17 20:08:20 +00:00
jljusten 8d0eff6317 ShellPkg: Remove unnecessary package dependencies 
Remove unnecessary references to IntelFrameworkPkg and
IntelFrameworkModulePkg.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10886 6f19259b-4bc3-4df7-8a09-765794883524
 2010-09-17 20:07:42 +00:00
jcarsey 36b4e01a25 remove extra file. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10884 6f19259b-4bc3-4df7-8a09-765794883524
 2010-09-16 22:37:24 +00:00
jcarsey 94f1ff8a87 remove extra file. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10883 6f19259b-4bc3-4df7-8a09-765794883524
 2010-09-16 22:37:00 +00:00
hhtian fbec9c0f1c copyright format update 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10875 6f19259b-4bc3-4df7-8a09-765794883524
 2010-09-14 12:22:42 +00:00
jcarsey a405b86d27 udk2010.up2.shell initial release. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10874 6f19259b-4bc3-4df7-8a09-765794883524
 2010-09-14 05:18:09 +00:00
xdu2 90bfa227ee Add some error checking. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10661 6f19259b-4bc3-4df7-8a09-765794883524
 2010-07-19 05:21:27 +00:00
klu2 21ecdf15a0 Library interface should be declared as EFIAPI 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10542 6f19259b-4bc3-4df7-8a09-765794883524
 2010-05-25 06:26:28 +00:00
hhtian 3a888f2a22 Update the copyright notice format 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10428 6f19259b-4bc3-4df7-8a09-765794883524
 2010-04-24 12:12:42 +00:00
lgao4 7b202cb0f9 1. Correct File header to ## @file 
2. Remove unnecessary .common] postfix on section.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10051 6f19259b-4bc3-4df7-8a09-765794883524
 2010-02-23 23:58:38 +00:00
jcarsey c9d92df05f k8 fixes and moving prompting for responses into this file. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9922 6f19259b-4bc3-4df7-8a09-765794883524
 2010-02-03 15:37:54 +00:00
jcarsey 91876ff963 remove unnecessary PCD usage 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9921 6f19259b-4bc3-4df7-8a09-765794883524
 2010-02-03 14:59:00 +00:00
jcarsey 1cd45e787d fix K8 coding issues. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9862 6f19259b-4bc3-4df7-8a09-765794883524
 2010-01-29 15:07:44 +00:00
jcarsey ac255da6f5 fix copyright and license block and fix a size issue. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9811 6f19259b-4bc3-4df7-8a09-765794883524
 2010-01-25 20:06:10 +00:00
jcarsey 1e6e84c7af fixed license header / copyright date on all files. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9810 6f19259b-4bc3-4df7-8a09-765794883524
 2010-01-25 20:05:08 +00:00
jcarsey 9e926b693d git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9758 6f19259b-4bc3-4df7-8a09-765794883524 2010-01-14 20:26:39 +00:00
jcarsey 22d1195390 add blank line 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9727 6f19259b-4bc3-4df7-8a09-765794883524
 2010-01-13 19:07:58 +00:00
jcarsey 969c783b46 adding new parameter to search and replace function to allow for easy skipping of items preceded by ^ 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9726 6f19259b-4bc3-4df7-8a09-765794883524
 2010-01-13 16:46:33 +00:00
jcarsey d54744cd6c git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9720 6f19259b-4bc3-4df7-8a09-765794883524 2010-01-12 19:04:06 +00:00
jcarsey b3011f4041 updating comments mostly. also added some new lib functions. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9710 6f19259b-4bc3-4df7-8a09-765794883524
 2010-01-11 21:49:04 +00:00
jcarsey ecd3d59f33 add ASSERT to 2 functions and fix issue with size difference between old and new shell versions. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9537 6f19259b-4bc3-4df7-8a09-765794883524
 2009-12-07 18:05:00 +00:00
jcarsey 11d2decf81 Adding StringNoCaseCompare to SortLib 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9535 6f19259b-4bc3-4df7-8a09-765794883524
 2009-12-07 18:04:03 +00:00
jcarsey 5cb3637f0f remove extra variables 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9504 6f19259b-4bc3-4df7-8a09-765794883524
 2009-12-02 02:47:19 +00:00
jcarsey e2f8297f9c updates from code review, buffer length, and correct use of StdOut for printing 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9499 6f19259b-4bc3-4df7-8a09-765794883524
 2009-12-01 05:40:24 +00:00
jcarsey 703289677a add carriage return 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9465 6f19259b-4bc3-4df7-8a09-765794883524
 2009-11-23 00:28:07 +00:00
jcarsey 36a9d67261 build break fix and new function 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9461 6f19259b-4bc3-4df7-8a09-765794883524
 2009-11-20 21:13:41 +00:00
jcarsey a31bd33cf8 comment repairs. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9460 6f19259b-4bc3-4df7-8a09-765794883524
 2009-11-20 18:21:03 +00:00
jcarsey 6c88029b45 specify operand order 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9451 6f19259b-4bc3-4df7-8a09-765794883524
 2009-11-19 21:10:41 +00:00
jcarsey 125c2cf4f1 updating headers from code review. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9449 6f19259b-4bc3-4df7-8a09-765794883524
 2009-11-18 21:36:50 +00:00
qhuang8 3d342022a1 Simplify the logic to remove the use of local variable "FileInfoGuid" to avoid GCC build warning. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9445 6f19259b-4bc3-4df7-8a09-765794883524
 2009-11-18 06:01:35 +00:00
jcarsey a4ee2a4f92 Adding new library instance for SortLib with built in function for sorting device paths. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9399 6f19259b-4bc3-4df7-8a09-765794883524
 2009-11-09 23:33:11 +00:00
jcarsey 2247dde4b6 Upgrade ShellLib and fix bug with param parsing 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9398 6f19259b-4bc3-4df7-8a09-765794883524
 2009-11-09 18:08:58 +00:00
jljusten 4b45b3cb20 Add DXE_DRIVER to list of supported module types for BaseFileHandleLib. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9273 6f19259b-4bc3-4df7-8a09-765794883524
 2009-09-16 16:28:58 +00:00
jcarsey 46f43bc4bc didnt want to change pointer for copymem... 
corrected full file name creation

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9007 6f19259b-4bc3-4df7-8a09-765794883524
 2009-07-24 21:32:00 +00:00
jcarsey d595d4b13a fixed operation of GetFirst and GetNext for files... 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8957 6f19259b-4bc3-4df7-8a09-765794883524
 2009-07-16 17:24:16 +00:00
jcarsey 4983ca934c add: 
1) sorting library
2) sorting test Application/ShellSortTestApp

update DEC and DSC for 2 additions

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8938 6f19259b-4bc3-4df7-8a09-765794883524
 2009-07-13 19:33:35 +00:00
jcarsey 94c5492c8a fix parameter type 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8904 6f19259b-4bc3-4df7-8a09-765794883524
 2009-07-12 03:43:03 +00:00
jcarsey 0158294b9b fixed operator order 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8887 6f19259b-4bc3-4df7-8a09-765794883524
 2009-07-10 19:46:17 +00:00
jcarsey 5f7431d0cf fix build breaks. and allow for new lists to be created. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8885 6f19259b-4bc3-4df7-8a09-765794883524
 2009-07-10 18:06:01 +00:00
jcarsey 727a4c7101 fix operator order. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8844 6f19259b-4bc3-4df7-8a09-765794883524
 2009-07-09 17:36:06 +00:00
jcarsey 9eb53ac345 fixing build errors 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8824 6f19259b-4bc3-4df7-8a09-765794883524
 2009-07-08 17:26:58 +00:00
jcarsey b82bfcc17f git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8681 6f19259b-4bc3-4df7-8a09-765794883524 2009-06-29 16:28:23 +00:00
jljusten 322016e52d Restore Include/Library/ShellCEntryLib.h. Cleanup function and 
function prototype comments.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8634 6f19259b-4bc3-4df7-8a09-765794883524
 2009-06-23 21:40:29 +00:00
jcarsey 9b3bf083f7 git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8633 6f19259b-4bc3-4df7-8a09-765794883524 2009-06-23 21:15:07 +00:00
jcarsey 92fbbb5d09 fix swap of pointers 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8585 6f19259b-4bc3-4df7-8a09-765794883524
 2009-06-17 16:39:35 +00:00
jljusten 39157531c8 Fix build of ShellC Lib/App for GCC. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8582 6f19259b-4bc3-4df7-8a09-765794883524
 2009-06-17 08:02:21 +00:00
jcarsey f1b87e7a60 removing return cursor to old position... 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8579 6f19259b-4bc3-4df7-8a09-765794883524
 2009-06-17 00:52:11 +00:00
jcarsey 975136ab1c fixed color printing in ShellPrintEx function 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8577 6f19259b-4bc3-4df7-8a09-765794883524
 2009-06-16 19:03:54 +00:00
jcarsey b1f95a06ca Updating with new functions and adding "C" style entrypoint library with example application. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8564 6f19259b-4bc3-4df7-8a09-765794883524
 2009-06-16 00:23:19 +00:00
jcarsey 14e96c2996 git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8563 6f19259b-4bc3-4df7-8a09-765794883524 2009-06-15 23:45:12 +00:00
jcarsey 614326e62b git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8562 6f19259b-4bc3-4df7-8a09-765794883524 2009-06-15 23:43:34 +00:00
jljusten 08d7f8e83d Fix ShellPkg build errors for UNIXGCC toolchain. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8555 6f19259b-4bc3-4df7-8a09-765794883524
 2009-06-15 18:42:13 +00:00
mdkinney 323f53ff7b Fix linked list loops 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8377 6f19259b-4bc3-4df7-8a09-765794883524
 2009-05-22 23:31:56 +00:00
qhuang8 69817bf8e0 Fix several Unicode issues that fails VS2005. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8350 6f19259b-4bc3-4df7-8a09-765794883524
 2009-05-20 14:42:48 +00:00
jcarsey d2b4564ba5 fixed to build under IPF. 
Refactored some commands into FileHandleLib since they are used in many binaries.
Added .h for GUID that was missing.
Added PCD for initialization of shell apps and shell itself in shell library interaction.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8295 6f19259b-4bc3-4df7-8a09-765794883524
 2009-05-11 18:02:16 +00:00
jcarsey 94b17fa1b6 First (Alpha) release of ShellPkg 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8256 6f19259b-4bc3-4df7-8a09-765794883524
 2009-05-07 18:46:18 +00:00