Eric Dong
c0a3c3da98
Refine the comments and code to follow spec.
...
Signed-off-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@14573 6f19259b-4bc3-4df7-8a09-765794883524
2013-08-20 07:13:28 +00:00
Eric Dong
dcdaee884f
Clean the flag before use it to avoid use old error value.
...
Signed-off-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@14510 6f19259b-4bc3-4df7-8a09-765794883524
2013-07-29 02:45:26 +00:00
Olivier Martin
6e84b4df30
Fixes the GCC build 'Unused variable' warning (raised an error when warnings are treated as errors).
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Olivier Martin <olivier.martin@arm.com>
Reviewed-by: Eric Dong <eric.dong@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@14474 6f19259b-4bc3-4df7-8a09-765794883524
2013-07-16 05:13:52 +00:00
Eric Dong
40ae09a2a7
Rollback patch 14470, because it error check in some extra ending code.
...
Signed-off-by: Eric Dong <eric.dong@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@14473 6f19259b-4bc3-4df7-8a09-765794883524
2013-07-16 05:09:47 +00:00
Olivier Martin
270e8dfd86
Fixes the GCC build 'Unused variable' warning (raised an error when warnings are treated as errors).
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Olivier Martin <olivier.martin@arm.com>
Reviewed-by: Eric Dong <eric.dong@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@14470 6f19259b-4bc3-4df7-8a09-765794883524
2013-07-16 02:11:24 +00:00
Eric Dong
70066a82a5
Fix DDK build fail.
...
Signed-off-by: Eric Dong <eric.dong@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@14453 6f19259b-4bc3-4df7-8a09-765794883524
2013-07-03 01:29:12 +00:00
Eric Dong
f8920f0dd4
Fix GCC build fail.
...
Signed-off-by: Eric Dong <eric.dong@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@14452 6f19259b-4bc3-4df7-8a09-765794883524
2013-07-03 01:21:39 +00:00
Eric Dong
82e8c1380f
Update HiiDataBase and UefiHiiLib to support Name/Value varstore.
...
Signed-off-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@14451 6f19259b-4bc3-4df7-8a09-765794883524
2013-07-02 07:53:35 +00:00
ydong10
a7f87053e0
Base on the type field to get the width of value field for option opcode.
...
Signed-off-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@14036 6f19259b-4bc3-4df7-8a09-765794883524
2013-01-06 06:12:50 +00:00
ydong10
23fe74dc76
Base on the value type to get the value for default opcode.
...
Signed-off-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@14006 6f19259b-4bc3-4df7-8a09-765794883524
2012-12-17 03:30:43 +00:00
ydong10
edae8d2dbd
Update the HiiConfigToBlock to follow spec.
...
Signed-off-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13983 6f19259b-4bc3-4df7-8a09-765794883524
2012-12-05 09:27:15 +00:00
erictian
02bbc6ee99
MdeModulePkg:removes the unreachable ‘break’ instruction after a ‘return’ instruction in the switch().
...
Signed-off-by: Olivier Martin <olivier.martin@arm.com>
Signed-off-by: Feng Tian <feng.tian@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13778 6f19259b-4bc3-4df7-8a09-765794883524
2012-09-29 02:44:33 +00:00
ydong10
05bf16e04d
Initialize the variable before use it.
...
Signed-off-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13656 6f19259b-4bc3-4df7-8a09-765794883524
2012-08-21 08:25:37 +00:00
ydong10
d9bbabfd13
Check whether has storage for date/time opcode, if it has storage, also generate the offset/width info for it.
...
Signed-off-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13473 6f19259b-4bc3-4df7-8a09-765794883524
2012-06-26 08:42:50 +00:00
ydong10
f01b91ae42
Fixed build failed.
...
Signed-off-by: Eric Dong <eric.dong@intel.com>
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13406 6f19259b-4bc3-4df7-8a09-765794883524
2012-05-31 08:35:48 +00:00
ydong10
bf4a3dbd47
Add new interface GetVariable2 and GetEfiGlobalVariable2 to return more info. Also replace old interface with new one.
...
Signed-off-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13375 6f19259b-4bc3-4df7-8a09-765794883524
2012-05-30 07:36:00 +00:00
ydong10
7c9fbd79d1
Fix memory leak issues.
...
Signed-off-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
Reviewed-by: Li Elvin <elvin.li@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13288 6f19259b-4bc3-4df7-8a09-765794883524
2012-05-07 08:51:42 +00:00
lgao4
5cfe42344d
Update HiiFont Service to return error status instead of ASSERT for the invalid input.
...
Signed-off-by: Liming Gao <liming.gao@intel.com>
Reviewed-by: Eric Dong <eric.dong@intel.com>
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13209 6f19259b-4bc3-4df7-8a09-765794883524
2012-04-24 01:59:55 +00:00
ydong10
e7fd76d180
Patch includes:
...
1. Support get default value for ref opcode logic.
2. Correct the sample for ref opcode with default value.
3. Refine logic about processing device path info in ref value.
Signed-off-by: ydong10
Reviewed-by: lgao4
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12774 6f19259b-4bc3-4df7-8a09-765794883524
2011-11-24 08:47:57 +00:00
ydong10
eb5e7d3e7a
Update code to follow coding style. Mainly change about:
...
1. Remove duplicate lib
2. Refine the name for enum member.
Signed-off-by: ydong10
Reviewed-by: lgao4
Reviewed-by: gdong1
Reviewed-by: vanjeff
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12767 6f19259b-4bc3-4df7-8a09-765794883524
2011-11-23 09:20:57 +00:00
ydong10
ef40f0f6d6
Patch for:
...
1. Get default value base on the priority: default opcode has highest priority and get from minimum or first option has lowest.
2. When default value saved in expression, not set default value for this question.
Signed-off-by: ydong10
Reviewed-by: lgao4
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12738 6f19259b-4bc3-4df7-8a09-765794883524
2011-11-18 07:05:17 +00:00
ydong10
90f6df07f8
Refine code and check null pointer error.
...
Signed-off-by: ydong10
Reviewed-by: mdkinney
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12532 6f19259b-4bc3-4df7-8a09-765794883524
2011-10-13 02:31:58 +00:00
ydong10
269218a300
Update code to make get string case insensitive about language
...
Signed-off-by: ydong10
Reviewed-by: rsun3
Reviewed-by: lgao4
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12517 6f19259b-4bc3-4df7-8a09-765794883524
2011-10-09 10:44:05 +00:00
ydong10
04eb20aa85
Add pointer check for NULL before dereference it.
...
Signed-off-by: ydong10
Reviewed-by: rsun3, lgao4
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12472 6f19259b-4bc3-4df7-8a09-765794883524
2011-09-29 06:33:23 +00:00
lgao4
c8ad2d7a29
Clean up the private GUID definition in module Level.
...
0. Remove the unused private GUID from module source files.
1. Use gEfiCallerIdGuid replace of the private module GUID.
2. Add the public header files to define HII FormSet and PackageList GUID used in every HII driver.
3. Move two EBC protocols for debug purpose from EBC driver to MdeModulePkg Include directory.
Signed-off-by: lgao4
Reviewed-by: ydong10 gdong1 tye jfan12 wli12 rsun3 jyao1
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12373 6f19259b-4bc3-4df7-8a09-765794883524
2011-09-18 12:21:01 +00:00
oliviermartin
8adfcdddf6
MdeModulePkg/HiiDatabaseDxe: Removed unused variables
...
'VarDefaultName' and 'ResultSize' were set but not used.
Reviewed-by: lgao4
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12341 6f19259b-4bc3-4df7-8a09-765794883524
2011-09-13 15:22:29 +00:00
ydong10
41ff10dc06
Update HiiBlockToConfig function to follow spec.
...
Signed-off-by: ydong10
Reviewed-by: lgao4
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12249 6f19259b-4bc3-4df7-8a09-765794883524
2011-09-01 08:19:55 +00:00
lgao4
fbf82a2cf2
Fixes two issues in HiiFontProtocol->StringToImage() implementation on how to show string with wrap flag.
...
Signed-off-by: lgao4
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12064 6f19259b-4bc3-4df7-8a09-765794883524
2011-08-01 06:40:17 +00:00
ydong10
f26b6a9cda
Fixed build fail with GCC/ICC tools
...
Signed-off-by:ydong10
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12014 6f19259b-4bc3-4df7-8a09-765794883524
2011-07-13 06:19:41 +00:00
ydong10
cce6230ffb
Change the HiiDataBase and browser codes to support new efi varstore data structure.
...
Signed-off-by:ydong10
Reviewed-by:lgao4
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12009 6f19259b-4bc3-4df7-8a09-765794883524
2011-07-12 07:24:36 +00:00
lgao4
e9668a606e
Add the missing logic in HiiConfigRouting ExtractConfig() to retrieves FALSE as default value for CheckBox without default flag.
...
Signed-off-by: lgao4
Reviewed-by: ydong10
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11782 6f19259b-4bc3-4df7-8a09-765794883524
2011-06-10 02:11:52 +00:00
lzeng14
4f0779023c
String Reference Cleanup.
...
Signed-off-by: lzeng14
Reviewed-by: lgao4
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11762 6f19259b-4bc3-4df7-8a09-765794883524
2011-06-08 05:53:18 +00:00
ydong10
81b618fe85
Update ALTCFG reference from default name token to default ID.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11558 6f19259b-4bc3-4df7-8a09-765794883524
2011-04-19 03:04:06 +00:00
ydong10
3a530010ec
Do not assert in HiiBlockToConfig function when an invalid format of ConfigRequest is inputed, just return error.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11526 6f19259b-4bc3-4df7-8a09-765794883524
2011-04-13 03:13:13 +00:00
lgao4
cf4c5a4270
Use the minimum value for Numeric and the first option value for OneOf as their default value when no specific default value is specified.
...
HII IFR Numeric and OneOf opcode may not specify their default value in opcode. And, zero may not be valid value for them. To make sure the valid value is set to default value, the minimum value for Numeric and the first option value for OneOf will be chosen as default value.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11497 6f19259b-4bc3-4df7-8a09-765794883524
2011-04-01 09:39:11 +00:00
lgao4
dc76cddca6
Fix ICC build failure.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11411 6f19259b-4bc3-4df7-8a09-765794883524
2011-03-18 05:59:21 +00:00
ydong10
4a12dfd454
Use exactly match method for HiiCompareLanguage.
...
Compare all of Language2 against the characters in Language1 up to the first ‘;’ or Null terminator.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11409 6f19259b-4bc3-4df7-8a09-765794883524
2011-03-17 07:31:35 +00:00
lgao4
640dfdc31d
Roll back change to previous version. Language should be compared as the exact match.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11398 6f19259b-4bc3-4df7-8a09-765794883524
2011-03-14 10:25:29 +00:00
ydong10
639710791a
Enhance inf and dec file to follow specs.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11392 6f19259b-4bc3-4df7-8a09-765794883524
2011-03-14 08:43:59 +00:00
lgao4
b0bdc7ba21
Update HiiCompareLanguage to support case that language in String package is "en" and the input language is "en-US".
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11356 6f19259b-4bc3-4df7-8a09-765794883524
2011-03-08 08:50:26 +00:00
lgao4
1b88f96461
The input StringInfo should be kept for HiiStringIdToImage() function.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11336 6f19259b-4bc3-4df7-8a09-765794883524
2011-02-23 10:07:38 +00:00
ydong10
3b2eba1814
HiiCompareLanguage should use the exact match method, old code use the best match method.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11333 6f19259b-4bc3-4df7-8a09-765794883524
2011-02-23 03:21:04 +00:00
lgao4
7a07cec6c0
Update HiiCompareLanguage() function to use GetBestLanguage() API to do RFC4646 language compare.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11319 6f19259b-4bc3-4df7-8a09-765794883524
2011-02-16 06:02:07 +00:00
lgao4
f6cf5cf800
Support proportional Font and Font output flags.
...
1. Abstract the maximum baseline and character height in Proportional Font package as its baseline and line height, and use fixed height as base line and line height for simple font packages.
2. Update logic to handle string without EFI_HII_OUT_FLAG_CLIP_CLEAN_Y flag when string height exceeds the line height, and handle the string without EFI_HII_OUT_FLAG_CLIP_CLEAN_X flag when string wide exceeds the screen wide.
3. Calculate Origin point by adding BaseLine on Starting position, and calculate the left-top corner of character by Origin point and CELL information.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11270 6f19259b-4bc3-4df7-8a09-765794883524
2011-01-24 04:58:45 +00:00
jljusten
40a699562a
MdeModulePkg HiiDatabaseDxe: Fix build error on GCC 4.4
...
Remove extra left side (lvalue) type casting that generated
warnings with GCC 4.4.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11267 6f19259b-4bc3-4df7-8a09-765794883524
2011-01-21 16:51:12 +00:00
ydong10
e33e34170f
Enhance code to avoid build error.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11261 6f19259b-4bc3-4df7-8a09-765794883524
2011-01-21 04:41:37 +00:00
ydong10
e5c861ac2e
Fixed HiiSetString failed. Tracker NUM:204479
...
Reason:
When call function HiiSetString to update the string which has no old string exist for one language, it will failed.
Solution:
When no old string exist, update with new string.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11257 6f19259b-4bc3-4df7-8a09-765794883524
2011-01-20 02:51:09 +00:00
lgao4
9ac0640d9c
EFI_INVALID_PARAMETER should return when the input Block is NULL for ConfigRouting.ConfigToBlock().
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11145 6f19259b-4bc3-4df7-8a09-765794883524
2010-12-09 12:20:36 +00:00
lgao4
09b794172e
Fix the bug that HiiConfigToBlock doesn't update BlockSize when Block is not large enough
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11085 6f19259b-4bc3-4df7-8a09-765794883524
2010-11-23 11:13:22 +00:00
lgao4
6894561804
Update HiiDatabase->ExportPackageLists() service to support NULL HII handle per UEFI spec.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10979 6f19259b-4bc3-4df7-8a09-765794883524
2010-10-25 11:12:15 +00:00
ydong10
cd7bfc2c63
Refine code to make code run safely.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10880 6f19259b-4bc3-4df7-8a09-765794883524
2010-09-16 04:51:25 +00:00
ydong10
c9325700d0
Refine soma code to make code run safely.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10877 6f19259b-4bc3-4df7-8a09-765794883524
2010-09-15 07:48:11 +00:00
hhtian
e5eed7d364
Update the copyright notice format
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10418 6f19259b-4bc3-4df7-8a09-765794883524
2010-04-24 09:33:45 +00:00
lgao4
771ececd12
Add the missing check for NULL pointer before use it.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10116 6f19259b-4bc3-4df7-8a09-765794883524
2010-02-27 09:04:11 +00:00
lgao4
2573712e01
Enhance SetupBrowser to support new UEFI HiiFormMap feature
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10069 6f19259b-4bc3-4df7-8a09-765794883524
2010-02-25 10:10:59 +00:00
lgao4
6bfbb5f0e0
1. Correct File header to ## @file
...
2. Remove unnecessary .common] postfix on section.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10052 6f19259b-4bc3-4df7-8a09-765794883524
2010-02-24 00:21:16 +00:00
lgao4
b86b413a96
1. Update GetStringWorker() of HiiDataBaseDxe to only search in other language and not update the StringSize to avoid GetString() buffer overflow.
...
2. Update SetupBrowser to correctly handle ordered list option.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10041 6f19259b-4bc3-4df7-8a09-765794883524
2010-02-22 06:30:41 +00:00
lgao4
6ddd3af70b
Update HiiDataBase to make sure that the installed StringPackages contains the same number string ID.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9989 6f19259b-4bc3-4df7-8a09-765794883524
2010-02-11 07:16:06 +00:00
erictian
ea02100237
1. free those inserted NsKeyNode resource when releasing SetKeyBoardLayout event.
...
2. cleanup HiiDataBaseDxe to directly use gEfiHiiKeyBoardLayoutGuid which is used as the guid of event group.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9978 6f19259b-4bc3-4df7-8a09-765794883524
2010-02-11 02:47:10 +00:00
lgao4
d7c0e60c44
Fix ICC build break by do data conversion.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9963 6f19259b-4bc3-4df7-8a09-765794883524
2010-02-10 06:01:18 +00:00
lgao4
d6a82eaf8d
Update HiiString Protocol and HiiSetString Api in HiiLib
...
1. Reserve the unique string identifier for all languages in the package list.
2. Track MaxStringId to do the simple check for the requested StringId > MaxStringId, which can improve performance.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9954 6f19259b-4bc3-4df7-8a09-765794883524
2010-02-09 07:12:35 +00:00
xdu2
1b2bf3cadc
Add some security check.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9934 6f19259b-4bc3-4df7-8a09-765794883524
2010-02-05 06:13:18 +00:00
rsun3
aa75dfeccd
Fix some coding style issues in MdeModulePkg.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9774 6f19259b-4bc3-4df7-8a09-765794883524
2010-01-15 08:03:23 +00:00
rsun3
b1a803d153
Some HII related definitions change. Note these changes are inconsistent with current UEFI 2.3 spec. They are supposed to be in later errata document.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9744 6f19259b-4bc3-4df7-8a09-765794883524
2010-01-14 05:38:29 +00:00
rsun3
aa2614b728
EFI_HII_DATABASE_PROTOCOL.NewPackageList() allows installation of multiple package lists with same package list GUID onto different handles. According, change behavior of the HII Library function HiiAddPackages() to be consistent with EFI_HII_DATABASE_PROTOCOL.NewPackageList().
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9452 6f19259b-4bc3-4df7-8a09-765794883524
2009-11-20 02:34:21 +00:00
lgao4
ff28420b56
Correctly get the width of orderedlist question.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9376 6f19259b-4bc3-4df7-8a09-765794883524
2009-10-27 07:55:00 +00:00
jljusten
e3d7cceb99
Fix warnings generated by GCC.
...
These warnings seem to have been triggered by the recent change of
EFI_STATUS from INTN to UINTN.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9329 6f19259b-4bc3-4df7-8a09-765794883524
2009-10-02 06:40:58 +00:00
eric_tian
35c218d7e6
fix the HiiStrIdToImage sct failure, which is caused by wrong algorithm of finding right-most line break opportunity.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8446 6f19259b-4bc3-4df7-8a09-765794883524
2009-06-03 01:43:47 +00:00
rsun3
f324bf4dbe
Roll back changes to apply GetBestLanguage() in HiiDataBase. Exact language match should be used in HiiDatabase.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8384 6f19259b-4bc3-4df7-8a09-765794883524
2009-05-26 03:48:50 +00:00
lgao4
91a306eee7
Correct the check to the valid device path. The device path can't be less than the basic header.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8381 6f19259b-4bc3-4df7-8a09-765794883524
2009-05-26 01:49:53 +00:00
eric_tian
4772ce75e8
refine the implementation of HiiStringToImage:
...
1. Remove the limitation of MAX_STRING_LENGTH and according to actual string length to store glyph info
2. fix a issue when print multi-lines, the next line will overlaps the above line. The original implementation doesn't recalculate the start point of X/Y axis.
3. refine the flow to avoid the meaningless recursive call.
4. modify the usage of "Index" to force them 1/1 mapping between glyphbuf and string. So the RowInfoArray and ColumnInfoArray can reflect the actual situation.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8371 6f19259b-4bc3-4df7-8a09-765794883524
2009-05-21 09:41:59 +00:00
lgao4
ae79d2f9ec
Update HiiDataBase to fix the SCT hang issues by the invalid device path.
...
Update the driver config access protocol extractconfig and routeconfig interface to check the input parameters.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8349 6f19259b-4bc3-4df7-8a09-765794883524
2009-05-20 12:05:45 +00:00
vanjeff
f618b2fa0a
rename array name to avoid naming collision.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8340 6f19259b-4bc3-4df7-8a09-765794883524
2009-05-20 02:12:26 +00:00
lgao4
6e3f5b2aa9
Fix K8 and Sct failure.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8337 6f19259b-4bc3-4df7-8a09-765794883524
2009-05-19 09:30:21 +00:00
lgao4
8567300ae4
Fix K8 issues in HiiDataBase
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8325 6f19259b-4bc3-4df7-8a09-765794883524
2009-05-18 12:12:56 +00:00
lgao4
04da0b4a11
Correct DriverSample to produce the ConfigAccess protocol
...
And fix the bug in HiiDataBase to incorrectly free pool.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8321 6f19259b-4bc3-4df7-8a09-765794883524
2009-05-18 05:03:45 +00:00
lgao4
1f1cb2f216
Retire original HII APIs: IfrLibExtractDefault and ConstructConfigAltResp, which are replaced by HiiSetToDefaults API.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8319 6f19259b-4bc3-4df7-8a09-765794883524
2009-05-18 03:26:54 +00:00
lgao4
76c2425177
Update HiiDataBase to fix parsing Hii package error. Some HiiPackages have no varstore and question, they has no the built in default value.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8314 6f19259b-4bc3-4df7-8a09-765794883524
2009-05-14 12:37:02 +00:00
lgao4
84f9a9ec8f
1. Update the implementation of HII ConfigRouting Protocol in HiiDataBase module to follow new ECRs.
...
1) ConfigRouting Protocol ExtractConfig interface must return the default values built in IFR that were not returned by ConfigAccess.ExtractConfig.
2) The parameters of ConfigRouting Protocol interfaces are clarified to the specific configuration string syntax.
2. Implement the last two HiiLib interfaces: HiiSetToDefaults and HiiValidateSettings.
3. Update DriverSample driver to use these two APIs.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8313 6f19259b-4bc3-4df7-8a09-765794883524
2009-05-14 07:06:06 +00:00
vanjeff
326c6b7130
ConfigRouting should get driver handle by device path in all drivers database in system, not only in Hii Package list database.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8284 6f19259b-4bc3-4df7-8a09-765794883524
2009-05-11 02:26:26 +00:00
rsun3
844390f7d5
Update HiiDataBase driver to use GetBestLanguage() for matching RFC 4646 languages.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8262 6f19259b-4bc3-4df7-8a09-765794883524
2009-05-08 05:39:24 +00:00
lgao4
6672d625fe
correct the minor format.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8244 6f19259b-4bc3-4df7-8a09-765794883524
2009-05-06 03:21:24 +00:00
lgao4
e34e769924
Remove unused IfrSupportLib
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8064 6f19259b-4bc3-4df7-8a09-765794883524
2009-04-12 03:18:19 +00:00
qhuang8
7b06dc8a91
Add ASSERT() check for StringInfo pointer.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8055 6f19259b-4bc3-4df7-8a09-765794883524
2009-04-10 04:27:35 +00:00
lgao4
634303c96f
Fix error when replace HexStringToBuf
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8047 6f19259b-4bc3-4df7-8a09-765794883524
2009-04-09 08:19:40 +00:00
lgao4
63d55bb98a
Replace BufToHexString by UnicodeValueToString
...
Replace HexStringToBuf by StrHexToUint64
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8034 6f19259b-4bc3-4df7-8a09-765794883524
2009-04-08 00:56:51 +00:00
vanjeff
9937b36506
1. retired console control protocol.
...
2. removed NULL console device from consplitter module.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7995 6f19259b-4bc3-4df7-8a09-765794883524
2009-04-01 02:52:17 +00:00
qhuang8
bd37f9718f
Add ASSERT() check for StringInfoIn structure.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7968 6f19259b-4bc3-4df7-8a09-765794883524
2009-03-27 04:56:54 +00:00
qhuang8
bf9af1b959
Apply GetBestLanguage() for the implementation of HiiStringIdToImage() API.
...
E.g. L"PlatformLang" variable is "en" and registered string supports "en-US"
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7954 6f19259b-4bc3-4df7-8a09-765794883524
2009-03-25 10:07:39 +00:00
qhuang8
2fef9e5f7a
Fix a potential bug that GetLanguages() API may return incorrect languages in a string package when the *LanguageSize == OutputSize.
...
This issue was hidden since UefiHiiLib API HiiLibGetSupportedLanguages() allocates large enough (4K) buffer to get the supported languages.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7953 6f19259b-4bc3-4df7-8a09-765794883524
2009-03-25 09:41:09 +00:00
qwang12
c40aa22af0
Remove Feature PCD PcdSupportFullConfigRoutingProtocol as EDK II sample implementation is UEFI compliant system which always produces gEfiHiiConfigRoutingProtocolGuid.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7892 6f19259b-4bc3-4df7-8a09-765794883524
2009-03-16 10:24:01 +00:00
vanjeff
3f57706fa9
remove console control protocol consuming in DrawImage(), caller should make sure current mode is graphics mode.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7568 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-23 03:02:07 +00:00
vanjeff
7c1bc8d656
Enhanced status return check.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7508 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-12 03:03:47 +00:00
lgao4
b998288321
Correct typo in comments, clean IfrSupportLib.h
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7494 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-10 13:32:19 +00:00
qwang12
3018ca2d36
1) Clean up the INF and add in comment to describe the surface area of modules
...
2) Minor comment fix.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7413 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-03 02:23:03 +00:00
qwang12
bc166db311
Add in ASSERT to check out-of-bound and possible dereference of NULL pointers.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7391 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-02 07:18:59 +00:00
qwang12
96ff65a1fb
K8:
...
1) Fix the bug the assert conditions. || should be &&.
2) Add in code path and check-for-null-pointer to do error handling.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7308 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-20 01:52:02 +00:00
jji4
c59634eab6
Source level security checked
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7303 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-19 06:55:18 +00:00
qhuang8
f3f2e05db8
Clean up to update the reference of the these macros:
...
EFI_SIGNATURE_16 -> SIGNATURE_16
EFI_SIGNATURE_32 -> SIGNATURE_32
EFI_SIGNATURE_64 -> SIGNATURE_64
EFI_FIELD_OFFSET -> OFFSET_OF
EFI_MAX_BIT -> MAX_BIT
EFI_MAX_ADDRESS -> MAX_ADDRESS
These macros are not defined in UEFI spec. It makes more sense to use the equivalent macros in Base.h to avoid alias.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7056 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-16 15:34:21 +00:00
qwang12
64d2df940c
1) Update file header.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6990 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-11 06:29:18 +00:00
qwang12
3cb3f198ac
1) Update file header.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6989 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-11 06:27:04 +00:00
gikidy
cfc8865f17
Remove some useless EDK_RELEASE_VERSION, EFI_SPECIFICATION_VERSION ,and review VALID_ARCHITECTURES in inf files with DSC file.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6818 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-03 09:08:05 +00:00
qhuang8
8db9d51d78
Make HiiDatabase module not depend on HiiLib; otherwise it will inherit HII_DATABASE_PROTOCOL to its own dependency.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6764 6f19259b-4bc3-4df7-8a09-765794883524
2008-11-27 13:15:24 +00:00
qhuang8
11e9250309
Add GetCurrentLanguage() to HiiLib in MdeModulePkg
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6758 6f19259b-4bc3-4df7-8a09-765794883524
2008-11-27 07:43:56 +00:00
mdkinney
c46484952a
Update to use ReallocatePool() from BaseMemoryLib
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6678 6f19259b-4bc3-4df7-8a09-765794883524
2008-11-22 00:52:53 +00:00
qwang12
f4113e1fdb
1) Remove the variable initalization in declaration.
...
2) Change all gBS->FreePool to use the MdePkg/BaseLib's FreePool.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6662 6f19259b-4bc3-4df7-8a09-765794883524
2008-11-21 06:59:58 +00:00
qwang12
69367b5bb9
Fixed a ECC error.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6631 6f19259b-4bc3-4df7-8a09-765794883524
2008-11-19 12:01:25 +00:00
qwang12
8d00a0f195
Sync in bug fix from EDK I:
...
1) issue with setup browser and IFR refresh opcode
2) [HII]HIIConfigRoutingExportConfig generate error format of <MultiConfigAltResp>
3) [HII] ConfigRouting->ExtractConfig() will cause overflow
4) [Hii Database] EFI_HII_DATABASE_NOTIFY should be invoked when a string package is created internally when a new String Token is created
5) [PT]HIIConfigAccessProtocolTest fail on NT32uefi
6) Incorrect HII package types in EDK
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6378 6f19259b-4bc3-4df7-8a09-765794883524
2008-11-04 14:28:08 +00:00
qhuang8
fe5717664e
Update to use DOS format
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6339 6f19259b-4bc3-4df7-8a09-765794883524
2008-10-31 04:38:54 +00:00
qwang12
676df92c2c
Remove SafeFreePool from MemoryAllocationLib as this API's name is misleading. Its implementation only check if a pointer is NULL. If a garbage pointer is passed in, the gBS->FreePool will still ASSERT in debug build and return error code.
...
It is recommended that module writer should keep track how a pointer is allocated and free it after use.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6306 6f19259b-4bc3-4df7-8a09-765794883524
2008-10-30 07:32:46 +00:00
jji4
fe1e36e550
Patch to remove STATIC modifier. This is on longer recommended by EFI Framework coding style. All duplicated symbols has been renamed accordingly.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6296 6f19259b-4bc3-4df7-8a09-765794883524
2008-10-30 06:05:06 +00:00
qwang12
5e580cf717
1) Move RFC_3066_ENTRY_SIZE and ISO_639_2_ENTRY_SIZE to UefiBaseType.h.
...
2) Rename BufInReverseOrderToHexString to BufToHexString
3) Rename HexStringToBuf to HexStringToBufInReverseOrder
4) Update function comments in HiiLib.h and IfrSupportLib.h.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5991 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-26 10:31:41 +00:00
qwang12
c27eb35861
HiiLibGetCurrentLanguage returns the current UEFI variable "PlatformLang" (if this variable does not exist, a default value is returned). This function is called by HiiDatabase itself. Now, HiiLibGetCurrentLanguage is in HiiLib. Because of this, we can't add location of Hii protoocol in the library constructor of HiiLib. This cause Hii Database driver never get loaded (circular dependency).
...
By moving HiiLibGetCurrentLanguage to UefiLib, library constructor (depex) can be added back to HiiLib to make sure the execution order is correct.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5939 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-21 08:51:15 +00:00
vanjeff
ed66e1bc0d
clean up the un-suitable ';' location when declaring the functions.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5820 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-04 09:37:28 +00:00
vanjeff
e53a6ea90e
remove EFI_EVENT_ alias, replace them with EVT_
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5813 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-04 07:42:38 +00:00
qwang12
08e6463a72
Merged in the bug fixes from EDK I.
...
*** Press F9 in Uefi64 FrontPage shouldnot enter sub-menu
** [FT] Some UI error on multiple platforms on framework_20080811
** [FT] UI test of How tall are you(Hex) on framework_20080811
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5767 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-02 01:21:43 +00:00
lgao4
60c93673b3
The driver and library in MdePkg, MdeModulePkg and Nt32Pkg that don't depend on PI spec should include Uefi.h not PiDxe.h.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5758 6f19259b-4bc3-4df7-8a09-765794883524
2008-08-30 14:09:38 +00:00
lgao4
e872988180
remove the unused msa files in MdeModulePkg.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5726 6f19259b-4bc3-4df7-8a09-765794883524
2008-08-25 05:03:29 +00:00
qwang12
aa2e1536cb
Optimize GetUnicodeStringTextOrSize's inner loop to call ReadUnalign16 instead of CompareMem and remove a unnecessary local variable.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5580 6f19259b-4bc3-4df7-8a09-765794883524
2008-07-28 05:36:44 +00:00
qwang12
e94358a3fe
Use two PCDs to replace _DISABLE_UNUSED_HII_PROTOCOLS_ macro.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5498 6f19259b-4bc3-4df7-8a09-765794883524
2008-07-16 09:36:33 +00:00
qwang12
e90b081afa
Clean up HiiDatabase for Doxygen comments requirement.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5467 6f19259b-4bc3-4df7-8a09-765794883524
2008-07-15 06:29:27 +00:00
qwang12
813acf3a9a
Merged in the following trackers from EDK:
...
EDK1145 Cursor mising in shell in some case
EDK1099: Dell - [HII] HiiGetFontInfo() not retrieve the system font by FoFontInfoMask
EDK1127: [UEFI 2.10] Keyboard layout support
EDK1129: [UEFI HII] GUID is represented wrongly in Config String
And some other fixes such as
*[UEFI HII] HiiGetAltCfg is generating "Name=" sub string in the wrong format
*UEFI HII: GetUnicodeStringTextOrSize() doesn't handle NULL StringDest properly
*GetFontInfo() need be updated to avoid iteration
*HIIStringProtocolTest failed on multiple platform
*[Uefi 2.1] Comply with latest Hii ECR
* GetFontInfo() need be updated to avoid iteration
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5361 6f19259b-4bc3-4df7-8a09-765794883524
2008-06-23 09:41:33 +00:00
qwang12
35ae460227
Updated copyright.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5352 6f19259b-4bc3-4df7-8a09-765794883524
2008-06-19 02:37:22 +00:00
qwang12
50b399856d
Update call-by-value to call-by-reference for EFI_HII_GLYPH_INFO type.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5351 6f19259b-4bc3-4df7-8a09-765794883524
2008-06-19 02:35:35 +00:00
qhuang8
ac64461468
De-unicode in comment for all source files.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5302 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-27 03:24:01 +00:00
qwang12
30d27d1542
Pass GCC build.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5287 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-23 06:26:23 +00:00
qwang12
7fd213953e
Pass GCC build.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5286 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-23 06:24:50 +00:00
qwang12
36fe40c2ea
1) Add BufToHexString, HexStringToBuf and IsHexDigit to BaseLib.
...
2) Remove the duplicated functions implementation from the modules that reference these APIs
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5283 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-23 05:30:08 +00:00
jljusten
6c46a5abba
edk2/MdeModulePkg/Universal/HiiDatabaseDxe/Database.c:
...
Pre-initialize variable to fix warning with gcc.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4708 6f19259b-4bc3-4df7-8a09-765794883524
2008-02-19 22:22:48 +00:00
qwang12
93e3992d1e
UEFI HII: Merge UEFI HII support changes from branch.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4599 6f19259b-4bc3-4df7-8a09-765794883524
2008-01-21 14:39:56 +00:00