Commit Graph

89 Commits

Author SHA1 Message Date
eric_tian 33d228aa02 refine some definitions comments.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9031 6f19259b-4bc3-4df7-8a09-765794883524
2009-08-10 06:32:30 +00:00
pkandel 27d9ad0656 Lightly revised SmmCis.h based on information in the PI spec.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9023 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-30 11:26:30 +00:00
pkandel 69c8f27cd8 Updated comment at line 595 to be PI 1.1 spec, instead of 1.0.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9020 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-29 13:31:16 +00:00
pkandel 5259c97d7a Committing changes to the comments, after review with engineers.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9018 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-28 13:25:37 +00:00
mdkinney 7f58645482 Move those status code definitions that exactly match the PI 1.2 Specification from the IntelFrameworkPkg to MdePkg
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8989 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-24 03:27:05 +00:00
eric_tian bc34515d50 improve the doxgen style comments.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8965 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-17 09:43:55 +00:00
lgao4 33801c0c8e Make code definition alignment.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8925 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-13 09:35:40 +00:00
lgao4 108854b2b8 Remove unnecessary FRAMEWORK_ prefix in IntelFrameworkPkg definitions for those definitions that don't conflict with ones in UEFI/PI specification.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8923 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-13 09:28:00 +00:00
mdkinney b6d47a83ac Add Framework MP Services Protocol
Change EFI_AP_PROCEDURE to FRAMEWORK_EFI_AP_PROCEDURE to remove name collision with PI 1.2 MP Services Protocol in MdePkg


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8912 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-13 00:18:41 +00:00
mdkinney 87d6344732 1) Add Include/Framework/BootScript.h that contains defines shared between Boot Script Executer PPI and Boot Script Save Protocol. Remove those safe defines from Include/Ppi/BootScriptExecuter.h
2) Remove Include/Framework/DataHubRecords.h and merge its content into Include/Guid/DataHubRecords.h
3) Remove Include/Framework/Legacy16.h and merge its contents into Include/Protocol/LegacyBios.h
4) Update FrameworkDxe.h to no longer include all the Legacy16.h and DataHubRecords.h contents.  This reduces the number of include file and definitions pulled in when a module include FrameworkDxe.h.  The Legacy16.h contents can now be included by a module through Protocol/LegacyBios.h and the DataHubRecords.h contents can be included by a module through Guid/DataHubRecords.h
5) Update Include/Guid/StatusCodeDataTypeId.h so it can be safely included by both PEIMs and DXE Modules since both the PEI and DXE phases support status codes
6) Remove extra #includes where possible to reduce number of files included during a build.
7) Update Include/Protocol/LegacyBiosPlatform.h to #include Include/Protocol/LegacyBios.h since it depends on HDD_INFO and COMPATIBILITY16 strictures carried by LegacyBios.h



git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8899 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-11 23:25:44 +00:00
mdkinney ede15247fc Make CR/LF consistent in source file
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8894 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-11 16:03:44 +00:00
mdkinney 3a228b9ed5 Remove "Module Name:" from include file headers.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8893 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-11 16:02:13 +00:00
eric_tian 7611ea1143 fix build issue
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8882 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-10 10:25:44 +00:00
eric_tian 6115bccfc3 roll back the change on the naming of DataHubRecords.h for backward compatibility.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8881 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-10 10:20:57 +00:00
lgao4 0e0eeecad4 Clean the public header files to remove the unnecessary include files.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8871 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-10 09:30:53 +00:00
klu2 64419615f2 1, Add @par section in file header comment
2, Rollback the member name changing in last modification to keep backward compatible. Although add more comment to declaration the these inconsistent issue.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8867 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-10 08:07:23 +00:00
jchen20 c031fd2369 Add comments to describe the difference between code and spec and move the processor invalid reason macro to StatusCode.h from CPU pkg to fix the bug #202469
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8865 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-10 08:05:50 +00:00
jchen20 6d1824fc6e Add comments to describe the difference between code and spec to fix the bug #202430
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8839 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-09 10:27:43 +00:00
jchen20 18d7ae2ee6 describe the difference with Spec to fix the bug #202465
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8837 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-09 09:41:35 +00:00
jchen20 b59768ca63 Add definition on SmmStatusCodeProtocol to comply the SMMCIS spec to fix the bug #202466
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8834 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-09 09:17:18 +00:00
jchen20 a69dbb0e9e the Comment the gap between Framework spec and code in the definition of FRAMEWORK_EFI_PEI_SERVICES
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8826 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-09 02:19:02 +00:00
eric_tian 13b3137440 according to DataHubSubclass spec, all fields of data record should be naturally alignment.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8821 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-08 09:56:07 +00:00
jchen20 40038403ea to fill the gap between Framework and code to fix the bug #202405, #202419, #202418, #202435,#202437, #202439, #202440
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8817 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-08 09:38:08 +00:00
eric_tian 631344e6d3 refine the DataHubRecords.h to comply with DataHubSubclass/MemSubclass/ProcSubclass/CacheSubclass spec.
add comments to notify there are gaps between code and specs.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8808 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-08 07:17:48 +00:00
eric_tian 4c617fa92b 1. add comments for those fields not defined by MemorySubclass spec.
2. change name MemorySpeed to MemoryTypeSpeed, which follows spec.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8804 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-08 04:32:40 +00:00
eric_tian 6b7058c4df Inconsistent with specification here:
It's a typo of MiscSubclass 0.9 spec. It should be a variable name "ChassisType" rather than a type "EFI_MISC_CHASSIS_TYPE".

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8803 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-08 03:59:53 +00:00
eric_tian eeff6bb017 1. EFI_MAXIMUM_CACHE_SIZE_DATA has changed to EFI_CACHE_MAXIMUM_SIZE_DATA, which follows spec.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8802 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-08 03:52:36 +00:00
eric_tian dcd8fb0c2b add comments to note it's the spec typo issue for EFI_CACHE_CONFIGURATION_DATA filed type. it should be UINT32 rather than UINT16
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8801 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-08 03:47:10 +00:00
eric_tian 2cbfdae36e add comment on EFI_PROCESSOR_CORE_FREQUENCY_LIST_DATA to note there is gap between code and spec.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8800 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-08 03:44:09 +00:00
eric_tian 2b47aaa69c add comments to note why EFI_MISC_PORT_DEVICE_PATH and etc exists here , which is not defined in MiscSubclass spec.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8797 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-08 03:38:23 +00:00
eric_tian b66be4ca3e 1. change the value of EFI_PROCESSOR_SUBCLASS_VERSION to follow spec.
2. remove EFI_STRING_TOKEN, which doesn't be defined by any spec. replace it with STRING_REF.
3. change the fields of EFI_EXP_BASE10_DATA to INT16 to follow spec.
4. change the field name of EFI_PROCESSOR_MISC_INFO to follow spec.
5. note that field which are introduced to reflect the SMBIOS2.6
6. change name EFI_PROCESSOR_HEALTH_STATUS to EFI_PROCESSOR_HEALTH_STATUS_DATA
7. EFI_CACHE_ASSOCIATION_DATA to  EFI_PROCESSOR_CACHE_ASSOCIATION_DATA

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8793 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-08 03:10:27 +00:00
eric_tian 7bfed576b0 Due to SmBios2.6 spec section 3.3.8.5 doesn't enumerate 24-way set-associative for cache info, so remove this value to follow spec.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8772 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-07 03:35:59 +00:00
darylm503 dbb698cbb5 Clean up Doxygen group comments.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8745 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-03 23:20:37 +00:00
darylm503 03df16089f Clean up Doxygen commenting.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8743 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-03 21:59:06 +00:00
vanjeff e02a0e9245 remove stranger characters.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8737 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-03 11:30:19 +00:00
klu2 8d303ef304 Synchronize the structure's member's name and comments for structure modified in CSM 0.97 specification.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8735 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-03 07:36:43 +00:00
klu2 e3e7f36a58 1, Synchronize CSM related structure definition's comments with Intel framework specification.
2, To following specification, correct following member's name:
   a) change the member name of EFI_COMPATIBILITY16_TABLE.OemintSegement to EFI_COMPATIBILITY16_TABLE.OemInt15Segment. 
   b) change the member name of EFI_COMPATIBILITY16_TABLE.OemIntOffset to EFI_COMPATIBILITY16_TABLE. OemInt15Offset. 
   c) change the member name of EFI_DISPATCH_OPROM_TABLE. BbsTablePointer to EFI_DISPATCH_OPROM_TABLE. BbsTable.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8733 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-03 06:25:35 +00:00
rsun3 2baf6c6837 PeiCis.h clean up.
1. Add Doxygen comments for FRAMEWORK_EFI_PEI_SERVICES;
2. Remove definition of EFI_PEI_STARTUP_DESCRIPTOR. It is not defined in the PEI CIS spec and is implementation specific.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8730 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-03 01:33:47 +00:00
klu2 2e747cee12 Correct the enumeration value's name for EFI_COMPATIBILITY_FUNCTIONS with Intel Framework specification.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8727 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-02 18:46:07 +00:00
rsun3 e1d8d892f2 DxeCis.h clean up.
1. Add comments
2. TIANO_DEVICE_PATH and TIANO_MEDIA_FW_VOL_FILEPATH_DEVICE_PATH_TYPE structures removed. They are not in DXE CIS spec.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8723 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-02 08:18:29 +00:00
klu2 2bbaeb0d62 Correct the structure's comments to follow doxygen format.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8721 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-02 07:40:24 +00:00
jljusten b4420c3607 Change single quote to use standard ascii character.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8708 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-01 18:18:10 +00:00
darylm503 8d129536f9 Updated copyright. Deleted erroneous "Module Name" line. Changed preceding macro, enum, and structure comments to Doxygen style. Changed existing structure member comments to Doxygen style. Cleaned up some comment blocks to conform to the coding specification. Changed @bug comments on structure members to the postfix style so that the correct members are documented. Removed duplicate, orphan, EFI_TO_COMPATIBILITY16_BOOT_TABLE comment and move remaining comment to the correct location. Add descriptive comment to terminating #endif.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8672 6f19259b-4bc3-4df7-8a09-765794883524
2009-06-26 19:36:51 +00:00
darylm503 c7ab4e83a6 Changed Copyright to 2006-2009 to reflect original through current revisions. Deleted the Module Name line. Changed "Firmware Volume Block Attributes" comments to Doxygen Style and grouped the #defines together under that comment. EFI_FVB_CAPABILITIES macro Values were not aligned. Alignment made it unclear whether this was a simple or parameterized macro. Enhanced comments to make this clear. Re-aligned the EFI_TEST_FFS_ATTRIBUTES_BIT macro to make it easier to read. Added an identifying comment to the terminating #endif.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8671 6f19259b-4bc3-4df7-8a09-765794883524
2009-06-26 19:09:39 +00:00
gikidy a244f400e5 Verified some definitions of DataHubRecord.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8666 6f19259b-4bc3-4df7-8a09-765794883524
2009-06-26 06:16:33 +00:00
lgao4 920d2c23a1 Update header file comments.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8583 6f19259b-4bc3-4df7-8a09-765794883524
2009-06-17 08:46:49 +00:00
rsun3 9f6f953491 Update comments.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8574 6f19259b-4bc3-4df7-8a09-765794883524
2009-06-16 08:33:16 +00:00
mdkinney 9226e4ee0a Clean up CSM related include files to match specification
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8469 6f19259b-4bc3-4df7-8a09-765794883524
2009-06-04 22:49:59 +00:00
gikidy 0f899407a3 Update revision reference tag.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8369 6f19259b-4bc3-4df7-8a09-765794883524
2009-05-21 09:04:03 +00:00
gikidy 470d0b274c Synchronize code with specs.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8367 6f19259b-4bc3-4df7-8a09-765794883524
2009-05-21 06:11:39 +00:00