Commit Graph

990 Commits

Author SHA1 Message Date
eric_tian f6d7003d5f move BUGBUG comments and add some comments to comply with Spec
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5897 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-16 07:13:42 +00:00
klu2 8335866b0b Correct module type for library UefiBootServicesTableLib and UefiRuntimeServicesTableLib.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5895 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-16 06:44:15 +00:00
eric_tian f944ec32e7 follow up code review
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5894 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-16 06:13:42 +00:00
eric_tian f73e0ad215 follow up code review
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5893 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-16 06:01:21 +00:00
eric_tian 55f298c3a3 follow up the comments from code review.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5892 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-16 05:22:09 +00:00
klu2 9edc73ada4 Code clean up.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5890 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-16 02:12:35 +00:00
vanjeff 835849540d remove '../' from Base Library.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5878 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-11 09:12:14 +00:00
vanjeff 3ec9bc1557 move and rename it
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5877 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-11 09:08:12 +00:00
vanjeff 5dedabbb4e Clean up BaseIoLibIntrinsic according to review comments.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5876 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-11 08:59:52 +00:00
qhuang8 43d2502010 Append the change log for the non-backward compatibility change in Edk r5869.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5871 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-10 16:13:07 +00:00
qhuang8 3fef0f51d8 1. Add new macro: ALIGN_VALUE to round up a value to the next boundary of a given alignment.
2. Update ALIGN_POINTER to use the new macro
3. Drop the second parameter of ALIGN_VARIABLE for simplicity. It can also directly use the new macro ALIGN_VALUE. 

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5869 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-10 16:00:20 +00:00
eric_tian c57da111f7 cleanup some comments.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5864 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-09 07:11:51 +00:00
eric_tian e3a7917f2e fix build issue
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5863 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-09 06:45:35 +00:00
eric_tian 1106ffe1c0 Function description in baselib.h is not clear. change it to comply with Doxgen format.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5862 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-09 06:22:30 +00:00
vanjeff 2b1532df6d changed the format when use "=="
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5859 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-09 05:28:47 +00:00
klu2 4efb2b4d92 Fix the wrong fixing for hardcore value 7.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5857 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-09 05:19:30 +00:00
klu2 f008fc323b Code cleanup for library instances in MdePkg.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5856 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-09 04:41:59 +00:00
vanjeff e31c47b99a fixed typo.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5855 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-09 03:19:37 +00:00
qhuang8 f83933cff0 Fix typo
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5850 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-08 23:27:26 +00:00
qhuang8 a4c47ba324 Add missing gEfiFirmwareFileSystem2Guid in INF [Guids] section
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5849 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-08 23:25:14 +00:00
qwang12 3a26bb17af 1) Add CONST to the pointer type input parameter.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5848 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-08 12:54:26 +00:00
qwang12 23a2150bcf 1) Add CONST to the pointer type input parameter.
2) Use global variable and AllocateCopyPool to save the size of generated binary.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5847 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-08 12:53:50 +00:00
qwang12 7c80ae1b31 add incompatbility changes's description about NULL_HANDLE.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5845 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-08 10:00:24 +00:00
klu2 6cff95cd69 use UnicodeVSPrintAsciiFormat, UnicodeSPrintAsciiFormat to simplify code.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5844 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-08 09:08:26 +00:00
klu2 7c6d32a564 use UnicodeVSPrintAsciiFormat, UnicodeSPrintAsciiFormat to simplify code.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5843 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-08 09:08:04 +00:00
klu2 7c366ec9ca wrong comment for "Unicode" string.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5842 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-08 08:35:54 +00:00
klu2 2cb3369a49 remove unused library class.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5841 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-08 08:26:45 +00:00
klu2 802b8312a2 remove unused include file for library class.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5840 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-08 08:23:28 +00:00
xli24 4b503a775e Minor update for PI include files according to code review comments.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5839 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-08 07:55:40 +00:00
lgao4 52cd71dca9 Update UefiScsiLib to add ASSERT comments and define new macros to replace the hard code value.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5838 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-08 05:56:40 +00:00
qwang12 fe21b1a6c1 Add in incompatibility note.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5837 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-08 05:51:14 +00:00
qwang12 681b5c23c4 Remove NULL_HANDLE. NULL_HANDLE should be replaced with NULL as consistency. For now, only DXE core is using this macro.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5835 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-08 05:00:44 +00:00
lgao4 11ceade4ba Add Usb Hid class request type into IndustryStandard/Usb.h, and replace the hard value in UefiUsbLib by them.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5834 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-08 04:59:00 +00:00
lgao4 cc4e048504 Correct the wrong '?' character to '-', and add check DestinationBuffer == SourceBuffer for CompareMem functions in all BaseMemory library instances.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5831 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-08 01:24:16 +00:00
xli24 f1b420aa4e Make prototype of EFI_PEI_STALL comply with PI spec.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5828 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-05 05:10:54 +00:00
jljusten fe7fd57806 edk2/MdePkg/Library/PeiIoLibCpuIo/IoLib.c:
* Align code with changes to CONST usage on function
  parameters made in edk2-r5818.


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5825 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-04 18:12:57 +00:00
jljusten 9e11702c33 edk2/MdePkg/MdePkg.dec:
* Change filename case from x64=>X64 to match move in r5811.


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5824 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-04 16:01:24 +00:00
xli24 ad400b07b8 Update MDE Library instances according to code review comments.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5823 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-04 13:39:18 +00:00
vanjeff ed66e1bc0d clean up the un-suitable ';' location when declaring the functions.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5820 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-04 09:37:28 +00:00
xli24 dafa11b191 Update MdePkg/Include/Ppi according to code review comments.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5818 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-04 09:15:21 +00:00
qhuang8 ca65d1057a Fix a typo in Pcd name
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5814 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-04 08:06:31 +00:00
vanjeff 9eb7382f73 1. remove EFI_EVENT_ alias, replace them with EVT_
2. remove definitions of EFI_DESCRIPTION_STRING and EFI_DESCRIPTION_STRING_BUNDLE.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5812 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-04 07:38:10 +00:00
vanjeff 81c749f767 Changed x64 into X64.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5811 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-04 06:20:32 +00:00
vanjeff 7b1bf9f61b added additional comments and fixed some typo.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5810 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-04 06:16:14 +00:00
vanjeff 11227adb14 1. Remove unnecessary CONST.
2. Remove Unnecessarily including <ProcessorBind.h>.
3. Add comments for struct definition.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5806 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-04 03:15:52 +00:00
jljusten 1fb24cc445 edk2/MdePkg/Include/x64/ProcessorBind.h:
edk2/MdePkg/Include/Ipf/ProcessorBind.h:
* Merge ICC warning ignores from Ia32/ProcessorBind.h.


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5805 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-03 23:20:24 +00:00
jljusten 427c6c737e edk2/MdePkg/Include/Ia32/ProcessorBind.h:
* Disable ICC warning for: "LocalVariable" was set but never used


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5804 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-03 21:07:42 +00:00
klu2 f36a7bf58c Add more comment for library instance and remove unused internal header file.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5799 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-03 08:44:12 +00:00
klu2 bf295af27c Add more comment for library instance and remove unused internal header file.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5798 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-03 08:42:16 +00:00
klu2 ce02b0b901 Add more file comments
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5797 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-03 08:35:20 +00:00