mirror of https://github.com/acidanthera/audk.git
734bd6cc41
The generic timer support libraries call the actual system register accessor function via a single pair of functions ArmArchTimerReadReg() and ArmArchTimerWriteReg(), which take an enum argument to identify the register, and return output values by pointer reference. Since these functions are never called with a non-immediate argument, we can simply replace each invocation with the underlying system register accessor instead. This is mostly functionally equivalent, with the exception of the bounds check for the enum (which is pointless given the fact that we never pass a variable), the check for the presence of the architected timer (which only makes sense for ARMv7, but is highly unlikely to vary between platforms that are similar enough to run the same firmware image), and a check for enum values that refer to the HYP view of the timer, which we never referred to anywhere in the code in the first place. So get rid of the middle man, and update the ArmGenericTimerPhyCounterLib and ArmGenericTimerVirtCounterLib implementations to call the system register accessors directly. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org> Tested-by: Ryan Harkin <ryan.harkin@linaro.org> |
||
|---|---|---|
| .. | ||
| ArmCpuLib.h | ||
| ArmDisassemblerLib.h | ||
| ArmGenericTimerCounterLib.h | ||
| ArmGicArchLib.h | ||
| ArmGicLib.h | ||
| ArmHvcLib.h | ||
| ArmLib.h | ||
| ArmMmuLib.h | ||
| ArmSmcLib.h | ||
| BdsLib.h | ||
| DefaultExceptionHandlerLib.h | ||
| SemihostLib.h | ||
| UncachedMemoryAllocationLib.h | ||