some notes

This commit is contained in:
ClementTsang 2024-09-22 02:11:24 -04:00
parent 657d5c3297
commit 8fba8b1443
No known key found for this signature in database
GPG Key ID: DC3B7867D8D97095
2 changed files with 2 additions and 2 deletions

View File

@ -6,7 +6,7 @@ use crate::data_collection::disks::IoCounters;
fn get_device_io(device: io_kit::IoObject) -> anyhow::Result<IoCounters> {
let parent = device.service_parent()?;
// XXX: Re: Conform check being disabled.
// NB: Regarding the conform check being disabled.
//
// Okay, so this is weird.
//

View File

@ -18,7 +18,7 @@ pub fn init_logger(
// logging at all in a debug context which is generally fine,
// release builds should have this logging disabled entirely for now.
unsafe {
// XXX: If we ever DO add general logging as a release feature, evaluate this
// NB: If we ever DO add general logging as a release feature, evaluate this
// again and whether this is something we want enabled in
// release builds! What might be safe is falling back to the non-set-soundness
// mode when specifically using certain feature flags (e.g. dev-logging feature