tyler.durden
/
compose
mirror of https://github.com/docker/compose.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Don't set securityGroup name, as all compose apps will create a `DefaultNetwork` 

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
This commit is contained in:
Nicolas De Loof 2020-09-30 15:17:45 +02:00
parent 757b9bb221
commit 20a8f01269
No known key found for this signature in database
GPG Key ID: 9858809D6F8F6E7E
2 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
ecs/awsResources.go
View File

@ -189,7 +189,6 @@ func (b *ecsAPIService) ensureNetworks(r *awsResources, project *types.Project,
securityGroup := networkResourceName(name) securityGroup := networkResourceName(name)
template.Resources[securityGroup] = &ec2.SecurityGroup{ template.Resources[securityGroup] = &ec2.SecurityGroup{
GroupDescription: fmt.Sprintf("%s Security Group for %s network", project.Name, name), GroupDescription: fmt.Sprintf("%s Security Group for %s network", project.Name, name),
GroupName: securityGroup,
VpcId: r.vpc, VpcId: r.vpc,
Tags: networkTags(project, net), Tags: networkTags(project, net),
} }

1
ecs/testdata/simple/simple-cloudformation-conversion.golden vendored
View File

@ -37,7 +37,6 @@
"DefaultNetwork": { "DefaultNetwork": {
"Properties": { "Properties": {
"GroupDescription": "TestSimpleConvert Security Group for default network", "GroupDescription": "TestSimpleConvert Security Group for default network",
"GroupName": "DefaultNetwork",
"Tags": [ "Tags": [
{ {
"Key": "com.docker.compose.project", "Key": "com.docker.compose.project",