tyler.durden/compose
1
0
Fork 0
mirror of https://github.com/docker/compose.git synced 2025-07-08 06:14:25 +02:00
Code Issues Packages Projects Releases Wiki Activity

Don't define service resource name

Browse Source 
if we do, CloudFormation can't update resource and changeset fail with
"CloudFormation cannot update a stack when a custom-named resource
requires replacing"

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
This commit is contained in:
Nicolas De Loof 2020-06-15 17:48:56 +02:00
parent 5e1f40b752
commit cb74f7924e
No known key found for this signature in database
GPG Key ID: 9858809D6F8F6E7E
2 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
ecs/pkg/amazon/backend/cloudformation.go
View File

@ -193,7 +193,6 @@ func (b Backend) Convert(project *types.Project) (*cloudformation.Template, erro
}, },
}, },
SchedulingStrategy: ecsapi.SchedulingStrategyReplica, SchedulingStrategy: ecsapi.SchedulingStrategyReplica,
ServiceName: service.Name,
ServiceRegistries: []ecs.Service_ServiceRegistry{serviceRegistry}, ServiceRegistries: []ecs.Service_ServiceRegistry{serviceRegistry},
Tags: []tags.Tag{ Tags: []tags.Tag{
{ {

1
ecs/pkg/amazon/sdk/sdk.go
View File

@ -182,6 +182,7 @@ func (s sdk) CreateStack(ctx context.Context, name string, template *cf.Template
}) })
return err return err
} }
func (s sdk) WaitStackComplete(ctx context.Context, name string, operation int) error { func (s sdk) WaitStackComplete(ctx context.Context, name string, operation int) error {
input := &cloudformation.DescribeStacksInput{ input := &cloudformation.DescribeStacksInput{
StackName: aws.String(name), StackName: aws.String(name),