0b2eaede8c
Adding unit test for bind mount creation
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@gmail.com>
2020-12-04 13:49:43 +01:00
814536c0bd
Fixing bind mount with relative path when specifying relative working dir. Added first local compose volume e2e test
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@gmail.com>
2020-12-04 13:49:43 +01:00
136d09e1ac
split `Up` into `Create`+`Start` so logs don't collide with progress
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-12-04 08:16:50 +01:00
39e4107e12
attach to log stream by default on `up`
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-12-03 16:51:00 +01:00
2f09b634cc
Implement `docker compose pull`
...
Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
2020-12-03 16:14:38 +01:00
56511a4a3a
renaming
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@gmail.com>
2020-12-03 15:47:19 +01:00
44b4bc01af
In `compose down` progress display: prefix container names with “Container”, same as Services, Networks, homogeneous with `compose up`
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@gmail.com>
2020-12-03 15:46:37 +01:00
e469b40e28
Remove duplicate ensureImagesExist()
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@gmail.com>
2020-12-02 13:51:56 +01:00
7e4cfc0e3b
Add order to down command
...
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-12-02 13:51:11 +01:00
6bf76eebb1
Merge pull request #991 from gtardif/compose_network_error
...
Compose network error
2020-12-01 18:31:43 +01:00
a35147bc63
Detect push failure and break
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-12-01 16:26:01 +01:00
52574046f0
introduce `compose push` command
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-12-01 14:55:52 +01:00
b1970f618c
Container networks: prefix network name only for internal networks or when name set (different from yaml key). No need to prefix again when connecting containers
...
Signed-off-by: Guillame Tardif <guillaume.tardif@gmail.com>
2020-12-01 10:03:18 +01:00
d24ffd97a0
Local compose error when external network not available
...
Signed-off-by: Guillame Tardif <guillaume.tardif@gmail.com>
2020-11-30 14:49:35 +01:00
5952183eca
introduce `compose build` command
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-11-30 12:43:38 +01:00
4d1f265c62
Adding error progress indication when errors
...
Signed-off-by: Guillame Tardif <guillaume.tardif@gmail.com>
2020-11-27 18:18:14 +01:00
7ddd8e5e97
Helper methods to create progress events, more homogeneous display for “creating”, “Created”, …
...
Signed-off-by: Guillame Tardif <guillaume.tardif@gmail.com>
2020-11-27 17:55:36 +01:00
8b60c76684
Remove project network on compose down
...
Signed-off-by: Guillame Tardif <guillaume.tardif@gmail.com>
2020-11-27 17:42:29 +01:00
bc9099de9b
Ensure images are pulled/build with build first, before creating networks / volumes and starting containers.
...
Will also avoid mixing build output and compose-cli progress display
Signed-off-by: Guillame Tardif <guillaume.tardif@gmail.com>
2020-11-27 13:52:58 +01:00
3ff6923d2e
align coding-style with network labels
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-11-27 10:51:58 +01:00
f65a0d3720
Create volume with labels
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-11-27 10:21:36 +01:00
646aca82d9
composeService to rely on apiClient
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-11-27 10:21:36 +01:00
de3b6cb450
Add compose labels for composefiles
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-11-26 17:13:24 +00:00
f7905efc36
Merge pull request #960 from docker/build
2020-11-26 17:58:22 +01:00
e441fbba5a
Add compose labels for network
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-11-26 15:45:25 +01:00
0f4bcb9f17
Build and pull in parallel with BuildKit
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-11-26 14:11:40 +01:00
a0b609a5dd
implement service image build by BuildKit
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-11-26 14:07:53 +01:00
24328c4620
Add container labels to improve compatibility with docker-compose
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-11-25 17:53:12 +01:00
5ffdaa5cca
Use json progress message
...
It contains the same output that `docker pull` shows
Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
2020-11-23 10:00:13 +01:00
be40bdb032
Remove useless Done in the progress writer
...
Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
2020-11-22 17:30:28 +01:00
1f43b83409
Use a dependency graph to start services
...
The algorithm is like so:
* get all the leaves of the graph, these are all the service that don't have any dependency
* once a service is started we take the list of its parents (dependents)
* if all the dependencies of each of those dependents are started then we can start it as well
* if not then we continue to the next dependent
Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
2020-11-21 22:30:32 +01:00
b3f406f410
Merge pull request #924 from docker/dependecy_order
2020-11-20 15:45:15 +01:00
ff84803546
compose ps implementation
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-11-19 13:34:43 +01:00
251c52664a
Implement service_healthy dependency condition
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-11-19 13:10:55 +01:00
adb62e9080
Run convergence in service dependency order
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-11-19 13:10:13 +01:00
9f594abd85
Local compose ls implementation
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-11-19 09:48:54 +01:00
51142827e7
Fix linter errors
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-11-18 17:18:41 +01:00
eb60bbb74f
define const for labels
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-11-17 15:56:39 +01:00
2278370ffa
Handle service scale with container numbering
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-11-17 15:15:27 +01:00
da99ad40d5
Fix logs (concurrent access to container.ID, logs was displaying the first container logs for every container)
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-11-17 15:13:36 +01:00
6346db1d6f
Move reconciliation logic into convergence.go
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-11-17 11:31:14 +01:00
8310bb2a91
Create services in dependency order
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-11-17 11:31:14 +01:00
744aebc3fd
"Already exists" also means the pull finished
...
Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
2020-11-17 11:31:14 +01:00
b0ee6d285a
Update docker/docker to be able to run this on a Mac, use goroutines when starting a stack
...
Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
2020-11-17 11:31:13 +01:00
9fdf69ea9c
Handle container (re)create/(re)start on compose up
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-11-17 11:29:12 +01:00
0d33e5cdcc
report docker resources creation in progress
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-11-17 11:28:50 +01:00
7944a1b94f
implement image pull on `compose up` with progress
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-11-17 11:28:49 +01:00
74de423cc3
reuse ECS logConsumer to implement formatted compose log output
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-11-17 11:28:08 +01:00
3f52508efe
Skeletton implementation for compose commands
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-11-17 11:28:08 +01:00
85ec312461
convert compose model into moby API types to prepare "up" local implementation
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-11-17 11:28:08 +01:00
Guillaume Tardif
Nicolas De Loof
Djordje Lukic
Ulysses Souza
Guillaume Tardif