334ebf5f75
Implement --domainname flag on compose up, also defining compose extension "x-aci-domain-name" to store ACI DNSLabelName.
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-22 14:41:31 +02:00
268c02523a
Only add `--domainname` flag to `docker run` in ACI context
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-22 14:41:31 +02:00
701d1b834e
ACI: allow users to set DNSLabelName and deploy containers with fqdn like `myapp.eastus.azurecontainers.io`
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-22 14:41:31 +02:00
7abdb085c0
Merge pull request #637 from docker/volume_tests
...
Added tests on ACI volume conversion, mock storageLogin required to get storage account keys
2020-09-22 14:40:46 +02:00
0092de6df1
Added tests on ACI volume conversion, mock storageLogin required to get storage account keys
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-22 14:24:12 +02:00
f42e05fcc3
Merge pull request #636 from docker/update-copyright
...
Update copyright
2020-09-22 12:21:16 +02:00
772493d70d
Merge pull request #617 from ulyssessouza/volumes_ro
...
Add 'readOnly' capability to volumes on ACI
2020-09-22 12:14:31 +02:00
d154c41586
Update copyright
...
Signed-off-by: Chris Crone <christopher.crone@docker.com>
2020-09-22 12:13:00 +02:00
01ea2488a2
Merge pull request #630 from docker/cli_metrics_failures
...
Cli metrics failures
2020-09-18 18:26:54 +02:00
57c14e70e1
Merge pull request #628 from docker/machine
...
Guess AWS machine type based on service resources reservations
2020-09-18 17:05:54 +02:00
b22ebd61c4
minor error improvement to match AWS docs
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Co-authored-by: Chris Crone <christopher.crone@docker.com>
2020-09-18 16:44:17 +02:00
6f19bbfd5e
We can’t anymore “fire and forget”, now that metrics get posted right at the end, most of the time we’d loose them.
...
Give it max 50 ms to post metrics, that’s plenty, post call ends in ~2 ms or less when desktop is up, less than one ms to fail the post when DD is not listening.
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-18 15:57:02 +02:00
a71b2a39bd
Add status field in API metrics
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-18 15:22:34 +02:00
02d59ae510
Add 'readOnly' capability to volumes on ACI
...
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-09-18 12:07:42 +02:00
3ccc603461
Add status field in CLI metrics : success, failure, cancelled
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-18 10:47:50 +02:00
10372b7098
Merge pull request #625 from docker/aci_context_create_no_sub
...
Check specified subscription in context create and if not found, prompt users they might need to login with -—tenant-id.
2020-09-17 22:29:06 +02:00
292ec55f46
Check specified subscription in context create and if not found, prompt users they might need to login with -—tenant-id.
...
Cf https://github.com/docker/aci-integration-beta/issues/27
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-17 22:05:43 +02:00
e6925b4217
Merge pull request #629 from docker/fix_windows_ci
...
Changing e2e test PATH to make windows tests pass
2020-09-17 17:25:20 +02:00
17bda79ca1
Changing e2e test PATH to make windows tests pass
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-17 17:13:05 +02:00
101e1555b8
Some more functional design
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-09-17 12:44:55 +02:00
d320d5460c
Merge pull request #621 from gtardif/ci_minor_changes
...
Minor CI changes
2020-09-17 12:20:48 +02:00
d945c34a55
Adding badge for cloud integration tests.
...
testing effect of https://github.com/docker/compose-cli/pull/620
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-17 12:19:04 +02:00
dae9ab7bb0
Merge pull request #627 from docker/fix_no_home
...
Fix context store when no home defined
2020-09-17 11:40:40 +02:00
e904c71b04
Merge pull request #624 from docker/feat-api-metrics
...
Add interceptor for API metrics
2020-09-17 11:40:22 +02:00
dbe87e23a9
Guess AWS machine type based on service resources reservations
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-09-17 11:03:25 +02:00
3bf6a00a61
goimports
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-17 10:58:01 +02:00
387370d074
Merge pull request #623 from docker/external
...
Prefer external.name over x-aws-securitygroup
2020-09-17 10:22:28 +02:00
9c6aead797
Allow running commands with HOME=“”.
...
Do not try to create ~/.docker before using CONFIG_DIR. HOME=“” will result in trying to use a relative .docker folder as default config folder, and if we cannot create the context store for any reason, try delegate to Moby CLI.
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-17 09:08:17 +02:00
6d35a6d644
Merge pull request #609 from docker/refacto_multi_error_format
...
Remove duplicated code formatting multi errors
2020-09-15 18:14:45 +02:00
5b76dda380
Merge pull request #622 from docker/efs
...
Introduce support for external EFS volumes
2020-09-15 18:10:23 +02:00
e56061d27c
Move fire and forget code from metrics.Track() (used only by CLI) to metrics.Send (used by both CLI and API)
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-15 17:28:23 +02:00
2570ebec86
Add interceptor for API metrics, ensure registered methods have a corresponding method set for metrics
...
Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
2020-09-15 17:16:10 +02:00
46cebb3194
Prefer external.name over x-aws-securitygroup
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-09-15 15:34:18 +02:00
30de56f64f
Introduce support for external EFS volumes
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-09-15 13:03:53 +02:00
0c1de64c84
Merge pull request #610 from docker/fix_volume_error_message
...
fix error message on ACI docker volume rm
2020-09-15 12:38:32 +02:00
317659be8e
Merge pull request #613 from docker/progress_result
...
Progress functions can return a string, that can be used in the caller of progress.Run() to display final result after progress display
2020-09-15 12:38:14 +02:00
6cb19ed26d
Merge pull request #620 from gtardif/ci_labeller
...
Allow running action labeller on PR from forks, using pull_request-target
2020-09-15 12:29:05 +02:00
d087d665d8
Trying back with pull_request_target event
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-15 11:40:38 +02:00
5e4470b153
Trying back with pull_request event
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-15 11:35:56 +02:00
f6d26b321c
Allow running action labeller on PR from forks, using pull_request-target. Cf https://github.com/actions/labeler/issues/12#issuecomment-670967607
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-15 10:20:32 +02:00
06d0ffae82
Fix volume error message
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-15 09:27:22 +02:00
1ffdab15b2
Merge pull request #616 from docker/go-1.15.2
...
Bump Golang to 1.15.2, golangci-lint to 1.31.0
2020-09-14 18:16:06 +02:00
4ce1fafc0a
Merge pull request #615 from docker/fix_linux_install
...
Fix linux install script parsing version
2020-09-14 18:14:42 +02:00
5ef51722d0
deps: Bump Golang to 1.15.2, golangci-lint to 1.31.0
...
Signed-off-by: Chris Crone <christopher.crone@docker.com>
2020-09-14 17:23:18 +02:00
1bb1499675
Fix linux script parsing version to check if we have the new CLI already installed or not (need to keep azure check for users who have the previous version installed :/ )
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-14 16:59:56 +02:00
267b267201
Progress functions can return a string, that can be used in the caller of progress.Run to display final result after progress display
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-14 14:29:03 +02:00
9c07a7b3ad
Merge pull request #611 from docker/version_cloutd_integration
...
In version, replace “Azure integration” version info by “Cloud integration"
2020-09-12 16:02:55 +02:00
2ce4e98d88
In version, replace “Azure integration” version info by “Cloud integration”
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-11 17:29:40 +02:00
b85eddd09c
Remove duplicated code formatting multi errors
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-09-11 16:08:14 +02:00
57ded74aee
Merge pull request #598 from docker/encode_env_values
...
Properly send env variables containing “=“ in their value in ACI payload. Also properly send quoted values
2020-09-10 17:17:02 +02:00
Guillaume Tardif
Chris Crone
Nicolas De loof
Ulysses Souza
Djordje Lukic