Commit Graph

288 Commits

Author SHA1 Message Date
Chris Crone 39cd5036a6
Merge pull request #144 from chris-crone/lint-speed
Use docker build for lint
2020-05-22 13:25:46 +02:00
Christopher Crone 3c5d37326d Use docker build for lint
This approach allows better caching of results (so faster subsequent
lints). It also avoids bind mounts which are slow.

Benchmarks on my machine (2017 MacBook Pro 13"):
* bind mount lint: 2m 38s
* new lint (after docker builder prune): 1m 35s
* old lint (rerun no changes): 2m 38s
* new lint (rerun added println in random Go file): 9s

Signed-off-by: Christopher Crone <christopher.crone@docker.com>
2020-05-22 13:14:44 +02:00
Chris Crone 0917acfb01
Merge pull request #142 from chris-crone/fix-141
Set random container name if not set
2020-05-22 11:31:16 +02:00
Christopher Crone 88ba591fc3 Seed random with nanosecond time
It's possible that users will run commands more than once a second.
Thus, seeding the random number generator with the current time in
seconds could produce results like the same container name in subsequent
commands.

Seeding with the current time in nanoseconds reduces the probability of
this.

Signed-off-by: Christopher Crone <christopher.crone@docker.com>
2020-05-22 10:46:54 +02:00
Djordje Lukic 6a0c0d7032
Merge pull request #125 from rumpl/feat-default-context
Add default context to the context ls output
2020-05-22 01:14:42 -07:00
Djordje Lukic 8495500aa2 Add a CliSuite for cli unit tests
Makes writing unit tests for commands quite easier
2020-05-22 10:13:56 +02:00
Christopher Crone dd66646c06 Unit test run help
Signed-off-by: Christopher Crone <christopher.crone@docker.com>
2020-05-21 20:03:06 +02:00
Christopher Crone 0efa67f7d2 Set random container name if not set
Signed-off-by: Christopher Crone <christopher.crone@docker.com>
2020-05-21 19:28:42 +02:00
Chris Crone 578376aabe
Merge pull request #140 from chris-crone/e2e-helpers
Simplify e2e suite helpers
2020-05-21 13:46:37 +02:00
Christopher Crone b5156eecc7 Simplify e2e suite helpers
Signed-off-by: Christopher Crone <christopher.crone@docker.com>
2020-05-21 09:33:08 +02:00
Djordje Lukic fe36c49246 Use alpine as base image
Installing docker on buster is a pain, use alpine to install it
2020-05-20 18:39:10 +02:00
Djordje Lukic 95e07a2134 Add default context to the context ls output 2020-05-20 18:39:10 +02:00
Chris Crone eae864ac33
Merge pull request #135 from rumpl/chore-remove-client-deps
Remove gRPC stuff from the client
2020-05-20 18:17:50 +02:00
Chris Crone 3c3b84f542
Merge pull request #138 from chris-crone/refactor-e2e-suite
Refactor e2e suite code
2020-05-20 18:17:01 +02:00
Christopher Crone 7d49706acf Refactor e2e suite code
Signed-off-by: Christopher Crone <christopher.crone@docker.com>
2020-05-20 18:08:07 +02:00
Guillaume Tardif 3d2d81b428
Merge pull request #118 from chris-crone/e2e-suite
Wrap e2e tests in suite
2020-05-20 17:23:01 +02:00
Guillaume Tardif 186289b75f Fix ace e2e tests : also use context store with config dir when registering aci backend 2020-05-20 17:15:56 +02:00
Djordje Lukic 3ffa79f743 Remove gRPC stuff from the client 2020-05-20 16:49:20 +02:00
Christopher Crone 57404a2663 Tidy Go modules
Signed-off-by: Christopher Crone <christopher.crone@docker.com>
2020-05-20 15:57:28 +02:00
Christopher Crone a8146ad59c Rework e2e tests into suite
Signed-off-by: Christopher Crone <christopher.crone@docker.com>
2020-05-20 15:57:10 +02:00
Christopher Crone 384cb89193 Update dockerignore
Signed-off-by: Christopher Crone <christopher.crone@docker.com>
2020-05-20 15:56:32 +02:00
Christopher Crone ebe3fbc180 Use config dir for serving API
Signed-off-by: Christopher Crone <christopher.crone@docker.com>
2020-05-20 15:56:07 +02:00
Christopher Crone 058e6203a7 Store config dir in CLI context
Signed-off-by: Christopher Crone <christopher.crone@docker.com>
2020-05-20 15:55:05 +02:00
Djordje Lukic 523681659c
Merge pull request #127 from rumpl/add-pull-request-template
Add pull request template
2020-05-20 05:44:19 -07:00
Christopher Crone b7fb7e2e84 Allow setting config dir with env var
Signed-off-by: Christopher Crone <christopher.crone@docker.com>
2020-05-20 14:39:02 +02:00
Djordje Lukic e902e2ad93 Add pull request template 2020-05-20 14:36:46 +02:00
Guillaume Tardif d218c0745e
Merge pull request #121 from gtardif/docker-classic
delegate Moby to docker-classic binary, link docker-classic in e2e tests
2020-05-20 14:28:35 +02:00
Guillaume Tardif 2610b986fd delegate Moby to docker-classic binary, link docker-classic in e2e tests 2020-05-20 14:23:29 +02:00
Guillaume Tardif c1875a219c
Merge pull request #72 from ulyssessouza/add-aci-volumes
Add volumes to run command
2020-05-20 14:18:30 +02:00
Ulysses Souza d2fece3311 Fix linter problems
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-05-20 10:16:36 +02:00
Ulysses Souza 762f462d80 Get "run" test back to main function
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-05-20 10:16:34 +02:00
Ulysses Souza 70bcdca2c2 Add tests to volume convertion
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-05-20 10:13:12 +02:00
Ulysses Souza b68c019e93 Implement ErrParsingFailed error
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-05-20 10:13:12 +02:00
Ulysses Souza bdd987f246 Refactor placement and method name
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-05-20 10:13:12 +02:00
Ulysses Souza d28e5fd742 Add e2e-aci tests for volumes
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-05-20 10:13:08 +02:00
Ulysses Souza b25a6b4bd6 Add volumes to run command
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-05-20 10:06:12 +02:00
Djordje Lukic 7603a3b832
Merge pull request #120 from ulyssessouza/fix-typo
Fix typo
2020-05-19 22:39:49 -07:00
Ulysses Souza a33f3e17f8 Fix typo
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-05-20 06:45:06 +02:00
Guillaume Tardif fce6d78750
Merge pull request #117 from gtardif/auto-release
Release CI config
2020-05-19 16:08:51 +02:00
Guillaume Tardif 5c873c1a84 Release CI config 2020-05-18 22:55:50 +02:00
Djordje Lukic 04e6023d08
Merge pull request #114 from docker/feat-context-list
Feat context list
2020-05-18 08:06:30 -07:00
Guillaume Tardif 3e2580cfdc
Merge pull request #115 from gtardif/grpc_e2e
First e2e test running grpc e2e test (js test client)
2020-05-18 17:02:48 +02:00
Guillaume Tardif 073832631f First e2e test running grpc e2e test (js test client) 2020-05-18 17:00:16 +02:00
Djordje Lukic 3891c8c414 Put all magic strings in variables in context store 2020-05-18 16:42:06 +02:00
Djordje Lukic 0bd18986dd Add "*" for the current context 2020-05-18 16:42:06 +02:00
Djordje Lukic cf1be96833
Merge pull request #99 from docker/feat-stop
Add `Stop` command on the gRPC side.
2020-05-18 07:40:39 -07:00
Anca Iordache f0f8e95f80
Merge pull request #116 from pmckeetx/dockercon-demo
Add DockerCon 2020 header image and update font
2020-05-18 16:30:08 +02:00
peter 43a781581c Add DockerCon 2020 header image and update font 2020-05-18 09:22:08 -05:00
Chris Crone 20009c55c3
Merge pull request #103 from chris-crone/config-tests
Add config package tests
2020-05-18 15:40:17 +02:00
Christopher Crone 91c1cddc70 Remove extra \n in server to appease linter
Signed-off-by: Christopher Crone <christopher.crone@docker.com>
2020-05-18 15:32:49 +02:00