Commit Graph

843 Commits

Author SHA1 Message Date
Guillaume Tardif 3a60c957ae Get storage account key from azure login, no need to specify it in compose file or run -v option 2020-08-14 12:26:09 +02:00
Guillaume Tardif c8dc0f1cf3
Merge pull request #479 from docker/dependabot/go_modules/github.com/Azure/go-autorest/autorest/azure/auth-0.5.1
build(deps): bump github.com/Azure/go-autorest/autorest/azure/auth from 0.5.0 to 0.5.1
2020-08-14 12:24:20 +02:00
Guillaume Tardif 3859312c17
Merge pull request #482 from docker/region_aci_tests
Change ACI test region to eastus2. Improve error output when waiting for container status
2020-08-14 12:19:52 +02:00
Guillaume Tardif 104b3d4dc8 Change ACI test region to eastus2. Improve error output when waiting for container status 2020-08-14 12:12:06 +02:00
dependabot-preview[bot] 15377d83cd
build(deps): bump github.com/Azure/go-autorest/autorest/azure/auth
Bumps [github.com/Azure/go-autorest/autorest/azure/auth](https://github.com/Azure/go-autorest) from 0.5.0 to 0.5.1.
- [Release notes](https://github.com/Azure/go-autorest/releases)
- [Changelog](https://github.com/Azure/go-autorest/blob/master/CHANGELOG.md)
- [Commits](https://github.com/Azure/go-autorest/compare/tracing/v0.5.0...autorest/azure/auth/v0.5.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-08-13 21:32:08 +00:00
Guillaume Tardif ee915cec78
Merge pull request #473 from docker/fix_warn_forward_signal
Do not display warning if cannot forward signal to child.
2020-08-13 14:12:50 +02:00
Guillaume Tardif b060d8acfc Do not display warning if cannot forward signal to child. See https://github.com/docker/pinata/pull/14327 2020-08-13 14:06:52 +02:00
Djordje Lukic 4286458300
Merge pull request #471 from docker/fix-run-timeout
Put 40 seconds for timeout instead of 20
2020-08-13 10:44:37 +02:00
Djordje Lukic 88c405e025 Use buffered channels for signals 2020-08-13 10:34:42 +02:00
Djordje Lukic 9a29037e0f Put 40 seconds for timeout instead of 20
For some reason this test fails on CI with a timeout.
2020-08-13 09:50:06 +02:00
Djordje Lukic 544d4811c3
Merge pull request #469 from docker/feat-aci-start
Feat aci start
2020-08-12 15:33:07 +02:00
Djordje Lukic 13327ac617 Make the compose message on start mean something 2020-08-12 15:10:54 +02:00
Djordje Lukic 33758f0764 Add start to gRPC 2020-08-12 14:50:47 +02:00
Djordje Lukic aa8bf1daaa Add test for ACI start 2020-08-12 14:50:47 +02:00
Djordje Lukic 1a3182fb7f Implement `docker start` for ACI 2020-08-12 14:50:47 +02:00
Guillaume Tardif abd363d641
Merge pull request #463 from docker/compose_labels_error
Explicit error message saying we don’t support labels in compose file
2020-08-12 13:51:32 +02:00
Guillaume Tardif e93da5cf5e
Merge pull request #468 from docker/aci_ps_all
Implement `docker ps —all` filter on ACI
2020-08-12 12:28:16 +02:00
Guillaume Tardif 3d758b7f26 Implement `docker ps —all` filter on ACI 2020-08-12 11:59:36 +02:00
Chris Crone 52cd3d97c0
Merge pull request #465 from docker/login_redirect
Change docker login azure redirect to docker ACI integration documentation
2020-08-12 11:09:03 +02:00
Guillaume Tardif d54fd53930
Merge pull request #461 from docker/aci_stop
ACI Stop implementation
2020-08-12 10:48:29 +02:00
Guillaume Tardif 6472ffa346 Change docker login azure redirect to docker ACI integration documentation 2020-08-12 10:40:08 +02:00
Guillaume Tardif ee062e8333 ACI Stop implementation 2020-08-12 10:32:35 +02:00
Guillaume Tardif 8fb16cea63 Explicit error message saying we don’t support labels in compose file. (See ACI limitations: https://github.com/docker/desktop-microsoft/issues/33) 2020-08-12 10:28:55 +02:00
Guillaume Tardif ba6e5e9098
Merge pull request #462 from docker/dependabot/go_modules/github.com/aws/aws-sdk-go-1.34.2
build(deps): bump github.com/aws/aws-sdk-go from 1.33.21 to 1.34.2
2020-08-12 09:31:24 +02:00
Guillaume Tardif e260549ab4
Merge pull request #450 from docker/dependabot/go_modules/github.com/AlecAivazis/survey/v2-2.1.1
build(deps): bump github.com/AlecAivazis/survey/v2 from 2.1.0 to 2.1.1
2020-08-12 09:29:53 +02:00
dependabot-preview[bot] e5066f9ede
build(deps): bump github.com/aws/aws-sdk-go from 1.33.21 to 1.34.2
Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.33.21 to 1.34.2.
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Changelog](https://github.com/aws/aws-sdk-go/blob/master/CHANGELOG.md)
- [Commits](https://github.com/aws/aws-sdk-go/compare/v1.33.21...v1.34.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-08-11 21:23:28 +00:00
dependabot-preview[bot] 57ca78fb3a
build(deps): bump github.com/AlecAivazis/survey/v2 from 2.1.0 to 2.1.1
Bumps [github.com/AlecAivazis/survey/v2](https://github.com/AlecAivazis/survey) from 2.1.0 to 2.1.1.
- [Release notes](https://github.com/AlecAivazis/survey/releases)
- [Commits](https://github.com/AlecAivazis/survey/compare/v2.1.0...v2.1.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-08-11 16:37:17 +00:00
Djordje Lukic f3aeb318f6
Merge pull request #460 from docker/fix-lint
Fix linting
2020-08-11 17:43:53 +02:00
Djordje Lukic 611667d252 Fix linting 2020-08-11 17:36:54 +02:00
Djordje Lukic 2b9da841ed
Merge pull request #426 from thaJeztah/simplify_multierror
[RFC] Remove custom multierrors package
2020-08-11 17:28:10 +02:00
Sebastiaan van Stijn c862d7821d
Remove custom multierrors package
The hashicorp/go-multierror package provides functionality to do
this. Replacing the custom package in favor of those (at the cost
of some small duplication).

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2020-08-11 17:24:51 +02:00
Djordje Lukic 2b29069255
Merge pull request #459 from docker/fix-aci-rm
Fix the rm test without force
2020-08-11 17:18:23 +02:00
Djordje Lukic f44d29f4df Fix the rm test without force
mutlierror didn't append an `Error:` if there is only one error...
2020-08-11 17:06:45 +02:00
Guillaume Tardif 37a547de59
Merge pull request #458 from docker/optional_ci_tests
CI : Optional tests for ACI / Windows
2020-08-11 17:02:19 +02:00
Guillaume Tardif d06d5ae358 Document optional test triggers in PR template. Beware, @test-aci or @test-windows in comments will also trigger tests, comments are not ignored for this 2020-08-11 16:49:42 +02:00
Djordje Lukic 80c1b2246b
Merge pull request #457 from docker/feat-aci-force-rm
Add --force to rm on ACI
2020-08-11 16:42:49 +02:00
Djordje Lukic 093a69136f Add --force to rm on ACI
If a container is running the user must force the removal of the
container.
2020-08-11 16:30:42 +02:00
Guillaume Tardif ba6e8045b2
Merge pull request #448 from docker/azure_sp_login
Add options to `docker login azure` to support Service Principal login. Use it in E2E tests
2020-08-11 16:22:47 +02:00
Guillaume Tardif 9d5285a1dc Remove debugging 2020-08-11 16:15:09 +02:00
Guillaume Tardif 6e4f580b99 Force all tests on main branch after testing on separate branch 2020-08-11 16:01:13 +02:00
Guillaume Tardif d884835ecb Build aci tests / windows tests on push or on PR that request @test-aci, @test-windows in description 2020-08-11 15:38:10 +02:00
Guillaume Tardif 6ff20cf104
more concise validation
Co-authored-by: Djordje Lukic <djordje.lukic@docker.com>
2020-08-11 13:45:46 +02:00
Guillaume Tardif ec5f4e9202 Add options to `docker login azure` to support Service Principal login. Use it in E2E tests 2020-08-11 12:11:51 +02:00
Guillaume Tardif c049f3c7af
Merge pull request #449 from docker/aci-win
Fix race in ACI tests on Windows
2020-08-10 18:20:55 +02:00
Chris Crone fc64f2923b aci-e2e: Windows fixes
Signed-off-by: Chris Crone <christopher.crone@docker.com>
2020-08-10 17:23:50 +02:00
Chris Crone 928e5ab017
Merge pull request #447 from docker/e2e-windows-host
Check Windows specific host error in e2e tests
2020-08-10 15:12:45 +02:00
Chris Crone 65fb6020a0 tests.e2e: Check Windows specific error
Signed-off-by: Chris Crone <christopher.crone@docker.com>
2020-08-10 15:06:20 +02:00
Guillaume Tardif 6405256752
Merge pull request #446 from docker/e2e-fix-windwows
Fix e2e tests on Windows
2020-08-10 14:50:22 +02:00
Guillaume Tardif 3c7e551940
Merge pull request #445 from docker/acr_login_cleanup
Use existing oauth Token struct rather than create our own
2020-08-10 14:45:26 +02:00
Guillaume Tardif 76d8f5a8b4 More goimport changes 2020-08-10 14:36:05 +02:00