Guillaume Tardif
a6ef06f131
Merge pull request #753 from docker/secrets-remove-inline
...
Remove inline secrets option
2020-10-09 16:03:38 +02:00
Ulysses Souza
4d6a0bb00d
Remove inline secrets option
...
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-10-09 14:54:12 +02:00
Guillaume Tardif
5efebd43c1
Merge pull request #736 from docker/check-volume-usage-on-delete
...
Look for all mounts before removing a volume
2020-10-09 14:46:25 +02:00
Ulysses Souza
99186b1d04
Look for all mounts before removing a volume
...
This checks the volume mounts of all container groups from all
resource groups before removing a volume/fileshare
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-10-09 14:39:21 +02:00
Guillaume Tardif
4380adeed5
Merge pull request #751 from docker/fix-string-len-e2e
...
Fix e2e-aci tests on comparing with empty string
2020-10-09 14:36:05 +02:00
Guillaume Tardif
289c83efe2
HttpRetry : do not get stuck on first call, timeout http requests and retry in case of failures
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-09 14:27:24 +02:00
Guillaume Tardif
4f87422a79
more debug info when ports available but hostIP is empty ; Seems to be a race where container has status running but not yet an IP allocated
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-09 14:09:09 +02:00
Ulysses Souza
019268dded
Fix e2e tests on comparing with empty string
...
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-10-09 13:21:17 +02:00
Guillaume Tardif
7fb976732f
Merge pull request #748 from docker/aci_resource_req
...
Aci resource reservation & limits
2020-10-09 12:13:35 +02:00
Guillaume Tardif
a2af3c4367
Merge pull request #752 from gtardif/aci_e2E_cleanup
...
Add ACI E2E resource cleanup command
2020-10-09 11:56:16 +02:00
Guillaume Tardif
68d0413e36
Minor cleanup
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-09 11:53:53 +02:00
Guillaume Tardif
8325768a72
Add ACI E2E resource cleanup command
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-09 10:07:13 +02:00
Guillaume Tardif
cfc490fd92
Update gRPC inspect result with HostConfig struct. Breaking changes in inspect API, but this is not used yet in VSCode Docker extension, and still in beta.
...
(Cf https://github.com/microsoft/vscode-docker/blob/master/src/docker/DockerServeClient/DockerServeUtils.ts )
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-08 18:05:52 +02:00
Guillaume Tardif
6516632ecf
Add resource reservations to container inspect
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-08 17:47:16 +02:00
Guillaume Tardif
b1edfb6507
Change inspect json output to group things a bit more nicely, and more like Moby json output
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-08 17:03:30 +02:00
Guillaume Tardif
343d54dac5
Allow to set memory / CPU limits higher than requests, ACI will request that limits are not higher than the total request for the container group. Also set requests = limits when only limits are set
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-08 17:03:30 +02:00
Guillaume Tardif
c09f771359
Use compose resource request to set ACI retrouve request, and single container resource requests.
...
Limits should be used to allow one container in a container group to use more than the container requested resources, up to the total resources requested for the container group.
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-08 17:03:30 +02:00
Guillaume Tardif
cda66b5e90
Merge pull request #741 from gtardif/fix_cli_metrics
...
Simplify metrics gathering, separate running commands from getting help
2020-10-08 15:34:09 +02:00
Guillaume Tardif
0d161f5ccd
Merge pull request #723 from gtardif/doc_aci_compose
...
Compose to ACI mapping documentation
2020-10-08 15:04:17 +02:00
Guillaume Tardif
808715d740
Adding secrets details
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-08 14:58:08 +02:00
Guillaume Tardif
7ff9162dc7
Remove enterprise specific commands
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-08 14:50:27 +02:00
Guillaume Tardif
a09983b474
Do not send metrics for help commands
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-08 14:47:31 +02:00
Guillaume Tardif
3e93a690d2
Adding command aliases, was missing only “f” and “b” (from `build bake` and `build build`)
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-08 13:12:36 +02:00
Guillaume Tardif
0d3f7186c5
Hardcoded list of commands and simplified metrics gathering.
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-08 11:59:12 +02:00
Nicolas De loof
005c6dcfe7
Merge pull request #730 from aiordache/ecs_detached_up
...
Add detach flag to `compose up`
2020-10-07 17:23:56 +02:00
aiordache
265dd197c3
Add detach flag to `compose up`
...
Signed-off-by: aiordache <anca.iordache@docker.com>
2020-10-07 15:51:43 +02:00
Guillaume Tardif
c3983eea78
More changes from feedback
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-07 12:15:17 +02:00
Guillaume Tardif
11829eddc0
Merge pull request #713 from docker/metrics_e2e
...
E2e test on metrics
2020-10-07 11:36:46 +02:00
Guillaume Tardif
e3b22ecd0b
Apply suggestions from code review
...
Co-authored-by: Chris Crone <christopher.crone@docker.com>
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-07 10:52:14 +02:00
guillaume.tardif
cd09351b0a
Fix ACI E2E test on windows (file path)
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-07 10:38:33 +02:00
guillaume.tardif
886363b44a
make metrics tests pass on windows
...
Signed-off-by: guillaume.tardif <guillaume.tardif@gmail.com>
2020-10-07 10:11:46 +02:00
Guillaume Tardif
9ad06e55b5
E2e test on metrics
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-07 10:11:46 +02:00
Guillaume Tardif
6fa93db021
Merge pull request #724 from gtardif/json_context_format
...
Allow `docker context ls —formatter {{json.}}` to not delegate to Moby and include context type in the json
2020-10-06 18:12:54 +02:00
Guillaume Tardif
de9a1d832e
Merge pull request #714 from docker/volumes-e2e
...
Add aci volumes e2e test
2020-10-06 18:12:30 +02:00
Guillaume Tardif
a1bb2d5abe
Allow `docker context ls —formatter {{json.}}` to not delegate to Moby and include context type in the json
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-06 18:00:35 +02:00
Guillaume Tardif
9cc914ef07
No need for docker dependency for CopyDir, and yaml parser.
...
No need for multiport compose file with volumes
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-06 17:54:26 +02:00
Ulysses Souza
f8a3aec64d
Add aci volumes e2e test
...
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-10-06 17:22:57 +02:00
Guillaume Tardif
0cea91c555
Merge pull request #732 from docker/status_reason
...
restore status in addition to reason as progress message
2020-10-06 14:22:13 +02:00
Nicolas De Loof
e8507893ee
restore status in addition to reason as progress message
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-10-06 14:05:08 +02:00
Guillaume Tardif
5c0a953f7e
Merge pull request #731 from docker/atlas_test_disable
...
Temporarily disable some red ACI tests
2020-10-06 13:51:32 +02:00
Guillaume Tardif
b10acc1a60
Temporarily disable some red ACI tests, to be put reverted once the platform is back to green (hopefully in a day or 2)
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-06 13:29:27 +02:00
Guillaume Tardif
6c9cbd37b9
Merge pull request #729 from docker/windows-golden
...
Add windows golden file for `context ls`
2020-10-06 13:25:40 +02:00
Ulysses Souza
d9115d4089
Add windows golden file for `context ls`
...
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-10-06 11:50:27 +02:00
Nicolas De loof
d1d00384fb
Merge pull request #728 from docker/NLB
...
NLB don't support securityGroups
2020-10-06 11:08:29 +02:00
Nicolas De Loof
481e069b2e
NLB don't support securityGroups
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2020-10-06 10:55:45 +02:00
Nicolas De loof
60bd0e5303
Merge pull request #706 from aiordache/ecs_task_failure_detection
2020-10-05 19:45:03 +02:00
aiordache
c15d05f7f4
refactor task failure detection
...
Signed-off-by: aiordache <anca.iordache@docker.com>
2020-10-05 19:37:13 +02:00
aiordache
eadcb3be32
Error check stack delete
...
Signed-off-by: aiordache <anca.iordache@docker.com>
2020-10-05 16:55:38 +02:00
aiordache
d3effd2ead
Detect task failures
...
Signed-off-by: aiordache <anca.iordache@docker.com>
2020-10-05 16:55:35 +02:00
Guillaume Tardif
c85a584046
Compose to ACI mapping documentation
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
2020-10-05 14:48:05 +02:00