Chris Crone
c13d16577e
Merge pull request #390 from chris-crone/readme-typos
...
Fix README typos
2020-07-16 17:12:44 +02:00
Chris Crone
6294843a06
Merge pull request #391 from docker/bump-deps
...
Bump Golang and linter
2020-07-16 17:12:31 +02:00
Christopher Crone
8ec9b3c77b
dependencies: Bump Golang and linter
...
* Go 1.14.5
* golangci-lint 1.28.3
Signed-off-by: Christopher Crone <christopher.crone@docker.com>
2020-07-16 13:22:12 +02:00
Christopher Crone
bf9b31e6f7
readme: Fix typos
...
Signed-off-by: Christopher Crone <christopher.crone@docker.com>
2020-07-16 13:21:08 +02:00
Chris Crone
9a4e937c8b
Merge pull request #389 from docker/fix-single-container-tag
...
Fix adding a tag to a container group
2020-07-16 11:24:57 +02:00
Djordje Lukic
4480d27595
Don't set the container name in the test
...
This will help us catch errors such as
https://github.com/docker/desktop-microsoft/issues/42
2020-07-16 10:39:41 +02:00
Djordje Lukic
a2edb5b64e
Fix adding a tag to a container group
2020-07-16 10:01:49 +02:00
Djordje Lukic
45a7c7a422
Merge pull request #385 from docker/aci_tags
...
Aci improvements on tags & single container run
2020-07-13 11:35:22 +02:00
Guillaume Tardif
042fb66ad8
Better progress display: “Group xxx” for container group creation, then separate lines for containers.
...
For single containers, there was a single mixed line now that the group and the container have the same name.
```
$ ./bin/docker --context acitest run nginx
[+] Running 2/2
⠿ Group strange-bartik Created 4.2s
⠿ strange-bartik Done 20.6s
strange-bartik
``
2020-07-13 11:23:06 +02:00
Djordje Lukic
f7d1b8d4bf
Merge pull request #387 from docker/fix_subscriptionID_param
...
Fixing subscription-id parameter not passed to backend...
2020-07-13 11:14:09 +02:00
Djordje Lukic
84dbd1467d
Move the struct for creating and aci context to azure package
2020-07-13 11:05:19 +02:00
Djordje Lukic
d8093d6c9c
Merge pull request #388 from docker/dependabot/go_modules/github.com/Azure/go-autorest/autorest-0.11.2
...
Bump github.com/Azure/go-autorest/autorest from 0.11.0 to 0.11.2
2020-07-13 10:12:14 +02:00
dependabot-preview[bot]
6002fcc6b9
Bump github.com/Azure/go-autorest/autorest from 0.11.0 to 0.11.2
...
Bumps [github.com/Azure/go-autorest/autorest](https://github.com/Azure/go-autorest ) from 0.11.0 to 0.11.2.
- [Release notes](https://github.com/Azure/go-autorest/releases )
- [Changelog](https://github.com/Azure/go-autorest/blob/master/CHANGELOG.md )
- [Commits](https://github.com/Azure/go-autorest/compare/autorest/v0.11.0...autorest/v0.11.2 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-07-10 21:24:57 +00:00
Guillaume Tardif
43b54ef75a
Also remove map[string]string for azure login (tenantId param)
2020-07-10 16:55:44 +02:00
Guillaume Tardif
97d408d25d
Replaced map[string] string by existing aciCreateOpts struct for context create
2020-07-10 16:39:09 +02:00
Guillaume Tardif
e2b0ee08ac
Fixed wrong error message
2020-07-10 15:45:49 +02:00
Guillaume Tardif
23a03c59aa
Change single container tag to `docker-single-container` ; added tag `docker-compose-application`. The compose tag is not used yet, can be useful for metrics, and maybe other things later on.
2020-07-10 15:45:49 +02:00
Guillaume Tardif
c36b64c10b
Fixing subscription-id parameter not passed to backend...
2020-07-10 15:27:41 +02:00
Guillaume Tardif
1fbdbbbbe3
Merge pull request #381 from docker/fix-logs-windows
...
Get the real width of the terminal
2020-07-10 13:06:07 +02:00
Guillaume Tardif
d21fd7b8cf
Do not fail (divide by zero) if terminal width is not set. Improved a bit the ACI e2e test, happy that it catches this error (this was going to break the log gRPC API)
2020-07-10 13:00:41 +02:00
Guillaume Tardif
eb5965c962
Merge pull request #380 from docker/remove-single-container-fixed-name
...
Relax single container name and replace by using tags
2020-07-10 11:32:16 +02:00
Guillaume Tardif
52c2d09eae
Merge pull request #376 from docker/logout
...
Implement azure logout
2020-07-10 09:48:39 +02:00
Djordje Lukic
26b4ece77d
Merge pull request #373 from docker/chore-guava
...
Update guava version to remove security warning
2020-07-09 15:02:39 +02:00
Ulysses Souza
b22118a861
Merge pull request #372 from docker/feat-non-interactive-exec
...
Allow non-interactive exec on ACI
2020-07-09 11:51:35 +02:00
Djordje Lukic
ef2d304762
Allow non-interactive exec on ACI
...
If the request is for a non-interactive exec we don't attach the stdin
when executing.
2020-07-09 11:47:22 +02:00
Djordje Lukic
ffd815da64
Merge pull request #375 from docker/feat-grpc-platform
...
Add the platform when returning a container over GRPC
2020-07-09 10:56:07 +02:00
Djordje Lukic
de385ba1ee
Merge pull request #377 from docker/dependabot/go_modules/github.com/AlecAivazis/survey/v2-2.0.8
...
Bump github.com/AlecAivazis/survey/v2 from 2.0.7 to 2.0.8
2020-07-09 10:55:44 +02:00
Djordje Lukic
e6c115dc17
Get the real width of the terminal
...
github.com/buger/goterm always returns 80 on windows...
2020-07-09 10:50:48 +02:00
Ulysses Souza
3b85582c38
Relax single container name
...
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
2020-07-09 10:40:50 +02:00
dependabot-preview[bot]
1fe5bf9b60
Bump github.com/AlecAivazis/survey/v2 from 2.0.7 to 2.0.8
...
Bumps [github.com/AlecAivazis/survey/v2](https://github.com/AlecAivazis/survey ) from 2.0.7 to 2.0.8.
- [Release notes](https://github.com/AlecAivazis/survey/releases )
- [Commits](https://github.com/AlecAivazis/survey/compare/v2.0.7...v2.0.8 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-07-08 21:25:13 +00:00
Guillaume Tardif
492ce96dd4
Implement azure logout
2020-07-08 17:48:10 +02:00
Guillaume Tardif
78cb0a87c7
Merge pull request #367 from docker/e2e_cleanup
...
E2e cleanup
2020-07-08 17:24:10 +02:00
Guillaume Tardif
0639aab22e
Allow single test run with make
2020-07-08 17:07:32 +02:00
Guillaume Tardif
7cd0b3c159
Separate ACI e2e tests, allowing to run a single one
2020-07-08 16:54:45 +02:00
Guillaume Tardif
a2ea2347ba
Remove It() in e2e tests, simplified step declaration. Nicer test output for all tests
2020-07-08 16:54:45 +02:00
Djordje Lukic
b146b2f391
Add the platform when returning a container over GRPC
2020-07-08 16:41:25 +02:00
Ulysses Souza
f62ab26714
Merge pull request #371 from docker/azure-volume-errors
...
Clean up volume parsing functions
2020-07-08 15:13:33 +02:00
Djordje Lukic
f5f01a8729
Update guava version to remove security warning
2020-07-08 15:07:12 +02:00
Christopher Crone
42a756f7d3
azure: Clean up volume parsing functions
...
Signed-off-by: Christopher Crone <christopher.crone@docker.com>
2020-07-08 13:40:40 +02:00
Chris Crone
b881f16085
Merge pull request #364 from chris-crone/set-version-docker
...
Set version when building with Docker
2020-07-08 11:51:00 +02:00
Chris Crone
33cbee03b8
Merge pull request #363 from chris-crone/bump-tools
...
Update Go and linter
2020-07-07 15:51:04 +02:00
Christopher Crone
539464ed3d
build: Set version when building with Docker
...
Signed-off-by: Christopher Crone <christopher.crone@docker.com>
2020-07-07 15:48:09 +02:00
Guillaume Tardif
1e3b90f4f8
Merge pull request #362 from docker/fix_aci_tests
...
Fix ACI e2e tests : do not use console if no tty option set in exec
2020-07-07 15:42:11 +02:00
Christopher Crone
878783d271
tools: Update Go and linter
...
Signed-off-by: Christopher Crone <christopher.crone@docker.com>
2020-07-07 15:29:48 +02:00
Guillaume Tardif
c5cd0f44f8
Fix ACI e2e tests : do not use console if no tty option set in exec
2020-07-07 14:05:25 +02:00
Guillaume Tardif
16acc36033
Merge pull request #356 from docker/fix-non-interactive
...
Add check on exec looking for arguments
2020-07-07 12:41:44 +02:00
Guillaume Tardif
de4ba33c60
Merge pull request #358 from docker/aci_env_variable
...
Aci env variable
2020-07-07 12:40:27 +02:00
Guillaume Tardif
f7daa70c87
Add ACI e2e test starting mysql with typical env vars
2020-07-07 12:22:56 +02:00
Guillaume Tardif
cb3ac513cc
Add run env variables support (KEY=AVLUE or KEY, will grab the process env value).
...
No support yet for env files
2020-07-07 11:39:35 +02:00
Guillaume Tardif
0c27fd6236
Support environment variables defined in compose file:
...
* KEY=VALUE
* KEY (no =VALUE) will fetch the process environment variable
envFile list is already parsed by compose-go and resolved to Environment key values no need to do anything for this.
2020-07-07 11:39:35 +02:00