tyler.durden
/
icinga2
mirror of https://github.com/Icinga/icinga2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
icinga2/test/icinga-checkresult.cpp

761 lines
27 KiB
C++
Raw Normal View History

Implement unit tests for state changes fixes #12530
2016-08-24 11:11:20 +02:00
/******************************************************************************
* Icinga 2 *
Change copyright header for 2018
2018-01-02 12:06:00 +01:00
* Copyright (C) 2012-2018 Icinga Development Team (https://www.icinga.com/) *
Implement unit tests for state changes fixes #12530
2016-08-24 11:11:20 +02:00
* *
* This program is free software; you can redistribute it and/or *
* modify it under the terms of the GNU General Public License *
* as published by the Free Software Foundation; either version 2 *
* of the License, or (at your option) any later version. *
* *
* This program is distributed in the hope that it will be useful, *
* but WITHOUT ANY WARRANTY; without even the implied warranty of *
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the *
* GNU General Public License for more details. *
* *
* You should have received a copy of the GNU General Public License *
* along with this program; if not, write to the Free Software Foundation *
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA. *
******************************************************************************/
#include "icinga/host.hpp"
Fix: Unit tests randomly crash after the tests have completed fixes #12610
2016-09-07 08:20:51 +02:00
#include <BoostTestTargetConfig.h>
Fixed missing include statement in unit tests refs #5613
2017-09-25 01:07:50 +02:00
#include <iostream>
Implement unit tests for state changes fixes #12530
2016-08-24 11:11:20 +02:00
using namespace icinga;
BOOST_AUTO_TEST_SUITE(icinga_checkresult)
static CheckResult::Ptr MakeCheckResult(ServiceState state)
{
CheckResult::Ptr cr = new CheckResult();
cr->SetState(state);
double now = Utility::GetTime();
cr->SetScheduleStart(now);
cr->SetScheduleEnd(now);
cr->SetExecutionStart(now);
cr->SetExecutionEnd(now);
return cr;
}
static void NotificationHandler(const Checkable::Ptr& checkable, NotificationType type)
{
std::cout << "Notification triggered: " << Notification::NotificationTypeToString(type) << std::endl;
checkable->SetExtension("requested_notifications", true);
checkable->SetExtension("notification_type", type);
}
static void CheckNotification(const Checkable::Ptr& checkable, bool expected, NotificationType type = NotificationRecovery)
{
BOOST_CHECK((expected && checkable->GetExtension("requested_notifications").ToBool()) || (!expected && !checkable->GetExtension("requested_notifications").ToBool()));
if (expected && checkable->GetExtension("requested_notifications").ToBool())
BOOST_CHECK(checkable->GetExtension("notification_type") == type);
checkable->SetExtension("requested_notifications", false);
}
Add more unit tests fixes #12530
2016-08-26 12:37:20 +02:00
BOOST_AUTO_TEST_CASE(host_1attempt)
{
Replace boost::bind/boost::function with std::bind/std::function
2017-11-21 11:52:55 +01:00
boost::signals2::connection c = Checkable::OnNotificationsRequested.connect(std::bind(&NotificationHandler, _1, _2));
Add more unit tests fixes #12530
2016-08-26 12:37:20 +02:00
Host::Ptr host = new Host();
Set Hosts/Services in tests as active where needed
2018-04-10 18:11:26 +02:00
host->SetActive(true);
Add more unit tests fixes #12530
2016-08-26 12:37:20 +02:00
host->SetMaxCheckAttempts(1);
host->Activate();
host->SetAuthority(true);
host->SetStateRaw(ServiceOK);
host->SetStateType(StateTypeHard);
std::cout << "Before first check result (ok, hard)" << std::endl;
BOOST_CHECK(host->GetState() == HostUp);
BOOST_CHECK(host->GetStateType() == StateTypeHard);
BOOST_CHECK(host->GetCheckAttempt() == 1);
CheckNotification(host, false);
std::cout << "First check result (unknown)" << std::endl;
host->ProcessCheckResult(MakeCheckResult(ServiceUnknown));
BOOST_CHECK(host->GetState() == HostDown);
BOOST_CHECK(host->GetStateType() == StateTypeHard);
BOOST_CHECK(host->GetCheckAttempt() == 1);
CheckNotification(host, true, NotificationProblem);
std::cout << "Second check result (ok)" << std::endl;
host->ProcessCheckResult(MakeCheckResult(ServiceOK));
BOOST_CHECK(host->GetState() == HostUp);
BOOST_CHECK(host->GetStateType() == StateTypeHard);
BOOST_CHECK(host->GetCheckAttempt() == 1);
CheckNotification(host, true, NotificationRecovery);
std::cout << "Third check result (critical)" << std::endl;
host->ProcessCheckResult(MakeCheckResult(ServiceCritical));
BOOST_CHECK(host->GetState() == HostDown);
BOOST_CHECK(host->GetStateType() == StateTypeHard);
BOOST_CHECK(host->GetCheckAttempt() == 1);
CheckNotification(host, true, NotificationProblem);
std::cout << "Fourth check result (ok)" << std::endl;
host->ProcessCheckResult(MakeCheckResult(ServiceOK));
BOOST_CHECK(host->GetState() == HostUp);
BOOST_CHECK(host->GetStateType() == StateTypeHard);
BOOST_CHECK(host->GetCheckAttempt() == 1);
CheckNotification(host, true, NotificationRecovery);
c.disconnect();
}
BOOST_AUTO_TEST_CASE(host_2attempts)
{
Replace boost::bind/boost::function with std::bind/std::function
2017-11-21 11:52:55 +01:00
boost::signals2::connection c = Checkable::OnNotificationsRequested.connect(std::bind(&NotificationHandler, _1, _2));
Add more unit tests fixes #12530
2016-08-26 12:37:20 +02:00
Host::Ptr host = new Host();
Set Hosts/Services in tests as active where needed
2018-04-10 18:11:26 +02:00
host->SetActive(true);
Add more unit tests fixes #12530
2016-08-26 12:37:20 +02:00
host->SetMaxCheckAttempts(2);
host->Activate();
host->SetAuthority(true);
host->SetStateRaw(ServiceOK);
host->SetStateType(StateTypeHard);
std::cout << "Before first check result (ok, hard)" << std::endl;
BOOST_CHECK(host->GetState() == HostUp);
BOOST_CHECK(host->GetStateType() == StateTypeHard);
BOOST_CHECK(host->GetCheckAttempt() == 1);
CheckNotification(host, false);
std::cout << "First check result (unknown)" << std::endl;
host->ProcessCheckResult(MakeCheckResult(ServiceUnknown));
BOOST_CHECK(host->GetState() == HostDown);
BOOST_CHECK(host->GetStateType() == StateTypeSoft);
BOOST_CHECK(host->GetCheckAttempt() == 1);
CheckNotification(host, false);
std::cout << "Second check result (critical)" << std::endl;
host->ProcessCheckResult(MakeCheckResult(ServiceCritical));
BOOST_CHECK(host->GetState() == HostDown);
BOOST_CHECK(host->GetStateType() == StateTypeHard);
BOOST_CHECK(host->GetCheckAttempt() == 1);
CheckNotification(host, true, NotificationProblem);
std::cout << "Third check result (ok)" << std::endl;
host->ProcessCheckResult(MakeCheckResult(ServiceOK));
BOOST_CHECK(host->GetState() == HostUp);
BOOST_CHECK(host->GetStateType() == StateTypeHard);
BOOST_CHECK(host->GetCheckAttempt() == 1);
CheckNotification(host, true, NotificationRecovery);
std::cout << "Fourth check result (critical)" << std::endl;
host->ProcessCheckResult(MakeCheckResult(ServiceCritical));
BOOST_CHECK(host->GetState() == HostDown);
BOOST_CHECK(host->GetStateType() == StateTypeSoft);
BOOST_CHECK(host->GetCheckAttempt() == 1);
CheckNotification(host, false);
std::cout << "Fifth check result (ok)" << std::endl;
host->ProcessCheckResult(MakeCheckResult(ServiceOK));
BOOST_CHECK(host->GetState() == HostUp);
BOOST_CHECK(host->GetStateType() == StateTypeHard);
BOOST_CHECK(host->GetCheckAttempt() == 1);
CheckNotification(host, false);
c.disconnect();
}
BOOST_AUTO_TEST_CASE(host_3attempts)
Implement unit tests for state changes fixes #12530
2016-08-24 11:11:20 +02:00
{
Replace boost::bind/boost::function with std::bind/std::function
2017-11-21 11:52:55 +01:00
boost::signals2::connection c = Checkable::OnNotificationsRequested.connect(std::bind(&NotificationHandler, _1, _2));
Implement unit tests for state changes fixes #12530
2016-08-24 11:11:20 +02:00
Host::Ptr host = new Host();
Set Hosts/Services in tests as active where needed
2018-04-10 18:11:26 +02:00
host->SetActive(true);
Implement unit tests for state changes fixes #12530
2016-08-24 11:11:20 +02:00
host->SetMaxCheckAttempts(3);
host->Activate();
host->SetAuthority(true);
host->SetStateRaw(ServiceOK);
host->SetStateType(StateTypeHard);
std::cout << "Before first check result (ok, hard)" << std::endl;
BOOST_CHECK(host->GetState() == HostUp);
BOOST_CHECK(host->GetStateType() == StateTypeHard);
BOOST_CHECK(host->GetCheckAttempt() == 1);
CheckNotification(host, false);
std::cout << "First check result (unknown)" << std::endl;
host->ProcessCheckResult(MakeCheckResult(ServiceUnknown));
BOOST_CHECK(host->GetState() == HostDown);
BOOST_CHECK(host->GetStateType() == StateTypeSoft);
BOOST_CHECK(host->GetCheckAttempt() == 1);
CheckNotification(host, false);
std::cout << "Second check result (critical)" << std::endl;
host->ProcessCheckResult(MakeCheckResult(ServiceCritical));
BOOST_CHECK(host->GetState() == HostDown);
BOOST_CHECK(host->GetStateType() == StateTypeSoft);
BOOST_CHECK(host->GetCheckAttempt() == 2);
CheckNotification(host, false);
std::cout << "Third check result (critical)" << std::endl;
host->ProcessCheckResult(MakeCheckResult(ServiceCritical));
BOOST_CHECK(host->GetState() == HostDown);
BOOST_CHECK(host->GetStateType() == StateTypeHard);
BOOST_CHECK(host->GetCheckAttempt() == 1);
CheckNotification(host, true, NotificationProblem);
std::cout << "Fourth check result (ok)" << std::endl;
host->ProcessCheckResult(MakeCheckResult(ServiceOK));
BOOST_CHECK(host->GetState() == HostUp);
BOOST_CHECK(host->GetStateType() == StateTypeHard);
BOOST_CHECK(host->GetCheckAttempt() == 1);
CheckNotification(host, true, NotificationRecovery);
std::cout << "Fifth check result (critical)" << std::endl;
host->ProcessCheckResult(MakeCheckResult(ServiceCritical));
BOOST_CHECK(host->GetState() == HostDown);
BOOST_CHECK(host->GetStateType() == StateTypeSoft);
BOOST_CHECK(host->GetCheckAttempt() == 1);
CheckNotification(host, false);
std::cout << "Sixth check result (ok)" << std::endl;
host->ProcessCheckResult(MakeCheckResult(ServiceOK));
BOOST_CHECK(host->GetState() == HostUp);
BOOST_CHECK(host->GetStateType() == StateTypeHard);
BOOST_CHECK(host->GetCheckAttempt() == 1);
CheckNotification(host, false);
c.disconnect();
}
Add more unit tests fixes #12530
2016-08-26 12:37:20 +02:00
BOOST_AUTO_TEST_CASE(service_1attempt)
{
Replace boost::bind/boost::function with std::bind/std::function
2017-11-21 11:52:55 +01:00
boost::signals2::connection c = Checkable::OnNotificationsRequested.connect(std::bind(&NotificationHandler, _1, _2));
Add more unit tests fixes #12530
2016-08-26 12:37:20 +02:00
Service::Ptr service = new Service();
Set Hosts/Services in tests as active where needed
2018-04-10 18:11:26 +02:00
service->SetActive(true);
Add more unit tests fixes #12530
2016-08-26 12:37:20 +02:00
service->SetMaxCheckAttempts(1);
service->Activate();
service->SetAuthority(true);
service->SetStateRaw(ServiceOK);
service->SetStateType(StateTypeHard);
std::cout << "Before first check result (ok, hard)" << std::endl;
BOOST_CHECK(service->GetState() == ServiceOK);
BOOST_CHECK(service->GetStateType() == StateTypeHard);
BOOST_CHECK(service->GetCheckAttempt() == 1);
CheckNotification(service, false);
std::cout << "First check result (unknown)" << std::endl;
service->ProcessCheckResult(MakeCheckResult(ServiceUnknown));
BOOST_CHECK(service->GetState() == ServiceUnknown);
BOOST_CHECK(service->GetStateType() == StateTypeHard);
BOOST_CHECK(service->GetCheckAttempt() == 1);
CheckNotification(service, true, NotificationProblem);
std::cout << "Second check result (ok)" << std::endl;
service->ProcessCheckResult(MakeCheckResult(ServiceOK));
BOOST_CHECK(service->GetState() == ServiceOK);
BOOST_CHECK(service->GetStateType() == StateTypeHard);
BOOST_CHECK(service->GetCheckAttempt() == 1);
CheckNotification(service, true, NotificationRecovery);
std::cout << "Third check result (critical)" << std::endl;
service->ProcessCheckResult(MakeCheckResult(ServiceCritical));
BOOST_CHECK(service->GetState() == ServiceCritical);
BOOST_CHECK(service->GetStateType() == StateTypeHard);
BOOST_CHECK(service->GetCheckAttempt() == 1);
CheckNotification(service, true, NotificationProblem);
std::cout << "Fourth check result (ok)" << std::endl;
service->ProcessCheckResult(MakeCheckResult(ServiceOK));
BOOST_CHECK(service->GetState() == ServiceOK);
BOOST_CHECK(service->GetStateType() == StateTypeHard);
BOOST_CHECK(service->GetCheckAttempt() == 1);
CheckNotification(service, true, NotificationRecovery);
c.disconnect();
}
BOOST_AUTO_TEST_CASE(service_2attempts)
{
Replace boost::bind/boost::function with std::bind/std::function
2017-11-21 11:52:55 +01:00
boost::signals2::connection c = Checkable::OnNotificationsRequested.connect(std::bind(&NotificationHandler, _1, _2));
Add more unit tests fixes #12530
2016-08-26 12:37:20 +02:00
Service::Ptr service = new Service();
Set Hosts/Services in tests as active where needed
2018-04-10 18:11:26 +02:00
service->SetActive(true);
Add more unit tests fixes #12530
2016-08-26 12:37:20 +02:00
service->SetMaxCheckAttempts(2);
service->Activate();
service->SetAuthority(true);
service->SetStateRaw(ServiceOK);
service->SetStateType(StateTypeHard);
std::cout << "Before first check result (ok, hard)" << std::endl;
BOOST_CHECK(service->GetState() == ServiceOK);
BOOST_CHECK(service->GetStateType() == StateTypeHard);
BOOST_CHECK(service->GetCheckAttempt() == 1);
CheckNotification(service, false);
std::cout << "First check result (unknown)" << std::endl;
service->ProcessCheckResult(MakeCheckResult(ServiceUnknown));
BOOST_CHECK(service->GetState() == ServiceUnknown);
BOOST_CHECK(service->GetStateType() == StateTypeSoft);
BOOST_CHECK(service->GetCheckAttempt() == 1);
CheckNotification(service, false);
std::cout << "Second check result (critical)" << std::endl;
service->ProcessCheckResult(MakeCheckResult(ServiceCritical));
BOOST_CHECK(service->GetState() == ServiceCritical);
BOOST_CHECK(service->GetStateType() == StateTypeHard);
BOOST_CHECK(service->GetCheckAttempt() == 1);
CheckNotification(service, true, NotificationProblem);
std::cout << "Third check result (ok)" << std::endl;
service->ProcessCheckResult(MakeCheckResult(ServiceOK));
BOOST_CHECK(service->GetState() == ServiceOK);
BOOST_CHECK(service->GetStateType() == StateTypeHard);
BOOST_CHECK(service->GetCheckAttempt() == 1);
CheckNotification(service, true, NotificationRecovery);
std::cout << "Fourth check result (critical)" << std::endl;
service->ProcessCheckResult(MakeCheckResult(ServiceCritical));
BOOST_CHECK(service->GetState() == ServiceCritical);
BOOST_CHECK(service->GetStateType() == StateTypeSoft);
BOOST_CHECK(service->GetCheckAttempt() == 1);
CheckNotification(service, false);
std::cout << "Fifth check result (ok)" << std::endl;
service->ProcessCheckResult(MakeCheckResult(ServiceOK));
BOOST_CHECK(service->GetState() == ServiceOK);
BOOST_CHECK(service->GetStateType() == StateTypeHard);
BOOST_CHECK(service->GetCheckAttempt() == 1);
CheckNotification(service, false);
c.disconnect();
}
BOOST_AUTO_TEST_CASE(service_3attempts)
Implement unit tests for state changes fixes #12530
2016-08-24 11:11:20 +02:00
{
Replace boost::bind/boost::function with std::bind/std::function
2017-11-21 11:52:55 +01:00
boost::signals2::connection c = Checkable::OnNotificationsRequested.connect(std::bind(&NotificationHandler, _1, _2));
Implement unit tests for state changes fixes #12530
2016-08-24 11:11:20 +02:00
Service::Ptr service = new Service();
Set Hosts/Services in tests as active where needed
2018-04-10 18:11:26 +02:00
service->SetActive(true);
Implement unit tests for state changes fixes #12530
2016-08-24 11:11:20 +02:00
service->SetMaxCheckAttempts(3);
service->Activate();
service->SetAuthority(true);
service->SetStateRaw(ServiceOK);
service->SetStateType(StateTypeHard);
std::cout << "Before first check result (ok, hard)" << std::endl;
BOOST_CHECK(service->GetState() == ServiceOK);
BOOST_CHECK(service->GetStateType() == StateTypeHard);
BOOST_CHECK(service->GetCheckAttempt() == 1);
CheckNotification(service, false);
std::cout << "First check result (unknown)" << std::endl;
service->ProcessCheckResult(MakeCheckResult(ServiceUnknown));
BOOST_CHECK(service->GetState() == ServiceUnknown);
BOOST_CHECK(service->GetStateType() == StateTypeSoft);
BOOST_CHECK(service->GetCheckAttempt() == 1);
CheckNotification(service, false);
std::cout << "Second check result (critical)" << std::endl;
service->ProcessCheckResult(MakeCheckResult(ServiceCritical));
BOOST_CHECK(service->GetState() == ServiceCritical);
BOOST_CHECK(service->GetStateType() == StateTypeSoft);
BOOST_CHECK(service->GetCheckAttempt() == 2);
CheckNotification(service, false);
std::cout << "Third check result (critical)" << std::endl;
service->ProcessCheckResult(MakeCheckResult(ServiceCritical));
BOOST_CHECK(service->GetState() == ServiceCritical);
BOOST_CHECK(service->GetStateType() == StateTypeHard);
BOOST_CHECK(service->GetCheckAttempt() == 1);
CheckNotification(service, true, NotificationProblem);
std::cout << "Fourth check result (ok)" << std::endl;
service->ProcessCheckResult(MakeCheckResult(ServiceOK));
BOOST_CHECK(service->GetState() == ServiceOK);
BOOST_CHECK(service->GetStateType() == StateTypeHard);
BOOST_CHECK(service->GetCheckAttempt() == 1);
CheckNotification(service, true, NotificationRecovery);
std::cout << "Fifth check result (critical)" << std::endl;
service->ProcessCheckResult(MakeCheckResult(ServiceCritical));
BOOST_CHECK(service->GetState() == ServiceCritical);
BOOST_CHECK(service->GetStateType() == StateTypeSoft);
BOOST_CHECK(service->GetCheckAttempt() == 1);
CheckNotification(service, false);
std::cout << "Sixth check result (ok)" << std::endl;
service->ProcessCheckResult(MakeCheckResult(ServiceOK));
BOOST_CHECK(service->GetState() == ServiceOK);
BOOST_CHECK(service->GetStateType() == StateTypeHard);
BOOST_CHECK(service->GetCheckAttempt() == 1);
CheckNotification(service, false);
c.disconnect();
}
Fix Flapping{Start,End} notifications in SOFT states or downtimes fixes #12560 fixes #12892
2016-11-10 14:02:02 +01:00
BOOST_AUTO_TEST_CASE(host_flapping_notification)
{
#ifndef I2_DEBUG
BOOST_WARN_MESSAGE(false, "This test can only be run in a debug build!");
#else /* I2_DEBUG */
Replace boost::bind/boost::function with std::bind/std::function
2017-11-21 11:52:55 +01:00
boost::signals2::connection c = Checkable::OnNotificationsRequested.connect(std::bind(&NotificationHandler, _1, _2));
Fix Flapping{Start,End} notifications in SOFT states or downtimes fixes #12560 fixes #12892
2016-11-10 14:02:02 +01:00
int timeStepInterval = 60;
Host::Ptr host = new Host();
Set Hosts/Services in tests as active where needed
2018-04-10 18:11:26 +02:00
host->SetActive(true);
Fix Flapping{Start,End} notifications in SOFT states or downtimes fixes #12560 fixes #12892
2016-11-10 14:02:02 +01:00
host->Activate();
host->SetAuthority(true);
host->SetStateRaw(ServiceOK);
host->SetStateType(StateTypeHard);
host->SetEnableFlapping(true);
/* Initialize start time */
Utility::SetTime(0);
std::cout << "Before first check result (ok, hard)" << std::endl;
BOOST_CHECK(host->GetState() == HostUp);
BOOST_CHECK(host->GetStateType() == StateTypeHard);
BOOST_CHECK(host->GetCheckAttempt() == 1);
Utility::IncrementTime(timeStepInterval);
std::cout << "Inserting flapping check results" << std::endl;
Fix flapping Re-implement flapping following the 'old way' of just observing the last 20 stage changes. refs #4982
2017-10-19 17:32:52 +02:00
for (int i = 0; i < 10; i++) {
Fix Flapping{Start,End} notifications in SOFT states or downtimes fixes #12560 fixes #12892
2016-11-10 14:02:02 +01:00
ServiceState state = (i % 2 == 0 ? ServiceOK : ServiceCritical);
host->ProcessCheckResult(MakeCheckResult(state));
Utility::IncrementTime(timeStepInterval);
}
BOOST_CHECK(host->IsFlapping() == true);
Fix flapping Re-implement flapping following the 'old way' of just observing the last 20 stage changes. refs #4982
2017-10-19 17:32:52 +02:00
CheckNotification(host, true, NotificationFlappingStart);
std::cout << "Now calm down..." << std::endl;
for (int i = 0; i < 20; i++) {
host->ProcessCheckResult(MakeCheckResult(ServiceOK));
Utility::IncrementTime(timeStepInterval);
}
CheckNotification(host, true, NotificationFlappingEnd);
Fix Flapping{Start,End} notifications in SOFT states or downtimes fixes #12560 fixes #12892
2016-11-10 14:02:02 +01:00
c.disconnect();
#endif /* I2_DEBUG */
}
BOOST_AUTO_TEST_CASE(service_flapping_notification)
{
#ifndef I2_DEBUG
BOOST_WARN_MESSAGE(false, "This test can only be run in a debug build!");
#else /* I2_DEBUG */
Replace boost::bind/boost::function with std::bind/std::function
2017-11-21 11:52:55 +01:00
boost::signals2::connection c = Checkable::OnNotificationsRequested.connect(std::bind(&NotificationHandler, _1, _2));
Fix Flapping{Start,End} notifications in SOFT states or downtimes fixes #12560 fixes #12892
2016-11-10 14:02:02 +01:00
int timeStepInterval = 60;
Add additional tests for flapping refs #4982
2017-11-02 14:36:16 +01:00
Service::Ptr service = new Service();
Set Hosts/Services in tests as active where needed
2018-04-10 18:11:26 +02:00
service->SetActive(true);
Fix Flapping{Start,End} notifications in SOFT states or downtimes fixes #12560 fixes #12892
2016-11-10 14:02:02 +01:00
service->Activate();
service->SetAuthority(true);
service->SetStateRaw(ServiceOK);
service->SetStateType(StateTypeHard);
service->SetEnableFlapping(true);
/* Initialize start time */
Utility::SetTime(0);
std::cout << "Before first check result (ok, hard)" << std::endl;
Add additional tests for flapping refs #4982
2017-11-02 14:36:16 +01:00
BOOST_CHECK(service->GetState() == ServiceOK);
Fix Flapping{Start,End} notifications in SOFT states or downtimes fixes #12560 fixes #12892
2016-11-10 14:02:02 +01:00
BOOST_CHECK(service->GetStateType() == StateTypeHard);
BOOST_CHECK(service->GetCheckAttempt() == 1);
Utility::IncrementTime(timeStepInterval);
std::cout << "Inserting flapping check results" << std::endl;
Fix flapping Re-implement flapping following the 'old way' of just observing the last 20 stage changes. refs #4982
2017-10-19 17:32:52 +02:00
for (int i = 0; i < 10; i++) {
Fix Flapping{Start,End} notifications in SOFT states or downtimes fixes #12560 fixes #12892
2016-11-10 14:02:02 +01:00
ServiceState state = (i % 2 == 0 ? ServiceOK : ServiceCritical);
service->ProcessCheckResult(MakeCheckResult(state));
Utility::IncrementTime(timeStepInterval);
}
BOOST_CHECK(service->IsFlapping() == true);
Fix flapping Re-implement flapping following the 'old way' of just observing the last 20 stage changes. refs #4982
2017-10-19 17:32:52 +02:00
CheckNotification(service, true, NotificationFlappingStart);
Add additional tests for flapping refs #4982
2017-11-02 14:36:16 +01:00
Fix flapping Re-implement flapping following the 'old way' of just observing the last 20 stage changes. refs #4982
2017-10-19 17:32:52 +02:00
std::cout << "Now calm down..." << std::endl;
for (int i = 0; i < 20; i++) {
service->ProcessCheckResult(MakeCheckResult(ServiceOK));
Utility::IncrementTime(timeStepInterval);
}
CheckNotification(service, true, NotificationFlappingEnd);
Fix Flapping{Start,End} notifications in SOFT states or downtimes fixes #12560 fixes #12892
2016-11-10 14:02:02 +01:00
c.disconnect();
Add additional tests for flapping refs #4982
2017-11-02 14:36:16 +01:00
#endif /* I2_DEBUG */
}
BOOST_AUTO_TEST_CASE(service_flapping_problem_notifications)
{
#ifndef I2_DEBUG
BOOST_WARN_MESSAGE(false, "This test can only be run in a debug build!");
#else /* I2_DEBUG */
Replace boost::bind/boost::function with std::bind/std::function
2017-11-21 11:52:55 +01:00
boost::signals2::connection c = Checkable::OnNotificationsRequested.connect(std::bind(&NotificationHandler, _1, _2));
Add additional tests for flapping refs #4982
2017-11-02 14:36:16 +01:00
int timeStepInterval = 60;
Service::Ptr service = new Service();
service->Activate();
service->SetAuthority(true);
service->SetStateRaw(ServiceOK);
service->SetStateType(StateTypeHard);
service->SetEnableFlapping(true);
service->SetMaxCheckAttempts(3);
/* Initialize start time */
Utility::SetTime(0);
std::cout << "Before first check result (ok, hard)" << std::endl;
BOOST_CHECK(service->GetState() == ServiceOK);
BOOST_CHECK(service->GetStateType() == StateTypeHard);
BOOST_CHECK(service->GetCheckAttempt() == 1);
Utility::IncrementTime(timeStepInterval);
std::cout << "Inserting flapping check results" << std::endl;
for (int i = 0; i < 10; i++) {
ServiceState state = (i % 2 == 0 ? ServiceOK : ServiceCritical);
service->ProcessCheckResult(MakeCheckResult(state));
Utility::IncrementTime(timeStepInterval);
}
BOOST_CHECK(service->IsFlapping() == true);
CheckNotification(service, true, NotificationFlappingStart);
//Insert enough check results to get into hard problem state but staying flapping
service->ProcessCheckResult(MakeCheckResult(ServiceCritical));
Utility::IncrementTime(timeStepInterval);
service->ProcessCheckResult(MakeCheckResult(ServiceCritical));
Utility::IncrementTime(timeStepInterval);
service->ProcessCheckResult(MakeCheckResult(ServiceCritical));
Utility::IncrementTime(timeStepInterval);
BOOST_CHECK(service->IsFlapping() == true);
BOOST_CHECK(service->GetStateType() == StateTypeHard);
BOOST_CHECK(service->GetState() == ServiceCritical);
CheckNotification(service, false, NotificationProblem);
// Calm down
while (service->IsFlapping()) {
service->ProcessCheckResult(MakeCheckResult(ServiceCritical));
Utility::IncrementTime(timeStepInterval);
}
CheckNotification(service, true, NotificationFlappingEnd);
/* Intended behaviour is a Problem notification being sent as well, but there are is a Problem:
* We don't know whether the Object was Critical before we started flapping and sent out a Notification.
* A notification will not be sent, no matter how many criticals follow.
*
* service->ProcessCheckResult(MakeCheckResult(ServiceCritical));
* CheckNotification(service, true, NotificationProblem);
* ^ This fails, no notification will be sent
*
* There is also a different issue, when we receive a OK check result, a Recovery Notification will be sent
* since the service went from hard critical into soft ok. Yet there is no fitting critical notification.
* This should not happen:
*
* service->ProcessCheckResult(MakeCheckResult(ServiceOK));
* CheckNotification(service, false, NotificationRecovery);
* ^ This fails, recovery is sent
*/
BOOST_CHECK(service->IsFlapping() == false);
BOOST_CHECK(service->GetStateType() == StateTypeHard);
BOOST_CHECK(service->GetState() == ServiceCritical);
// Known failure, see #5713
// CheckNotification(service, true, NotificationProblem);
service->ProcessCheckResult(MakeCheckResult(ServiceOK));
Utility::IncrementTime(timeStepInterval);
// Known failure, see #5713
// CheckNotification(service, true, NotificationRecovery);
c.disconnect();
#endif /* I2_DEBUG */
}
BOOST_AUTO_TEST_CASE(service_flapping_ok_into_bad)
{
#ifndef I2_DEBUG
BOOST_WARN_MESSAGE(false, "This test can only be run in a debug build!");
#else /* I2_DEBUG */
Replace boost::bind/boost::function with std::bind/std::function
2017-11-21 11:52:55 +01:00
boost::signals2::connection c = Checkable::OnNotificationsRequested.connect(std::bind(&NotificationHandler, _1, _2));
Add additional tests for flapping refs #4982
2017-11-02 14:36:16 +01:00
int timeStepInterval = 60;
Service::Ptr service = new Service();
service->Activate();
service->SetAuthority(true);
service->SetStateRaw(ServiceOK);
service->SetStateType(StateTypeHard);
service->SetEnableFlapping(true);
service->SetMaxCheckAttempts(3);
/* Initialize start time */
Utility::SetTime(0);
std::cout << "Before first check result (ok, hard)" << std::endl;
BOOST_CHECK(service->GetState() == ServiceOK);
BOOST_CHECK(service->GetStateType() == StateTypeHard);
BOOST_CHECK(service->GetCheckAttempt() == 1);
Utility::IncrementTime(timeStepInterval);
std::cout << "Inserting flapping check results" << std::endl;
for (int i = 0; i < 10; i++) {
ServiceState state = (i % 2 == 0 ? ServiceOK : ServiceCritical);
service->ProcessCheckResult(MakeCheckResult(state));
Utility::IncrementTime(timeStepInterval);
}
BOOST_CHECK(service->IsFlapping() == true);
CheckNotification(service, true, NotificationFlappingStart);
//Insert enough check results to get into hard problem state but staying flapping
service->ProcessCheckResult(MakeCheckResult(ServiceCritical));
Utility::IncrementTime(timeStepInterval);
service->ProcessCheckResult(MakeCheckResult(ServiceCritical));
Utility::IncrementTime(timeStepInterval);
service->ProcessCheckResult(MakeCheckResult(ServiceCritical));
Utility::IncrementTime(timeStepInterval);
BOOST_CHECK(service->IsFlapping() == true);
BOOST_CHECK(service->GetStateType() == StateTypeHard);
BOOST_CHECK(service->GetState() == ServiceCritical);
CheckNotification(service, false, NotificationProblem);
// Calm down
while (service->IsFlapping()) {
service->ProcessCheckResult(MakeCheckResult(ServiceCritical));
Utility::IncrementTime(timeStepInterval);
}
CheckNotification(service, true, NotificationFlappingEnd);
service->ProcessCheckResult(MakeCheckResult(ServiceCritical));
Utility::IncrementTime(timeStepInterval);
BOOST_CHECK(service->IsFlapping() == false);
BOOST_CHECK(service->GetStateType() == StateTypeHard);
BOOST_CHECK(service->GetState() == ServiceCritical);
// We expect a problem notification here
// Known failure, see #5713
// CheckNotification(service, true, NotificationProblem);
c.disconnect();
#endif /* I2_DEBUG */
}
BOOST_AUTO_TEST_CASE(service_flapping_ok_over_bad_into_ok)
{
#ifndef I2_DEBUG
BOOST_WARN_MESSAGE(false, "This test can only be run in a debug build!");
#else /* I2_DEBUG */
Replace boost::bind/boost::function with std::bind/std::function
2017-11-21 11:52:55 +01:00
boost::signals2::connection c = Checkable::OnNotificationsRequested.connect(std::bind(&NotificationHandler, _1, _2));
Add additional tests for flapping refs #4982
2017-11-02 14:36:16 +01:00
int timeStepInterval = 60;
Service::Ptr service = new Service();
service->Activate();
service->SetAuthority(true);
service->SetStateRaw(ServiceOK);
service->SetStateType(StateTypeHard);
service->SetEnableFlapping(true);
service->SetMaxCheckAttempts(3);
/* Initialize start time */
Utility::SetTime(0);
std::cout << "Before first check result (ok, hard)" << std::endl;
BOOST_CHECK(service->GetState() == ServiceOK);
BOOST_CHECK(service->GetStateType() == StateTypeHard);
BOOST_CHECK(service->GetCheckAttempt() == 1);
Utility::IncrementTime(timeStepInterval);
std::cout << "Inserting flapping check results" << std::endl;
for (int i = 0; i < 10; i++) {
ServiceState state = (i % 2 == 0 ? ServiceOK : ServiceCritical);
service->ProcessCheckResult(MakeCheckResult(state));
Utility::IncrementTime(timeStepInterval);
}
BOOST_CHECK(service->IsFlapping() == true);
CheckNotification(service, true, NotificationFlappingStart);
//Insert enough check results to get into hard problem state but staying flapping
service->ProcessCheckResult(MakeCheckResult(ServiceCritical));
Utility::IncrementTime(timeStepInterval);
service->ProcessCheckResult(MakeCheckResult(ServiceCritical));
Utility::IncrementTime(timeStepInterval);
service->ProcessCheckResult(MakeCheckResult(ServiceCritical));
Utility::IncrementTime(timeStepInterval);
BOOST_CHECK(service->IsFlapping() == true);
BOOST_CHECK(service->GetStateType() == StateTypeHard);
BOOST_CHECK(service->GetState() == ServiceCritical);
CheckNotification(service, false, NotificationProblem);
// Calm down
while (service->IsFlapping()) {
service->ProcessCheckResult(MakeCheckResult(ServiceCritical));
Utility::IncrementTime(timeStepInterval);
}
CheckNotification(service, true, NotificationFlappingEnd);
service->ProcessCheckResult(MakeCheckResult(ServiceOK));
Utility::IncrementTime(timeStepInterval);
BOOST_CHECK(service->IsFlapping() == false);
BOOST_CHECK(service->GetStateType() == StateTypeHard);
BOOST_CHECK(service->GetState() == ServiceOK);
// There should be no recovery
// Known failure, see #5713
// CheckNotification(service, false, NotificationRecovery);
c.disconnect();
Fix Flapping{Start,End} notifications in SOFT states or downtimes fixes #12560 fixes #12892
2016-11-10 14:02:02 +01:00
#endif /* I2_DEBUG */
}
Implement unit tests for state changes fixes #12530
2016-08-24 11:11:20 +02:00
BOOST_AUTO_TEST_SUITE_END()