12038 Commits

Author SHA1 Message Date
Julian Brost
3b0bcb7d84 Only handle event::SetSuppressed{Notifications,NotificationTypes} within the local zone
Note that even when passing `nullptr` as target zone to `RelayMessage()`, the
cluster message will still be sent to the parent zone. These incoming messages
will now be rejected by the parent nodes. At the moment, there's no way to only
send within the local zone.
2021-03-25 14:10:13 +01:00
Noah Hilverling
2cb995e937
Merge pull request from GHSA-pcmr-2p2f-r7j6
Verify certificates against CRL before renewing them (2.12)
v2.12.3
2020-12-15 12:30:19 +01:00
Noah Hilverling
a995dc0577
Merge pull request #8542 from Icinga/bugfix/openssl-error-buffer-2.12
Use proper buffer size for OpenSSL error messages (support/2.12)
2020-12-15 12:13:56 +01:00
Noah Hilverling
61c78311b7 Add security fix to CHANGELOG 2020-12-15 10:49:01 +01:00
Julian Brost
abbd7d5494 Allow specifying a CRL in icinga2 pki verify 2020-12-15 10:33:38 +01:00
Julian Brost
cae22a89da Verify certificates against CRL before renewing them
When a CRL is specified in the ApiListener configuration, Icinga 2 only
used it when connections were established so far, but not when a
certificate is requested. This allows a node to automatically renew a
revoked certificate if it meets the other conditions for auto-renewal
(issued before 2017 or expires in less than 30 days).
2020-12-15 10:33:38 +01:00
Alexander Aleksandrovič Klimov
3b862fe9ee
Merge pull request #8565 from Icinga/feature/changelog-2.12.3
Add 2.12.3 changelog & change VERSION file
2020-12-15 10:30:15 +01:00
Noah Hilverling
4db8654bf8 Add 2.12.3 changelog & change VERSION file 2020-12-15 10:28:20 +01:00
Julian Brost
c868010884 Use ERR_error_string_n() instead of ERR_error_string()
Explicitly pass the actual length of the buffer to avoid overflows.
2020-12-15 08:29:37 +01:00
Julian Brost
1f945add50 Increase size of buffer for OpenSSL error messages
According to man 3 ERR_error_string, "buf must be at least 256 bytes
long", therefore increase the buffer size to 256 everywhere.
2020-12-15 08:29:37 +01:00
Julian Brost
159ccced65 Remove std::string to_string(const errinfo_openssl_error& e)
The function was never used and it's implementation contains a bug where
a buffer of too small size is used as a paramter to ERR_error_string.
According to the `man 3 ERR_error_info`, the buffer has to be at least
256 bytes in size.

Also the function seems of limited use as it allows to output the tag
object used with additional error information for exceptions in Boost.
However, you boost::get_error_info<>() just returns the value type but
not the full tag object from the exception.
2020-12-15 08:29:37 +01:00
Noah Hilverling
c89636fcaa
Merge pull request #8549 from Icinga/bugfix/unable-to-toggle-notifications-from-icingaweb2-8533-2.12
Fix runtime config updates not working for objects without zone
2020-12-14 13:28:51 +01:00
Alexander Aleksandrovič Klimov
2ed72c0947
Merge pull request #8506 from Icinga/bugfix/children-recover-too-late
On recovery: re-check children
2020-12-11 15:41:49 +01:00
Noah Hilverling
11486faeba Fix runtime config updates not working for objects without zone
refs #8533
2020-12-11 09:36:39 +01:00
Noah Hilverling
1e71ab8819
Merge pull request #8551 from Icinga/feature/also-drop-distributions-in-2.12.x
Also drop distributions on support/2.12
2020-12-11 09:23:08 +01:00
Alexander A. Klimov
cc8ad5172c GitHub actions: drop Fedora 30 2020-12-10 17:26:18 +01:00
Alexander A. Klimov
1aa2b25b25 GitHub actions: drop CentOS 6 2020-12-10 17:26:03 +01:00
Alexander A. Klimov
3e0176b02b GitHub actions: drop Fedora 29 2020-12-10 17:25:57 +01:00
Alexander A. Klimov
340c50d8a8 GitHub actions: drop openSUSE 15.0 2020-12-10 17:25:49 +01:00
Alexander A. Klimov
a803be65fa GitHub actions: drop SLES 15.0 2020-12-10 17:25:44 +01:00
Alexander A. Klimov
173801b389 GitHub actions: drop SLES 12.4 2020-12-10 17:25:39 +01:00
Alexander A. Klimov
854939a8ce On recovery: re-check children 2020-12-02 12:24:40 +01:00
Alexander A. Klimov
668bf06424 Don't fire suppressed notifications if last parent recovery >= last check result 2020-12-02 12:03:19 +01:00
Alexander Aleksandrovič Klimov
f3f3a946c1
Merge pull request #8511 from Icinga/feature/improve-config-sync-locking-2.12
Improve config sync locking (support/2.12)
2020-11-27 17:53:29 +01:00
Julian Brost
e7d9c5138b Remove SpinLock
No longer needed as its only user now uses std::mutex.
2020-11-27 11:32:11 +01:00
Julian Brost
9dab8644d1 ApiListener: merge new config validation and actication functions
Merge AsyncTryActivateZonesStage and TryActivateZonesStageCallback and
name the result TryActivateZonesStage. The old split was a leftover from
the one being a callback function with no actual meaningful separation.
2020-11-27 11:32:11 +01:00
Julian Brost
07b9c62c98 Use std::mutex instead of Spinlock 2020-11-27 11:32:11 +01:00
Julian Brost
c5d8248e78 API filesync: wait for validation process to exit
This avoid having to pass a lock implictly using the captured variables
of a lambda.
2020-11-27 11:32:10 +01:00
Julian Brost
867a3c0216 Add Process::WaitForResult to allow waiting for the process to finish 2020-11-27 11:32:10 +01:00
Alexander Aleksandrovič Klimov
0364041b95
Merge pull request #8503 from Icinga/bugfix/missing-changelog-item-2.12.2
Add #8495 to the changelog for version 2.12.2
v2.12.2
2020-11-24 15:37:34 +01:00
Julian Brost
0fa84b0c87 Add #8495 to the changelog for version 2.12.2
It was already merged, just missing from the changelog.
2020-11-24 15:33:56 +01:00
Alexander Aleksandrovič Klimov
fc65387d98
Merge pull request #8497 from Icinga/feature/icinga-2.12.2
Release version 2.12.2
2020-11-23 13:30:11 +01:00
Julian Brost
9f8ff26d88
Merge pull request #8496 from Icinga/bugfix/replay-log-blocks
Start ApiListener#SyncClient() in the thread pool
2020-11-23 13:28:46 +01:00
Julian Brost
e589257d1b
Merge pull request #8495 from Icinga/bugfix/config-sync-only-remove-files-if-timestamp-changed
Config sync: Only remove files, if timestamp changed
2020-11-23 12:37:20 +01:00
Julian Brost
d3d5188369 Release version 2.12.2 2020-11-23 12:28:34 +01:00
Alexander A. Klimov
748993af8a Start ApiListener#SyncClient() in the thread pool
... not hosting the coroutines not to block them.

Otherwise a large replay log would block messages sending
until the peer disconnects us.
2020-11-23 12:07:08 +01:00
Julian Brost
91119c8946
Merge pull request #8465 from Icinga/feature/one-connection
ApiListener#NewClientHandlerInternal(): reject connections from already connected endpoints
2020-11-23 12:03:18 +01:00
Julian Brost
611aa39468
Merge pull request #8467 from Icinga/feature/http-status-codes-in-icinga-mainlog-7053
Include HTTP status codes in log
2020-11-23 11:59:05 +01:00
Alexander Aleksandrovič Klimov
a5dc71ebab
Merge pull request #8474 from Icinga/bugfix/message-routing-for-global-zones-2.12
Fix cluster message routing for global zones
2020-11-23 11:55:23 +01:00
Alexander Aleksandrovič Klimov
9fb776bb0f
Merge pull request #8461 from Icinga/bugfix/do-not-accept-api-updates-for-unknown-zone-2.12.2
API: Don't accept object updates for unknown zone
2020-11-23 11:54:08 +01:00
Noah Hilverling
7f232d6007 Config sync: Only remove files, if timestamp changed 2020-11-23 11:39:46 +01:00
Noah Hilverling
b15d6444c8
Merge pull request #8483 from Icinga/bugfix/close-anonymous-connections-2.12
Close anonymous connections after 10 seconds
2020-11-16 17:17:52 +01:00
Julian Brost
b9f0f6ed40 Close anonymous connections after 10 seconds
Anonymous connections are normally only used for requesting a
certificate and are closed after this request is received. However, the
request is only sent if the child has successfully verified the
certificate of its parent so that it is an authenticated connection from
its perspective. In case this verification fails, both ends view it as
an anonymous connection and never actually use it but attempt a
reconnect after 10 seconds leaking the connection. Therefore close it
after a timeout.
2020-11-13 16:33:40 +01:00
Alexander Aleksandrovič Klimov
36c1bce294
Merge pull request #8477 from Icinga/probot/update-authors/support/2.12/4cd4743e0eb371477b72ed326937e5bd21d65c99
Update AUTHORS
2020-11-12 15:10:16 +01:00
icinga-probot[bot]
27be0dd4eb
Update AUTHORS 2020-11-12 14:08:46 +00:00
Alexander Aleksandrovič Klimov
4cd4743e0e
Merge pull request #8470 from Icinga/bugfix/replay-object-deletion-2.12
Log config object deletions to replay log
2020-11-12 15:08:29 +01:00
Julian Brost
0e98a52763 Fix cluster message routing for global zones
RelayMessageOne used to relay the message only to one other endpoint for
other zones, which is fine, as long as the target zone is a child/parent
zone but breaks if the target zone is a global one. In this case, the
message has to be forwarded within the local zone as well as to one node
in each child zone.
2020-11-12 09:50:35 +01:00
Julian Brost
5cf90805c8 Log config object deletions to replay log
The initial config object sync for each new connection (in
`ApiListener::SendRuntimeConfigObjects()`) only considers currently
existing objects and has no way to pass the information that objects
were deleted in the meantime.

This commit logs config object deletions to the replay log if required
so that there is a chance that it will be propagated to nodes that were
offline when the deletion happened.

Note that this can only be considered a workaround as the replay log
might be pruned or could even be completely disabled. Also, there still
seems to be a race-condition between the config sync and replay log of
multiple new connections at the same time.
2020-11-10 17:42:43 +01:00
Noah Hilverling
a2d14dcdd2 API: Don't accept object updates for unknown zone 2020-11-09 16:37:25 +01:00
Alexander A. Klimov
29e5d7def7 Include HTTP status codes in log
refs #7053
2020-11-09 10:20:13 +01:00