tyler.durden/icinga2
1
0
Fork 0
mirror of https://github.com/Icinga/icinga2.git synced 2025-09-23 09:48:05 +02:00
Code Issues Packages Projects Releases Wiki Activity
12,140 Commits 280 Branches 124 Tags
Commit Graph

12140 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Julian Brost
31545cbe65
Merge pull request from GHSA-98wp-jc6q-x5q5 
API: hide ApiListener#ticket_salt (2.12)
 2021-07-15 11:13:35 +02:00
Julian Brost
730860bf0f
Merge pull request from GHSA-wrpw-pmr8-qgj7 
Remove passwords from API (2.12)
 2021-07-15 11:12:29 +02:00
Julian Brost
ce26bf9a4c Icinga 2.12.5 v2.12.5 2021-07-09 16:15:24 +02:00
Alexander A. Klimov
b5b83fa515 API: hide ApiListener#ticket_salt 2021-07-09 09:30:45 +02:00
Julian Brost
843353ab69 Remove passwords from API 
IdoMysqlConnection, IdoPgsqlConnection, IcingaDB, and ElasticsearchWriter
require passwords in their configuration to authenticate against external
services. This commit ensures that these can no longer be accessed using the
API.
 2021-07-09 09:05:05 +02:00
Julian Brost
289a872eaf
Merge pull request #8865 from Icinga/feature/improve-crashlog-212 
Improve crashlog
 2021-07-09 08:21:44 +02:00
Julian Brost
4a1e6528ea
Merge pull request #8889 from Icinga/bugfix/trigger-fixed-downtimes-immediately-212 
Downtime#Start(): trigger fixed downtimes immediately instead of waiting for the timer
 2021-07-08 15:33:11 +02:00
Julian Brost
7bfe896efb Stacktrace test: try to prevent inlining even harder 
- Explicitly disable optimizations for MSVC
- Make stack_test_func_a bigger
 2021-07-08 14:53:15 +02:00
Julian Brost
d8ab328c33 Add comments to stack trace formatter and test case 2021-07-08 14:53:15 +02:00
Julian Brost
c3f77be473 Compile with -D_GNU_SOURCE 
Needed by `boost::stacktrace` for `_Unwind_Backtrace()`.
 2021-07-08 14:53:15 +02:00
Julian Brost
1a82a9fa87 CMakeLists: use HAVE_LIBEXECINFO only after actually checking for it 
So far, the check that actually sets HAVE_LIBEXECINFO was executed after
it was already used to add dependencies.
 2021-07-08 14:53:15 +02:00
Julian Brost
14987274dc Add a test case for the stack trace formatter 2021-07-08 14:53:15 +02:00
Julian Brost
f5873a8e75 Use backtrace_symbols() when printing stack traces on FreeBSD 
Unfortunately, the symbol resolution of boost::stacktrace is broken on
FreeBSD, therefore fall back to using backtrace_symbols() to print the
stack trace saved by Boost.

Additionally, -D_GNU_SOURCE is required on FreeBSD for the
_Unwind_Backtrace function used by boost::stacktrace.
 2021-07-08 14:53:15 +02:00
Julian Brost
a2e5cfd34f Crash handlers: use more compact string representation 2021-07-08 14:53:15 +02:00
Julian Brost
2310cdb4fa Begin crash log for SIGABRT with error message and timestamp 
This makes the format more similar to what the uncaught C++ and SEH
exception handlers write. Previously there was no indication in the
crash log that a SIGABRT happened.
 2021-07-08 14:53:15 +02:00
Julian Brost
cb3febfd2a Windows: require at least MSVC 19.20 to build 
Older versions of MSVC fail to rethrow an unhandled C++ exception (using
`throw;`) in the termination handler (`std::set_terminate`), however
Icinga relies on this behavior in its crash handler
(`Application::ExceptionHandler`).
 2021-07-08 14:53:15 +02:00
Julian Brost
51bb751f23 docs: mention use of boost::stacktrace 2021-07-08 14:53:15 +02:00
Julian Brost
2330ab59f8 Add some comments to __cxa_throw 
Maybe this will save the next person who has to look at this code some
time. Please don't blame me for the implementation, I'm just trying to
reconstruct what it does.
 2021-07-08 14:53:15 +02:00
Julian Brost
9fcc781172 Restructure stack and context trace selection in DiagnosticInformation and document behavior 
The logic for selecting the traces to print stays the same, but there
are fewer nested ifs now. This changes the format of the returned string
a bit by adding a heading for both traces.
 2021-07-08 14:53:15 +02:00
Julian Brost
df59aa0087 Add documentation for cast_exception function 2021-07-08 14:53:15 +02:00
Julian Brost
996f280bfc Pass fallback stacktrace to DiagnosticInformation in terminate handler 
By default, DiagnosticInformation uses the stack trace saved when the
exception was thrown, but this mechanism is not in use on Windows.
Gathering a stacktrace in the terminate handler serves as a fallback.
 2021-07-08 14:53:15 +02:00
Julian Brost
8b2f4636db Replace icinga::StackTrace with boost::stacktrace::stacktrace 
Provides roughly the same functionality but works better on certain
platforms (especially Windows) and is less code to maintain.
 2021-07-08 14:53:15 +02:00
Julian Brost
4a29c39eba Print details in uncaught SEH exception handler 2021-07-08 14:53:15 +02:00
Julian Brost
8b67e4a637 Move error message and time to the beginning of the SEH crash log 
This is more similar to the normal exception crashlog which also states
the problem and time at the beginning of the file.
 2021-07-08 14:53:15 +02:00
Julian Brost
9ebd812da5 Use boost::stacktrace instead of custom implementation in Windows SEH filter 2021-07-08 14:53:15 +02:00
Julian Brost
b5017b78d7 Run termination handler for uncaught C++ exceptions on Windows 
On Windows, the termination handler is executed for uncaught C++
exceptions unless a SEH unhandled exception filter is also set. In this
case, this filter has to explicitly chain the default filter to keep
this behavior.
 2021-07-08 14:53:15 +02:00
Alexander Aleksandrovič Klimov
088860474c
Merge pull request #8877 from Icinga/bugfix/fixed-dt-end-notify-212 
Checkable::NotifyDowntimeEnd(): don't send Downtime end notification unless triggered
 2021-07-07 23:55:17 +02:00
Alexander Aleksandrovič Klimov
fac7e5043e
Merge pull request #8879 from Icinga/feature/scheduleddowntime-change-remove-downtimes-212 
On ScheduledDowntime change: remove downtimes created before change
 2021-07-07 22:36:40 +02:00
Alexander Aleksandrovič Klimov
8550c01d3c
Merge pull request #8886 from Icinga/feature/windows-build-scripts-32-bit-212 
Windows build scripts: allow setting BITS=32 to use 32 bit dependency paths by default
 2021-07-07 19:23:39 +02:00
Alexander Aleksandrovič Klimov
09b56242f3
Merge pull request #8885 from Icinga/feature/openssl111k-212 
Bump OpenSSL to 1.1.1k
 2021-07-07 19:23:16 +02:00
Alexander A. Klimov
0cca93543c Checkable::NotifyDowntimeEnd(): don't send Downtime end notification unless triggered 
... for fixed Downtimes as well.
 2021-07-07 15:42:20 +02:00
Alexander A. Klimov
2bcd249efb On ScheduledDowntime change: remove future downtimes created before change 
refs #8309
 2021-07-07 15:42:18 +02:00
Alexander A. Klimov
c7ad5f6e2e On ScheduledDowntime change: ignore downtimes created before change 
... while creating new downtimes.

refs #8309
 2021-07-07 15:42:18 +02:00
Alexander A. Klimov
2dcba12765 Introduce Downtime#config_owner_hash 
refs #8309
 2021-07-07 15:42:18 +02:00
Alexander A. Klimov
c203716ff3 ScheduledDowntime: ignore not related Downtimes while creating Downtimes 2021-07-07 15:42:18 +02:00
Alexander A. Klimov
13d3d18a7f Downtime#Start(): trigger fixed downtimes immediately instead of waiting for the timer 
... not to cause e.g. notifications if a problem occurs
between the downtime start time and the timer routine.
 2021-07-07 15:31:46 +02:00
Julian Brost
2fd8e13ebf Windows build scripts: allow setting BITS=32 to use 32 bit dependency paths by default 2021-07-07 14:54:27 +02:00
Alexander A. Klimov
e7aa9dd3ed Bump OpenSSL to 1.1.1k 2021-07-07 14:50:23 +02:00
Noah Hilverling
7df2620bda
Merge pull request #8864 from Icinga/bugfix/downtime-for-host-service-with-long-name-8022-212 
ConfigObjectUtility::GetObjectConfigPath(): hash names of not already existing objects
 2021-07-07 10:39:52 +02:00
Noah Hilverling
4fb27a45cb
Merge pull request #8863 from Icinga/bugfix/harden-scheduled-downtimes-212 
ScheduledDowntime::TimerProc(): Catch exceptions to make sure other downtimes are still created
 2021-07-07 10:39:44 +02:00
Noah Hilverling
a79f4f9108
Merge pull request #8866 from Icinga/bugfix/new-connection-timeout-212 
Add timeout for full Icinga connection handshake
 2021-07-07 10:39:38 +02:00
Alexander Aleksandrovič Klimov
bd9ab5ab93
Merge pull request #8876 from Icinga/probot/sync-changelog/9898ccf63fc76ad9ec29d279d20f20cadae86dce 
CHANGELOG.md: add v2.11.9
 2021-07-06 17:37:21 +02:00
Noah Hilverling
7e0eab3767 ScheduledDowntime::TimerProc(): Catch exceptions to make sure other downtimes are still created 2021-07-06 12:27:16 +02:00
Julian Brost
ecbaa5db67 Add timeout for all new connections 
This commit adds a timeout for both establishing new outgoing and incoming
connections. This timeout applies to everything until the connection is in a
state where either JsonRpcConnection or HttpServerConnection takes over.
 2021-07-06 11:32:41 +02:00
Julian Brost
49c546ff4c CHANGELOG.md: add v2.11.9 2021-07-06 08:24:45 +00:00
Alexander Aleksandrovič Klimov
9898ccf63f
Merge pull request #8862 from Icinga/feature/gha-windows-212 
GitHub actions: build Windows
 2021-07-06 10:24:32 +02:00
Julian Brost
97d70daa57 GetObjectConfigPath: only truncate and hash comment and downtime filenames 
This partially reverts 68a0079c26686363b6202a8abd2712d2bf96d9f2 and keeps the
fix only for comment and downtime objects for now. For reasoning, please see
the comment in the code.
 2021-07-05 16:18:57 +02:00
Julian Brost
eaee629047 GetObjectPath: ensure use of escaped name in all cases and use TruncateUsingHash() 
68a0079c26686363b6202a8abd2712d2bf96d9f2 introduced two problems that are fixed
with this commit:
1. The new truncated/hashed name did not use EscapeName()
2. There was a possible collision of names when creating objects with a full
   name of format "[80 characters]...[40 hex digits]" (i.e. the same as the
   truncated/hashed variant but short enough that it isn't hashed)
 2021-07-05 16:18:57 +02:00
Julian Brost
bdbe35b42d Utility: add a function to truncate strings while avoiding collisions 2021-07-05 16:18:57 +02:00
Alexander A. Klimov
3788f9170a ConfigObjectUtility::GetObjectConfigPath(): hash names of not already existing objects 
... to avoid too long file names.

refs #8022
 2021-07-05 16:18:57 +02:00