Gunnar Beutner
148a6c5bf3
Make load order for objects more reliable
...
fixes #8770
2015-03-23 15:58:15 +01:00
Gunnar Beutner
a99773b62d
Fix: 'return' keyword doesn't work inside for loops
...
fixes #8834
2015-03-22 00:05:18 +01:00
Gunnar Beutner
60c8c38066
Fix copyright header indentation
2015-03-21 11:02:27 +01:00
Gunnar Beutner
3d1aba3287
Fix style violations
2015-03-21 10:04:32 +01:00
Michael Friedrich
7c0749679c
Fix missing config validator for command arguments 'set_if'
...
fixes #8724
2015-03-20 16:15:22 +01:00
Gunnar Beutner
86a1bbf468
Allow using more than one %validator rule for the same type
...
fixes #8829
2015-03-20 15:55:13 +01:00
Gunnar Beutner
4e680e6d58
Flush stderr in Application::Exit
...
fixes #8734
2015-03-20 12:28:52 +01:00
Michael Friedrich
6c8bc20369
Use Utility::NaturalJoin for notification filter formatting
...
refs #8685
2015-03-19 14:09:14 +01:00
Michael Friedrich
6e778c4947
Show notification state/type filter names in notice/debug log
...
fixes #8685
2015-03-19 14:09:07 +01:00
Gunnar Beutner
ab36912ccd
Improve error message for invalid field access
...
fixes #8769
2015-03-19 13:48:31 +01:00
Gunnar Beutner
2826ef7647
Implement the parse_performance_data function
...
fixes #8693
2015-03-19 13:38:24 +01:00
Gunnar Beutner
1756859125
Don't ignore extraneous arguments for functions
...
fixes #8748
2015-03-19 13:37:36 +01:00
Louis Sautier
113a90dd7f
Remove prompt to create a TicketSalt from the wizard
...
fixes #8766
Signed-off-by: Gunnar Beutner <gunnar@beutner.name>
2015-03-16 15:25:23 +01:00
Gunnar Beutner
ea7d1ee77d
Add OS details in 'icinga2 --version'
...
fixes #8761
2015-03-16 13:52:59 +01:00
Gunnar Beutner
f70cebca0c
Build fix for 2.3.x
2015-03-16 13:45:18 +01:00
Gunnar Beutner
1fcb012976
Improve Flex version detection on Windows
...
refs #8750
2015-03-16 13:33:01 +01:00
Gunnar Beutner
9bcbc8f4f8
Don't update custom vars for each status update
...
fixes #8736
2015-03-16 10:23:56 +01:00
Gunnar Beutner
6155dd2e7d
Ensure that flex meets the version requirements
...
fixes #8750
2015-03-16 10:23:13 +01:00
Michael Friedrich
6a6662644e
Fix log message for cli commands breaks the init script
...
fixes #8721
2015-03-12 15:57:52 +01:00
Michael Friedrich
64214bd853
Fix crash in Dependency::Stop()
...
This partially reverts the fix in #8436
fixes #8687
refs #8436
Conflicts:
lib/db_ido_pgsql/idopgsqlconnection.cpp
2015-03-12 11:56:20 +01:00
Michael Friedrich
e1a07ad129
Fix formatting for the GDB stacktrace
...
fixes #8684
2015-03-11 16:31:52 +01:00
Michael Friedrich
9db3d42135
Make sure that the /var/log/icinga2/crash directory exists
...
fixes #8683
2015-03-11 16:08:37 +01:00
Gunnar Beutner
cef5191d44
Fix timeout problem with API heartbeat messages
...
fixes #8672
2015-03-11 12:56:22 +01:00
Gunnar Beutner
21522f9ed6
Fix line continuation support for parentheses
...
fixes #8679
2015-03-11 09:55:38 +01:00
Gunnar Beutner
8516e78b92
Kill entire process group after plugin timeout
...
fixes #8540
2015-03-11 07:38:07 +01:00
Gunnar Beutner
73629172b4
Fix argument type for the StringContains function
...
refs #8659
2015-03-11 06:44:32 +01:00
Michael Friedrich
059cda9e37
Implement String#contains
...
fixes #8659
2015-03-11 06:44:23 +01:00
Gunnar Beutner
4e16f48255
Don't accept config updates for zones for which we have an authoritative copy of the config
...
fixes #8555
2015-03-09 08:46:01 +01:00
Gunnar Beutner
3046ad5d5e
Fix incorrect value for the process_performance_data column in the icinga_hosts table
...
fixes #8544
2015-03-09 08:12:05 +01:00
Gunnar Beutner
e50d3e6e5a
Fix validator for dependencies
...
fixes #8596
2015-03-09 08:04:18 +01:00
Gunnar Beutner
22f3c5082d
Add validator for time ranges in ScheduledDowntime objects
...
fixes #8600
2015-03-09 08:02:12 +01:00
Gunnar Beutner
60d5959ba4
Remove incorrect VERIFY
...
fixes #8628
2015-03-09 06:51:22 +01:00
Gunnar Beutner
77fc213d6d
Remove unnecessary dynamic_casts
2015-03-07 14:47:54 +01:00
Gunnar Beutner
52102d815d
Fix second Deserialize() call in ApiEvents::ExecuteCommandAPIHandler
...
refs #8117
2015-03-06 01:45:43 +01:00
Gunnar Beutner
139540b570
Make sure we don't evaluate apply rules for fake hosts used in agent checks
...
fixes #8117
2015-03-05 21:19:04 +01:00
Gunnar Beutner
9181d7ae05
Add missing service name in check results
...
refs #8257
2015-03-05 20:50:27 +01:00
Gunnar Beutner
bb4beefca9
Add missing "return"s in Ido*Connection::Reconnect
2015-03-05 15:57:46 +01:00
Gunnar Beutner
fd9dc32a3d
Implement SNI support for the TlsStream class
...
fixes #8610
2015-03-05 14:15:42 +01:00
Gunnar Beutner
4a2a6d999a
Fix incorrect debug hints for nested attributes
...
fixes #8604
2015-03-05 13:18:15 +01:00
Gunnar Beutner
4b15ec7774
Remove the macro argument for IMPL_TYPE_LOOKUP
...
fixes #8599
2015-03-05 07:42:13 +01:00
Gunnar Beutner
767ddbdec7
Fix compiler warning in Process::Run
2015-03-04 16:41:53 +01:00
Gunnar Beutner
f41f9b085d
Implement support for the 'Limit' column in Livestatus
...
fixes #8529
2015-03-04 12:18:04 +01:00
Gunnar Beutner
afd1927a98
Improve Livestatus query performance
...
fixes #8594
2015-03-04 10:58:22 +01:00
Gunnar Beutner
c33e78aa04
Don't discard config validators
2015-03-04 09:12:57 +01:00
Gunnar Beutner
4d63351561
Fix some compile warnings
2015-03-04 08:26:15 +01:00
Gunnar Beutner
9bbe9a4875
Fix a memory leak in *Expression::GetReference
...
fixes #8593
2015-03-04 08:00:38 +01:00
Gunnar Beutner
c9c7f9bed1
Fix lag calculation for the 'cluster-zone' check
2015-03-03 14:42:22 +01:00
Gunnar Beutner
3615716983
Include GDB backtrace in crash reports
...
fixes #8575
2015-03-03 13:53:11 +01:00
Gunnar Beutner
c3e32911a7
Fix: else if doesn't work without an else branch
...
fixes #8572
2015-03-03 10:22:21 +01:00
Gunnar Beutner
1d2b008dcb
Fix validator for TimePeriod ranges
...
fixes #8568
2015-03-03 09:56:38 +01:00
Gunnar Beutner
cf37decbef
Fix start condition for downtimes
...
fixes #8560
2015-03-03 09:52:13 +01:00
Gunnar Beutner
2867d79514
Add VERIFY check in Utility::ExecuteDeferredInitializers
...
Coverity Bug ID: 1167738
2015-03-03 09:26:21 +01:00
Gunnar Beutner
3e12bfef25
Remove redundant error check in Utility::GetTime
...
Coverity Bug ID: 1167732
2015-03-03 09:23:29 +01:00
Gunnar Beutner
274e6e9785
Fix uninitialized field in the CheckerComponent class
2015-03-03 09:14:15 +01:00
Gunnar Beutner
ac7a55cf56
Fix file descriptor leak in SetDaemonIO
2015-03-03 07:36:43 +01:00
Gunnar Beutner
7c31654552
Remove the return type for Utility::LoadExtensionLibrary
2015-03-03 07:19:34 +01:00
Gunnar Beutner
bdb2a15e27
Use _exit instead of Exit in Application::SetResourceLimits
2015-03-02 17:19:41 +01:00
Jean Flach
4d0ee2a7fd
Americaniz(s)e colo(u)r in troubleshoot cli
2015-03-02 16:42:38 +01:00
Michael Friedrich
c61134d55a
Fix deadlock in DB IDO and external command events
...
refs #8511
2015-03-02 16:20:22 +01:00
Michael Friedrich
97ff17eb4e
Fix troubleshooting cli hint text
...
refs #3446
2015-03-02 15:28:02 +01:00
Michael Friedrich
1f9a719712
Fix output formatting in troubleshoot cli command
...
refs #3446
2015-03-02 14:37:58 +01:00
Michael Friedrich
dd5ca24210
Fix compiler warnings
2015-03-02 14:10:26 +01:00
Jason Young
faf6ce1a5f
Update PerfdataValue::Parse to ignore invalid warn, crit, min, and max values
...
... instead of generating exception so that metric values can
still be passed to the graphing backend.
Also update icinga-perfdata tests to reflect these changes.
refs #5043
Signed-off-by: Michael Friedrich <michael.friedrich@netways.de>
2015-03-02 13:52:41 +01:00
Gunnar Beutner
5df3010826
Remove unused variable in PkiUtility::SignCsr
2015-03-02 13:32:08 +01:00
Gunnar Beutner
7aaa6975fc
Remove unnecessary SubStr call
2015-03-02 13:30:37 +01:00
Gunnar Beutner
8a062a688b
Remove redundant checks
2015-03-02 13:21:06 +01:00
Gunnar Beutner
09038eeb7c
Remove unused variable
2015-03-02 13:21:06 +01:00
Jean-Marcel Flach
e39896df15
Add more colour to troubleshoot cli
2015-03-02 13:17:49 +01:00
Gunnar Beutner
4d25a2cb22
Implement the assignment operator for the Value class
2015-03-02 12:55:48 +01:00
Gunnar Beutner
bb393a9d4f
Remove unused variables
2015-03-02 12:52:37 +01:00
Gunnar Beutner
1bcc1a7b92
Fix incorrect operator in Value::operator^
2015-03-02 12:51:11 +01:00
Gunnar Beutner
79a69d3e89
Fix incorrect header length check in NetString::ReadStringFromStream
2015-03-02 12:47:24 +01:00
Gunnar Beutner
1e9e5edcff
Fix incorrect assignment in Logger::EnableConsoleLog
2015-03-02 12:47:24 +01:00
Gunnar Beutner
d913089a14
Remove redundant function
2015-03-02 12:47:20 +01:00
Gunnar Beutner
81e821b60c
Make copy constructor private for the Log class
2015-03-02 12:42:33 +01:00
Gunnar Beutner
b6ca140ee2
Fix incorrect return type for Application::Run
2015-03-02 12:41:44 +01:00
Gunnar Beutner
f7ca0c5b52
Fix incorrect format specifier for fprintf
2015-03-02 12:41:44 +01:00
Jean-Marcel Flach
96583857c0
Fix whitespace
2015-03-02 12:35:58 +01:00
Jean-Marcel Flach
68e7de7e59
Work on troubleshoot cli
...
Changes the format timestamps are displayed.
--include-vars and --include-objects now print to console if --console
is given.
Also fixes two memory leaks.
fixes #8564 #8563
refs 3446
2015-03-02 12:21:34 +01:00
Gunnar Beutner
5968622108
Fix incorrect assignment in PluginUtility::ExecuteCommand
...
Coverity Bug ID: 1272344
2015-03-02 10:14:15 +01:00
Gunnar Beutner
a296147839
Fix uninitialized fields in the StreamLogger class
...
Coverity Bug ID: 1272329
2015-03-02 10:14:15 +01:00
Gunnar Beutner
ce1599fbb3
Fix uninitialized field in the LivestatusScriptFrame class
...
Coverity Bug ID: 1272326
2015-03-02 10:14:15 +01:00
Gunnar Beutner
8f7599d4b3
Fix uninitialized field in the LivestatusQuery class
...
Coverity Bug ID: 1272325
2015-03-02 10:14:15 +01:00
Gunnar Beutner
9548692f00
Fix uninitialized field in the Checkable class
...
Coverity Bug ID: 1272323
2015-03-02 10:14:14 +01:00
Gunnar Beutner
2ee1a197a9
Fix uninitialized field in the ScriptError class
...
Coverity Bug ID: 1272322
2015-03-02 10:14:14 +01:00
Gunnar Beutner
e52a1f38f3
Fix uninitialized field in the ApiListener class
...
Coverity Bug ID: 1272321
2015-03-02 10:14:14 +01:00
Gunnar Beutner
41cb5977f3
Remove unreachable code
...
Coverity Bug ID: 1272319
2015-03-02 10:14:14 +01:00
Gunnar Beutner
5b286dae31
Fix leak in SocketEvents::Threadproc
...
Coverity Bug ID: 1272338
2015-03-02 10:14:14 +01:00
Gunnar Beutner
b4be584679
Fix uninitialized fields
...
Coverity Bug ID: 1272331
2015-03-02 10:14:14 +01:00
Gunnar Beutner
f1509d2f10
Fix uninitialized variable in DaemonUtility::ValidateConfigFiles
...
Coverity bug ID: 1272330
2015-03-02 10:14:14 +01:00
Jean-Marcel Flach
ba9cf9e4c2
Add message concerning file compression to troubleshoot cli
2015-03-02 09:35:04 +01:00
Gunnar Beutner
2d65489f3a
Make sure the WQ status timer is stopped properly
...
refs #8550
2015-03-01 22:25:48 +01:00
Gunnar Beutner
cd380a8494
Fix another crash in Timer::Call
...
fixes #8550
2015-02-28 08:43:49 +01:00
Gunnar Beutner
4cc7d4963c
Refactor the API timeout timer
...
refs #8554
2015-02-27 20:18:20 +01:00
Gunnar Beutner
d7000fa757
Make sure that the timeout timer gets destroyed properly
...
refs #8554
2015-02-27 19:54:41 +01:00
Gunnar Beutner
9622b075bc
Use the main threadpool to disconnect API clients
...
refs #8554
2015-02-27 18:32:28 +01:00
Gunnar Beutner
985c6bc7d9
Fix a deadlock in WorkQueue::WorkerThreadProc
...
refs #8554
2015-02-27 18:32:20 +01:00
Gunnar Beutner
5d1e549063
Fix a crash in Timer::Reschedule
...
refs #8554
2015-02-27 16:44:33 +01:00
Gunnar Beutner
5eb32efb05
Fix crash in SocketEvents::ThreadProc
...
fixes #8554
2015-02-27 15:53:38 +01:00
Jean-Marcel Flach
9ed21563ff
Use RequestShutdown with exitcode instead of Application::Exit
...
fixes #8436
2015-02-27 14:43:30 +01:00
Gunnar Beutner
2884e8318d
Fix null pointer dereference in ApiClient::TimeoutTimerHandler
...
fixes #8553
2015-02-27 14:12:50 +01:00
Jean-Marcel Flach
07fd4e6031
Add colours to troubleshoot cli
...
refs #3446
2015-02-27 14:09:26 +01:00
Gunnar Beutner
d397933eff
Fix a crash in Timer::Call
...
fixes #8473
2015-02-27 14:07:12 +01:00
Gunnar Beutner
9567cd663b
Fix another potential hang in TlsStream::Handshake
...
refs #8550
2015-02-27 09:03:23 +01:00
Gunnar Beutner
bb2cdff435
Fix a deadlock in ApiClient::Disconnect
...
fixes #8549
2015-02-26 17:23:06 +01:00
Gunnar Beutner
4e8c5706e1
Don't send heartbeats during log replay
...
fixes #8461
refs #8485
2015-02-26 14:59:39 +01:00
Gunnar Beutner
fd090e057b
Implement 'else if'
...
fixes #8548
2015-02-26 13:51:13 +01:00
Gunnar Beutner
c439ee6d9f
Fix a crash in ApiClient::TimeoutTimerHandler
...
refs #8485
2015-02-26 13:31:38 +01:00
Jean-Marcel Flach
d084effa4b
Change behaviour of troubleshoot cli parameters
2015-02-26 13:30:48 +01:00
Gunnar Beutner
0c51857084
Fix another crash in SocketEvents::Register
...
fixes #8547
2015-02-26 13:11:50 +01:00
Gunnar Beutner
1302f7c841
Improve log message for cluster connection timeouts
...
refs #8485
2015-02-26 13:09:13 +01:00
Jean-Marcel Flach
cc99406dd3
Add --include-vars and --include-objects troubleshoot cli
...
refs #3446
2015-02-26 12:43:43 +01:00
Gunnar Beutner
a3ccd2a1fb
Close client connections if we haven't received any messages in some time
...
refs #8485
2015-02-26 12:41:47 +01:00
Gunnar Beutner
2b44fcb571
Make sure that the 'connecting' flag is reset properly
...
refs #8485
2015-02-26 11:26:08 +01:00
Michael Friedrich
93d390873d
Fix Livestatus tests on Windows
...
fixes #8486
2015-02-26 11:14:55 +01:00
Gunnar Beutner
c30d64a261
Build fix for Windows
...
refs #8486
2015-02-26 09:06:00 +01:00
Jean-Marcel Flach
150353d88f
Remove --include-objects option from troubleshoot for now
2015-02-25 15:40:24 +01:00
Gunnar Beutner
c86b17132c
Make sure that the scheduled start time for downtimes isn't ignored
...
fixes #6959
2015-02-25 15:19:50 +01:00
Gunnar Beutner
aef5bc2f3a
Fix a crash in TlsStream::Close
...
fixes #8537
2015-02-25 14:41:23 +01:00
Michael Friedrich
49c5c42945
Change Livestatus query log level to 'notice'
...
fixes #8527
2015-02-25 14:11:59 +01:00
Gunnar Beutner
29ac204449
Fix valgrind warning in ExternalCommandListener::CommandPipeThread
...
fixes #8536
2015-02-25 14:05:57 +01:00
Jean-Marcel Flach
1d0f6ed457
Fix a missing import
2015-02-25 14:04:02 +01:00
Gunnar Beutner
acd5d55f64
Fix null pointer dereference in ApiEvents::RepositoryTimerHandler
...
fixes #8535
2015-02-25 14:00:00 +01:00
Jean-Marcel Flach
19e160ce92
Fix some whitespace
2015-02-25 13:49:41 +01:00
Gunnar Beutner
4972364f42
Fix another problem where Icinga doesn't detect that a cluster connection is dead
...
refs #8485
2015-02-25 13:21:38 +01:00
Gunnar Beutner
4da3b1c5b3
Make sure that Notification objects are activated after Host/Service objects
...
fixes #8517
2015-02-25 12:43:38 +01:00
Jean-Marcel Flach
dd6691537b
Fix troubleshoot not writing everything to file
2015-02-25 11:08:55 +01:00
Jean-Marcel Flach
a28685d139
Rename troubleshootCollectCommand to troubleshootCommand
2015-02-25 09:55:35 +01:00
Gunnar Beutner
551cb6ae87
Don't convert loop variables to string when using apply-for
...
fixes #8519
2015-02-24 17:51:16 +01:00
Gunnar Beutner
5fe2536629
Add missing locks in ApiListener::UpdateConfigDir
2015-02-24 16:03:32 +01:00
Gunnar Beutner
9cd681148d
Fix crash in 'icinga2 console'
...
fixes #8516
2015-02-24 12:52:10 +01:00
Gunnar Beutner
12820d2225
Improve output formatting for the 'cluster-zone' check
...
refs #8515
2015-02-24 09:27:37 +01:00
Gunnar Beutner
f4c7d945e2
Show slave lag for the cluster-zone check
...
fixes #8515
2015-02-24 09:14:17 +01:00
Gunnar Beutner
5ceb64d649
Implement the get_time() function
2015-02-24 09:08:31 +01:00
Gunnar Beutner
7504f3a3dc
Prevent unnecessary thread wake-ups
...
refs #8485
2015-02-24 08:41:06 +01:00
Gunnar Beutner
2922d5d9bd
Fix another potential problem where TLS connection might get stalled
...
refs #8485
2015-02-24 07:11:22 +01:00
Gunnar Beutner
6dd33fa751
Make sure to not ignore fields which are set to an empty string
...
fixes #8496
2015-02-23 15:25:04 +01:00
Gunnar Beutner
a104dcf773
Add validator for the 'ignore_soft_states' attribute
...
refs #7326
2015-02-23 14:29:17 +01:00
Gunnar Beutner
b5dbc66b22
Implement the 'is_inside' attribute for the TimePeriod type
...
refs #8467
2015-02-23 14:08:06 +01:00
Gunnar Beutner
47479ac4de
Implement the 'get_time_period' function
...
refs #8467
2015-02-23 13:56:53 +01:00
Michael Friedrich
aac53c1dd1
Add 'ignore_soft_states' attribute to Dependency objects
...
fixes #7326
2015-02-23 10:13:20 +01:00
Gunnar Beutner
4e27ded7ce
Fix off-by-one mistake in error reporting for 'icinga2 console'
...
fixes #8500
2015-02-21 13:19:04 +01:00
Michael Friedrich
4e1c754786
Cli: Don't validate config objects in 'node update-config'
...
refs #8488
2015-02-20 21:34:59 +01:00
Gunnar Beutner
37e075c38a
Move some of the initialization code into icinga-app
...
refs #6257
2015-02-20 19:57:26 +01:00
Michael Friedrich
9ae9204df2
Cli: Don't parse objects/changes on each AddObject() call
...
refs #8488
2015-02-20 17:05:00 +01:00
Jean Flach
8402d64fd9
Fix a Windows build error
2015-02-20 16:59:10 +01:00
Jean Flach
41f7ec9c8e
Improve coding style conformation
...
refs #3446
2015-02-20 16:13:25 +01:00
Michael Friedrich
6455ef6b0a
Cli: More code style fixes in 'troubleshoot' command
...
refs #3446
2015-02-20 15:27:53 +01:00
Gunnar Beutner
0fb55060d2
Fix another potential deadlock in SocketEvents::WakeUpThread
...
refs #8484
2015-02-20 15:25:56 +01:00
Michael Friedrich
ba77d7b35f
ApiListener: Fix misleading connection log messages
...
fixes #8493
2015-02-20 15:11:44 +01:00