Commit Graph

970 Commits

Author SHA1 Message Date
Michael Friedrich baa8fb424f Fix missing custom attributes in backends if name is equal to object attribute
fixes #9222
2015-05-15 15:59:44 +02:00
Michael Friedrich e37cd25ed4 Fix failed assertion in DB IDO
fixes #9121
2015-04-27 11:00:41 +02:00
Michael Friedrich 7af41e93c0 Fix that downtimes are always "fixed" even if scheduled as "flexible"
fixes #9142
2015-04-25 15:06:29 +02:00
Michael Friedrich 83f4ebc0df Fix compiler warnings w/ config validators
fixes #9015
2015-04-20 14:16:19 +02:00
Michael Friedrich 53e6b1a6dd Fix custom attributes with recursive macro function calls
fixes #9073
2015-04-17 17:23:08 +02:00
Michael Friedrich d3a56b6404 Fix acknowledgement with expire time not added as comment expire_time
GetExpireTime() is always set to 0 which will make the comment reflect
wrong information compared to the text.

fixes #9041
2015-04-17 16:44:40 +02:00
Gunnar Beutner f69c0bd5a2 Remove the ScopeCurrent constant
fixes #9044
2015-04-15 08:36:17 +02:00
Michael Friedrich 4f767ab06a Change log level to 'notice' for 'Attempting to send notifications' messages
fixes #9021
2015-04-12 15:11:38 +02:00
Michael Friedrich 37f24592ed Trigger downtimes for NOT-OK states after OnDowntimeAdded()
The fix in #8389 must happen *after* adding the downtime which signals an
insert into the IDO DB.
Once the downtimes have been added to the database, the additional
trigger_time and is_in_effect can be updated accordingly, *if* the
current object is already in a NOT-OK state.

fixes #9016
2015-04-12 14:38:35 +02:00
Gunnar Beutner 10441e9cd7 Fix permissions for agent CheckResult messages
fixes #8821
2015-03-30 13:50:14 +02:00
Gunnar Beutner a5c5569324 Improve timeperiod validation error messages
fixes #8893
2015-03-29 08:13:11 +02:00
Gunnar Beutner a6822fd59a Fix validation errors for time ranges which span the DST transition
fixes #8892
2015-03-29 08:05:01 +02:00
Gunnar Beutner 72a7b08480 Move implementation code from thpp files into separate files
fixes #8890
2015-03-28 11:08:12 +01:00
Gunnar Beutner ec7224e3ed Generate C++ code for type validators
fixes #7709
fixes #8867
2015-03-27 07:59:27 +01:00
Gunnar Beutner 3adec4576c Fix arrays in command arguments
fixes #8869
2015-03-26 09:29:52 +01:00
Gunnar Beutner d3c0c1e42b Fix incorrect variable values for apply+for
fixes #8851
2015-03-23 15:53:21 +01:00
Gunnar Beutner 151b6bbf00 Fix style violations 2015-03-21 10:04:14 +01:00
Michael Friedrich e1cb543bb5 Fix missing config validator for command arguments 'set_if'
fixes #8724
2015-03-20 16:12:24 +01:00
Gunnar Beutner e8cee8d5e2 Allow using more than one %validator rule for the same type
fixes #8829
2015-03-20 15:49:55 +01:00
Gunnar Beutner e22386e63f Make load order for objects more reliable
fixes #8770
2015-03-19 15:58:38 +01:00
Michael Friedrich 88f16abb3c Use Utility::NaturalJoin for notification filter formatting
refs #8685
2015-03-19 14:08:06 +01:00
Gunnar Beutner 6c96d5bc98 Clean up the start-up process a bit
fixes #8791
2015-03-18 11:14:51 +01:00
Michael Friedrich 3c945914ff Show notification state/type filter names in notice/debug log
fixes #8685
2015-03-12 17:11:24 +01:00
Michael Friedrich 05c237c780 Don't increment check attempt counter on OK->NOT-OK transition
refs #7287

Signed-off-by: Michael Friedrich <michael.friedrich@netways.de>
2015-03-11 16:33:36 +01:00
Gunnar Beutner 228aafc945 Implement the parse_performance_data function
fixes #8693
2015-03-11 16:29:50 +01:00
Gunnar Beutner e50d3e6e5a Fix validator for dependencies
fixes #8596
2015-03-09 08:04:18 +01:00
Gunnar Beutner 22f3c5082d Add validator for time ranges in ScheduledDowntime objects
fixes #8600
2015-03-09 08:02:12 +01:00
Gunnar Beutner 52102d815d Fix second Deserialize() call in ApiEvents::ExecuteCommandAPIHandler
refs #8117
2015-03-06 01:45:43 +01:00
Gunnar Beutner 139540b570 Make sure we don't evaluate apply rules for fake hosts used in agent checks
fixes #8117
2015-03-05 21:19:04 +01:00
Gunnar Beutner 9181d7ae05 Add missing service name in check results
refs #8257
2015-03-05 20:50:27 +01:00
Gunnar Beutner 1d2b008dcb Fix validator for TimePeriod ranges
fixes #8568
2015-03-03 09:56:38 +01:00
Gunnar Beutner cf37decbef Fix start condition for downtimes
fixes #8560
2015-03-03 09:52:13 +01:00
Jason Young faf6ce1a5f Update PerfdataValue::Parse to ignore invalid warn, crit, min, and max values
... instead of generating exception so that metric values can
still be passed to the graphing backend.
Also update icinga-perfdata tests to reflect these changes.

refs #5043

Signed-off-by: Michael Friedrich <michael.friedrich@netways.de>
2015-03-02 13:52:41 +01:00
Gunnar Beutner 5968622108 Fix incorrect assignment in PluginUtility::ExecuteCommand
Coverity Bug ID: 1272344
2015-03-02 10:14:15 +01:00
Gunnar Beutner 9548692f00 Fix uninitialized field in the Checkable class
Coverity Bug ID: 1272323
2015-03-02 10:14:14 +01:00
Gunnar Beutner c86b17132c Make sure that the scheduled start time for downtimes isn't ignored
fixes #6959
2015-02-25 15:19:50 +01:00
Gunnar Beutner acd5d55f64 Fix null pointer dereference in ApiEvents::RepositoryTimerHandler
fixes #8535
2015-02-25 14:00:00 +01:00
Gunnar Beutner 4da3b1c5b3 Make sure that Notification objects are activated after Host/Service objects
fixes #8517
2015-02-25 12:43:38 +01:00
Gunnar Beutner 551cb6ae87 Don't convert loop variables to string when using apply-for
fixes #8519
2015-02-24 17:51:16 +01:00
Gunnar Beutner a104dcf773 Add validator for the 'ignore_soft_states' attribute
refs #7326
2015-02-23 14:29:17 +01:00
Gunnar Beutner b5dbc66b22 Implement the 'is_inside' attribute for the TimePeriod type
refs #8467
2015-02-23 14:08:06 +01:00
Gunnar Beutner 47479ac4de Implement the 'get_time_period' function
refs #8467
2015-02-23 13:56:53 +01:00
Michael Friedrich aac53c1dd1 Add 'ignore_soft_states' attribute to Dependency objects
fixes #7326
2015-02-23 10:13:20 +01:00
Gunnar Beutner a76f816623 Implement the 'continue' and 'break' keywords
fixes #8394
2015-02-19 12:57:52 +01:00
Gunnar Beutner f097e48889 Don't use separate threads for each ApiClient object
fixes #6109
2015-02-14 16:34:36 +01:00
Michael Friedrich 2ed78e82a8 Validate configured TimePeriod ranges
Requires re-throwing the hidden exceptions inside the existing
timeperiod code and validating the configured time range
strings then.

fixes #7576
2015-02-13 17:10:58 +01:00
Michael Friedrich 2cab6fbb9d Make the argments for the stats functions const-ref
fixes #8433
2015-02-13 11:29:15 +01:00
James Pharaoh 9fe52d0dc1 Make checks using 'command_endpoint' work inside HA zones
Previously there was no local processing of the executed
check result, which is mandatory inside a HA cluster.

Additionally this patch splits the command execution and
check result processing into more logical parts, executing
local checks, checks on the same command endpoint, and
remote checks.

More details in the referenced issue.

fixes #8249

Signed-off-by: Michael Friedrich <michael.friedrich@netways.de>
2015-02-12 17:53:50 +01:00
Michael Friedrich 2ae06b7a52 Implement {EN,DIS}ABLE_HOST_SVC_NOTIFICATIONS commands
fixes #7784
2015-02-11 16:45:52 +01:00
Michael Friedrich 24852e05c7 Move ValidateMacroString into the MacroProcessor class
refs #7311
2015-02-11 16:14:59 +01:00
Michael Friedrich 0d18b96c39 Resolve macros in dictionary values
refs #7311
2015-02-11 15:58:59 +01:00
Gunnar Beutner cb6f1043e1 Replace if( with if ( 2015-02-11 15:47:45 +01:00
Michael Friedrich 8ca57cba03 Add macro config validator for command args, env, custom attr, perfdata templates
fixes #7311
2015-02-11 15:32:10 +01:00
Gunnar Beutner 2de89fe8d4 Allow funcs in the 'env' dictionary
refs #7564
2015-02-10 10:59:08 +01:00
Gunnar Beutner 9de7da4d2a Update validators for CustomVarObject
fixes #7542
2015-02-10 08:53:15 +01:00
Gunnar Beutner 96aa503dbe Disable flapping detection by default
fixes #6868
2015-02-09 14:23:09 +01:00
Gunnar Beutner 97fc5bb10b Implement additional attributes for the Host class
refs #7564
2015-02-09 08:50:17 +01:00
Gunnar Beutner e456cfd99c Relax the validator for Notification::users/Notification::user_groups a bit
fixes #8067
2015-02-08 11:03:10 +01:00
Michael Friedrich b23d58dccc Add host/service runtime macro downtime_depth
fixes #8195
2015-02-08 00:15:38 +01:00
Michael Friedrich 34b5a4d9b4 Trigger added downtimes immediately if checkable is Not-OK
fixes #8389
2015-02-08 00:08:12 +01:00
Michael Friedrich db9c55835f Require at least one user for notification objects (user or as member of user_groups)
fixes #8067
2015-02-07 23:04:01 +01:00
Michael Friedrich 9302a6d03c StatusDataWriter: Fix wrong host notification filters
fixes #8387
refs #8192
2015-02-07 22:46:34 +01:00
Michael Friedrich ea2ac81003 Remove name and return value for stats functions
fixes #6171
2015-02-07 22:36:17 +01:00
Michael Friedrich 9ce061a8c4 Fix User::ValidateFilters isn't being used
fixes #8111
2015-02-07 21:57:49 +01:00
Michael Friedrich a1f04992f3 Fix notify flag is ignored in ACKNOWLEDGE_*_PROBLEM commands
fixes #8298
2015-02-07 21:39:19 +01:00
Gunnar Beutner 0605b76e7a Report failed agent checks to the master
fixes #8257
2015-02-05 15:36:17 +01:00
Gunnar Beutner 2d5112c878 Send check result even when accept_commands is not set
fixes #8333
2015-02-05 15:17:56 +01:00
Michael Friedrich 06a262f7db Schedule a host downtime for command SCHEDULE_HOST_SVC_DOWNTIME
fixes #8299
2015-02-04 21:19:47 +01:00
Gunnar Beutner e3dcc8a610 Implement a unit test for nullary lambdas
fixes #7805
2015-02-03 14:02:32 +01:00
Gunnar Beutner c01fb97337 Don't escape macros for the macro() function
refs #7564
2015-01-29 16:52:04 +01:00
Gunnar Beutner 2f44581f14 Validate timeperiod segments
fixes #8309
2015-01-29 14:14:56 +01:00
Gunnar Beutner a3e0c9d898 Add missing mutex for AddNotification/RemoveNotification
fixes #8311
2015-01-29 13:21:22 +01:00
Gunnar Beutner fb323ee215 Evaluate apply filters in the for loop
fixes #7610
2015-01-29 12:38:25 +01:00
Gunnar Beutner dd4a7ab240 Update validators for command arguments
refs #7564
2015-01-29 10:30:02 +01:00
Gunnar Beutner 7b4f1e217a Implement support for functions in set_if
refs #7564
2015-01-29 10:09:53 +01:00
Gunnar Beutner ea3c3e0c3e Fix incorrectly resolved macros
refs #7564
2015-01-28 15:48:08 +01:00
Gunnar Beutner 235c7348f4 Implement accessor functions for hosts, services, etc.
refs #7564
2015-01-28 14:18:27 +01:00
Gunnar Beutner 4ad4c314ae Implement the 'macro' function for dynamic custom vars
refs #7564
2015-01-28 14:14:48 +01:00
Gunnar Beutner fb44744680 Implement support for using functions in custom attributes
refs #7564
2015-01-27 13:40:05 +01:00
Gunnar Beutner 13917e07b0 Implement validator support for function objects
fixes #8291
2015-01-27 10:55:14 +01:00
Gunnar Beutner a11cdbdc39 Replace spaces with tabs 2015-01-27 10:50:15 +01:00
Stephan Platz 2d393eab28 Add macro "check_source" for hosts and services to use them in notification mails
fixes #8277

Signed-off-by: Gunnar Beutner <gunnar@beutner.name>
2015-01-25 16:04:36 +01:00
Michael Friedrich 78bfd0204c Update copyright year 2015-01-22 12:00:23 +01:00
Gunnar Beutner 363f23b1d8 Rename ScriptFunction to Function
fixes #8258
2015-01-21 08:48:38 +01:00
Gunnar Beutner 9a6a84d9d9 Implicitly convert filter values to bool for object rules
fixes #8184
2015-01-12 08:38:14 +01:00
Michael Friedrich 6ae9685cee Fix sending notifications for volatile checks on OK->OK changes
volatile checks make state changes behave like HARD state changes.
Though OK -> OK transitions must not be notified.

Increased log information for notifications too.

fixes #8063
2015-01-08 16:20:44 +01:00
Gunnar Beutner f02c87b14c Fix missing command arguments
fixes #8144
2015-01-08 11:38:09 +01:00
Gunnar Beutner 407f88e185 Fix incorrect week day calculation in LegacyTimePeriod::ParseTimeSpec
fixes #6943
2014-12-20 22:04:24 +01:00
Gunnar Beutner 97168378e8 Rename _DEBUG to I2_DEBUG
fixes #7767
2014-12-19 12:19:28 +01:00
Gunnar Beutner 06052c0539 Fix validation for service names in Notification, Dependency and ScheduledDowntime objects
fixes #8122
2014-12-19 11:44:31 +01:00
Gunnar Beutner 9f18211ada Remove obsolete code
refs #7709
2014-12-18 15:57:30 +01:00
Gunnar Beutner 873e294158 Refactor the WorkQueue class to make error reporting easier
refs #7709
2014-12-18 15:11:57 +01:00
Michael Friedrich a0359799bd Compat: Fix event_handler_enabled dump based on enable_event_handler attribute
fixes #8105
2014-12-18 11:22:15 +01:00
Gunnar Beutner 55b7f00382 Remove unnecessary includes 2014-12-15 10:16:06 +01:00
Gunnar Beutner 343d46bcbe Make sure IcingaApplication::GetVars returns a default value
refs #8074
2014-12-15 06:02:59 +01:00
Gunnar Beutner 1cb0231c05 Refactor how variable scopes work
refs #8074
2014-12-14 11:33:45 +01:00
Gunnar Beutner dd4c04aa9b Implement the 'global' keyword to differentiate between variable scopes
refs #8074
2014-12-13 17:48:58 +01:00
Gunnar Beutner 05485ea2d6 Disallow calling strings as functions
fixes #8040
2014-12-12 20:45:11 +01:00
Michael Friedrich d11286e9a5 DB IDO: Update child object reachability if parentchanges to !{OK,UP}
fixes #7683
2014-12-12 16:12:05 +01:00
Gunnar Beutner cfd775c948 Move the VMFrame class to libbase
refs #8065
2014-12-12 15:33:56 +01:00