Commit Graph

917 Commits

Author SHA1 Message Date
Gunnar Beutner 57713374cc Fix incorrect validator for command arguments
fixes #9436
2015-06-18 08:14:34 +02:00
Michael Friedrich f42bf537c3 Build fix
refs #9324
2015-06-15 17:25:17 +02:00
Markus Frosch 11574e0bf1 Fix multi line handling for compat check results
When a multi line result is submitted via the command pipe, any multi line
output is escaped to a actual string '\n', because any external command only
can be a single line.

Example:
  [1432735140] PROCESS_SERVICE_CHECK_RESULT;host;service;3;Test1\nTest2|test=1

We need to unescape this values, just like we use to escape multi line output
for IDO and status.dat.

fixes #9324

Signed-off-by: Michael Friedrich <michael.friedrich@netways.de>
2015-06-15 17:21:51 +02:00
Michael Friedrich a149b5ae72 Fix missing custom attributes in backends if name is equal to object attribute
fixes #9222
2015-05-29 10:21:52 +02:00
Michael Friedrich 23264a291e Fix failed assertion in DB IDO
fixes #9121
2015-04-27 11:00:59 +02:00
Michael Friedrich c59a8c8277 Fix that downtimes are always "fixed" even if scheduled as "flexible"
fixes #9142
2015-04-25 15:07:58 +02:00
Michael Friedrich 4b2e1c2662 Change log level to 'notice' for 'Attempting to send notifications' messages
fixes #9021
2015-04-20 08:56:34 +02:00
Michael Friedrich 201c41f2ca Fix custom attributes with recursive macro function calls
fixes #9073
2015-04-17 17:23:34 +02:00
Michael Friedrich 57cc7b195a Fix acknowledgement with expire time not added as comment expire_time
GetExpireTime() is always set to 0 which will make the comment reflect
wrong information compared to the text.

fixes #9041
2015-04-17 16:46:46 +02:00
Michael Friedrich e659784a66 Trigger downtimes for NOT-OK states after OnDowntimeAdded()
The fix in #8389 must happen *after* adding the downtime which signals an
insert into the IDO DB.
Once the downtimes have been added to the database, the additional
trigger_time and is_in_effect can be updated accordingly, *if* the
current object is already in a NOT-OK state.

fixes #9016
2015-04-12 14:41:30 +02:00
Gunnar Beutner a552e917b3 Improve timeperiod validation error messages
fixes #8893
2015-03-31 08:49:55 +02:00
Gunnar Beutner 17c929aabf Fix permissions for agent CheckResult messages
fixes #8821
2015-03-30 13:50:40 +02:00
Gunnar Beutner f97fded243 Fix validation errors for time ranges which span the DST transition
fixes #8892
2015-03-29 08:18:01 +02:00
Gunnar Beutner 47e17bfe89 Fix arrays in command arguments
fixes #8869
2015-03-26 09:44:47 +01:00
Gunnar Beutner 7a3957cb0b Fix incorrect variable values for apply+for
fixes #8851
2015-03-23 15:58:19 +01:00
Gunnar Beutner 148a6c5bf3 Make load order for objects more reliable
fixes #8770
2015-03-23 15:58:15 +01:00
Gunnar Beutner 3d1aba3287 Fix style violations 2015-03-21 10:04:32 +01:00
Michael Friedrich 7c0749679c Fix missing config validator for command arguments 'set_if'
fixes #8724
2015-03-20 16:15:22 +01:00
Gunnar Beutner 86a1bbf468 Allow using more than one %validator rule for the same type
fixes #8829
2015-03-20 15:55:13 +01:00
Michael Friedrich 6c8bc20369 Use Utility::NaturalJoin for notification filter formatting
refs #8685
2015-03-19 14:09:14 +01:00
Michael Friedrich 6e778c4947 Show notification state/type filter names in notice/debug log
fixes #8685
2015-03-19 14:09:07 +01:00
Gunnar Beutner 2826ef7647 Implement the parse_performance_data function
fixes #8693
2015-03-19 13:38:24 +01:00
Gunnar Beutner e50d3e6e5a Fix validator for dependencies
fixes #8596
2015-03-09 08:04:18 +01:00
Gunnar Beutner 22f3c5082d Add validator for time ranges in ScheduledDowntime objects
fixes #8600
2015-03-09 08:02:12 +01:00
Gunnar Beutner 52102d815d Fix second Deserialize() call in ApiEvents::ExecuteCommandAPIHandler
refs #8117
2015-03-06 01:45:43 +01:00
Gunnar Beutner 139540b570 Make sure we don't evaluate apply rules for fake hosts used in agent checks
fixes #8117
2015-03-05 21:19:04 +01:00
Gunnar Beutner 9181d7ae05 Add missing service name in check results
refs #8257
2015-03-05 20:50:27 +01:00
Gunnar Beutner 1d2b008dcb Fix validator for TimePeriod ranges
fixes #8568
2015-03-03 09:56:38 +01:00
Gunnar Beutner cf37decbef Fix start condition for downtimes
fixes #8560
2015-03-03 09:52:13 +01:00
Jason Young faf6ce1a5f Update PerfdataValue::Parse to ignore invalid warn, crit, min, and max values
... instead of generating exception so that metric values can
still be passed to the graphing backend.
Also update icinga-perfdata tests to reflect these changes.

refs #5043

Signed-off-by: Michael Friedrich <michael.friedrich@netways.de>
2015-03-02 13:52:41 +01:00
Gunnar Beutner 5968622108 Fix incorrect assignment in PluginUtility::ExecuteCommand
Coverity Bug ID: 1272344
2015-03-02 10:14:15 +01:00
Gunnar Beutner 9548692f00 Fix uninitialized field in the Checkable class
Coverity Bug ID: 1272323
2015-03-02 10:14:14 +01:00
Gunnar Beutner c86b17132c Make sure that the scheduled start time for downtimes isn't ignored
fixes #6959
2015-02-25 15:19:50 +01:00
Gunnar Beutner acd5d55f64 Fix null pointer dereference in ApiEvents::RepositoryTimerHandler
fixes #8535
2015-02-25 14:00:00 +01:00
Gunnar Beutner 4da3b1c5b3 Make sure that Notification objects are activated after Host/Service objects
fixes #8517
2015-02-25 12:43:38 +01:00
Gunnar Beutner 551cb6ae87 Don't convert loop variables to string when using apply-for
fixes #8519
2015-02-24 17:51:16 +01:00
Gunnar Beutner a104dcf773 Add validator for the 'ignore_soft_states' attribute
refs #7326
2015-02-23 14:29:17 +01:00
Gunnar Beutner b5dbc66b22 Implement the 'is_inside' attribute for the TimePeriod type
refs #8467
2015-02-23 14:08:06 +01:00
Gunnar Beutner 47479ac4de Implement the 'get_time_period' function
refs #8467
2015-02-23 13:56:53 +01:00
Michael Friedrich aac53c1dd1 Add 'ignore_soft_states' attribute to Dependency objects
fixes #7326
2015-02-23 10:13:20 +01:00
Gunnar Beutner a76f816623 Implement the 'continue' and 'break' keywords
fixes #8394
2015-02-19 12:57:52 +01:00
Gunnar Beutner f097e48889 Don't use separate threads for each ApiClient object
fixes #6109
2015-02-14 16:34:36 +01:00
Michael Friedrich 2ed78e82a8 Validate configured TimePeriod ranges
Requires re-throwing the hidden exceptions inside the existing
timeperiod code and validating the configured time range
strings then.

fixes #7576
2015-02-13 17:10:58 +01:00
Michael Friedrich 2cab6fbb9d Make the argments for the stats functions const-ref
fixes #8433
2015-02-13 11:29:15 +01:00
James Pharaoh 9fe52d0dc1 Make checks using 'command_endpoint' work inside HA zones
Previously there was no local processing of the executed
check result, which is mandatory inside a HA cluster.

Additionally this patch splits the command execution and
check result processing into more logical parts, executing
local checks, checks on the same command endpoint, and
remote checks.

More details in the referenced issue.

fixes #8249

Signed-off-by: Michael Friedrich <michael.friedrich@netways.de>
2015-02-12 17:53:50 +01:00
Michael Friedrich 2ae06b7a52 Implement {EN,DIS}ABLE_HOST_SVC_NOTIFICATIONS commands
fixes #7784
2015-02-11 16:45:52 +01:00
Michael Friedrich 24852e05c7 Move ValidateMacroString into the MacroProcessor class
refs #7311
2015-02-11 16:14:59 +01:00
Michael Friedrich 0d18b96c39 Resolve macros in dictionary values
refs #7311
2015-02-11 15:58:59 +01:00
Gunnar Beutner cb6f1043e1 Replace if( with if ( 2015-02-11 15:47:45 +01:00
Michael Friedrich 8ca57cba03 Add macro config validator for command args, env, custom attr, perfdata templates
fixes #7311
2015-02-11 15:32:10 +01:00